Re: [PATCH] scsi: ufs: Make use of UFS_BIT macro wherever possible

2017-08-29 Thread Alim Akhtar
Hi Bart, Thanks for your review. On 08/28/2017 09:15 PM, Bart Van Assche wrote: > On Mon, 2017-08-28 at 17:49 +0530, Alim Akhtar wrote: >> This entire file uses UFS_BIT macro for bits definition, expect for few >> places. This patch convert those defines to use UFS_BIT macr

[PATCH 0/4] Add required changes to ufshcd to support exynos ufs hci

2018-05-06 Thread Alim Akhtar
reviewing over head. I am floating these as a new patch set. [1] https://www.spinics.net/lists/linux-scsi/msg90292.html These patches are based on mainline v4.17-rc3. Alim Akhtar (4): scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr scsi: ufs: add quirk not to allow reset of interrupt

[PATCH 3/4] scsi: ufs: add quirk to enable host controller without hce

2018-05-06 Thread Alim Akhtar
Some host controller doesn't support host controller enable via HCE. Signed-off-by: Seungwon Jeon <ess...@gmail.com> Signed-off-by: Alim Akhtar <alim.akh...@samsung.com> --- drivers/scsi/ufs/ufshcd.c | 75 +-- drivers/scsi/ufs/ufshcd.h

[PATCH 1/4] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr

2018-05-06 Thread Alim Akhtar
In the right behavior, setting the bit to '0' indicates clear and '1' indicates no change. If host controller handles this the other way, UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR can be used. Signed-off-by: Seungwon Jeon <ess...@gmail.com> Signed-off-by: Alim Akhtar <alim.akh...@samsung.com>

[PATCH 4/4] scsi: ufs: make ufshcd_config_pwr_mode of non-static func

2018-05-06 Thread Alim Akhtar
This makes ufshcd_config_pwr_mode non-static so that other vendors like exynos can use the same. Signed-off-by: Seungwon Jeon <ess...@gmail.com> Signed-off-by: Alim Akhtar <alim.akh...@samsung.com> --- drivers/scsi/ufs/ufshcd.c | 5 ++--- drivers/scsi/ufs/ufshcd.h | 2 ++ 2 file

[PATCH 2/4] scsi: ufs: add quirk not to allow reset of interrupt aggregation

2018-05-06 Thread Alim Akhtar
Some host controller supports interrupt aggregation, but doesn't allow to reset counter and timer by s/w. Signed-off-by: Seungwon Jeon <ess...@gmail.com> Signed-off-by: Alim Akhtar <alim.akh...@samsung.com> --- drivers/scsi/ufs/ufshcd.c | 3 ++- drivers/scsi/ufs/ufshcd.h | 6 +++

[PATCH V3] scsi: ufs: Add specific callback for setting DMA mask

2018-05-19 Thread Alim Akhtar
work as HCI has only 36bit addressing and SMMU has created mapping of 64 bit and as the device truncates the address, its mapping will not be found by iommu. To resolve such issues, let the variant driver sets its own DMA mask. Signed-off-by: Alim Akhtar <alim.akh...@samsung.com> --- driver

Re: [RFC PATCH V2] scsi: ufs: Add specific callback for setting DMA mask

2018-05-19 Thread Alim Akhtar
Hi Subhash On 05/17/2018 03:01 AM, Subhash Jadavani wrote: > On 2018-05-15 21:31, Alim Akhtar wrote: >> Ping !!! >> >> On Thu, Mar 8, 2018 at 4:33 PM, Alim Akhtar <alim.akh...@samsung.com> >> wrote: >>> Currently DMA mask for UFS HCI is set by readi

Re: [PATCH 0/4] Add required changes to ufshcd to support exynos ufs hci

2018-05-15 Thread Alim Akhtar
Hi All, Any thought on this patch set? On Sun, May 6, 2018 at 3:44 PM, Alim Akhtar <alim.akh...@samsung.com> wrote: > Hi All > > These patches are part of a larger patch series [1] which attempts upstreaming > EXYNOS UFS driver support. There was not much activities after v

Re: [RFC PATCH V2] scsi: ufs: Add specific callback for setting DMA mask

2018-05-15 Thread Alim Akhtar
Ping !!! On Thu, Mar 8, 2018 at 4:33 PM, Alim Akhtar <alim.akh...@samsung.com> wrote: > Currently DMA mask for UFS HCI is set by reading CAP register's > [64AS] bit. Some HCI controller like Exynos support 36-bit bus address. > This works perfectly fine with DMA mask se

Re: [PATCH V3] scsi: ufs: Add specific callback for setting DMA mask

2018-05-28 Thread Alim Akhtar
Hi Bart On 05/20/2018 07:51 PM, Bart Van Assche wrote: > On Sun, 2018-05-20 at 07:54 +0530, Alim Akhtar wrote: >> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c >> index a355d98..9a1374e 100644 >> --- a/drivers/scsi/ufs/ufshcd.c >> +++ b/drivers/scsi

[RFC PATCH] scsi: ufs: Add specific callback for setting DMA mask

2018-03-08 Thread Alim Akhtar
work as HCI has only 36bit addressing and SMMU has created mapping of 64 bit and as the device truncates the address, its mapping will not be found by iommu. To resolve such issues, let the variant driver sets its own DMA mask. Signed-off-by: Alim Akhtar <alim.akh...@samsung.com> --- driver

[RFC PATCH V2] scsi: ufs: Add specific callback for setting DMA mask

2018-03-08 Thread Alim Akhtar
work as HCI has only 36bit addressing and SMMU has created mapping of 64 bit and as the device truncates the address, its mapping will not be found by iommu. To resolve such issues, let the variant driver sets its own DMA mask. Signed-off-by: Alim Akhtar <alim.akh...@samsung.com> --- driver

<    1   2