Mid-layer handling of NOT_READY conditions...

2005-01-28 Thread Andrew Vasquez
command queuing internally, a NOT_READY status would cause the lun-queue to be frozen for some period time while the storage settled-down. Would this be an approach to consider? Or should we tackle the problem by addressing the quirky (cmd-retries cmd-allowed) state? Thanks, Andrew Vasquez

Re: Mid-layer handling of NOT_READY conditions...

2005-01-28 Thread Andrew Vasquez
On Fri, 2005-01-28 at 15:24 -0800, Andrew Vasquez wrote: ... There seems to be two problem with this approach: 1. As the storage continues to return NOT_READY, scsi_decide_disposition() blindly increments cmd-retries and checks against cmd-allowed, returning

Re: Mid-layer handling of NOT_READY conditions...

2005-01-31 Thread Andrew Vasquez
On Sat, 2005-01-29 at 11:34 -0800, Patrick Mansfield wrote: On Sat, Jan 29, 2005 at 10:44:41AM -0600, James Bottomley wrote: On Fri, 2005-01-28 at 21:46 -0800, Andrew Vasquez wrote: Returning back DID_IMM_RETRY for these 'transport' related conditions would of course help in this issue

RE: Mid-layer handling of NOT_READY conditions...

2005-01-31 Thread Andrew Vasquez
On Mon, 2005-01-31 at 11:56 -0500, [EMAIL PROTECTED] wrote: On Sat, 2005-01-29 at 11:34 -0800, Patrick Mansfield wrote: On Sat, Jan 29, 2005 at 10:44:41AM -0600, James Bottomley wrote: On Fri, 2005-01-28 at 21:46 -0800, Andrew Vasquez wrote: Returning back DID_IMM_RETRY

Re: Mid-layer handling of NOT_READY conditions...

2005-01-31 Thread Andrew Vasquez
) in scsi_check_sense(). Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] scsi_error.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) = drivers/scsi/scsi_error.c 1.86 vs edited = --- 1.86/drivers/scsi/scsi_error.c 2005-01-17 22:54:45 -08:00 +++ edited/drivers

PATCH [0/3] qla2xxx: new experimental changes...

2005-02-04 Thread Andrew Vasquez
'hardware_lock' and begin using the host-host_lock exclusively. D. additional hardware (ISP) support. E. firmware loading via request_firmware() infrastructure. Regards, Andrew Vasquez QLogic Corporation - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

PATCH [2/3] qla2xxx: add FC remote port support.

2005-02-04 Thread Andrew Vasquez
) helpers into new qla_attr.c file. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx/Makefile |2 drivers/scsi/qla2xxx/qla_attr.c | 321 drivers/scsi/qla2xxx/qla_def.h |3 drivers/scsi/qla2xxx/qla_gbl.h | 10 + drivers

Re: PATCH [0/3] qla2xxx: new experimental changes...

2005-02-04 Thread Andrew Vasquez
On Fri, 2005-02-04 at 20:35 +, Christoph Hellwig wrote: patch3 seems to not have made it to the list. I'll resend... From a quick view the first three patches look fine, except for backing out one msleep conversion and the superflous return at the end of qla2xxx_slave_destroy I'll

PATCH [3/3] qla2xxx: remove internal lun discovery...

2005-02-04 Thread Andrew Vasquez
Repost: seems as though first one didn't make it to the list. Remove internal lun discovery routines and support structures. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx/qla_dbg.c|5 drivers/scsi/qla2xxx/qla_def.h| 69 drivers/scsi/qla2xxx

PATCH [3/3] qla2xxx: remove internal lun discovery...

2005-02-04 Thread Andrew Vasquez
Remove internal lun discovery routines and support structures. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx/qla_dbg.c|5 drivers/scsi/qla2xxx/qla_def.h| 69 drivers/scsi/qla2xxx/qla_gbl.h|6 drivers/scsi/qla2xxx/qla_init.c | 584

Re: PATCH [0/3] qla2xxx: new experimental changes...

2005-02-04 Thread Andrew Vasquez
On Fri, 2005-02-04 at 17:46 -0500, Jeff Garzik wrote: Andrew Vasquez wrote: On Fri, 2005-02-04 at 20:35 +, Christoph Hellwig wrote: patch3 seems to not have made it to the list. I'll resend... Is patch #3 rather large? I still haven't gotten it. No it's actually about

Re: still BUG's for smp_processor_id() on interrupt

2005-02-08 Thread Andrew Vasquez
, the smp_processor_id() is used only as a heuristic. The attached patch should quash the noise. Thanks. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] = drivers/scsi/qla2xxx/qla_isr.c 1.23 vs edited = --- 1.23/drivers/scsi/qla2xxx/qla_isr.c 2005-02-04 10:24:27 -08:00 +++ edited/drivers/scsi

Re: [PATCH 1/2 scsi-rc-fixes-2.6] Midlayer rework to allow remote port between shost and starget

2005-02-09 Thread Andrew Vasquez
This patch modifies the midlayer for the addition of transport objects to be layered between the scsi_host and the scsi_target. FC will be the first consumer - placing the remote port between the host and the target. These seems to be some reference-counting problems during starget

Re: [RFC] target code updates to support scanned targets

2005-02-16 Thread Andrew Vasquez
On Tue, 15 Feb 2005, James Bottomley wrote: On Tue, 2005-02-15 at 16:53 -0800, Andrew Vasquez wrote: Yes, but the parent needs to know if the starget is actually created. With the fc_rports snapshot I've been working with, I've coded up the following: Why do you need to know if the scan

Re: [RFC] target code updates to support scanned targets

2005-02-17 Thread Andrew Vasquez
On Wed, 16 Feb 2005, Andrew Vasquez wrote: On Tue, 15 Feb 2005, James Bottomley wrote: Well, how about a different format for this, so there's a scsi_remove_target that takes a generic device (analogous to the scsi_scan_target) except that this time if the device isn't a target, we remove

[RFC] adding per scsi-host workqueues for defered processing

2005-02-21 Thread Andrew Vasquez
. */ scsi_queue_work(shost, rport-scan_work); else scsi_target_unblock(rport-dev); Anyway, comments? -- Andrew Vasquez = drivers/scsi/hosts.c 1.107 vs edited = --- 1.107/drivers/scsi/hosts.c 2005-01-18 11:15:06 -08:00 +++ edited/drivers/scsi

SCSI API generics (was Re: [PATCH] add block/unblock to iscsi class)

2005-02-23 Thread Andrew Vasquez
On Wed, 23 Feb 2005, Mike Christie wrote: The attached patch copies the code from the fc transport class which allows a LLD to block and unblock a device. The block/unblock code is used by the iscsi-sfnet driver in replacement of a internal timer doing the same thing. I understand that

Re: SCSI API generics (was Re: [PATCH] add block/unblock to iscsi class)

2005-02-23 Thread Andrew Vasquez
On Wed, 23 Feb 2005, Mike Christie wrote: Andrew Vasquez wrote: Speaking of which, are there any major objections to the patches proposed here: Add scsi_target_[un]block() and scsi_target_remove() generics http://marc.theaimsgroup.com/?l=linux-scsim=110867050306738w=2 [RFC] adding per

Re: [2.6 patch] drivers/scsi/qla2xxx/: cleanups

2005-02-28 Thread Andrew Vasquez
; module_param(ql2xdoinitscan, int, S_IRUGO|S_IWUSR); MODULE_PARM_DESC(ql2xdoinitscan, Signal mid-layer to perform scan after driver load: 0 -- no @@ -163,6 +162,8 @@ I'll queue-up these for the next set of patches. Thanks, Andrew Vasquez - To unsubscribe from this list: send

Re: [RFC] adding per scsi-host workqueues for defered processing

2005-03-07 Thread Andrew Vasquez
On Sat, 05 Mar 2005, [EMAIL PROTECTED] wrote: In thinking this through a little further - if the workq is just for the transport, the transport ought to simply create and use the workq. There would be no need to modify the host structure. If we're trying to avoid the potential for several

Re: Fw: [Bugme-new] [Bug 4473] New: QLogic 2100: SCSI timeouts, device resets, and crashes kernel

2005-04-11 Thread Andrew Vasquez
if this effects the error. To do this just echo 60 /sys/block/sd${N}/device/timeout. Also you can run iostat during your testing to see what you IO times / queue depths look like. Andrew Vasquez may be able to add more info. Greg, The logs seem to indicate some (additional) problems with the ISP

PATCH [0/5] qla2xxx: remote port rework...

2005-04-13 Thread Andrew Vasquez
operations (via change_queue_depth()). c) additional hardware (ISP) support. d) Additional dusting and scrubbing: unused functions and structures left over from the cleanup. e) firmware loading via request_firmware() infrastructure. f) lock simplification and consolidation. Regards, Andrew

PATCH [2/5] qla2xxx: add remote port codes...

2005-04-13 Thread Andrew Vasquez
Add initial support for FC remote port infrastructure. o Use fc_remote_port...() registration and block/unlock functions. o Consolidate 'attribute' (fc-remote/sysfs) helpers into new qla_attr.c file. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx

PATCH [4/5] qla2xxx: cleanup DMA mappings...

2005-04-13 Thread Andrew Vasquez
done before the mapping has taken place are bogus. Doug Ledford [EMAIL PROTECTED]. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx/qla_iocb.c | 77 +++- 1 files changed, 38 insertions(+), 39 deletions(-) --- a/drivers/scsi/qla2xxx

PATCH [3/5] qla2xxx: remove lun discovery codes...

2005-04-13 Thread Andrew Vasquez
Remove internal lun discovery routines and support structures. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx/qla_attr.c | 51 +- drivers/scsi/qla2xxx/qla_dbg.c|5 drivers/scsi/qla2xxx/qla_def.h| 103 drivers/scsi/qla2xxx/qla_gbl.h| 10

PATCH [5/5] qla2xxx: remove /proc interface

2005-04-13 Thread Andrew Vasquez
Remove /proc support. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx/qla_os.c | 254 -- 1 files changed, 254 deletions(-) --- a/drivers/scsi/qla2xxx/qla_os.c 2005-04-13 08:56:07.0 -0700 +++ b/drivers/scsi/qla2xxx

PATCH [6/5] qla2xxx: update version :)

2005-04-13 Thread Andrew Vasquez
Update version. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx/qla_version.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) --- a/drivers/scsi/qla2xxx/qla_version.h2005-04-13 08:56:07.0 -0700 +++ b/drivers/scsi/qla2xxx/qla_version.h

Re: PATCH [6/5] qla2xxx: update version :)

2005-04-15 Thread Andrew Vasquez
On Wed, 13 Apr 2005, Christoph Hellwig wrote: On Wed, Apr 13, 2005 at 01:50:07PM -0700, Andrew Vasquez wrote: Update version. Btw, Documentation/scsi/qla2xxx.revision.notes hasn't been updated for ages. Either scrap it or give it some love, I don't mind too much which of these you

Re: PATCH [4/5] qla2xxx: cleanup DMA mappings...

2005-04-15 Thread Andrew Vasquez
and failure to check return values on the mappings. Make the check for space in the ring buffer happen after the DMA mapping is done since any checks done before the mapping has taken place are bogus. Doug Ledford [EMAIL PROTECTED]. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi

Re: PATCH [2/5] qla2xxx: add remote port codes...

2005-04-19 Thread Andrew Vasquez
shouldn't be needed, a simple forward-declaration of struct scsi_transport_template should do it. Ok, makes sense. James, please apply: Make transport-functions structure non-static. Replace #include of scsi_transport.h with a forward declaration. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED

Re: PATCH [2/5] qla2xxx: add remote port codes...

2005-04-19 Thread Andrew Vasquez
On Wed, 13 Apr 2005, Christoph Hellwig wrote: atomic_set(fcport-state, FCS_ONLINE); + if (ha-flags.init_done) + qla2x00_reg_remote_port(ha, fcport); } ... - goto probe_failed; + goto probe_alloc_failed; } + pci_set_drvdata(pdev,

Re: [PATCH] remove some dead code in qla2xxx

2005-04-22 Thread Andrew Vasquez
ACK. James, please apply - several of my follow-up patches are based off a tree with these changes. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] = drivers/scsi/qla2xxx/qla_dbg.c 1.12 vs edited = --- 1.12/drivers/scsi/qla2xxx/qla_dbg.c 2005-04-13 17:45:53 +02:00 +++ edited/drivers

Re: Removing a disk from the qla2xxx driver.

2005-04-22 Thread Andrew Vasquez
recognition of the device persists throughout the driver's lifetime -- this is not necessary. Hope this helps. Regards, Andrew Vasquez - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: PATCH [6/5] qla2xxx: update version :)

2005-04-22 Thread Andrew Vasquez
On Tue, 19 Apr 2005, Christoph Hellwig wrote: On Wed, Apr 13, 2005 at 02:24:36PM -0700, Andrew Vasquez wrote: Ok, here's the deal -- QLogic's standard 8.01.00 driver contains the following major additions: * support for 4Gb ISPs * FCIP support Btw, any plans to do proper FCIP

[PATCH 0/17] qla2xxx: Add ISP24xx support.

2005-07-06 Thread Andrew Vasquez
://ftp.qlogic.com/outgoing/linux/patches/8.x/8.01.00b5k/ Hopefully this patch-set addresses the issues voiced against the earlier 4gb submission. Regards, Andrew Vasquez QLogic Corporation commit cb2ccfbc4f91e62e69d2f84992a45a557c02230d Author: Andrew Vasquez [EMAIL PROTECTED] Date: Wed Jul 6 09:25:46

[PATCH 14/17] qla2xxx: Firmware updates.

2005-07-06 Thread Andrew Vasquez
Firmware updates. Resync with latest 21xx firmware -- 1.19.25. Resync with latest 22xx firmware -- 2.02.08. Resync with latest 23xx/63xx firmware -- 3.03.15. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] This patch is too large for an inline patch, please download the bzip'd patch

[PATCH 15/17] qla2xxx: Update copyright banner.

2005-07-06 Thread Andrew Vasquez
Update copyright banner. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/ql2100.c |2 +- drivers/scsi/qla2xxx/ql2200.c |2 +- drivers/scsi/qla2xxx/ql2300.c |2 +- drivers/scsi/qla2xxx/ql2322.c |2 +- drivers/scsi/qla2xxx/ql6312.c

[PATCH 16/17] qla2xxx: Correct maximum supported lun and target-id definitions.

2005-07-06 Thread Andrew Vasquez
Correct maximum supported lun and target-id definitions. The driver uses command-IOCBs which support a maximum lun value of 0x -- correct #define to reflect the change. Also, remove superfluous MAX_TARGET definition. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx

[PATCH 8/17] qla2xxx: Add ISP24xx IOCB manipulation routines.

2005-07-06 Thread Andrew Vasquez
Add ISP24xx IOCB manipulation routines. Add appropriate glue-code for ISP24xx support while manipulting IOCB packets. Add an ISP24xx specific 'start_scsi' routine due to command-type-7 layout changes. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_gbl.h|1

[PATCH 13/17] qla2xxx: Code scrubbing.

2005-07-06 Thread Andrew Vasquez
Code scrubbing. - Remove trailing whitespace from driver files. - Remove unused #defines and inlines. - Standardize on C comments (// - /* */) Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_dbg.c | 130 ++- drivers/scsi

[PATCH 1/17] qla2xxx: Factor-out ISP specific functions to method-based call tables.

2005-07-06 Thread Andrew Vasquez
Factor-out ISP specific functions to method-based call tables. In anticipation of ISP24xx/ISP25xx support, factor-out ISP specific functions into a method-based call table. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_attr.c |5 - drivers/scsi/qla2xxx

[PATCH 6/17] qla2xxx: Add MBX command routines for ISP24xx support.

2005-07-06 Thread Andrew Vasquez
Add MBX command routines for ISP24xx support. Generalize several routines [qla2x00_load_ram_ext(), qla2x00_execute_fw(), qla2x00_verify_checksum()] to handle larger addressing space. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_def.h |3 drivers/scsi

Re: [PATCH 0/17] qla2xxx: Add ISP24xx support.

2005-07-08 Thread Andrew Vasquez
James, Here's three small patches which fix-up several issues found since my original patchset. Should apply cleanly to a scsi-misc-2.6 tree with the previous patch set applied. Thanks, Andrew Vasquez - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message

[PATCH] qla2xxx: Add firmware version number to qla24xx_fw_version_str().

2005-07-08 Thread Andrew Vasquez
Add firmware version number to qla24xx_fw_version_str(). Original code was accidently trimmed during port. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_os.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) 21fad7fa5cb535355f128fc0459a2de79f1975be

[PATCH] qla2xxx: Cleanup FC remote port registration.

2005-07-08 Thread Andrew Vasquez
/PRLI bits). This allows for a more cleaner rport-dd_data management as can be seen with the simplified qla2xxx_slave_alloc() function. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_init.c | 17 ++--- drivers/scsi/qla2xxx/qla_os.c | 16

[PATCH] qla2xxx: Consolidate ISP24xx chip reset logic.

2005-07-08 Thread Andrew Vasquez
Consolidate ISP24xx chip reset logic. Consolidate near-duplicate RISC reset logic from qla24xx_reset_chip() and qla24xx_chip_diag(). Also, after initiating a soft-reset, insure the firmware has completed all NVRAM accesses before continuing. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED

Re: 2.6.13-rc3-mm1: horribly drivers/scsi/qla2xxx/Makefile

2005-07-15 Thread Andrew Vasquez
, but this is so horribly wrong. Yes, quite. How about the following to correct the intention. Add correct Kconfig option for ISP24xx support. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig --- a/drivers/scsi

Re: Incorrect driver getting loaded for Qlogic FC-HBA

2005-07-26 Thread Andrew Vasquez
distro are you using? If you are using RHEL, and are still having problems, I'd suggest you file a report with Redhat. Regards, Andrew Vasquez - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: Incorrect driver getting loaded for Qlogic FC-HBA

2005-07-27 Thread Andrew Vasquez
On Wed, 27 Jul 2005, Rajat Jain wrote: On 7/27/05, Andrew Vasquez [EMAIL PROTECTED] wrote: A similar problem was noted with RHEL4, it seems the modules.pcimap and pci.ids file were correct, but the pcitable file contained entries for all ql[ae]23xx based HBAs to load qla2300.ko

Re: Fix up qla2xxx configuration bogosity

2005-07-28 Thread Andrew Vasquez
On Thu, 28 Jul 2005, James Bottomley wrote: On Wed, 2005-07-27 at 22:10 -0700, Andrew Vasquez wrote: Would you also apply the attached patch which adds the appropriate FW_LOADER pre-requisite and a separate entry for ISP24xx support. That's what I see reading the code; however, it looks

Re: calling scsi_adjust_queue_depth() during I/O...

2005-08-05 Thread Andrew Vasquez
On Fri, 05 Aug 2005, Tejun Heo wrote: Oops, forget about the previous mail. Above patch make it into the tree and it's the source of the problem. My git HEAD was pointing at the latest update but I haven't updated my cache, so I was looking at the old source tree. My apologies for

[PATCH 0/19] qla2xxx: Driver update [8.02.00-k4].

2007-09-20 Thread Andrew Vasquez
shost_priv(). - Cleanup several 'sparse' warnings. - Sparse cleanups in qla_mid.c - Clear options-flags while staging firmware-execution. - Rework MSI-X handlers. - Update version number to 8.02.00-k4. Regards, Andrew Vasquez QLogic Corporation - To unsubscribe from this list: send the line unsubscribe

[PATCH 03/19] qla2xxx: Limit iIDMA speed adjustments.

2007-09-20 Thread Andrew Vasquez
Do not adjust the iIDMA speed on ports which have a faster link-speed than the HBA itself. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_init.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b

[PATCH 18/19] qla2xxx: Rework MSI-X handlers.

2007-09-20 Thread Andrew Vasquez
, since the msi-x registered handlers are optimised for a particular vector, it is preferable to handle the one vector received per invocation of the handler. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_isr.c |7 ++- 1 files changed, 2 insertions(+), 5

[PATCH 02/19] qla2xxx: Add flash burst-read/write support.

2007-09-20 Thread Andrew Vasquez
Newer ISPs support a mechanism to read and write flash-memory via the firmware LOAD/DUMP memory mailbox command routines. When supported, utilizing these mechanisms significantly reduces overall access times. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_gbl.h

[PATCH 19/19] qla2xxx: Update version number to 8.02.00-k4.

2007-09-20 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 18095b9..2d551a3 100644 --- a/drivers/scsi/qla2xxx

[PATCH 04/19] qla2xxx: Allow region-based flash-part accesses.

2007-09-20 Thread Andrew Vasquez
From: Joe Carnuccio [EMAIL PROTECTED] Additional cleanups and Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_attr.c | 108 --- drivers/scsi/qla2xxx/qla_def.h |2 + drivers/scsi/qla2xxx/qla_fw.h |2 + drivers/scsi

[PATCH 05/19] qla2xxx: Add PCI error recovery support.

2007-09-20 Thread Andrew Vasquez
From: Seokmann Ju [EMAIL PROTECTED] Additional cleanups and Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_def.h |1 + drivers/scsi/qla2xxx/qla_isr.c | 28 +- drivers/scsi/qla2xxx/qla_os.c | 114 3 files

[PATCH 06/19] qla2xxx: Query additional RISC information during a pause.

2007-09-20 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_fw.h |4 ++- drivers/scsi/qla2xxx/qla_isr.c | 53 2 files changed, 56 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_fw.h b/drivers/scsi/qla2xxx

[PATCH 07/19] qla2xxx: Correct staging of RISC while attempting to pause.

2007-09-20 Thread Andrew Vasquez
There's no need to reset the RISC prior to pausing. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_dbg.c | 23 ++- 1 files changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c

[PATCH 08/19] qla2xxx: Query additional RISC registers during ISP25XX firmware dump.

2007-09-20 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_dbg.c | 18 ++ drivers/scsi/qla2xxx/qla_dbg.h |2 ++ drivers/scsi/qla2xxx/qla_fw.h |2 +- 3 files changed, 21 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b

[PATCH 09/19] qla2xxx: Correct infinite-login-retry issue.

2007-09-20 Thread Andrew Vasquez
From: Ravi Anand [EMAIL PROTECTED] Where the DPC logic would get jammed into continuously reloging-into a port. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_os.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx

[PATCH 10/19] qla2xxx: Set correct attribute count during FDMI RPA.

2007-09-20 Thread Andrew Vasquez
Also remove legacy '/proc' name during OS_DEVICE_NAME registration. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_def.h |2 +- drivers/scsi/qla2xxx/qla_gs.c |6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx

[PATCH 11/19] qla2xxx: Use the correct pointer-address during NVRAM writes.

2007-09-20 Thread Andrew Vasquez
Original code, incorrectly passed the address-of a pointer rather than the pointer value itself. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_attr.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers

[PATCH 16/19] qla2xxx: Sparse cleanups in qla_mid.c

2007-09-20 Thread Andrew Vasquez
Make several needlessly global functions static: - qla2x00_mark_vp_devices_dead() - qla24xx_configure_vp() Remove unused function qla24xx_modify_vport(). Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_mid.c | 34 ++ 1 files changed

[PATCH 15/19] qla2xxx: Cleanup several 'sparse' warnings.

2007-09-20 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_iocb.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 3a5e78c..7f6a89b 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c

[PATCH 13/19] qla2xxx: Remove unused member (list) from srb_t structure.

2007-09-20 Thread Andrew Vasquez
This change reduces by as much as 16% the memory footprint for each allocated sbr_t structure requested from the mempool. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_def.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/scsi

[PATCH 12/19] qla2xxx: Retrieve max-NPIV support capabilities from FW.

2007-09-20 Thread Andrew Vasquez
From: Seokmann Ju [EMAIL PROTECTED] Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_attr.c |2 +- drivers/scsi/qla2xxx/qla_def.h |2 +- drivers/scsi/qla2xxx/qla_gbl.h |4 ++-- drivers/scsi/qla2xxx/qla_init.c | 16 +++- drivers/scsi/qla2xxx

[PATCH 14/19] qla2xxx: Use shost_priv().

2007-09-20 Thread Andrew Vasquez
Drop usage of legacy to_qla_host() macro. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_attr.c | 88 +++--- drivers/scsi/qla2xxx/qla_dbg.c |2 +- drivers/scsi/qla2xxx/qla_def.h |2 - drivers/scsi/qla2xxx/qla_mid.c |6

Re: [PATCH] aic94xx: Use request_firmware() to provide SAS address if the adapter lacks one

2007-10-08 Thread Andrew Vasquez
On Mon, 08 Oct 2007, Darrick J. Wong wrote: If the aic94xx chip doesn't have a SAS address in the chip's flash memory, use the request_firmware() interface to get one from userspace. This way, there's no debate as to who or how an address gets generated--it's totally up to the administrator

Re: [PATCH] aic94xx: Use request_firmware() to provide SAS address if the adapter lacks one

2007-10-08 Thread Andrew Vasquez
On Mon, 08 Oct 2007, Darrick J. Wong wrote: On Mon, Oct 08, 2007 at 03:48:32PM -0700, Andrew Vasquez wrote: So how about factoring that out to a transport-level interface. How about something along the lines of the following patch, whereby the software driver upon detecting no valid

Re: [PATCH] aic94xx: Use request_firmware() to provide SAS address if the adapter lacks one

2007-10-09 Thread Andrew Vasquez
On Tue, 09 Oct 2007, James Smart wrote: Why do you prefer request_firmware() vs something over sysfs ? Does environments like the kdump kernel also have access to data needed by request_firmware() ? There's already much in the way of automation and infrastructure present in supporting

Re: [patch 3/7] qla2xxx printk fixes

2007-10-17 Thread Andrew Vasquez
] Acked-by: Andrew Vasquez [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 8/8] qla2xxx: Update version number to 8.02.00-k5.

2007-10-19 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 2d551a3..ae6f7a2 100644 --- a/drivers/scsi/qla2xxx

[PATCH 7/8] qla2xxx: Correct display of ISP serial-number.

2007-10-19 Thread Andrew Vasquez
The original serial-number calculations based on WWPN no longer apply to newer ISPs (ISP24xx and ISP25xx). These newer board's serial number reside in the VPD. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_attr.c |3 +++ 1 files changed, 3 insertions(+), 0

[PATCH 6/8] qla2xxx: Correct residual-count handling discrepancies during UNDERRUN handling.

2007-10-19 Thread Andrew Vasquez
is consistent with what earlier firmwares did by explicitly cracking open the FCP_RSP statuses and clearing SS_RESIDUAL_UNDER. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_isr.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/scsi

[PATCH 3/8] qla2xxx: Handle unaligned sector writes during NVRAM/VPD updates.

2007-10-19 Thread Andrew Vasquez
Since both NVRAM and VPD regions of the flash reside on unaligned sector boundaries, during update, the driver must perform a read-modify-write operation to the composite NVRAM/VPD region. This affects ISP25xx type boards only. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi

[PATCH 2/8] qla2xxx: Defer explicit interrupt-polling processing to init-time scenarios.

2007-10-19 Thread Andrew Vasquez
As the intermixing may cause issues where HCCR bits could be cleared inappropriately during MSI/MSI-X interrupt handling. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_iocb.c |2 +- drivers/scsi/qla2xxx/qla_mbx.c |2 +- 2 files changed, 2 insertions(+), 2

[PATCH 1/8] qla2xxx: Resync with latest HBA SSID specification -- 2.2u.

2007-10-19 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_devtbl.h |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_devtbl.h b/drivers/scsi/qla2xxx/qla_devtbl.h index dd43541..d78d35e 100644 --- a/drivers/scsi/qla2xxx

[PATCH 0/8] qla2xxx: Driver updates for 2.6.24 [8.02.00-k5].

2007-10-19 Thread Andrew Vasquez
(mostly) legacy I/O port free. - Correct residual-count handling discrepancies during UNDERRUN handling. - Correct display of ISP serial-number. - Update version number to 8.02.00-k5. Regards, Andrew Vasquez QLogic Corporation - To unsubscribe from this list: send the line unsubscribe linux-scsi

[PATCH 4/8] qla2xxx: Fix issue where final flash-segment updates were falling into the slow-path write handler.

2007-10-19 Thread Andrew Vasquez
Original implementation would not use the burst-write mechanisms for requests equal to OPTROM_BURST_DWORDS transfer dwords. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_sup.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi

[PATCH 5/8] qla2xxx: Make driver (mostly) legacy I/O port free.

2007-10-19 Thread Andrew Vasquez
Recent ISPs need only the single MMIO BAR to manipulate HW registers. Unfortunately, ISP21xx, ISP22xx, ISP23xx, and ISP63xx type cards still require the I/O mapped region to manipulate the FLASH via the two HW flash-registers (flash_address and flash_data). Signed-off-by: Andrew Vasquez [EMAIL

[PATCH 0/4] qla2xxx: fixes for 2.6.24 [8.02.00-k6].

2007-11-12 Thread Andrew Vasquez
registers while processing a system-error. - Correct NPIV support for recent ISPs. - Properly handle Vport state-change-notifications. - Update version number to 8.02.00-k6. Regards, Andrew Vasquez QLogic Corporation - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

[PATCH 1/4] qla2xxx: Don't explicitly read mbx registers while processing a system-error.

2007-11-12 Thread Andrew Vasquez
and above) and peek into the incorrect regions of registers. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_isr.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index 1104bd2

[PATCH 3/4] qla2xxx: Properly handle Vport state-change-notifications.

2007-11-12 Thread Andrew Vasquez
. The fix is to also take into consideration the vp_idx, which is set by the firmware to indicate the vport the RSCN was meant for. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_isr.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 4/4] qla2xxx: Update version number to 8.02.00-k6.

2007-11-12 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index ae6f7a2..6e3dc40 100644 --- a/drivers/scsi/qla2xxx

[PATCH 2/4] qla2xxx: Correct NPIV support for recent ISPs.

2007-11-12 Thread Andrew Vasquez
Firmware will export to software the maximum number of vports supported for any given firmware version and ISP type. Use this information rather than the current hardcoding of limitations within the driver. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_attr.c

Re: [PATCH] drivers/scsi/: Spelling fixes

2007-12-17 Thread Andrew Vasquez
+- drivers/scsi/lpfc/lpfc_mbox.c |2 +- drivers/scsi/megaraid/megaraid_mbox.c | 10 +- drivers/scsi/psi240i.c|2 +- drivers/scsi/qla2xxx/qla_gs.c |2 +- qla2xxx bits: Acked-by: Andrew Vasquez [EMAIL PROTECTED] - To unsubscribe from this list

Re: [patch 18/30] scsi/qla2xxx/: possible cleanups

2007-12-21 Thread Andrew Vasquez
On Fri, 21 Dec 2007, Andrew Morton wrote: On Fri, 14 Dec 2007 10:20:04 -0800 Andrew Vasquez [EMAIL PROTECTED] wrote: It is, though, not widely publicized: git://avgit01.qlogic.com/qla2xxx-upstream The repo is torndown and rebased on frequent a basis, and is meant to provide

Re: [PATCH -mmotm] scsi: fix the wrong position of the comment

2013-03-10 Thread Andrew Vasquez
the wrong position of the comment introduced by scsi-rename-random32-to-prandom_u32.patch in the -mm tree. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc: Andrew Vasquez andrew.vasq...@qlogic.com --- drivers/scsi/qla2xxx

Re: qla_wxyz pci_set_mwi question

2007-04-12 Thread Andrew Vasquez
On Wed, 11 Apr 2007, Randy Dunlap wrote: Both scsi/qla2xxx/qla_init.c and scsi/qla4xxx/ql4_init.c use pci_set_mwi() like this: mwi = 0; if (pci_set_mwi(ha-pdev)) mwi = PCI_COMMAND_INVALIDATE; and then go on to set the PCI_COMMAND word based on that value.

Re: qla_wxyz pci_set_mwi question

2007-04-12 Thread Andrew Vasquez
On Thu, 12 Apr 2007, Matthew Wilcox wrote: On Thu, Apr 12, 2007 at 10:20:38AM -0700, Andrew Vasquez wrote: No, the current logic doesn't make much sense at all, initialization should not continue if MWI is not set... I'll queue-up something like the patch below for our next batch

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
that you're proposing implies that there's some 'random' bit-space within the IEEE NAA with which one can safely encode without stomping on any valid OUI. From 9ee6de3bbaa03390b83226e7bb84c49566a583b3 Mon Sep 17 00:00:00 2001 From: Andrew Vasquez [EMAIL PROTECTED] Date: Wed, 11 Apr 2007 16:02:06 -0700 Subject

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, Andrew Vasquez wrote: On Mon, 16 Apr 2007, David Miller wrote: They DON'T CARE, they want their systems to work and if you don't give them that you're not being a good driver maintainer. Let's push aside attitudes and unrealistic statistics, could we perhaps

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, David Miller wrote: From: Andrew Vasquez [EMAIL PROTECTED] Date: Mon, 16 Apr 2007 14:10:49 -0700 Ok, how about the following patch based on the one you posted which adds the codes to retrieve the WWPN/WWNN from firmware on SPARC, and also adds the module-parameter

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, David Miller wrote: From: Andrew Vasquez [EMAIL PROTECTED] Date: Mon, 16 Apr 2007 15:25:17 -0700 Fine, I'll agree that wacking-users (and I'll wager the outliers) with a 2x4 was a bit extreme, And that, right there, is basically the end of the conversation. You

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, David Miller wrote: From: Andrew Vasquez [EMAIL PROTECTED] Date: Mon, 16 Apr 2007 16:28:51 -0700 Sorry, but let's be realistic, this type of warning would have *NEVER* been addressed if we kept the status quo Wrong. I watch the logs all the time and would have

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, David Miller wrote: From: Andrew Vasquez [EMAIL PROTECTED] Date: Mon, 16 Apr 2007 16:47:05 -0700 Dave, according to your earlier emails, the qla2xxx driver worked 'fine' in driver versions before commit 7aef45ac92f49e76d990b51b7ecd714b9a608be1. If that were

Re: Major qla2xxx regression on sparc64

2007-04-18 Thread Andrew Vasquez
On Wed, 18 Apr 2007, Christoph Hellwig wrote: I don't think a module option is a good idea at this point. The problem is you broke some so far perfectly working setups, which is not okay. The only first step can be printing a really big warning. After this has been in for a while (at lest

Re: Major qla2xxx regression on sparc64

2007-04-19 Thread Andrew Vasquez
based on other archs I can test with embedded ISPs. Thanks again for the SPARC tips. Regards, Andrew Vasquez - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

  1   2   3   >