Re: Kernel support for hot-plugging PCI adapters

2001-03-05 Thread Jeff Garzik
for 'probe', 'id_table', etc. I don't think there is support in the current tree for a controller that supports physical hotplugging of PCI adapters, yet. Compaq has a driver outside the tree to do such a thing (needing only very minor kernel patches), see http://opensource.compaq.com -- Jeff Garzik

Re: scsi bus numbering

2001-04-02 Thread Jeff Garzik
, when you update the 2.4 makefile where link order is significant. (as it is not, in all cases) -- Jeff Garzik | May you have warm words on a cold evening, Building 1024 | a full moon on a dark night, MandrakeSoft | and a smooth road all the way to your door. - To unsubscribe from

Re: [PATCH] scsi/sata write barrier support

2005-01-27 Thread Jeff Garzik
Doug Maxey wrote: On Thu, 27 Jan 2005 13:02:48 +0100, Jens Axboe wrote: Hi, For the longest time, only the old PATA drivers supported barrier writes with journalled file systems. This patch adds support for the same type of cache flushing barriers that PATA uses for SCSI, to be utilized with

Re: [PATCH] scsi/sata write barrier support #2

2005-01-27 Thread Jeff Garzik
Jens Axboe wrote: Hi, A few changes: - Cleanup up the driver additions even more, blk_complete_barrier_rq() does all the work now. - Fixed up the exports - Comment functions - Fixed a bug with SCSI and write back caching disabled - Rename blk_queue_flush() to blk_queue_flushing() to indicate

Re: [PATCH] scsi/sata write barrier support

2005-01-28 Thread Jeff Garzik
Jens Axboe wrote: On Thu, Jan 27 2005, Jeff Garzik wrote: Doug Maxey wrote: On Thu, 27 Jan 2005 13:02:48 +0100, Jens Axboe wrote: Hi, For the longest time, only the old PATA drivers supported barrier writes with journalled file systems. This patch adds support for the same type of cache flushing

Re: [ANNOUNCE] Adaptec SAS/SATA device driver [03/27]

2005-02-17 Thread Jeff Garzik
Luben, Your emails do not comply with the Linux kernel patch submission format. Please read http://linux.yyz.us/patch-format.html Most critical is rule number #5 (signed-off-by line), but also important is rule number #1 (providing a useful subject line). NOTE: I am _not_ requesting that

Re: [ANNOUNCE] Adaptec SAS/SATA device driver [03/27]

2005-02-17 Thread Jeff Garzik
Luben Tuikov wrote: On 02/17/05 14:03, Jeff Garzik wrote: Luben, Your emails do not comply with the Linux kernel patch submission format. Please read http://linux.yyz.us/patch-format.html Most critical is rule number #5 (signed-off-by line), but also important is rule number #1 (providing

Re: [ANNOUNCE] Adaptec SAS/SATA device driver [22/27]

2005-02-17 Thread Jeff Garzik
Comment: You should use libata for your ATA-SCSI translation. Doing so eliminates duplicate code, and ensures that you are compliant with the SAT and ATA passthru specifications from T10. Jeff - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a

[Fwd: [patch libata-dev-2.6 5/5] libata: update ATA pass thru opcodes]

2005-02-18 Thread Jeff Garzik
I thought the Command sets are supposed to be qualified paragraph was worth forwarding to linux-scsi. Jeff ---BeginMessage--- Update ATA pass thru opcodes to match what is specified in the current ATA pass thru spec (T10/04-262r7). Signed-off-by: John W. Linville [EMAIL PROTECTED] ---

Re: [PATCH 04/19] drivers/scsi/ahci: Use the DMA_{64,32}BIT_MASK constants

2005-02-20 Thread Jeff Garzik
On Sun, Feb 20, 2005 at 05:55:30PM +0100, Tobias Klauser wrote: Hello, Description: Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when calling pci_set_dma_mask() or pci_set_consistent_dma_mask() See http://marc.theaimsgroup.com/?t=10800199301r=1w=2 for details Please CC

Re: [ANNOUNCE] iSCSI Initiator Core Stack v1.6.1.20

2005-02-23 Thread Jeff Garzik
Comments from an initial scan of the code. This does not include any review of iSCSI interaction itself. 1) the TRACE stuff uses too much stack space 2) style: way too many interal headers; feel free to disagree, though, this is maintainer's preference. 3) non-standard function definitions:

Re: [PATCH 19/19] drivers/scsi/sata_vsc: Use the DMA_{64,32}BIT_MASK constants

2005-02-23 Thread Jeff Garzik
Applied patch #4 and #19 to libata. Please do not include Hello, or Description: in your patch description, as I must hand-edit these out manually. Jeff - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [Patch] QLogic qla2x00 driver fixes

2005-02-24 Thread Jeff Garzik
Doug Ledford wrote: Don't use cmd-request-nr_hw_segments as it may not be initialized (SG_IO in particular bypasses anything that initializes this and just uses scsi_do_req to insert a scsi_request directly on the head of the queue) and a bogus value here can trip up the checks to make sure that

Re: [Patch] QLogic qla2x00 driver fixes

2005-02-25 Thread Jeff Garzik
Arjan van de Ven wrote: On Thu, 2005-02-24 at 23:21 -0500, Doug Ledford wrote: Don't use cmd-request-nr_hw_segments as it may not be initialized (SG_IO in particular bypasses anything that initializes this and just uses scsi_do_req to insert a scsi_request directly on the head of the queue)

Re: [ANNOUNCE] iSCSI enterprise target software

2005-03-01 Thread Jeff Garzik
Ming Zhang wrote: On Tue, 2005-03-01 at 13:37, Arjan van de Ven wrote: On Tue, 2005-03-01 at 10:24 -0800, Bryan Henderson wrote: One thing that's implicit in your reasons for wanting to be in the kernel is that you've chosen to exploit the kernel's page cache. As a user of the page cache, you

[PATCH 1/3] Fix 3ware irq handling: correct IRQ_HANDLED

2005-03-01 Thread Jeff Garzik
Only indicate irq-handled if that is really true Driver currently returns IRQ_HANDLED for all interrupts. Fix this. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] diff -Nru a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c --- a/drivers/scsi/3w-9xxx.c2005-03-02 02:14:42 -05:00 +++ b/drivers

[PATCH 2/3] Fix 3ware irq handling: remove bogus test

2005-03-01 Thread Jeff Garzik
Remove bogus irq test. Driver tested irq handler's irq argument against the PCI device's pci_dev-irq value, a test which would always succeed. Change this to if (1) to avoid re-indenting the [huge] interrupt handling code. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] diff -Nru a/drivers/scsi/3w

[PATCH 3/3] Fix 3ware irq handling: update irq handler indentation

2005-03-01 Thread Jeff Garzik
) test. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] diff -Nru a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c --- a/drivers/scsi/3w-9xxx.c2005-03-02 02:14:58 -05:00 +++ b/drivers/scsi/3w-9xxx.c2005-03-02 02:14:58 -05:00 @@ -1173,138 +1173,136 @@ /* Get the per adapter lock

Re: [PATCH 3/3] Fix 3ware irq handling: update irq handler indentation

2005-03-01 Thread Jeff Garzik
Jeff Garzik wrote: The previous patch replaced an always-true test with if (1), a function change. er, s/function/functional/ - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [patch 05/11] drivers/scsi/*: convert to pci_register_driver

2005-03-06 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: kj-domen/drivers/scsi/ahci.c |2 +- kj-domen/drivers/scsi/ata_piix.c |2 +- kj-domen/drivers/scsi/sata_nv.c |2 +- kj-domen/drivers/scsi/sata_promise.c |2 +- kj-domen/drivers/scsi/sata_sil.c |2 +-

Re: [BK PATCH] SCSI updates for 2.6.11

2005-03-16 Thread Jeff Garzik
James Bottomley wrote: This is my current tranch of patches that were waiting the transition from -rc to released (sorry it's late ... I've been on holiday). The patch is available here: bk://linux-scsi.bkbits.net/scsi-for-linus-2.6 Are my 3ware bugfixes in the queue? Currently 3ware claims it

Re: [PATCH scsi-misc-2.6 04/08] scsi: remove meaningless volatile qualifiers from structure definitions

2005-03-22 Thread Jeff Garzik
James Bottomley wrote: On Wed, 2005-03-23 at 11:14 +0900, Tejun Heo wrote: scsi_device-device_busy, Scsi_Host-host_busy and -host_failed have volatile qualifiers, but the qualifiers don't serve any purpose. Kill them. While at it, protect -host_failed update in

Re: [patch 062/198] ahci: AHCI mode SATA patch for Intel ESB2

2005-04-12 Thread Jeff Garzik
On Tue, Apr 12, 2005 at 03:31:34AM -0700, [EMAIL PROTECTED] wrote: From: Jason Gaston [EMAIL PROTECTED] This patch adds the Intel ESB2 DID's to the ahci.c file for AHCI mode SATA support. Please don't send libata stuff directly to Linus. Even a patch that appears as simple as this has

Re: [ANNOUNCE] sdparm 0.90

2005-04-18 Thread Jeff Garzik
Douglas Gilbert wrote: sdparm is a new command line utility designed to get and set SCSI disk parameters (cf hdparm for ATA disks). More generally it gets and sets mode page information on SCSI devices or devices that use a SCSI command set (e.g. CD/DVD drives (any transport) and SCSI tape

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Jeff Garzik
On Sat, Jul 09, 2005 at 07:31:38PM -0400, Ben Collins wrote: Thing is, these don't seem to be working for SBP2. I assume these conversions came from libata Incorrect. (since that's the only other user of them). Incorrect. Was the logic compared to the SBP2 conversions before being moved

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Jeff Garzik
On Sat, Jul 09, 2005 at 07:06:56PM -0400, Ben Collins wrote: I can understand that TYPE_RDC is what we had as TYPE_SDAD. Now, in our tree for TYPE_RDC, we converted it to TYPE_DISK. We also did a lot of mode conversions for DISK/RDC/ROM types. This isn't correct. RBC is a separate, valid disk

Re: [PATCH 0/3] Add disk hotswap support to libata

2005-07-21 Thread Jeff Garzik
Lukasz Kosewski wrote: Hey all, introductory blurb here. This sequence of patches will add a framework to libata to allow for hot-swapping disks in and out. There are three patches: 01-promise_sataII150_support 02-libata_hotswap_infrastructure 03-promise_hotswap_support Pretty cool stuff!

Re: [Patch 0/2] Update aic79xx

2005-07-22 Thread Jeff Garzik
Hannes Reinecke wrote: Hi James, I've finished the update of aic79xx to make use of the scsi_transport_spi infrastructure. The first patch is actually jgarzik's one, with some additions to make it work :-) The second patch is the integration proper. patch made a mess of it, however, so better

Re: [PATCH 1/3] Add disk hotswap support to libata

2005-07-26 Thread Jeff Garzik
Lukasz Kosewski wrote: This patch changes the sata_promise driver in libata to correctly mask out hotplug interrupts. The location of the primary hotplug registers in the SATA150 Tx4/Tx2 Plus controllers is correctly defined as '0x6C', HOWEVER, for the SATAII150 Tx4/Tx2 Plus controllers, this

[RFC][PATCH] libata ATAPI alignment

2005-07-28 Thread Jeff Garzik
So, one thing that's terribly ugly about SATA ATAPI is that we need to pad DMA transfers to the next 32-bit boundary, if the length is not evenly divisible by 4. Messing with the scatterlist to accomplish this is terribly ugly no matter how you slice it. One way would be to create my own

Re: sdparm cannot start or stop SATA disks

2005-07-29 Thread Jeff Garzik
Douglas Gilbert wrote: sdparm uses the START STOP UNIT SCSI command to start and stop (spin up and spin down) SCSI devices. Currently libata does not implement that SCSI command. [Hopefully Jeff contradicts me.] Correct. Someone should submit a libata patch for this! Jeff - To

Re: sdparm cannot start or stop SATA disks

2005-07-29 Thread Jeff Garzik
Douglas Gilbert wrote: A further thought about implementing the START STOP UNIT SCSI command in libata: the TEST UNIT READY SCSI command should become more than just a no-op. Correct. Jeff - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message

Re: sdparm cannot start or stop SATA disks

2005-07-29 Thread Jeff Garzik
Douglas Gilbert wrote: I could have a go at the SCSI half of it. According to SAT, START STOP UNIT should only be allowed for non-packet ATA devices. I assume your SATAPI code will the bypass libata-scsi.c SAT layer. Mostly. There is still a few translation bits in there. 99% bypass, not

Re: [RFC][PATCH] libata ATAPI alignment

2005-08-02 Thread Jeff Garzik
Jens Axboe wrote: On Fri, Jul 29 2005, Jeff Garzik wrote: diff --git a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c --- a/drivers/scsi/ahci.c +++ b/drivers/scsi/ahci.c @@ -44,7 +44,7 @@ enum { AHCI_PCI_BAR= 5, - AHCI_MAX_SG = 168, /* hardware max is 64K

Re: [PATCH] uninline exported ata_host_intr

2005-08-05 Thread Jeff Garzik
Olaf Hering wrote: ata_host_intr cant be either inline or exported. Signed-off-by: Olaf Hering [EMAIL PROTECTED] Index: linux-2.6.12/drivers/scsi/libata-core.c === --- linux-2.6.12.orig/drivers/scsi/libata-core.c +++

Re: [PATCH] uninline exported ata_host_intr

2005-08-05 Thread Jeff Garzik
Olaf Hering wrote: On Fri, Aug 05, Jeff Garzik wrote: When I wrote this, the compiler did what I expected: it inlined the local copy, and exported a copy for external modules to call. so you have the code twice? how clever... This is one of the key hot paths in the driver. Considering

Re: [PATCH 3/3] PCI, scsi, ahci: Unify usages of 0x1b4b vendor ID to use PCI_VENDOR_ID_MARVELL_EXT

2013-04-08 Thread Jeff Garzik
On 04/04/2013 02:23 PM, Bjorn Helgaas wrote: On Wed, Mar 20, 2013 at 10:35 PM, Myron Stowe myron.st...@redhat.com wrote: With the 0x1b4b vendor ID #define in place, convert hard-coded ID values. Also, unify the previous SCSI specific use of this vendor ID to the new macro. Signed-off-by: Myron

Re: [PATCH 09/24] libata-scsi: convert to use the data buffer accessors

2007-09-11 Thread Jeff Garzik
I would much rather see the !use_sg cleanup in a separate patch series... Jeff - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

2007-09-14 Thread Jeff Garzik
Stefan Richter wrote: Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- Applicable to 2.6.23-rc6 and to scsi-misc. drivers/scsi/Kconfig | 32 1 file changed, 20 insertions(+), 12 deletions(-) ACK - To unsubscribe from this list: send the line

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-14 Thread Jeff Garzik
Gilbert Wu wrote: Fixed the problem that smartctl -a /dev/some_sata_disk -d ata does not work on SATA device. ( The smartctl v5.38 does need -d ata option.) The aic94xx need to return ATA output register for all ATA commands except ATA Read/Write commands. The aic94xx also mark out the DRQ

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-14 Thread Jeff Garzik
Gilbert Wu wrote: Fixed the problem that smartctl -a /dev/some_sata_disk -d ata does not work on SATA device. ( The smartctl v5.38 does need -d ata option.) The aic94xx need to return ATA output register for all ATA commands except ATA Read/Write commands. The aic94xx also mark out the DRQ

Re: [RFC PATCH] SCSI: split Kconfig menu into two

2007-09-15 Thread Jeff Garzik
Stefan Richter wrote: Adrian Bunk wrote: On Sat, Sep 15, 2007 at 04:11:45PM +0200, Stefan Richter wrote: Perfect is in the eye of the beholder. You would consequently have to add such options into all menus which contain scsi low-level providers. Kconfig is a user interface, so perfect is

Re: [RFC PATCH] SCSI: split Kconfig menu into two

2007-09-15 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: On Saturday 15 September 2007, Adrian Bunk wrote: On Sat, Sep 15, 2007 at 11:44:59AM -0400, Jeff Garzik wrote: Stefan Richter wrote: Adrian Bunk wrote: On Sat, Sep 15, 2007 at 04:11:45PM +0200, Stefan Richter wrote: Perfect is in the eye of the beholder

Re: [PATCH] set supported_mode for lots of llds

2007-09-15 Thread Jeff Garzik
FUJITA Tomonori wrote: The majority of llds don't set supported_mode in scsi_host_template so we get: luce:/sys/class/scsi_host/host0$ cat supported_mode unknown It's harmless but it would be better to get: luce:/sys/class/scsi_host/host0$ cat supported_mode Initiator Given that this is the

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-16 Thread Jeff Garzik
James Bottomley wrote: On Sat, 2007-09-15 at 12:05 -0500, James Bottomley wrote: On Fri, 2007-09-14 at 10:58 -0700, Gilbert Wu wrote: Fixed the problem that smartctl -a /dev/some_sata_disk -d ata does not work on SATA device. ( The smartctl v5.38 does need -d ata option.) The aic94xx need

Re: [patchset 0/24] Lots of the Accessors patches and !use_sg cleanup

2007-09-17 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: On Monday 17 September 2007, James Bottomley wrote: Realistically (and I hate myself for saying this) libata-pata does provide a much better alternative for the ATAPI devices. Is it just time to recognise the inevitable and kill ide-scsi? Agreed, libata-pata

Re: [patchset 0/24] Lots of the Accessors patches and !use_sg cleanup

2007-09-17 Thread Jeff Garzik
James Bottomley wrote: On Mon, 2007-09-17 at 16:57 -0400, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: On Monday 17 September 2007, James Bottomley wrote: Realistically (and I hate myself for saying this) libata-pata does provide a much better alternative for the ATAPI devices

Re: [PATCH ver2 1/2] libata-scsi: Remove !use_sg code paths

2007-09-20 Thread Jeff Garzik
Boaz Harrosh wrote: This is a minimal patch needed to remove use of !use_sg but it is not a complete clean up of the !use_sg paths. Libata-core still has the qc-flags ATA_QCFLAG_SG and !qc-n_elem code paths. Perhaps an ata maintainer would have a go at it. - TODO:

[PATCH] libata: translate INQUIRY VPD page 89h (ATA info)

2007-09-21 Thread Jeff Garzik
commit a6d5ac6a3a1cfbed2a045928bbadd5285f1df084 Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Sep 21 05:07:19 2007 -0400 [libata] SCSI: support INQUIRY page 89h (ATA info page) Signed-off-by: Jeff Garzik [EMAIL PROTECTED] drivers/ata/libata-scsi.c | 82

[PATCH] libata: slightly improved req-sense, send-diag no-ops

2007-09-21 Thread Jeff Garzik
commit 8a7a20fb60d9746ec68a876aade1f14c4f2b7b46 Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Sep 21 06:23:42 2007 -0400 [libata] Slightly improved no-op REQUEST SENSE, SEND DIAGNOSTIC A few pedantic apps care about missing or lame mandatory SCSI commands, so

Re: [PATCH] libata: slightly improved req-sense, send-diag no-ops

2007-09-21 Thread Jeff Garzik
Alan Cox wrote: REQUEST SENSE -- as we autosense, R.S. just returns zeroes SEND DIAGNOSTIC -- our default (no-op) self-test succeeds, all other requests for testing fail. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Acked-by: Alan Cox [EMAIL PROTECTED

[PATCH] libata: simple TEST UNIT READY simulation

2007-09-21 Thread Jeff Garzik
As per SAT (sans removable devices)... commit 09d9637c413406cf63f0e1efb364411ac8a9243c Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Sep 21 07:09:36 2007 -0400 [libata] SCSI: simple TEST UNIT READY simulation It's trivial to ping the device, and that's a much more sane

[PATCH] libata: improve FORMAT UNIT; minor code cleanups

2007-09-21 Thread Jeff Garzik
commit ee67edb0e7701f8ae9114692837a8bbee9f99a35 Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Sep 21 07:26:08 2007 -0400 [libata] SCSI: improve FORMAT UNIT; minor code cleanups * SAT specifies that FORMAT UNIT should be translated into a series of READ and WRITE commands

[PATCH] libata: clean up R/W recovery mode page

2007-09-21 Thread Jeff Garzik
commit 14052d9ba16b826e4bc79db4b2b77e451faf0b01 Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Sep 21 07:54:49 2007 -0400 [libata] SCSI: clean up R/W recovery mode page Clear ARRE, we don't do auto-reallocation on reads, just on writes. Also, hardcode the size

Re: [PATCH] libata: translate INQUIRY VPD page 89h (ATA info)

2007-09-21 Thread Jeff Garzik
James Bottomley wrote: On Fri, 2007-09-21 at 05:48 -0400, Jeff Garzik wrote: commit a6d5ac6a3a1cfbed2a045928bbadd5285f1df084 Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Sep 21 05:07:19 2007 -0400 [libata] SCSI: support INQUIRY page 89h (ATA info page) Signed-off-by: Jeff

Re: [PATCH] libata: translate INQUIRY VPD page 89h (ATA info)

2007-09-21 Thread Jeff Garzik
James Bottomley wrote: On Fri, 2007-09-21 at 05:48 -0400, Jeff Garzik wrote: commit a6d5ac6a3a1cfbed2a045928bbadd5285f1df084 Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Sep 21 05:07:19 2007 -0400 [libata] SCSI: support INQUIRY page 89h (ATA info page) Signed-off-by: Jeff

[PATCH v2] libata: translate INQUIRY VPD page 89h (ATA info)

2007-09-21 Thread Jeff Garzik
Ditched ATAPI, fixed a bug, a few clean-ups and fixmes taken care of. commit a1c69f03a85fe6fa1b7f2f3726dd7205eb68a328 Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Sep 21 20:38:03 2007 -0400 [libata] SCSI: support INQUIRY page 89h (ATA info page) Signed-off-by: Jeff Garzik

Re: [PATCH v2] libata: translate INQUIRY VPD page 89h (ATA info)

2007-09-21 Thread Jeff Garzik
Jeff Garzik wrote: + memcpy(pbuf[8], ATA , 8); + ata_id_string(args-id, pbuf[16], ATA_ID_PROD, 16); + ata_id_string(args-id, pbuf[32], ATA_ID_FW_REV, 4); And I just checked in a fix that changes the above to reflect the SCSI simulator's vendor/product/version (linux

[PATCH] Broadcom 8603 SAS/SATA driver, rough draft

2007-09-22 Thread Jeff Garzik
/scsi/Kconfig| 10 + drivers/scsi/Makefile |1 + drivers/scsi/broadsas.c | 997 +++ 3 files changed, 1008 insertions(+), 0 deletions(-) create mode 100644 drivers/scsi/broadsas.c Jeff Garzik (1): Add rough draft Broadcom 8603 SAS/SATA

Re: [PATCH] Broadcom 8603 SAS/SATA driver, rough draft

2007-09-23 Thread Jeff Garzik
Douglas Gilbert wrote: Is the lack of SMP support a driver limitation or is it the silicon? How about support for wide ports (i.e. when 2 or more HBA phys are attached to remote phys which have the same SAS addresses)? Last question: can the chip run in SCSI target mode? Just for

Re: [PATCH] Broadcom 8603 SAS/SATA driver, rough draft

2007-09-23 Thread Jeff Garzik
James Bottomley wrote: On Sun, 2007-09-23 at 19:43 -0400, Jeff Garzik wrote: James Bottomley wrote: On Sun, 2007-09-23 at 00:04 -0400, Jeff Garzik wrote: Rather than sitting on this for far too long, I wanted to go ahead and get this out there. I heard some chips might be trickling out

Re: [PATCH] Broadcom 8603 SAS/SATA driver, rough draft

2007-09-24 Thread Jeff Garzik
James Bottomley wrote: On the other hand, I think I can find a nice lever to move Marvell with, so I'll take this on without needing potentially to compromise your contacts. FWIW Marvell is moving quite nicely... they are actively providing docs under NDA, and sometimes sample code (or even

Re: [PATCH 0/4] more gdth patches for your amusement

2007-09-24 Thread Jeff Garzik
James Bottomley wrote: On Sat, 2007-07-21 at 16:34 -0400, Jeff Garzik wrote: This is the rest of the stuff checked into the 'gdth' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git As noted before, I'm fine with Christoph's gdth work superceding mine, or whatever

[PATCH] Marvell 6440 SAS/SATA driver (rough draft)

2007-09-25 Thread Jeff Garzik
+ drivers/scsi/mvsas.c| 1064 +++ 4 files changed, 2111 insertions(+), 0 deletions(-) create mode 100644 drivers/scsi/broadsas.c create mode 100644 drivers/scsi/mvsas.c Jeff Garzik (3): Add Broadcom 8603 SAS/SATA driver (rough

Re: [PATCH 6/9] mpt fusion: error recovery improvements,andsynchronizing internal commands

2007-09-25 Thread Jeff Garzik
Moore, Eric wrote: On Tuesday, September 25, 2007 11:32 AM, James Bottomley wrote: Youve rejected the error recovery patchs, which is fair enough. Just the separation ... the actual patch looks OK. I'll will continue working to separate the error recovery improvements: into smaller

Re: [PATCH 6/9] mpt fusion: error recovery improvements,andsynchronizing internal commands

2007-09-25 Thread Jeff Garzik
Michael Reed wrote: Jeff Garzik wrote: Moore, Eric wrote: On Tuesday, September 25, 2007 11:32 AM, James Bottomley wrote: Youve rejected the error recovery patchs, which is fair enough. Just the separation ... the actual patch looks OK. I'll will continue working to separate the error

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread Jeff Garzik
FUJITA Tomonori wrote: diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c index adc9559..694015d 100644 --- a/drivers/scsi/hosts.c +++ b/drivers/scsi/hosts.c @@ -342,6 +342,10 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread Jeff Garzik
Matthew Wilcox wrote: On Tue, Sep 25, 2007 at 10:37:33PM -0400, Jeff Garzik wrote: Are there any const-ness worries for scsi_host_template, or plans for the future? I do not see any other examples of the host template members getting modified. Goodness, Jeff, you haven't looked too hard

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread Jeff Garzik
James Bottomley wrote: This whole mess is generated basically because the zero default of the template should be treated as initiator. How about this, which makes that manifest? James diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c index adc9559..7e26440 100644 ---

[PATCH 1/8] gdth: Split out EISA and ISA register into separate functions

2007-09-25 Thread Jeff Garzik
An equivalent-transformation change. No functional changes beyond those necessary to call the new, split-out functions. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] --- diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index b20c188..f330d34 100644 --- a/drivers/scsi/gdth.c +++ b/drivers

[PATCH 2/8] gdth: Split out PCI register into separate function

2007-09-25 Thread Jeff Garzik
An equivalent-transformation change. No functional changes beyond those necessary to call the new function. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] --- diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index f330d34..840bdf6 100644 --- a/drivers/scsi/gdth.c +++ b/drivers/scsi

[PATCH 3/8] gdth: Remove 2.4.x support, in-kernel changelog

2007-09-25 Thread Jeff Garzik
% redundant in modern kernels. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] --- diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index 840bdf6..a6b5717 100644 --- a/drivers/scsi/gdth.c +++ b/drivers/scsi/gdth.c @@ -27,280 +27,8 @@ * along with this kernel; if not, write to the Free Software

[PATCH 4/8] gdth: Isolate driver-global variables using helpers

2007-09-25 Thread Jeff Garzik
between gdth_ctr_count and gdth_ctr_vcount. The whole virtual-controller stuff needs reviewing for edge cases. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] --- diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index a6b5717..b9d1f69 100644 --- a/drivers/scsi/gdth.c +++ b/drivers/scsi/gdth.c

[PATCH 6/8] gdth: Move probe-time error handling code to end of each function

2007-09-25 Thread Jeff Garzik
Use standard laddered-goto error handling approach in three probe-time functions. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] --- diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index d7ef159..89ac155 100644 --- a/drivers/scsi/gdth.c +++ b/drivers/scsi/gdth.c @@ -3964,13 +3964,11

[PATCH 8/8] gdth: convert to modern SCSI host alloc/scan

2007-09-25 Thread Jeff Garzik
Signed-off-by: Jeff Garzik [EMAIL PROTECTED] --- diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index f382664..3f3ef4b 100644 --- a/drivers/scsi/gdth.c +++ b/drivers/scsi/gdth.c @@ -3960,7 +3960,7 @@ static int __init gdth_register_virt(struct scsi_host_template *shtp, { struct

[PATCH 5/8] gdth: kill gdth_{read,write}[bwl] wrappers

2007-09-25 Thread Jeff Garzik
They are direct equivalents to {read,write}[bwl]. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] --- diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index b9d1f69..d7ef159 100644 --- a/drivers/scsi/gdth.c +++ b/drivers/scsi/gdth.c @@ -294,13 +294,6 @@ static struct timer_list gdth_timer

[PATCH] SCSI: export sas_hash_addr()

2007-09-26 Thread Jeff Garzik
sas_hash_addr() is the spec-defined standard hashing function. Make it available to drivers that need it. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] diff --git a/drivers/scsi/libsas/sas_init.c b/drivers/scsi/libsas/sas_init.c index 9cd5abe..13c3d21 100644 --- a/drivers/scsi/libsas/sas_init.c

Re: [PATCH 1/5] add dma_max_segment_size option to scsi_host_template

2007-09-26 Thread Jeff Garzik
FUJITA Tomonori wrote: This patch moves blk_queue_max_segment_size to scsi_alloc_queue from llds. It enables scsi_add_host to tells iommu lld's dma_max_segment_size. If a low-level driver doesn't specify dma_max_segment_size, scsi-ml uses 65536 (MAX_SEGMENT_SIZE). So there are not any functional

Re: [PATCH 1/5] add dma_max_segment_size option to scsi_host_template

2007-09-26 Thread Jeff Garzik
FUJITA Tomonori wrote: On Wed, 26 Sep 2007 06:11:45 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: FUJITA Tomonori wrote: This patch moves blk_queue_max_segment_size to scsi_alloc_queue from llds. It enables scsi_add_host to tells iommu lld's dma_max_segment_size. If a low-level driver doesn't

Re: [PATCH 1/5] add dma_max_segment_size option to scsi_host_template

2007-09-27 Thread Jeff Garzik
FUJITA Tomonori wrote: You are right. scsi_debug's pseudo-bus works. But probabaly, scsi_debug doesn't need to call blk_queue_max_segment_size now. Either way works for me. :) Maybe dev_set_max_seg() is a better name, if people get really picky (I don't care). How about

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-27 Thread Jeff Garzik
FUJITA Tomonori wrote: CC'ed Jens, James, and linux-scsi. On Thu, 27 Sep 2007 03:31:55 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: FUJITA Tomonori wrote: Yeah, we could nicely handle lld's restrictions (especially with stacking devices). But iommu code needs only max_segment_size

generating a Linux WWN?

2007-09-27 Thread Jeff Garzik
Is there an accepted way to generate a SAS address, when the adapter does not supply one (NVRAM invalid or missing, etc.)? Unless somebody complains, I was just planning to use get_random_bytes(). But maybe Linux has an IEEE id we can use, to make the practice a bit more legitimate and avoid

Re: generating a Linux WWN?

2007-09-27 Thread Jeff Garzik
James Smart wrote: Uh, although this may work very well for small constrained configs, as one who debugs larger environments (and things always grow or get connected in ways you don't expect), depending on a random number for uniqueness makes me very unsettled. Debugging that small-percentage

Re: generating a Linux WWN?

2007-09-27 Thread Jeff Garzik
Matthew Wilcox wrote: On Thu, Sep 27, 2007 at 09:16:13AM -0500, [EMAIL PROTECTED] wrote: Unfortunately, it looks like IEEE doesn't have any OID's registered for Linux or other reserved areas (http://standards.ieee.org/regauth/oui/oui.txt). However, it does look like they go in order... so maybe

Re: generating a Linux WWN?

2007-09-27 Thread Jeff Garzik
Michael Reed wrote: Record the WWN of your SAS / FC port so that if/when it goes missing you can put it back? Have spares on site? Linux: not just for million dollar data centers any more :) (sorry, couldn't resist :)) More seriously, SAS will be making an increasing appearance on

[PATCH] aic94xx: fix SMP request DMA direction

2007-09-27 Thread Jeff Garzik
Unless I'm missing something, the SMP request goes /to/ the PCI device :) Signed-off-by: Jeff Garzik [EMAIL PROTECTED] --- drivers/scsi/aic94xx/aic94xx_task.c |4 - 2 files changed, 83 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/aic94xx/aic94xx_task.c b/drivers/scsi/aic94xx

Re: [PATCH] 3w-9xxx: use PCI resource length correctly

2007-09-28 Thread Jeff Garzik
Eduardo Habkost wrote: Trying to ioremap() a larger area than pci_resource_len() may fail (e.g. under Xen). Fixes 3w-9xxx to use pci_resource_len() as length parameter to ioremap() instead of PAGE_SIZE. Signed-off-by: Eduardo Habkost [EMAIL PROTECTED] --- drivers/scsi/3w-9xxx.c | 14

Re: [PATCH] aic94xx: fix SMP request DMA direction

2007-09-29 Thread Jeff Garzik
Muli Ben-Yehuda wrote: On Fri, Sep 28, 2007 at 04:55:34PM -0700, Darrick J. Wong wrote: On Thu, Sep 27, 2007 at 10:33:41PM -0400, Jeff Garzik wrote: Unless I'm missing something, the SMP request goes /to/ the PCI device :) Signed-off-by: Jeff Garzik [EMAIL PROTECTED] ACK; builds ok and SMP

[PATCH] aic94xx: fix SSP IU status print-out

2007-09-30 Thread Jeff Garzik
The SSP response DPRINTK in asd_get_response_tasklet() was printing a hardcoded status result, rather than the status from the SSP response IU. Arguably, this should not be a DPRINTK either, since the admin might want to know about this. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] --- drivers

Re: [PATCH] SCSI: export sas_hash_addr()

2007-09-30 Thread Jeff Garzik
James Bottomley wrote: On Thu, 2007-09-27 at 21:01 -0400, Jeff Garzik wrote: James Bottomley wrote: On Wed, 2007-09-26 at 03:35 -0400, Jeff Garzik wrote: sas_hash_addr() is the spec-defined standard hashing function. Make it available to drivers that need it. I'm not opposed in principle

Re: [PATCH] SCSI: export sas_hash_addr()

2007-09-30 Thread Jeff Garzik
Jeff Garzik wrote: James Bottomley wrote: On Thu, 2007-09-27 at 21:01 -0400, Jeff Garzik wrote: James Bottomley wrote: On Wed, 2007-09-26 at 03:35 -0400, Jeff Garzik wrote: sas_hash_addr() is the spec-defined standard hashing function. Make it available to drivers that need it. I'm

Re: [RFC 0/16] gdth combined patchset call for testers

2007-09-30 Thread Jeff Garzik
Boaz Harrosh wrote: [8/16] gdth: Remove virt hosts - Christoph Boaz Here we need an executive decision! The issue is as stated by Christoph: The virt_ctr option allows to register a new scsi_host for each bus on the raid controller. This non-default option makes no sense with

Re: [RFC 0/16] gdth combined patchset call for testers

2007-09-30 Thread Jeff Garzik
Boaz Harrosh wrote: [11/16] gdth: switch to modern scsi host registration - Christoph Christoph what is missing from here is the remove of the deprecated pci_find_device() call. Can I Just use pci_get_device() of the same signature or do I need to call some other pci_ members after that?

Re: [RFC 0/16] gdth combined patchset call for testers

2007-09-30 Thread Jeff Garzik
BTW, when reposting the patches of others, its nice to add a From: header to the very first line of the email body. Andrew does that a lot, and the git tools are aware of this convention. Also, hey, if you like our patches, I think you should add your own Signed-off-by line (assuming/hoping

Re: [RFC 0/16] gdth combined patchset call for testers

2007-09-30 Thread Jeff Garzik
Christoph Hellwig wrote: The big problem with the pci_driver conversion is that lack of device ids in the driver. A few years ago I sent Achim a mail to ask if there's a definitive list of used PCI ids, but didn't get an answer - maybe the mail bounced. If we can't get this list we'd have to

Re: [RFC 0/16] gdth combined patchset call for testers

2007-09-30 Thread Jeff Garzik
The patchset looks pretty good to me, overall. Thanks for pulling all this stuff together! Jeff - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: slave_configure for qlogicpti

2007-09-30 Thread Jeff Garzik
David Miller wrote: It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}() so you can kill those off too. Seeing as how they are exact duplicates of libata's ata_scsi_rbuf_{get,put}, I wonder how they got there in the first place (rather than becoming common code), and I wonder

Re: slave_configure for qlogicpti

2007-10-01 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik [EMAIL PROTECTED] Date: Sun, 30 Sep 2007 20:52:45 -0400 David Miller wrote: It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}() so you can kill those off too. Seeing as how they are exact duplicates of libata's ata_scsi_rbuf_{get,put

Re: [PATCH 13/16] gdth: Make one abuse of scsi_cmnd less obvious

2007-10-01 Thread Jeff Garzik
Boaz Harrosh wrote: - Christoph or Jeff will work on the finish up of the BUS hotplug API. I have looked at code examples elsewhere in the kernel, and Jeff's master plan sounds very good. But I would hope not to do it myself as it will take me much longer. Jeff it sounds like you have

Re: [PATCH] aic94xx: fix SSP IU status print-out

2007-10-02 Thread Jeff Garzik
James, what is the upstream status of my two aic94xx bug fixes? Have they been sent to Linus yet? Since you seem M.I.A., I'll send them upstream if I do not hear from you today. Jeff - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to

  1   2   3   4   5   >