None of the filesystems appear interested in using the integrity tagging
feature. Potentially because very few storage devices actually permit
using the application tag space.
Deprecate the tagging functions.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
Documentation/block
a pointer to the
integrity payload (when applicable).
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
Documentation/block/data-integrity.txt | 10 +-
block/bio-integrity.c | 23 ---
drivers/scsi/sd_dif.c | 8
The T10 Protection Information format is also used by some devices that
do not go through the SCSI layer (virtual block devices, NVMe). Relocate
the relevant functions to a library that can be used without involving
SCSI.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
block
The protection interval is not necessarily tied to the logical block
size of a block device. Stop using the terms sector and sectors.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
block/bio-integrity.c | 46 +-
block/blk-integrity.c
We'd occasionally merge requests with conflicting integrity flags.
Introduce a merge helper which checks that the requests have compatible
integrity payloads.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
block/blk-integrity.c | 36 ++--
block
Introduce a set of error codes that can be used by the block integrity
subsystem to signal which class of error was encountered by either the
I/O controller or the storage device.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
block/blk-core.c | 12
Add a BLK_ prefix to the integrity profile flags. Also rename the flags
to be more consistent with the generate/verify terminology in the rest
of the integrity code.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
block/bio-integrity.c | 4 ++--
block/blk-integrity.c | 43
bip_buf is not really needed so we can remove it.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
block/bio-integrity.c | 10 ++
include/linux/bio.h | 3 ---
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/block/bio-integrity.c b/block/bio-integrity.c
Instead of the operate parameter we pass in a seed value and a pointer
to a function that can be used to process the integrity metadata. The
generation function is changed to have a return value to fit into this
scheme.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
block/bio
with protection information.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
Documentation/ABI/testing/sysfs-block | 9 +
block/blk-integrity.c | 11 +++
drivers/scsi/sd_dif.c | 8 +++-
include/linux/blkdev.h| 1 +
4
Make the choice of checksum a per-I/O property by introducing a flag
that can be inspected by the SCSI layer.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
block/bio-integrity.c | 3 +++
drivers/scsi/sd_dif.c | 6 --
include/linux/bio.h| 1 +
include/linux/blkdev.h
property.
Update sd_protect_op to communicate the relevant information to the
low-level device driver via a set of flags in scsi_cmnd.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
drivers/scsi/sd.c| 56
drivers/scsi/sd.h
a pointer to the
integrity payload (when applicable).
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
Documentation/block/data-integrity.txt | 10 +-
block/bio-integrity.c | 23 ---
drivers/scsi/sd_dif.c | 8
K. Petersen martin.peter...@oracle.com
---
block/blk-lib.c| 85 ++
include/linux/blkdev.h | 2 ++
2 files changed, 87 insertions(+)
diff --git a/block/blk-lib.c b/block/blk-lib.c
index 97a733cf3d5f..5a0afc6e933e 100644
--- a/block/blk-lib.c
.
The copy block range limit can be overridden in scsi_disk's
max_copy_block sysfs attribute.
sd_setup_copy_command() is used to prepare any REQ_COPY requests. The
relevant descriptors are placed in a payload page akin to REQ_DISCARD.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
Copy offloading requires us to know the NAA descriptor for both source
target device. This descriptor is mandatory in the Device Identification
VPD page. Locate this descriptor in the returned VPD data so we don't
have to do lookups for every copy command.
Signed-off-by: Martin K. Petersen
| 21 ++
include/linux/blkdev.h | 22 ++
include/scsi/scsi_device.h |3
include/uapi/linux/fs.h|1
18 files changed, 553 insertions(+), 41 deletions(-)
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from
. This
descriptor contains the source bdev and source sector for the copy
operation. Target bdev/sector/size are described by the bio proper.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
Documentation/ABI/testing/sysfs-block | 9 +
block/blk-core.c | 5
Add an ioctl which can be used to clone a block range within a single
block device. This is useful for testing the copy offload code.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
block/ioctl.c | 35 +++
include/uapi/linux/fs.h | 1
.
Yep. That's what I used for development.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
With the old stack we'd be stuck at 512KB because the sg limitations
caused us to come just short of 1MB...
--
Martin K. Petersen Oracle Linux Engineering
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Matthew == Matthew Wilcox [EMAIL PROTECTED] writes:
Matthew After three weeks with no discussion, I guess it may as well
Matthew be applied.
Matthew scsi: Better error messages when device not ready
Looks good to me.
Acked-by: Martin K. Petersen [EMAIL PROTECTED]
--
Martin K. Petersen
that we'll use
READ(10) for LBAs below 2TB and READ(16) for LBAs above (assuming 512
byte sectors).
READ(32) / WRITE(32) are slightly different and are there to support
devices formatted with DIF Type 2 protection.
--
Martin K. Petersen Oracle Linux Engineering
-
To unsubscribe from this list
jidong == jidong xiao [EMAIL PROTECTED] writes:
jidong I know sg_modes can help to perform a SCSI MODE SENSE command,
jidong is there any tool/command that can perform a READ Capacity
jidong command?
sg_readcap
--
Martin K. Petersen Oracle Linux Engineering
-
To unsubscribe from
help...
--
Martin K. Petersen http://mkp.net/
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Martin K. Petersen Oracle Linux Engineering
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
of this. It can probably be fixed by
James including blkdev.h from scsi_device.h
You must have had a reject on scsi_device.h. My patch did include
linux/blkdev.h to fix that very issue.
--
Martin K. Petersen Oracle Linux Engineering
-
To unsubscribe from this list: send the line unsubscribe linux
Eric == Moore, Eric [EMAIL PROTECTED] writes:
Eric Martin K. Petersen on Data Intergrity Feature, which is also
Eric called EEDP(End to End Data Protection), which he presented some
Eric ideas/suggestions of adding an API in linux for this.
T10 DIF is interesting for a few things
similar) in the ATA camp. So for now it's a SCSI-only thing.
I encourage people to lean on their favorite disk manufacturer. This
would be a great feature to have on SATA too...
--
Martin K. Petersen Oracle Linux Engineering
-
To unsubscribe from this list: send the line unsubscribe linux
() with
scsi_print_result() which is verbose when CONFIG_SCSI_CONSTANTS is
on.
Signed-off-by: Martin K. Petersen [EMAIL PROTECTED]
---
drivers/scsi/constants.c | 267 +--
include/scsi/scsi_dbg.h | 10 +
2 files changed, 151 insertions(+), 126 deletions
This patch enhances SCSI error printing by:
- Making use of scsi_print_result() in the completion functions.
- Having scmd_printk() output the disk name (when applicable).
Signed-off-by: Martin K. Petersen [EMAIL PROTECTED]
---
drivers/scsi/scsi.c| 47
that output is
consistent
Signed-off-by: Martin K. Petersen [EMAIL PROTECTED]
---
drivers/scsi/sd.c | 253 --
include/scsi/sd.h | 70 ++
2 files changed, 165 insertions(+), 158 deletions(-)
Index: scsi-misc-2.6/drivers/scsi/sd.c
Convert the sd.c SCSI logging calls to scmd_printk()/sd_printk()
instead of plain printk().
Signed-off-by: Martin K. Petersen [EMAIL PROTECTED]
---
sd.c | 50 +-
1 files changed, 29 insertions(+), 21 deletions(-)
Index: scsi-misc-2.6
Add missing additional sense code and provide pointer to upstream
reference (from Doug Gilbert).
Signed-off-by: Martin K. Petersen [EMAIL PROTECTED]
---
constants.c |5 +
1 files changed, 5 insertions(+)
Index: scsi-misc-2.6/drivers/scsi/constants.c
for all the other sectors
Eric within the boundary.
In other words you only support one app tag per request and not per
sector?
--
Martin K. Petersen Oracle Linux Engineering
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED
Add missing additional sense code and provide pointer to upstream
reference (from Doug Gilbert).
Add missing const (from Michael Tokarev).
Signed-off-by: Martin K. Petersen [EMAIL PROTECTED]
---
constants.c |7 ++-
1 files changed, 6 insertions(+), 1 deletion(-)
Index: scsi-misc
Daniel == Daniel J Priem [EMAIL PROTECTED] writes:
Daniel - * http://www.t10.org/lists/asc-num.txt+ */
Daniel + * http://www.t10.org/lists/asc-num.txt */
Daniel its a typo.
The diff looks fine both here and in the archives. Maybe your mailer
mangled it?
--
Martin K. Petersen Oracle
James == James Bottomley [EMAIL PROTECTED] writes:
James However, I could see the SATA manufacturers selling capacity at
James 512 (or the new 4096) sectors but allowing their OEMs to
James reformat them 520 (or 4160)
4104. It's 8 bytes per hardware sector. At least for T10...
--
Martin K
an incorrect NVDATA flag
from within the driver.
Instead LSI has promised to revert to the original behavior in their
firmware/NVDATA updates. Eric, can you give us an update? There was
another bug report on linux-scsi just a couple of weeks ago.
--
Martin K. Petersen Oracle Linux Engineering
block to unmap + 1. However in
Lukas the condition it is handled as the last block of the region to
Lukas unmap.
Acked-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi
quite finish the block stuff, mainly due to
some conflicts with a few topology changes I also have pending.
I'll take a look at your series. Maybe I'll swap things around and put
the topology changes on top instead of below. Leverage some of the work
you did...
--
Martin K. Petersen Oracle
logical block sizes that are not powers of two.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
in the Standard Inquiry VPD
page). We don't support driving the HBA in PI mode with a non-PI target.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info
/disable/configure T10 PI for
Pasi md/dm raid? Perhaps the
Pasi bdev/integrite/{write_enable|read_verify} work directly for the
Pasi md/dm device?
You don't have to configure anything. If all component devices are
capable the md/dm device will register a suitable integrity profile.
--
Martin K
provide the same LBA count
regardless of whether PI is enabled or not. So there isn't much point in
not enabling it.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More
of metadata for a parity sector is not valid T10 protection
information, for instance.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
error
handling code. However, for some fast-fail scenarios it is necessary to
be able to tune this as it can take several iterations (bus device,
target, bus, controller) before we give up.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
diff --git a/Documentation/ABI/testing/sysfs
respectively. There are separate metrics for reads and writes and
the reported device alignment is taken into account. The statistics are
available in block/alignment_stat and block/part/alignment_stat. The
output format is documented in Documentation/ABI/testing/sysfs-block.
Signed-off-by: Martin K. Petersen
From: Martin K. Petersen martin.peter...@oracle.com
It does not make sense to translate ref tags with unexpected values.
Instead we simply ignore them and let the upper layers catch the
problem. Ref tags that contain the expected value are still remapped.
Signed-off-by: Martin K. Petersen
From: Martin K. Petersen martin.peter...@oracle.com
We have encountered a few devices that misbehaved when operating in T10
PI mode. Allow T10 PI protection type to be overridden from userland.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
drivers/scsi/sd.c | 25
From: Martin K. Petersen martin.peter...@oracle.com
Hitachi Ultrastar 15K300 is quirky. Disable T10 PI (DIF).
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
---
drivers/scsi/scsi_devinfo.c |1 +
drivers/scsi/scsi_scan.c|3 +++
include/scsi/scsi_device.h |4
From: Martin K. Petersen martin.peter...@oracle.com
Only a target device should return ABORTED COMMAND when a PI error is
discovered. The HBA should always set the sense key to ILLEGAL REQUEST.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
Cc: nagalakshmi.nandig...@lsi.com
Cc
From: Martin K. Petersen martin.peter...@oracle.com
Add a parameter that allows the host protection capabilities mask to be
provided at module load time.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
Cc: nagalakshmi.nandig...@lsi.com
Cc: eric.mo...@lsi.com
---
drivers/scsi
From: Martin K. Petersen martin.peter...@oracle.com
- blk_check_merge_flags() verifies that cmd_flags / bi_rw are
compatible. This function is called for both req-req and req-bio
merging.
- blk_rq_get_max_sectors() and blk_queue_get_max_sectors() can be used
to query the maximum
From: Martin K. Petersen martin.peter...@oracle.com
If the device supports WRITE SAME, use that to optimize zeroing of
blocks. If the device does not support WRITE SAME or if the operation
fails, fall back to writing zeroes the old-fashioned way.
Signed-off-by: Martin K. Petersen martin.peter
From: Martin K. Petersen martin.peter...@oracle.com
Remove special-casing of non-rw fs style requests (discard). The nomerge
flags are consolidated in blk_types.h, and rq_mergeable() and
bio_mergeable() have been modified to use them.
bio_is_rw() is used in place of bio_has_data() a few places
From: Martin K. Petersen martin.peter...@oracle.com
Introduce a BLKZEROOUT ioctl which can be used to clear block ranges by
way of blkdev_issue_zeroout().
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
Acked-by: Mike Snitzer snit...@redhat.com
---
block/ioctl.c | 27
From: Martin K. Petersen martin.peter...@oracle.com
The REPORT SUPPORTED OPERATION CODES command can be used to query
whether a given opcode is supported by a device. Add a helper function
that allows us to look up commands.
We only issue RSOC if the device reports compliance with SPC-3 or
later
From: Martin K. Petersen martin.peter...@oracle.com
The WRITE SAME command supported on some SCSI devices allows the same
block to be efficiently replicated throughout a block range. Only a
single logical block is transferred from the host and the storage device
writes the same data to all blocks
From: Martin K. Petersen martin.peter...@oracle.com
Implement support for WRITE SAME(10) and WRITE SAME(16) in the SCSI disk
driver.
- We set the default maximum to 0x because there are several
devices out there that only support two-byte block counts even with
WRITE SAME(16). We only
value mean?
Sreekanth The meaning of this log info value is Virtual IO has failed
Sreekanth and has to be retried.
OK, I'd prefer to see that documented in the patch.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi
are you reverting to iterating over the queues? A while back I fixed
this up so it wouldn't fail when nr_cpus the number of reply queues.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord
{
ioc-shost-sg_tablesize = MPT2SAS_SG_DEPTH;
}
Wouldn't it be better to print the new scatterlist limit after it has
been clamped to reflect what it's actually being set to?
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe
, BLIST_TRY_VPD_PAGES},
Is that version field meaningful or is it safe for us to inquire about
VPD pages without problems on older versions?
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord
block provisioning heuristics and is not affected by
no_write_same at all.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
tooling to ensure that the right things are reported when a PI error is
injected at various places in the stack.
One thing that needs to be done is to make returning these new errors to
userland conditional on !BIP_BLOCK_INTEGRITY. I'll put that on my list.
--
Martin K. Petersen Oracle Linux
. My original patch did this.
More on that in my response to hch...
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
struct thing.
Open to ideas. The many-clones-to-one-completion-status issue isn't
entirely trivial to tackle.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo
)) {
Failing more gracefully is OK with me.
Acked-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info
.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
or if the discard
request fails we will fall back to first REQ_WRITE_SAME and then a
regular REQ_WRITE.
Also update the callers of blkdev_issue_zero() to reflect the new flag
and make sb_issue_zeroout() prefer the discard approach.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
Reviewed
Now that we sanity check the optimal I/O size reported by the device we
no longer need to blacklist the VPD pages on certain Seagate drives.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
Cc: sta...@vger.kernel.org
---
drivers/scsi/scsi_devinfo.c | 1 -
1 file changed, 1 deletion
.
Reported-by: Chris Friesen chris.frie...@windriver.com
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
Cc: sta...@vger.kernel.org
---
drivers/scsi/sd.c | 3 ++-
drivers/scsi/sd.h | 9 +
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi
exception status.
Given that you're already splitting I/Os in IBLOCK I think it would
probably be better to pick a size you're comfortable with. 4 or 8 megs
sound reasonable to be
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi
for the message log whenever the user sets
Sreekanth the max_sgl_entries to a value greater than
Sreekanth SCSI_MAX_SG_SEGMENTS to warn about the kernel definition
Sreekanth overriding.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
. 4. then call
Sreekanth the free_cpumask_var API to free the memory allocated in step
Sreekanth 2.
(Still dreaming of a combined mpt2sas and mpt3sas so I wouldn't have to
review everything twice).
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux
. What does that buy us?
I agree with not leaking any of the new errors to unsuspecting
applications and only passing them out if the caller has explicitly
enabled DIX.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi
provided as override value.
At the very least print a warning if you subsequently clamp the value to
MAX_SG_CHAIN_SEGMENTS. Requested number of segments %u is bigger than
kernel max %u.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line
, increased per controller
Sumit can_queue. Behavior of MFI controllers will remain unchanged.
This whole reserved commands business seems a bit brittle to me. But I
don't have any particular objections to the code.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen
Sumit == sumit.sax...@avagotech.com writes:
Sumit Update megaraid_sas driver version.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body
, I'd like to get that sorted out too. It got stuck on running out
of request flags and that requires some block layer surgery. I'll try to
get that piece done right away for 3.20 so we can get xcopy into 3.21.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list
Hannes == Hannes Reinecke h...@suse.de writes:
Hannes Yep. That definitely needs to be discussed. Especially we'd
Hannes need to discuss how to handle exceptions, seeing that XCOPY
Hannes might fail basically at any time.
Like any SCSI command :)
--
Martin K. Petersen Oracle Linux
should be 256bytes
Sumit aligned. Code is optimized to reduce the size of frame for fusion
Sumit adapters and make the MFI frame size calculation a bit
Sumit transparent and readable.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
don't get stuck in wait state
Sumit and IOCTLs are returned to application.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord
Sumit == sumit.sax...@avagotech.com writes:
Sumit struct fusion_context *fusion is already memset to '0', so remove
Sumit redundant code of meset fusion-load_balance_info to '0'.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Sumit == sumit.sax...@avagotech.com writes:
Sumit Update driver mask_interrupts before enable/disable hardware
Sumit interrupt in order to avoid missing interrupts because of
Sumit mask_interrupts still set to 1 and hardware interrupts are
Sumit enabled.
Reviewed-by: Martin K. Petersen
commands to JBOD will be sent via
Sumit fastpath. 2) If firmware does not support SED JBOD, driver will
Sumit fall back to old design .i.e send all JBOD IOs via fastpath.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe
.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
values.
Reporting queue_max_hw_sectors sounds sane to me.
What's your concern wrt. older hardware?
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info
the code works fine on big endian with this patch in place.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the manual procedure.
It saves the data a roundtrip on the fabric. That itself may be more
valuable than a direct bandwidth win if there is concurrent I/O on the
wire.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body
Olaf == Olaf Hering o...@aepfle.de writes:
Olaf Does that target code offer what scsi_debug offers, a bunch of
Olaf stuff listable with 'lsscsi'? The latter can be passed to
Olaf backstores/pscsi.
Yes.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send
Tapasweni == Tapasweni Pathak tapaswenipat...@gmail.com writes:
Tapasweni Remove null check on sdkp as it won't be null at this line.
Thanks for the heads up. It's actually a merge snafu. The check is
supposed to be if (!sdkp-ATO). I already have a patch in my queue to
fix this.
--
Martin K
.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Sudip == Sudip Mukherjee sudipm.mukher...@gmail.com writes:
Sudip we were dereferencing sdkp first and then we were checking for it
Sudip being NULL.
http://marc.info/?l=linux-kernelm=142564395705827w=2
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send
*
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
This fixes it by invalidating protection info for the unmapped
Akinobu region by filling with 0xff pattern. This change also adds
Akinobu helper function fd_do_prot_fill() in order to reduce code
Akinobu duplication with existing fd_format_prot().
Reviewed-by: Martin K. Petersen martin.peter
of the patches(2,3,4 and 5) will
Sumit remain unchanged.
The other patches looked OK on their own. But it's probably best to
repost the whole series since you'll need a review from at least one
person other than me.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from
401 - 500 of 2771 matches
Mail list logo
