RE: [PATCH][V2] scsi: aacraid: rcode is unsigned and should be signed int

2017-02-07 Thread Raghava Aditya Renukunta
om> > > aac_fib_send can return -ve error returns and hence rcode should > be signed. Currently the rcode >= 0 check is always true and -ve > errors are not being checked. > > Thanks to Dan Carpenter for spotting my original broken fix to this > issue. > >

RE: [PATCH] scsi: aacraid: avoid open-coded upper_32_bits

2017-02-07 Thread Raghava Aditya Renukunta
.@oracle.com> > Cc: Arnd Bergmann <a...@arndb.de>; Johannes Thumshirn > <jthumsh...@suse.de>; Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; Dave Carroll > <david.carr...@microsemi.com>; linux-scsi@vger.kernel.org; linux- > ker...@vger.

[PATCH 01/24] aacraid: Remove duplicate irq management code

2017-01-23 Thread Raghava Aditya Renukunta
Removed duplicate code that for acquiring and releasing irqs Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/linit.c | 58 +++-

[PATCH 16/24] aacraid: Add task management functionality

2017-01-23 Thread Raghava Aditya Renukunta
Added support to send out task management commands. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 364 +- 1 file

[PATCH 00/24] aacraid: Patchset for Smart Family card support

2017-01-23 Thread Raghava Aditya Renukunta
This patchset adds support to the HBA1000 and SMARTIOC2000 family of cards. The driver version to now updated to 50740 Raghava Aditya Renukunta (24): [SCSI] aacraid: Remove duplicate irq management code [SCSI] aacraid: Added aacraid.h include guard [SCSI] aacraid: Added support

[PATCH 14/24] aacraid: Added support for hotplug

2017-01-23 Thread Raghava Aditya Renukunta
Added support for drive hotplug add and removal Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 13 ++-- drivers/scsi/aacraid/aacraid.h | 17 +-

[PATCH 09/24] aacraid: Added support for read medium error

2017-01-23 Thread Raghava Aditya Renukunta
This patch processes Raw IO read medium errors. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 10 ++ drivers/scsi/aacraid/aacraid.h | 1 + 2 files

[PATCH 02/24] aacraid: Added aacraid.h include guard

2017-01-23 Thread Raghava Aditya Renukunta
Added aacraid.h include guard Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/aacraid.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/aacraid

[PATCH 21/24] aacraid: Retrieve HBA host information ioctl

2017-01-23 Thread Raghava Aditya Renukunta
Added a new ioctl interface to retrieve the host device information. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/aac

[PATCH 17/24] aacraid: Added support to abort cmd and reset lun

2017-01-23 Thread Raghava Aditya Renukunta
Added task management command support to abort any timed out commands in case of a eh_abort call and to reset lun's in case of eh_reset call. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> ---

[PATCH 18/24] aacraid: VPD 83 type3 support

2017-01-23 Thread Raghava Aditya Renukunta
This patch adds support to retrieve the unique identifier data (VPD page 83 type3) for Logical drives created on SmartIOC 2000 products. In addition added a sysfs device structure to expose the id information. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com>

[PATCH 12/24] aacraid: Retrieve Queue Depth from Adapter FW

2017-01-23 Thread Raghava Aditya Renukunta
Retrieved queue depth from fw and saved it for future use. Only applicable for HBA1000 drives. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/aa

[PATCH 19/24] aacraid: Added new IWBR reset

2017-01-23 Thread Raghava Aditya Renukunta
Added a new IWBR soft reset type, reworked the IOP reset interface for a bit. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/aacraid.h | 15 +++-- drivers/scsi/aacra

[PATCH 15/24] aacraid: Include HBA direct interface

2017-01-23 Thread Raghava Aditya Renukunta
Added support to send direct pasthru srb commands from management utilty to the controller. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/aacr

[PATCH 13/24] aacraid: Added support to set QD of attached drives

2017-01-23 Thread Raghava Aditya Renukunta
Added support to set qd of drives in slave_configure.This only works for HBA1000 attached drives. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/l

[PATCH 10/24] aacraid: Reworked aac_command_thread

2017-01-23 Thread Raghava Aditya Renukunta
Reworked aac_command_thread into aac_process_events Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/commsup.c | 410 ++--- 1 file

[PATCH 05/24] aacraid: Retrieve and update the device types

2017-01-23 Thread Raghava Aditya Renukunta
This patch adds support to retrieve the type of each adapter connected device. Applicable to HBA1000 and SmartIOC2000 products Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/

[PATCH 04/24] aacraid: Added sa firmware support

2017-01-23 Thread Raghava Aditya Renukunta
sa_firmware adds the capability to differentiate the new SmartIOC family of adapters from the series 8 and below. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/aac

[PATCH 24/24] aacraid: update version

2017-01-23 Thread Raghava Aditya Renukunta
Update the driver version to 50740 Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/aacraid.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

[PATCH 22/24] aacraid: Update copyrights

2017-01-23 Thread Raghava Aditya Renukunta
Added new copyright messages Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 8 +++- drivers/scsi/aacraid/aacraid.h | 32 +

[PATCH 23/24] aacraid: Change Driver Version Prefix

2017-01-23 Thread Raghava Aditya Renukunta
Change the aacraid driver prefix from 1.2-1 to 1.2.1 Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/linit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 11/24] aacraid: Added support for periodic wellness sync

2017-01-23 Thread Raghava Aditya Renukunta
This patch adds a new functions that periodically sync the time of host to the adapter. In addition also informs the adapter that the driver is alive and kicking. Only applicable to the HBA1000 and SMARTIOC2000. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.

[PATCH 20/24] aacraid: Added ioctl to trigger IOP/IWBR reset

2017-01-23 Thread Raghava Aditya Renukunta
Added a new ioctl interface to trigger an IOP or IWBR reset from ioctl. Primary used by management utility to trigger resets. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/

[PATCH 03/24] aacraid: added support for init_struct_8

2017-01-23 Thread Raghava Aditya Renukunta
This patch lays the groundwork for supporting the new HBA-1000 controller family.A new INIT structure INIT_STRUCT_8 has been added which allows for a variable size for MSI-x vectors among other things, and is used for both Series-8, HBA-1000 and SmartIOC-2000. Signed-off-by: Raghava Aditya

[PATCH 08/24] aacraid: Added support for response path

2017-01-23 Thread Raghava Aditya Renukunta
This patch enables the driver to actually process the I/O, or srb replies from adapter. In addition to any HBA1000 or SmartIOC2000 adapter events. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com>

[PATCH 07/24] aacraid: Process Error for response I/O

2017-01-23 Thread Raghava Aditya Renukunta
Make sure that the driver processes error conditions even in the fast response path for response from the adapter. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/aa

[PATCH 06/24] aacraid: Reworked scsi command submission path

2017-01-23 Thread Raghava Aditya Renukunta
Moved the READ and WRITE switch cases to the top. Added a default case to the switch case and replaced duplicate scsi result value with a macro. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com>

RE: [PATCH V2 05/24] aacraid: Retrieve and update the device types

2017-01-26 Thread Raghava Aditya Renukunta
> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Thursday, January 26, 2017 1:00 AM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com> > Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- >

RE: [PATCH V2 06/24] aacraid: Reworked scsi command submission path

2017-01-26 Thread Raghava Aditya Renukunta
Hi Johannes, > -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Thursday, January 26, 2017 1:06 AM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com> > Cc: j...@linux.vnet.ibm.com; martin.peter..

[PATCH V3 00/24] aacraid: Patchset for Smart Family Support

2017-01-27 Thread Raghava Aditya Renukunta
This patchset adds support to the HBA1000 and SMARTIOC2000 family of cards. The driver version is now updated to 50740 Changes in V2: Fixed kbuild test robot warnings Changes in V3: Removed Camel case definitions Misc fixes Raghava Aditya Renukunta (24): [SCSI] aacraid: Remove duplicate irq

[PATCH V3 21/24] aacraid: Retrieve HBA host information ioctl

2017-01-27 Thread Raghava Aditya Renukunta
Added a new ioctl interface to retrieve the host device information. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None Changes in V3: None drivers/scsi/aacraid/aac

RE: [PATCH 00/24] aacraid: Patchset for Smart Family card support

2017-01-25 Thread Raghava Aditya Renukunta
> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Wednesday, January 25, 2017 3:31 PM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com> > Cc: j...@linux.vnet.ibm.com; martin.peter..

[PATCH V2 04/24] aacraid: Added sa firmware support

2017-01-25 Thread Raghava Aditya Renukunta
sa_firmware adds the capability to differentiate the new SmartIOC family of adapters from the series 8 and below. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None

[PATCH V2 17/24] aacraid: Added support to abort cmd and reset lun

2017-01-25 Thread Raghava Aditya Renukunta
Added task management command support to abort any timed out commands in case of a eh_abort call and to reset lun's in case of eh_reset call. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com>

[PATCH V2 15/24] aacraid: Include HBA direct interface

2017-01-25 Thread Raghava Aditya Renukunta
Added support to send direct pasthru srb commands from management utilty to the controller. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None drivers/scsi/aacra

[PATCH V2 21/24] aacraid: Retrieve HBA host information ioctl

2017-01-25 Thread Raghava Aditya Renukunta
Added a new ioctl interface to retrieve the host device information. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aac

[PATCH V2 22/24] aacraid: Update copyrights

2017-01-25 Thread Raghava Aditya Renukunta
Added new copyright messages Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 8 +++- drivers/scsi/aacraid/aac

[PATCH V2 09/24] aacraid: Added support for read medium error

2017-01-25 Thread Raghava Aditya Renukunta
This patch processes Raw IO read medium errors. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 10 ++ drivers/scsi/aacra

[PATCH V2 02/24] aacraid: Added aacraid.h include guard

2017-01-25 Thread Raghava Aditya Renukunta
Added aacraid.h include guard Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aacraid.h | 3 +++ 1 file changed, 3 insertions(+) diff --g

[PATCH V2 05/24] aacraid: Retrieve and update the device types

2017-01-25 Thread Raghava Aditya Renukunta
This patch adds support to retrieve the type of each adapter connected device. Applicable to HBA1000 and SmartIOC2000 products Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in

[PATCH V2 14/24] aacraid: Added support for hotplug

2017-01-25 Thread Raghava Aditya Renukunta
Added support for drive hotplug add and removal Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 13 ++-- drivers/scsi/aacraid/aac

[PATCH V2 13/24] aacraid: Added support to set QD of attached drives

2017-01-25 Thread Raghava Aditya Renukunta
Added support to set qd of drives in slave_configure.This only works for HBA1000 attached drives. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None drivers/scsi/aac

[PATCH V2 16/24] aacraid: Add task management functionality

2017-01-25 Thread Raghava Aditya Renukunta
Added support to send out task management commands. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: Fixed overflow warning drivers/scsi/aacraid/aa

[PATCH V2 18/24] aacraid: VPD 83 type3 support

2017-01-25 Thread Raghava Aditya Renukunta
This patch adds support to retrieve the unique identifier data (VPD page 83 type3) for Logical drives created on SmartIOC 2000 products. In addition added a sysfs device structure to expose the id information. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com>

[PATCH V2 01/24] aacraid: Remove duplicate irq management code

2017-01-25 Thread Raghava Aditya Renukunta
Removed duplicate code that for acquiring and releasing irqs Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/

[PATCH V2 08/24] aacraid: Added support for response path

2017-01-25 Thread Raghava Aditya Renukunta
This patch enables the driver to actually process the I/O, or srb replies from adapter. In addition to any HBA1000 or SmartIOC2000 adapter events. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@micr

[PATCH V2 03/24] aacraid: added support for init_struct_8

2017-01-25 Thread Raghava Aditya Renukunta
This patch lays the groundwork for supporting the new HBA-1000 controller family.A new INIT structure INIT_STRUCT_8 has been added which allows for a variable size for MSI-x vectors among other things, and is used for both Series-8, HBA-1000 and SmartIOC-2000. Signed-off-by: Raghava Aditya

[PATCH V2 12/24] aacraid: Retrieve Queue Depth from Adapter FW

2017-01-25 Thread Raghava Aditya Renukunta
Retrieved queue depth from fw and saved it for future use. Only applicable for HBA1000 drives. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None drivers/scsi/aacr

[PATCH V2 07/24] aacraid: Process Error for response I/O

2017-01-25 Thread Raghava Aditya Renukunta
Make sure that the driver processes error conditions even in the fast response path for response from the adapter. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None

[PATCH V2 06/24] aacraid: Reworked scsi command submission path

2017-01-25 Thread Raghava Aditya Renukunta
Moved the READ and WRITE switch cases to the top. Added a default case to the switch case and replaced duplicate scsi result value with a macro. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com>

[PATCH V2 00/24] aacraid: Patchset for Smart Family support

2017-01-25 Thread Raghava Aditya Renukunta
This patchset adds support to the HBA1000 and SMARTIOC2000 family of cards. The driver version is now updated to 50740 Changes in V2: Fixed kbuild test robot warnings Raghava Aditya Renukunta (24): [SCSI] aacraid: Remove duplicate irq management code [SCSI] aacraid: Added aacraid.h include

[PATCH V2 24/24] aacraid: update version

2017-01-25 Thread Raghava Aditya Renukunta
Update the driver version to 50740 Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aacraid.h | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH V2 10/24] aacraid: Reworked aac_command_thread

2017-01-25 Thread Raghava Aditya Renukunta
Reworked aac_command_thread into aac_process_events Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/com

[PATCH V2 19/24] aacraid: Added new IWBR reset

2017-01-25 Thread Raghava Aditya Renukunta
Added a new IWBR soft reset type, reworked the IOP reset interface for a bit. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aac

[PATCH V2 11/24] aacraid: Added support for periodic wellness sync

2017-01-25 Thread Raghava Aditya Renukunta
This patch adds a new functions that periodically sync the time of host to the adapter. In addition also informs the adapter that the driver is alive and kicking. Only applicable to the HBA1000 and SMARTIOC2000. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.

[PATCH V2 23/24] aacraid: Change Driver Version Prefix

2017-01-25 Thread Raghava Aditya Renukunta
Change the aacraid driver prefix from 1.2-1 to 1.2.1 Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/linit.c | 2 +- 1 file changed, 1 ins

[PATCH V2 20/24] aacraid: Added ioctl to trigger IOP/IWBR reset

2017-01-25 Thread Raghava Aditya Renukunta
Added a new ioctl interface to trigger an IOP or IWBR reset from ioctl. Primary used by management utility to trigger resets. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in

RE: [PATCH V2 04/24] aacraid: Added sa firmware support

2017-01-26 Thread Raghava Aditya Renukunta
> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Thursday, January 26, 2017 12:55 AM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com> > Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- >

RE: [PATCH V2 03/24] aacraid: added support for init_struct_8

2017-01-26 Thread Raghava Aditya Renukunta
> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Thursday, January 26, 2017 12:37 AM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com> > Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- >

RE: [PATCH V2 05/24] aacraid: Retrieve and update the device types

2017-01-26 Thread Raghava Aditya Renukunta
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Raghava Aditya Renukunta > Sent: Thursday, January 26, 2017 10:44 AM > To: Johannes Thumshirn <jthumsh...@suse.de> > Cc: j...@linux.vn

RE: Driver version for PMC Adaptec HBA in Linux and from vendor

2017-02-17 Thread Raghava Aditya Renukunta
Hello Paul, > Dear Raghava, dear Linux folks, > > > Using a PMC Adaptec HBA 1000-8e with latest Linux, it only initializes > in sync mode, instead of async mode. The patches that enable async mode in HBA 1000-8e , have been included in the James Bottomley's linux-scsi Branch and are on

[PATCH V2 01/15] aacraid: Fix camel case

2017-02-16 Thread Raghava Aditya Renukunta
Replaced camel case with snake case for init supported options. Suggested-by: Johannes Thumshirn <jthumsh...@suse.de> Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> Reviewed-by: Johannes

[PATCH V2 07/15] aacraid: Fix sync fibs time out on controller reset

2017-02-16 Thread Raghava Aditya Renukunta
After controller shutdown, all sync fibs time out due to not knowing about the switch to INT-x mode Fixed by replacing aac_src_access_devreg() to aac_set_intx_mode() call. Cc: sta...@vger.kernel.org Fixes: 495c021767bd78c998 (aacraid: MSI-x support) Signed-off-by: Raghava Aditya Renukunta

[PATCH V2 00/15] aacraid: Fixes and enhancements for arc family

2017-02-16 Thread Raghava Aditya Renukunta
. Refactored memory leak fix patch Refactored EEH patch to remove macro Misc grammar fixes Raghava Aditya Renukunta (15): [SCSI] aacraid: Fix camel case [SCSI] aacraid: Use correct channel number for raw srb [SCSI] aacraid: Fix for excessive prints on EEH [SCSI] aacraid: Prevent E3 lockup when

[PATCH V2 08/15] aacraid: Skip wellness sync on controller failure

2017-02-16 Thread Raghava Aditya Renukunta
Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> --- Changes in V2: None drivers/scsi/aacraid/commsup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH V2 05/15] aacraid: Fix memory leak in fib init path

2017-02-16 Thread Raghava Aditya Renukunta
controller family) Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> --- Changes in V2: Refactored memory free code to make it easier to understand drivers/scsi/aacraid/co

[PATCH V2 03/15] aacraid: Fix for excessive prints on EEH

2017-02-16 Thread Raghava Aditya Renukunta
eeh errors which continued for a good 6 minutes. Fixed by returning without waiting when EEH error is reported. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> --- Changes for V2: Refactored co

[PATCH V2 02/15] aacraid: Use correct channel number for raw srb

2017-02-16 Thread Raghava Aditya Renukunta
in the cmd sent to the firmware and gets an invalid response. Fixed by using channel id from srb command. Cc: sta...@vger.kernel.org Fixes: 423400e64d377c0 ("scsi: aacraid: Include HBA direct interface") Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.

[PATCH V2 04/15] aacraid: Prevent E3 lockup when deleting units

2017-02-16 Thread Raghava Aditya Renukunta
Arrconf management utility at times sends fibs with AdapterProcessed set in its fibs. This causes the controller to panic and lockup. Fixed by failing the commands that have AdapterProcessed set in its flag. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Re

[PATCH V2 06/15] aacraid: Added sysfs for driver version

2017-02-16 Thread Raghava Aditya Renukunta
Added support to retrieve driver version from a new sysfs variable called driver_version. It makes it easier for the user to figure out the driver version that is currently running. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David C

[PATCH V2 10/15] aacraid: Decrease adapter health check interval

2017-02-16 Thread Raghava Aditya Renukunta
the controller when it fails, and decreasing the time interval will help. Fixed by decreasing check interval from 24 hours to 1 minute Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> Reviewed-by: Johann

[PATCH V2 12/15] aacraid: Reorder Adapter status check

2017-02-16 Thread Raghava Aditya Renukunta
. Fixed by first checking KERNEL_PANIC and then the others. Cc: sta...@vger.kernel.org Fixes: e8b12f0fb835223752 ([SCSI] aacraid: Add new code for PMC-Sierra's SRC base controller family) Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David C

[PATCH V2 09/15] aacraid: Reload offlined drives after controller reset

2017-02-16 Thread Raghava Aditya Renukunta
that are marked offline. In addition invoke a scsi host bus rescan to capture any additional configuration changes. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> Reviewed-by: Johannes Thumsh

[PATCH V2 14/15] aacraid: Fix a potential spinlock double unlock bug

2017-02-16 Thread Raghava Aditya Renukunta
(scsi: aacraid: Added support for hotplug) Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> Reviewed-by: Johannes Thumshirn <jthumsh...@

[PATCH V2 11/15] aacraid: Skip IOP reset on controller panic(SMART Family)

2017-02-16 Thread Raghava Aditya Renukunta
When the SMART family of controller panic (KERNEL_PANIC) , they do not honor IOP resets. So better to skip it and directly perform a IWBR reset. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com&

[PATCH V2 15/15] aacraid: Update driver version

2017-02-16 Thread Raghava Aditya Renukunta
Updated driver version to 50792 Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> --- Changes in V2: None drivers/scsi/aacraid/aacrai

[PATCH V2 13/15] aacraid: Save adapter fib log before an IOP reset

2017-02-16 Thread Raghava Aditya Renukunta
-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 4 drivers/scsi/aacr

[PATCH] aacraid: Fixed expander hotplug for SMART family

2017-02-22 Thread Raghava Aditya Renukunta
Enclosure channels and using the latest device type for addition or removal or enclosure expanders. Fixes: 6223a39fe6fbbeef (scsi: aacraid: Added support for hotplug) Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/commsup.c | 5 +

RE: [PATCH] scsi: aacraid: fix information leak on hbainfo.driver_name

2017-02-13 Thread Raghava Aditya Renukunta
Hello Colin, > -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Tuesday, February 7, 2017 5:55 AM > To: dl-esc-Aacraid Linux Driver ; James E . J . > Bottomley ; Martin K . Petersen >

RE: [bug report] scsi: aacraid: Added support for hotplug

2017-02-14 Thread Raghava Aditya Renukunta
Hi Dan, > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Monday, February 13, 2017 11:44 PM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com> > Cc: linux-scsi@vger.kernel.org > Subject: Re: [bug r

[PATCH 08/16] aacraid: Skip wellness sync on controller failure

2017-02-14 Thread Raghava Aditya Renukunta
Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/commsup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c i

[PATCH 07/16] aacraid: Fix sync fibs time out on controller reset

2017-02-14 Thread Raghava Aditya Renukunta
After controller shutdown, all sync fibs time out due to not knowing about the switch to INT-x mode Fixed by replacing aac_src_access_devreg() to aac_set_intx_mode() call. Cc: sta...@vger.kernel.org Fixes: 495c021767bd78c998 (aacraid: MSI-x support) Signed-off-by: Raghava Aditya Renukunta

[PATCH 01/16] aacraid: Fix camel case

2017-02-14 Thread Raghava Aditya Renukunta
Replaced camel case with snake case for init supported options. Suggested-by: Johannes Thumshirn <jthumsh...@suse.de> Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacr

[PATCH 00/16] aacraid: Fixes and enhancements for arc family

2017-02-14 Thread Raghava Aditya Renukunta
. The reset mechanism is triggered in 2 paths, one is from the eh handler from the kernel and the other is from the driver's internal periodic health checkup. Raghava Aditya Renukunta (16): [SCSI] aacraid: Fix camel case [SCSI] aacraid: Use correct channel number for raw srb [SCSI] aacraid: Fix

[PATCH 03/16] aacraid: Fix for excessive prints on EEH

2017-02-14 Thread Raghava Aditya Renukunta
eeh errors which continued for a good 6 minutes. Fixed by returning without waiting when EEH error is reported. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/co

[PATCH 02/16] aacraid: Use correct channel number for raw srb

2017-02-14 Thread Raghava Aditya Renukunta
in the cmd sent to the firmware and gets an invalid response. Fixed by using channel id from srb command. Cc: sta...@vger.kernel.org Fixes: 423400e64d377c0 ("scsi: aacraid: Include HBA direct interface") Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.

[PATCH 06/16] aacraid: Added sysfs for driver version

2017-02-14 Thread Raghava Aditya Renukunta
Added support to retrieve driver version from a new sysfs variable called driver_version. It makes it easier for the user to figure out the driver version that is currently running. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David C

[PATCH 14/16] aacraid: Save adapter fib log before an IOP reset

2017-02-14 Thread Raghava Aditya Renukunta
-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 4 drivers/scsi/aacraid/aacraid.h | 6 ++ drivers/scsi/aacraid/src.c | 17 + 3 files

[PATCH 05/16] aacraid: Fix memory leak in fib init path

2017-02-14 Thread Raghava Aditya Renukunta
controller family) Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/commsup.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/

[PATCH 09/16] aacraid: Reload offlined drives after controller reset

2017-02-14 Thread Raghava Aditya Renukunta
that are marked offline. In addition invoke a scsi host bus rescan to capture any additional configuration changes. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/co

[PATCH 13/16] aacraid: Reorder Adapter status check

2017-02-14 Thread Raghava Aditya Renukunta
. Fixed by first checking KERNEL_PANIC and then the others. Cc: sta...@vger.kernel.org Fixes: e8b12f0fb835223752 ([SCSI] aacraid: Add new code for PMC-Sierra's SRC base controller family) Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David C

[PATCH 12/16] aacraid: Skip IOP reset on controller panic(SMART Family)

2017-02-14 Thread Raghava Aditya Renukunta
When the SMART family of controller panic (KERNEL_PANIC) , they do not honor IOP resets. So better to skip it and directly perform a IWBR reset. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com>

[PATCH 11/16] aacraid: Decrease adapter health check interval

2017-02-14 Thread Raghava Aditya Renukunta
the controller when it fails, and decreasing the time interval will help. Fixed by decreasing check interval from 24 hours to 1 minute Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> --- drivers/

[PATCH 04/16] aacraid: Prevent E3 lockup when deleting units

2017-02-14 Thread Raghava Aditya Renukunta
Arrconf management utility at times sends fibs with AdapterProcessed set in its fibs. This causes the controller to panic and lockup. Fixed by failing the commands that have AdapterProcessed set in its flag. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Re

[PATCH 16/16] aacraid: Update driver version

2017-02-14 Thread Raghava Aditya Renukunta
Updated driver version to 50792 Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/aacraid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[PATCH 10/16] aacraid: Terminate kthread on controller fw assert

2017-02-14 Thread Raghava Aditya Renukunta
he command thread. As a follow-up, the eh_reset handler would take care of the controller reset. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/commsup.c | 7

[PATCH 15/16] aacraid: Fix a potential spinlock double unlock bug

2017-02-14 Thread Raghava Aditya Renukunta
(scsi: aacraid: Added support for hotplug) Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: David Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/commsup.c | 2 +-

RE: [bug report] scsi: aacraid: Added support for hotplug

2017-02-13 Thread Raghava Aditya Renukunta
Hi Don, > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Monday, February 13, 2017 10:47 AM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com> > Cc: linux-scsi@vger.kernel.org > Subject: [bug report] s

RE: [PATCH 06/16] aacraid: Added sysfs for driver version

2017-02-16 Thread Raghava Aditya Renukunta
> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Wednesday, February 15, 2017 11:43 PM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; j...@linux.vnet.ibm.com; > martin.peter...@oracle.com; linux-scsi@vg

RE: [PATCH 10/16] aacraid: Terminate kthread on controller fw assert

2017-02-16 Thread Raghava Aditya Renukunta
> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Thursday, February 16, 2017 1:31 AM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; j...@linux.vnet.ibm.com; > martin.peter...@oracle.com; linux-scsi@vg

<    1   2   3   4   >