Re: shouldn't irq be module_param_array instead of module_param in scsi/gdth.c ?

2005-01-30 Thread Randy.Dunlap
Jesper Juhl wrote: This little warning made me take a closer look : drivers/scsi/gdth.c:645: warning: return from incompatible pointer type And line 645 looks like this : module_param(irq, int, 0); looking a bit up in the file I find : /* IRQ list for GDT3000/3020 EISA controllers */ static int

Re: [PATCH] add scsi bus for virtual drivers take3

2005-02-14 Thread Randy.Dunlap
Mike Christie wrote: I do not know what I was diffing the last time. The attached patch should work now. Sorry. Mike It would be nice to include the full patch description in the email body so that people don't have to refer 2-3 emails back to read it in the future, please. -- ~Randy - To

[PATCH] scsi_sysfs: use NULL instead of 0

2005-03-27 Thread Randy.Dunlap
drivers/scsi/scsi_sysfs.c:814:66: warning: Using plain integer as NULL pointer Signed-off-by: Randy Dunlap [EMAIL PROTECTED] diffstat:= drivers/scsi/scsi_sysfs.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -Naurp ./drivers/scsi/scsi_sysfs.c~scsi_sysfs_null

Re: iomapping a big endian area

2005-04-04 Thread Randy.Dunlap
James Bottomley wrote: On Mon, 2005-04-04 at 17:50 +1000, Benjamin Herrenschmidt wrote: I disagree. The driver will never know ... ? the driver has to know. Look at the 53c700 to see exactly how awful it is. This beast has byte and word registers. When used BE, all the byte registers alter

Re: increasing scsi_max_sg / max_segments for scsi writes/reads

2005-04-10 Thread Randy.Dunlap
On Sat, 9 Apr 2005 19:35:52 -0700 (PDT) sai narasimhamurthy wrote: | Hi, | I had posted a question on increasing the scsi | read/write sectors per command. I figured out some of | the things, but many questions still exist. | | I was wondering why the maximum writes I could get | from a

Re: [PATCH]megaraid_sas: Reduce stack usage in megasas_probe_one()

2005-04-20 Thread Randy.Dunlap
On Wed, 20 Apr 2005 00:59:43 -0700 Yum Rayan wrote: | This patch reduces stack usage in megasas_probe_one() from to 2200 to | 156. A patched version of gcc 3.4.3 with -fno-unit-at-a-time disabled | was used on i386 platform. Hi Yum, In the future, please use diff -up (or even more options, but

Re: Kernel OOPS with aacraid driver

2005-04-22 Thread Randy.Dunlap
On Fri, 22 Apr 2005 07:49:56 +0200 Klaus Steinberger wrote: | Hello, | | since Kernel Version 2.6.10 I get kernel OOPS when I try to use the Adaptec | Raidtools (ASMBE as well as the CLI tool: aacli). I reported this to Fedora | Bugzilla as the following bug ( 148761 ) | |

Re: Fw: Kernel panic with dc395x in 2.6.12.2

2005-07-28 Thread Randy.Dunlap
On Fri, 29 Jul 2005 01:05:48 +0200 Pierre Ossman wrote: randy_dunlap wrote: oh drat. Please test 2.6.12.2 with the following patch segment backed out (-R, reversed). I don't see any other patches that could be the cause. If this isn't the problem, I would have to begin to suspect some

[PATCH 6/8] kernel-doc: fix scsi docbook

2008-02-03 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Add missing function parameter descriptions. Make function short description fit on one line as required. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/scsi/scsi.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ---