Hi,
this patch removes some useless struct declarations from drivers/scsi/scsi.h.
All this structs are already defined in the header files included above
except Scsi_Host, for which we now directly include scsi/scsi_host.h
Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED]
--- linux-2.6.10/drivers
Am Montag, 14. Februar 2005 12:09 schrieb Christoph Hellwig:
On Mon, Feb 14, 2005 at 11:57:29AM +0100, Rolf Eike Beer wrote:
Hi,
this patch removes some useless struct declarations from
drivers/scsi/scsi.h. All this structs are already defined in the header
files included above except
Rev: 0010
To avoid the empty line I think this patch is needed.
Eike
Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED]
diff -aupr linux-2.6.11/drivers/scsi/aic7xxx/aic7xxx_osm.c
linux-2.6.12-rc1/drivers/scsi/aic7xxx/aic7xxx_osm.c
--- linux-2.6.11/drivers/scsi/aic7xxx/aic7xxx_osm.c
Am Donnerstag, 4. August 2005 17:40 schrieb Dave Jones:
On Thu, Aug 04, 2005 at 11:38:30AM +0200, Rolf Eike Beer wrote:
+ulFibreFrame = kmalloc((2048/4), GFP_KERNEL);
The size bug was already found by Dave Jones. This never should be
written this way (not your fault). The array should
Dave Jones wrote:
On Thu, Aug 04, 2005 at 05:56:14PM +0200, Rolf Eike Beer wrote:
Am Donnerstag, 4. August 2005 17:40 schrieb Dave Jones:
On Thu, Aug 04, 2005 at 11:38:30AM +0200, Rolf Eike Beer wrote:
+ulFibreFrame = kmalloc((2048/4), GFP_KERNEL);
The size bug was already
Boaz Harrosh wrote:
Split eisa probing into it's own helper, and do proper error unwinding.
Protect EISA probind by the proper CONFIG_EISA symbol.
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]
@@ -5694,6 +5582,148 @@ static int gdth_isa_probe_one(struct
scsi_host_template *shtp,
Boaz Harrosh wrote:
(note: this is ontop of Jeff's pci cleanup patch)
Split out isa probing into a helper of it's own. Error handling is
cleaned up, but errors are not propagated yet. Also enclose the isa
probe under the proper CONFIG_ISA symbol instead of the !IA64 hack.
Signed-off-by:
Boaz Harrosh wrote:
- Cleanup the rest of the scsi_cmnd-SCp members and move them
to gdth_cmndinfo:
SCp.have_data_in = volatile wait_for_completion
Signed-off-by Boaz Harrosh [EMAIL PROTECTED]
volatile here is probably nonsense. Either you need proper locking on this
struct in
Gilbert Wu wrote:
diff -urN a/drivers/scsi/aic94xx/aic94xx_init.c
b/drivers/scsi/aic94xx/aic94xx_init.c ---
a/drivers/scsi/aic94xx/aic94xx_init.c 2007-10-10 17:13:29.0 -0700
+++ b/drivers/scsi/aic94xx/aic94xx_init.c 2007-10-10 17:15:58.0
-0700
@@ -313,6 +315,179 @@
}
Gilbert Wu wrote:
diff -urN a/drivers/scsi/aic94xx/aic94xx_init.c
b/drivers/scsi/aic94xx/aic94xx_init.c ---
a/drivers/scsi/aic94xx/aic94xx_init.c 2007-10-10 17:13:29.0 -0700
+++ b/drivers/scsi/aic94xx/aic94xx_init.c 2007-10-11 19:31:03.0
-0700
@@ -313,6 +315,180 @@
}
Jeff Garzik wrote:
* pass Scsi_Host to ips_remove_device() via pci_set_drvdata(),
allowing us to eliminate the ips_ha[] search loop and call
ips_release() directly.
* call pci_{request,release}_regions() and eliminate individual
request/release_[mem_]region() calls
* call
Mikhail Yakshin wrote:
Sadly, I don't have access to any possible controller at the market and
it only supports a limited number of current hardware controllers
(Areca, older LSI, newer LSI, Adaptec). I'd like to ask several things:
1. Are there any existing implementations of such thing
Sean Rendell wrote:
Hi all,
I was wondering if someone knows how to debug this. I have a HP xw4300 PC
with 2G RAM and 3GHz P4. Included is a Promise EX8350 RAID card with 4
drives configured as RAID5. While doing some lengthy disk exercises (ie cp
a 200G directory of files) the kernel
Am Sonntag 30 September 2012, 13:07:54 schrieb Paul Bolle:
Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
warnings:
drivers/scsi/qla2xxx/qla_gs.c: In function ‘qla2x00_fdmi_rhba’:
drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is above
array bounds
Signed-off-by: Rolf Eike Beer eike-ker...@sf-tec.de
---
drivers/scsi/bfa/bfa_ioc.h | 1 -
drivers/scsi/bfa/bfad.c| 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/scsi/bfa/bfa_ioc.h b/drivers/scsi/bfa/bfa_ioc.h
index b2856f9..80a2c15 100644
--- a/drivers/scsi/bfa/bfa_ioc.h
+++ b
Signed-off-by: Rolf Eike Beer eike-ker...@sf-tec.de
---
drivers/scsi/bfa/bfa.h | 9 -
drivers/scsi/bfa/bfa_core.c | 18 --
2 files changed, 27 deletions(-)
diff --git a/drivers/scsi/bfa/bfa.h b/drivers/scsi/bfa/bfa.h
index 4ad7e36..0ef77dc 100644
--- a/drivers/scsi
Am Donnerstag 15 November 2012, 15:51:46 schrieb Sasha Levin:
store_host_reset() has tried to re-invent the wheel to compare sysfs
strings. Unfortunately it did so poorly and never bothered to check the
input from userspace before overwriting stack with it, so something simple
as:
echo
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 55367b0..767dd16 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -442,6 +442,11 @@ static inline int scsi_device_created(struct
scsi_device *sdev)
return sdev-sdev_state == SDEV_CREATED
ioc-diag_trigger_mpi is an SL_WH_MPI_TRIGGERS_T struct.
There is a cut and paste error here and SL_WH_EVENT_TRIGGERS_T is
used
instead of SL_WH_MPI_TRIGGERS_T. Since the SL_WH_EVENT_TRIGGERS_T is
smaller than SL_WH_MPI_TRIGGERS_T, it means we only clear part of the
buffer.
Signed-off-by: Dan
Am , schrieb Bart Van Assche:
On 12/07/12 09:40, Rolf Eike Beer wrote:
diff --git a/include/scsi/scsi_device.h
b/include/scsi/scsi_device.h
index 55367b0..767dd16 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -442,6 +442,11 @@ static inline int scsi_device_created
Am , schrieb Bart Van Assche:
On 12/07/12 11:02, Rolf Eike Beer wrote:
Am , schrieb Bart Van Assche:
On 12/07/12 09:40, Rolf Eike Beer wrote:
diff --git a/include/scsi/scsi_device.h
b/include/scsi/scsi_device.h
index 55367b0..767dd16 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi
Paolo Bonzini wrote:
Hi all,
this series adds multiqueue support to the virtio-scsi driver, based
on Jason Wang's work on virtio-net. It uses a simple queue steering
algorithm that expects one queue per CPU. LUNs in the same target always
use the same queue (so that commands are not
Hommel, Thomas (GE Indust, GE Fanuc) wrote:
Here's a record of driver initialization with debugging enabled. I can't
figure out what goes wrong, but maybe sombody else can...
Any help is appreciated
[...]
mptbase: ioc0: WARNING - mpt_timer_expired complete!
Unable to handle kernel paging
Jesper Juhl wrote:
[kv]alloc() return void *. No need to cast the return value.
@@ -5756,7 +5756,7 @@ static int osst_probe(struct device *dev)
write_lock(os_scsi_tapes_lock);
if (os_scsi_tapes == NULL) {
os_scsi_tapes =
- (struct osst_tape
names anyway
While I'm at it, I fixed the coding style of this function. The rest of the
file is is still horror, but this no excuse for not fixing this function.
This shrinks the file by another 500 bytes and should not make any difference
in function.
Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED
Bolke de Bruin wrote:
So the basic question is. Does this controller work on kernel 2.6.5?
Don't think about it. This thing is a mess. I tried to remove the #errors
(which was rather simple) and replace them by kmalloc(). Of course then
someone should care about ENOMEM case. One function had
cpqfcTS_reset() is never referenced from anywhere. By using the nonexistent
constant SCSI_RESET_ERROR it causes just another unneeded compile error.
Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED]
--- a/drivers/scsi/cpqfcTSinit.c2005-08-13 09:34:20.0 +0200
+++ b/drivers/scsi
superfluos
defines for device scanning.
Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED]
--- a/drivers/scsi/cpqfcTSstructs.h 2005-08-14 10:56:41.0 +0200
+++ b/drivers/scsi/cpqfcTSstructs.h 2005-08-14 10:57:32.0 +0200
@@ -95,12 +95,6 @@
#define DEV_NAME cpqfcTS
-struct
Remove ioctls to get PCI information and driver version. These information
can be found via lspci or dmesg. Also remove two typedefs already commented
out.
Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED]
--- a/drivers/scsi/cpqfcTSioctl.h 2005-08-07 20:18:56.0 +0200
+++ b/drivers
Remove compat code for Linux 2.4 and earlier.
Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED]
--- a/drivers/scsi/cpqfcTScontrol.c 2005-08-13 19:00:35.0 +0200
+++ b/drivers/scsi/cpqfcTScontrol.c 2005-08-14 11:02:09.0 +0200
@@ -28,8 +28,6 @@
Hewlitt Packard Manual Part
Christoph Hellwig wrote:
On Tue, Aug 16, 2005 at 11:11:06AM +0200, Rolf Eike Beer wrote:
cpqfcTS_reset() is never referenced from anywhere. By using the
nonexistent constant SCSI_RESET_ERROR it causes just another unneeded
compile error.
That was the old reset handler. Do you actually have
Jiri Slaby wrote:
Rolf Eike Beer napsal(a):
Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED]
--- a/drivers/scsi/cpqfcTSinit.c 2005-08-14 14:20:40.0 +0200
+++ b/drivers/scsi/cpqfcTSinit.c 2005-08-14 14:25:33.0 +0200
@@ -264,18 +264,14 @@ static void launch_FCworker_thread
Remove compat code for Linux 2.4 and earlier. Fixed bug in earlier version
that caused compile error.
Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED]
--- a/drivers/scsi/cpqfcTScontrol.c 2005-08-13 19:00:35.0 +0200
+++ b/drivers/scsi/cpqfcTScontrol.c 2005-08-14 11:02:09.0
-by: Rolf Eike Beer [EMAIL PROTECTED]
diff -aup linux-2.6.13-rc6/drivers/scsi/cpqfcTSinit.c
linux-2.6.13-rc6-eike/drivers/scsi/cpqfcTSinit.c
--- linux-2.6.13-rc6/drivers/scsi/cpqfcTSinit.c 2005-08-16 16:42:14.0
+0200
+++ linux-2.6.13-rc6-eike/drivers/scsi/cpqfcTSinit.c2005-08-16
16
Martin K. Petersen wrote:
Rolf == Rolf Eike Beer [EMAIL PROTECTED] writes:
Hey Rolf!
I should go and use R. Eike Beer ;)
Rolf There was a request on lkml last week for a working version of
Rolf this driver. For the moment I try to clean this up a bit before
Rolf doing some real work. I found 4
: remove that lock_kernel() stuff missed in the first version
Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED]
diff -aup linux-2.6.13-rc6/drivers/scsi/cpqfcTSinit.c
linux-2.6.13-rc6-eike/drivers/scsi/cpqfcTSinit.c
--- linux-2.6.13-rc6/drivers/scsi/cpqfcTSinit.c 2005-08-16 16:42:14.0
+0200
(pointed out by Christoph Hellwig)
Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED]
diff -aup linux-2.6.13-rc6/drivers/scsi/cpqfcTSinit.c
linux-2.6.13-rc6-eike/drivers/scsi/cpqfcTSinit.c
--- linux-2.6.13-rc6/drivers/scsi/cpqfcTSinit.c 2005-08-16 16:42:14.0
+0200
+++ linux-2.6.13-rc6-eike
into the next queue
item, but everytime 160 bytes of stack memory are memcpy()'ed. This patch
introduced a fourth argument for this error case and changes the third one
not to be void* anymore. It also shrinks this driver by 50 lines and 1kB.
Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED]
diff -aup
Andrew Vasquez wrote:
ISP4xxx driver initialization routines.
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED]
---
drivers/scsi/qla4xxx/ql4_init.c | 1753
+++ drivers/scsi/qla4xxx/ql4_iocb.c |
595 +
2 files changed, 2348 insertions(+), 0
Christoph Hellwig wrote:
@@ -1600,8 +1593,6 @@
SCSI_LOG_ERROR_RECOVERY(3, printk(Wake up parent of
scsi_eh_%d\n,shost-host_no));
- complete(shost-eh_notify);
-
while (1) {
/*
* If we get a signal, it
Christoph Hellwig wrote:
As Rolf Eike Beer noted we might not actually get to the
kthread_should_stop() because we are waiting in the semaphore forever.
I didn't get a rmmod hang because of this, but my instrumentation showed
the thread defitiyly didn't exit.
So make sure to wake the EH thread
Christoph Hellwig wrote:
As Rolf Eike Beer noted we might not actually get to the
kthread_should_stop() because we are waiting in the semaphore forever.
I didn't get a rmmod hang because of this, but my instrumentation showed
the thread defitiyly didn't exit.
So make sure to wake the EH thread
James Bottomley wrote:
On Mon, 2007-02-12 at 11:29 +0100, Rolf Eike Beer wrote:
Am Sonntag, 11. Februar 2007 schrieb James Bottomley:
This is the accumulated SCSI tree for 2.6.20. It is available at
master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git
You once again
Vinayak Holikatti wrote:
+static int __devinit
+ufshcd_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
+{
+ struct ufs_hba *hba;
+ void __iomem *mmio_base;
+ int err;
+
+ err = pci_enable_device(pdev);
+ if (err) {
+ dev_err(pdev-dev,
Am Dienstag 21 August 2012, 21:53:15 schrieb sreekanth.re...@lsi.com:
Fix for issue - Unable to boot from the SAS drive connected to HBA
This patch checks whether HBA is SAS2008 B0 controller.
if it is a SAS2008 B0 controller then it use IO-APIC interrupt instead of
MSIX, as SAS2008 B0
This module has been removed in commit 6072609d9bb91ff54aee3ef29304bd5b4fc88aae
([SCSI] Remove scsi_wait_scan module), so this module is gone since 3.6.
Signed-off-by: Rolf Eike Beer <eike-ker...@sf-tec.de>
---
drivers/scsi/Kconfig | 7 ---
1 file changed, 7 deletions(-)
diff
Am Mittwoch, 22. Juni 2016, 14:52:40 schrieb Meelis Roos:
> > > > > I noticed on RP3440 and A500 that recent 4.4-rc* crashes on boot.
> > > > >
> > > > >I've not seen it with 4.4-rc yet, but I've seen it on debian kernel
> > >
> > > > >4.3.3:
> > > This is still present in 4.6, just tested. All
> Right.
> I just succeeded in reproducing the bug with moving blk_bio_segment_split()
> into an own file (and with "extern" instead of "static" in blk-merge.c).
> When compiled with -O2 it still crashes. So, next step is to analyze what
> gcc does wrong when compiling this function. It should get
48 matches
Mail list logo
