Re: simplify procfs code for seq_file instances V2

2018-05-09 Thread Alexey Dobriyan
On Sun, May 06, 2018 at 06:45:31PM +0100, Al Viro wrote: > On Sun, May 06, 2018 at 08:19:49PM +0300, Alexey Dobriyan wrote: > > @@ -62,9 +62,9 @@ struct proc_dir_entry { > > umode_t mode; > > u8 namelen; > > #ifdef CONFIG_64BIT > > -#define SI

Re: simplify procfs code for seq_file instances V2

2018-05-06 Thread Alexey Dobriyan
On Wed, Apr 25, 2018 at 05:47:47PM +0200, Christoph Hellwig wrote: > Changes since V1: > - open code proc_create_data to avoid setting not fully initialized >entries live > - use unsigned int for state_size Need this to maintain sizeof(struct proc_dir_entry): Otherwise ACK fs/proc/ part.

Re: simplify procfs code for seq_file instances

2018-04-25 Thread Alexey Dobriyan
On Tue, Apr 24, 2018 at 06:06:53PM +0200, Christoph Hellwig wrote: > On Tue, Apr 24, 2018 at 08:19:16AM -0700, Andrew Morton wrote: > > > > I want to ask if it is time to start using poorman function overloading > > > > with _b_c_e(). There are millions of allocation functions for example, > > > >

Re: simplify procfs code for seq_file instances

2018-04-19 Thread Alexey Dobriyan
> git://git.infradead.org/users/hch/misc.git proc_create I want to ask if it is time to start using poorman function overloading with _b_c_e(). There are millions of allocation functions for example, all slightly difference, and people will add more. Seeing /proc interfaces doubled like this

Re: [PATCH 03/39] proc: introduce proc_create_seq_private

2018-04-19 Thread Alexey Dobriyan
On Thu, Apr 19, 2018 at 02:41:04PM +0200, Christoph Hellwig wrote: > Variant of proc_create_data that directly take a struct seq_operations > --- a/fs/proc/internal.h > +++ b/fs/proc/internal.h > @@ -45,6 +45,7 @@ struct proc_dir_entry { > const struct inode_operations *proc_iops; >

Re: [PATCH 14/39] proc: introduce proc_create_net_single

2018-04-19 Thread Alexey Dobriyan
On Thu, Apr 19, 2018 at 02:41:15PM +0200, Christoph Hellwig wrote: > Variant of proc_create_data that directly take a seq_file show > +struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode, > + struct proc_dir_entry *parent, > + int (*show)(struct

Re: [PATCH 02/39] proc: introduce proc_create_seq{,_data}

2018-04-19 Thread Alexey Dobriyan
On Thu, Apr 19, 2018 at 02:41:03PM +0200, Christoph Hellwig wrote: > Variants of proc_create{,_data} that directly take a struct seq_operations > argument and drastically reduces the boilerplate code in the callers. > +static int proc_seq_open(struct inode *inode, struct file *file) > +{ > +

Re: 2.6.24-rc4-mm1 and excessive block IO errors

2007-12-07 Thread Alexey Dobriyan
On Fri, Dec 07, 2007 at 03:05:37PM -0800, Andrew Morton wrote: On Fri, 07 Dec 2007 20:44:45 + Zan Lynx [EMAIL PROTECTED] wrote: I am not sure if this problem has been addressed already. I read some about the fast-fail issues and this may be related? On nearly all my USB block

Re: 2.6.24-rc4-mm1: hostbyte=0x01 driverbyte=0x00 (now bisected)

2007-12-06 Thread Alexey Dobriyan
On Thu, Dec 06, 2007 at 08:52:29AM +0100, Hannes Reinecke wrote: Alexey Dobriyan wrote: git-scsi-misc.patch Apologies for not looking into the problem earlier. See http://marc.info/?t=11962802235r=1w=2 2.6.24-rc3-mm2: Result: hostbyte=0x01 driverbyte=0x00\nend_request: I/O

2.6.24-rc4-mm1: hostbyte=0x01 driverbyte=0x00 (now bisected)

2007-12-05 Thread Alexey Dobriyan
git-scsi-misc.patch Apologies for not looking into the problem earlier. See http://marc.info/?t=11962802235r=1w=2 2.6.24-rc3-mm2: Result: hostbyte=0x01 driverbyte=0x00\nend_request: I/O error for previous installment. I've bisected it to the following patch in git-scsi-misc branch. Revert

Re: sr_mod oops (elv_next_request involved)

2007-10-23 Thread Alexey Dobriyan
On Mon, Oct 22, 2007 at 04:12:06PM +0400, Alexey Dobriyan wrote: Steps to reproduce: modprobe sr_mod To clarify: this is done during boot sequence. rmmod sr_mod modprobe sr_mod This -- by hand. BUG: unable to handle kernel paging request at virtual address f881b9f3

sr_mod oops (elv_next_request involved)

2007-10-22 Thread Alexey Dobriyan
Steps to reproduce: modprobe sr_mod rmmod sr_mod modprobe sr_mod BUG: unable to handle kernel paging request at virtual address f881b9f3 printing eip: f881b9f3 *pdpt = 3001 1*pde = 0480a067 *pte = Oops: 0010 [#1] PREEMPT SMP

[PATCH] esp_scsi.c: fix compilation

2007-04-27 Thread Alexey Dobriyan
irqreturn.h for irqreturn_t and dma_addr_t being u128 warnings ;-) Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- drivers/scsi/esp_scsi.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) --- a/drivers/scsi/esp_scsi.c +++ b/drivers/scsi/esp_scsi.c @@ -13,6 +13,7

Re: [PATCH 2.6.13 1/20] aic94xx: Makefile

2005-09-09 Thread Alexey Dobriyan
On Fri, Sep 09, 2005 at 03:32:05PM -0400, Luben Tuikov wrote: --- linux-2.6.13-orig/drivers/scsi/aic94xx/Makefile +++ linux-2.6.13/drivers/scsi/aic94xx/Makefile +CHECK = sparse -Wbitwise make C=1 CHECK=sparse -Wbitwise or make C=1 +clean-files += *~ Don't override what

[PATCH] gdth: schedule GDTIOCTL_OSVERS for removal

2005-08-09 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- Documentation/feature-removal-schedule.txt |8 1 files changed, 8 insertions(+) --- linux-vanilla/Documentation/feature-removal-schedule.txt +++ linux-gdth/Documentation/feature-removal-schedule.txt @@ -135,3 +135,11 @@ Why

[PATCH CC] gdth: remove GDTIOCTL_OSVERS

2005-08-07 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- drivers/scsi/gdth.c | 12 drivers/scsi/gdth_ioctl.h |8 2 files changed, 20 deletions(-) diff -uprN linux-vanilla/drivers/scsi/gdth.c linux-gdth/drivers/scsi/gdth.c --- linux-vanilla/drivers/scsi/gdth.c

Documentation/ioctl-mess.txt and ida_ioctl() review (was Re: [PATCH 2/3] cpqarray: ioctl support to configure LUNs dynamically)

2005-08-04 Thread Alexey Dobriyan
On Thu, Aug 04, 2005 at 10:15:29AM +0530, Saripalli, Venkata Ramanamurthy (STSD) wrote: Patch 2 of 3 This patch adds support for IDAREGNEWDISK, IDADEREGDISK, IDAGETLOGINFO ioctls required to configure LUNs dynamically on SA4200 controller using ACU. drivers/block/cpqarray.c: 1131 static

Re: [KJ] [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros

2005-04-13 Thread Alexey Dobriyan
On Wednesday 13 April 2005 12:11, Tobias Klauser wrote: Replace the MS_TO_JIFFIES() macro with msecs_to_jiffies() from jiffies.h --- linux-2.6.12-rc2-mm3/drivers/scsi/a100u2w.c +++ linux-2.6.12-rc2-mm3-tk/drivers/scsi/a100u2w.c static void waitForPause(unsigned amount) { - ULONG

Re: [ANNOUNCE 3/6] Open-iSCSI High-Performance Initiator for Linux

2005-03-07 Thread Alexey Dobriyan
On Monday 07 March 2005 09:15, Alex Aizman wrote: drivers/scsi/Kconfig changes. --- linux-2.6.11.orig/drivers/scsi/Kconfig +++ linux-2.6.11.dima/drivers/scsi/Kconfig +config ISCSI_IF + tristate iSCSI Open Transport Interface + depends on SCSI INET + ---help--- +

Re: [ANNOUNCE 2/6] Open-iSCSI High-Performance Initiator for Linux

2005-03-07 Thread Alexey Dobriyan
On Monday 07 March 2005 09:12, Alex Aizman wrote: Common header files: - iscsi_ifev.h (user/kernel events). - iscsi_if.h (iSCSI open interface over netlink); - iscsi_proto.h (RFC3720 #defines and types); --- linux-2.6.11.orig/include/scsi/iscsi_if.h