[PATCH v2] scsi: ufs: make ufshcd_get_lists_status() register operation obvious

From: Tomohiro Kusumi It could be just cmp 0xe instead of >>1 and cmp 0x7, with readable code. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 11 +-- drivers/scsi/ufs/ufshci.h | 4 2 files changed, 5 insertions(+), 10

[PATCH 2/2] scsi: ufs: make ufshcd_get_lists_status() register operation obvious

From: Tomohiro Kusumi It could be just cmp 0xe instead of >>1 and cmp 0x7, with readable code. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 11 +-- drivers/scsi/ufs/ufshci.h | 4 2 files changed, 5 insertions(+), 10

[PATCH 1/2] scsi: ufs: use MASK_EE_STATUS

From: Tomohiro Kusumi MASK_EE_STATUS added by 66ec6d59 was unused, but it seems to have been defined to do this. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 1/6] scsi: ufs: make ufshcd_is_{device_present,hba_active}() return bool

From: Tomohiro Kusumi ufshcd driver generally uses bool for is_xxx type things instead of int, so conform to its style. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PATCH 3/6] scsi: ufs: non functional macro fix

From: Tomohiro Kusumi Not having () isn't likely to do any harm in this case, but all the other macros below do have it. Also add "are" in a comment. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 8 1 file changed, 4

[PATCH 5/6] scsi: ufs: remove deprecated enum for hw interrupt

From: Tomohiro Kusumi These flags are no longer needed after 2fbd009b in 2013. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c

[PATCH 6/6] scsi: ufs: just use sizeof() for snprintf()

From: Tomohiro Kusumi Not much reason to use ARRAY_SIZE() when we know it's for a C string. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c

[PATCH 4/6] scsi: ufs: add missing macros for register bits from UFSHCI spec

From: Tomohiro Kusumi Add macros for register bits that can be found in JESD223C (v2.1). Not all registers are defined in ufshci.h (i.e. some are unused whether macros are defined or undefined), but all the bits for those registers that are already defined should appear

[PATCH 2/6] scsi: ufs: use existing macro CONTROLLER_ENABLE to test register bit

From: Tomohiro Kusumi (Note this commit directly goes on top of the previous one) Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c

[PATCH] scsi: ufs: fix wrong/ambiguous fall through comments

From: Tomohiro Kusumi These aren't really falling through to anywhere meaningful. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c