Re: [PATCH] [SCSI] Make scsi_transfer_length take a scsi_data_buffer argument

2014-08-06 Thread Sagi Grimberg
On 7/25/2014 11:00 PM, Martin K. Petersen wrote: For bidirectional commands we need to be able to distinguish between the in and out scsi_data_buffers when calculating the wire transfer length. Make scsi_transfer_length() take a scsi_data_buffer argument so the caller can choose which I/O

Re: [PATCH] [SCSI] Make scsi_transfer_length take a scsi_data_buffer argument

2014-08-06 Thread Sagi Grimberg
On 8/6/2014 3:12 PM, Sagi Grimberg wrote: SNIP diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index f2db82beb646..fdea8c1527d4 100644 --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -391,7 +391,7 @@ static int iscsi_prep_scsi_cmd_pdu(struct iscsi_task *task)

Re: [PATCH] [SCSI] Make scsi_transfer_length take a scsi_data_buffer argument

2014-08-06 Thread Martin K. Petersen
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes: Sagi On second thought, since the transfer length is always the command Sagi scsi data buffer length, why not keep it as is and if at any point Sagi in the future DIF will co-exist with bidi, we can add Sagi scsi_bidi_transfer_length which

Re: [PATCH] [SCSI] Make scsi_transfer_length take a scsi_data_buffer argument

2014-07-29 Thread Christoph Hellwig
Can I get another review for this one? Sami? On Fri, Jul 25, 2014 at 02:19:27PM -0700, Christoph Hellwig wrote: On Fri, Jul 25, 2014 at 04:00:19PM -0400, Martin K. Petersen wrote: For bidirectional commands we need to be able to distinguish between the in and out scsi_data_buffers when

[PATCH] [SCSI] Make scsi_transfer_length take a scsi_data_buffer argument

2014-07-25 Thread Martin K. Petersen
For bidirectional commands we need to be able to distinguish between the in and out scsi_data_buffers when calculating the wire transfer length. Make scsi_transfer_length() take a scsi_data_buffer argument so the caller can choose which I/O direction the calculation should apply to.

Re: [PATCH] [SCSI] Make scsi_transfer_length take a scsi_data_buffer argument

2014-07-25 Thread Christoph Hellwig
On Fri, Jul 25, 2014 at 04:00:19PM -0400, Martin K. Petersen wrote: For bidirectional commands we need to be able to distinguish between the in and out scsi_data_buffers when calculating the wire transfer length. Make scsi_transfer_length() take a scsi_data_buffer argument so the caller can