Re: [PATCH] ib_srp: Remove WARN_ON in srp_terminate_io()

2018-10-17 Thread Christoph Hellwig
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c > index e52b9d3c0bd6..c777b36ba62a 100644 > --- a/drivers/nvme/host/fc.c > +++ b/drivers/nvme/host/fc.c > @@ -483,6 +483,8 @@ nvme_fc_signal_discovery_scan(struct nvme_fc_lport *lport, > char hostaddr[FCNVME_TRADDR_LENGTH];/*

[PATCH] ib_srp: Remove WARN_ON in srp_terminate_io()

2018-10-17 Thread Hannes Reinecke
The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE at that time, so no new commands can be submitted via srp_queuecommand() Signed-off-by: Hannes Reinecke Reviewed-by: Jens Axboe Reviewed-by: Johannes Thumshirn --- drivers/infiniband/ulp/srp/ib_srp.c | 7 ---

Re: [PATCH] ib_srp: Remove WARN_ON in srp_terminate_io()

2018-09-21 Thread Bart Van Assche
On 9/21/18 5:15 AM, Hannes Reinecke wrote: The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE at that time, so no new commands can be submitted via srp_queuecomment() Signed-off-by: Hannes Reinecke --- drivers/infiniband/ulp/srp/ib_srp.c | 7 --- 1 file changed,

Re: [PATCH] ib_srp: Remove WARN_ON in srp_terminate_io()

2018-09-21 Thread Johannes Thumshirn
On Fri, Sep 21, 2018 at 02:15:05PM +0200, Hannes Reinecke wrote: > The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE > at that time, so no new commands can be submitted via srp_queuecomment() s/srp_queuecomment/srp_queuecommand/ -- Johannes Thumshirn

[PATCH] ib_srp: Remove WARN_ON in srp_terminate_io()

2018-09-21 Thread Hannes Reinecke
The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE at that time, so no new commands can be submitted via srp_queuecomment() Signed-off-by: Hannes Reinecke --- drivers/infiniband/ulp/srp/ib_srp.c | 7 --- 1 file changed, 7 deletions(-) diff --git