RE: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

2016-04-15 Thread Sathya Prakash Veerichetty
nath Prabu Subramani; Calvin Owens Subject: RE: [PATCH] mpt3sas - remove unused fw_event_work delayed_work Joe , The below mentioned patch is an older patch, verified latest code also the code before merging(mpt2sas & mpt3sas) didn't find changes of below patch. So I am searching for the patch whi

RE: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

2016-04-15 Thread Chaitra Basappa
wens Subject: Re: [PATCH] mpt3sas - remove unused fw_event_work delayed_work >>>>> "Joe" == Joe Lawrence <joe.lawre...@stratus.com> writes: Joe> Do we know why f1c35e6aea579 "mpt2sas: RESCAN Barrier work is added Joe> in case of HBA reset" was unneeded

Re: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

2016-04-14 Thread Martin K. Petersen
> "Joe" == Joe Lawrence writes: Joe> Do we know why f1c35e6aea579 "mpt2sas: RESCAN Barrier work is added Joe> in case of HBA reset" was unneeded for the mpt3 version? If that Joe> is interesting, that info could be added to v2 commit message as Joe> well. Chaitra?

Re: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

2016-04-11 Thread Joe Lawrence
--- From: Sathya Prakash [mailto:sathya.prak...@broadcom.com] Sent: Saturday, April 02, 2016 1:45 AM To: emi...@redhat.com; Joe Lawrence Cc: linux-scsi@vger.kernel.org; Chaitra Basappa; Suganath Prabu Subramani; Calvin Owens Subject: RE: [PATCH] mpt3sas - remove unused fw_event_work delayed_wo

RE: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

2016-04-11 Thread Chaitra Basappa
el.org; Chaitra Basappa; Suganath Prabu Subramani; Calvin Owens Subject: RE: [PATCH] mpt3sas - remove unused fw_event_work delayed_work We will look into this early next week and provide a detailed response. On the first look this is ACK from Broadcom, will reconfirm. -Original Message- From

RE: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

2016-04-01 Thread Sathya Prakash
; Sathya Prakash; Chaitra P B; Suganath Prabu Subramani; Calvin Owens Subject: Re: [PATCH] mpt3sas - remove unused fw_event_work delayed_work On Fri, 2016-04-01 at 15:13 -0400, Joe Lawrence wrote: > On 04/01/2016 02:51 PM, Ewan D. Milne wrote: > > On Fri, 2016-04-01 at 13:56 -0400, Joe Lawre

Re: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

2016-04-01 Thread Ewan D. Milne
On Fri, 2016-04-01 at 15:13 -0400, Joe Lawrence wrote: > On 04/01/2016 02:51 PM, Ewan D. Milne wrote: > > On Fri, 2016-04-01 at 13:56 -0400, Joe Lawrence wrote: > >> @@ -2804,12 +2803,12 @@ _scsih_fw_event_cleanup_queue(struct > >> MPT3SAS_ADAPTER *ioc) > >>/* > >> * Wait

Re: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

2016-04-01 Thread Joe Lawrence
On 04/01/2016 02:51 PM, Ewan D. Milne wrote: > On Fri, 2016-04-01 at 13:56 -0400, Joe Lawrence wrote: >> @@ -2804,12 +2803,12 @@ _scsih_fw_event_cleanup_queue(struct MPT3SAS_ADAPTER >> *ioc) >> /* >> * Wait on the fw_event to complete. If this returns 1, then >>

Re: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

2016-04-01 Thread Ewan D. Milne
On Fri, 2016-04-01 at 13:56 -0400, Joe Lawrence wrote: > The driver's fw events are queued up using the the fw_event_work's > struct work, not its delayed_work member. The latter appears to be > unused and may provoke CONFIG_DEBUG_OBJECTS_TIMERS "assert_init not > available" false warnings in

Re: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

2016-04-01 Thread Laurence Oberman
rg Cc: "Sathya Prakash" <sathya.prak...@broadcom.com>, "Chaitra P B" <chaitra.basa...@broadcom.com>, "Suganath Prabu Subramani" <suganath-prabu.subram...@broadcom.com>, "Calvin Owens" <calvinow...@fb.com>, "Joe Lawrence" <joe.la

[PATCH] mpt3sas - remove unused fw_event_work delayed_work

2016-04-01 Thread Joe Lawrence
The driver's fw events are queued up using the the fw_event_work's struct work, not its delayed_work member. The latter appears to be unused and may provoke CONFIG_DEBUG_OBJECTS_TIMERS "assert_init not available" false warnings in _scsih_fw_event_cleanup_queue. Remove it and update