Re: [PATCH] qla2xxx: Fix issue reported by static checker for qla2x00_els_dcmd2_sp_done()

2018-08-08 Thread Madhani, Himanshu
Hi Bart, > On Aug 8, 2018, at 8:10 AM, Bart Van Assche wrote: > > External Email > > On Tue, 2018-08-07 at 20:39 -0700, Himanshu Madhani wrote: >> From: Quinn Tran > > To me this seems to be a real bug fix rather than a patch that only suppresses > a static checker complaint. If that is the

Re: [PATCH] qla2xxx: Fix issue reported by static checker for qla2x00_els_dcmd2_sp_done()

2018-08-08 Thread Bart Van Assche
On Tue, 2018-08-07 at 20:39 -0700, Himanshu Madhani wrote: > From: Quinn Tran To me this seems to be a real bug fix rather than a patch that only suppresses a static checker complaint. If that is the case, please mention this in the patch subject. Thanks, Bart.

[PATCH] qla2xxx: Fix issue reported by static checker for qla2x00_els_dcmd2_sp_done()

2018-08-07 Thread Himanshu Madhani
From: Quinn Tran This patch fixes following Smatch complaint: drivers/scsi/qla2xxx/qla_iocb.c:2647 qla2x00_els_dcmd2_sp_done() error: we previously assumed 'e' could be null (see line 2631) Fixes: 8777e4314d39 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine") Reported-by: Dan