Re: [PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero

2017-05-08 Thread Martin K. Petersen 

Colin,

> The 2nd check to see if request_size is less than zero is redundant
> because the first check takes error exit path on this condition. So,
> since it is redundant, remove it.

Applied to 4.12/scsi-fixes.

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero

2017-05-04 Thread Tyrel Datwyler 
On 05/03/2017 09:29 AM, Colin King wrote:
> From: Colin Ian King 
> 
> The 2nd check to see if request_size is less than zero is redundant
> because the first check takes error exit path on this condition. So,
> since it is redundant, remove it.
> 
> Detected by CoverityScan, CID#146149 ("Logically Dead Code")
> 
> Signed-off-by: Colin Ian King 

Reviewed-by: Tyrel Datwyler

[PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero

2017-05-03 Thread Colin King 
From: Colin Ian King 

The 2nd check to see if request_size is less than zero is redundant
because the first check takes error exit path on this condition. So,
since it is redundant, remove it.

Detected by CoverityScan, CID#146149 ("Logically Dead Code")

Signed-off-by: Colin Ian King 
---
 drivers/scsi/pmcraid.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index a4aadf5f4dc6..1cc814f1505a 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -3770,9 +3770,6 @@ static long pmcraid_ioctl_passthrough(
pmcraid_err("couldn't build passthrough ioadls\n");
goto out_free_cmd;
}
-   } else if (request_size < 0) {
-   rc = -EINVAL;
-   goto out_free_cmd;
}
 
/* If data is being written into the device, copy the data from user
-- 
2.11.0