Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-10 Thread Dale R. Worley
Seymour, Shane M shane.seym...@hp.com writes: Both of those things would have to be futures and require discussion - the very original version cleared stats on a device open but I got asked to keep it the stats cumulative so they would be more similar to disk stats. Yes, this is a futures

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-09 Thread Kai Mäkisara (Kolumbus)
On 9.2.2015, at 8.00, Seymour, Shane M shane.seym...@hp.com wrote: Kai - see last 3 paragraphs for question about if something is a bug or not. BTW I had a look - I couldn't quickly find out if there was a way to tell if the medium has changed in a tape drive (there could be something

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-08 Thread Dale R. Worley
One feature of tape statistics is that they're as much about the *tape* as they are about the *drive*, which is uncommon for block devices. It might be useful to have a set of counters which is cleared every time a new tape is inserted into the drive. In particular, bad reads since this tape was

RE: [PATCH] st: implement sysfs based tape statistics v2

2015-02-08 Thread Seymour, Shane M
09, 2015 10:19 AM To: 'Dale R. Worley' Cc: linux-scsi@vger.kernel.org Subject: RE: [PATCH] st: implement sysfs based tape statistics v2 Both of those things would have to be futures and require discussion - the very original version cleared stats on a device open but I got asked to keep

RE: [PATCH] st: implement sysfs based tape statistics v2

2015-02-08 Thread Seymour, Shane M
, Shane M Cc: linux-scsi@vger.kernel.org Subject: Re: [PATCH] st: implement sysfs based tape statistics v2 One feature of tape statistics is that they're as much about the *tape* as they are about the *drive*, which is uncommon for block devices. It might be useful to have a set of counters which

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-06 Thread Jeremy Linton
On 1/26/2015 6:11 PM, Seymour, Shane M wrote: I was wondering if anyone had any feedback or had any chance to review the changes? Per the other discussion about having the same stat format forever. It seems to me that you might want to preemptively add a few additional counters.

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread Kai Mäkisara (Kolumbus)
On 2.2.2015, at 17.16, Laurence Oberman oberma...@gmail.com wrote: I pulled this this morning and will be testing. The prior version was stable for me on the upstream and RHEL 6.5 kernel without exhaustive testing. We also just received more requests to get this into RHEL from HP / Red

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread Laurence Oberman
...@suse.com Sent: Thursday, February 5, 2015 12:03:29 PM Subject: Re: [PATCH] st: implement sysfs based tape statistics v2 On 2.2.2015, at 17.16, Laurence Oberman oberma...@gmail.com wrote: I pulled this this morning and will be testing. The prior version was stable for me on the upstream

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread Kai Mäkisara (Kolumbus)
E.J. Bottomley (jbottom...@parallels.com) jbottom...@parallels.com, je...@suse.com Sent: Thursday, February 5, 2015 12:03:29 PM Subject: Re: [PATCH] st: implement sysfs based tape statistics v2 On 2.2.2015, at 17.16, Laurence Oberman oberma...@gmail.com wrote: I pulled this this morning

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread James Bottomley
On Thu, 2015-02-05 at 19:46 +0200, Kai Mäkisara (Kolumbus) wrote: On 5.2.2015, at 19.40, Laurence Oberman lober...@redhat.com wrote: I missed the earlier conversations with James, I will go search for them. Do you mean add them so they are similar to the /proc/diskstats cat

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread Bryn M. Reeves
On Thu, Feb 05, 2015 at 07:46:32PM +0200, Kai Mäkisara (Kolumbus) wrote: On 5.2.2015, at 19.40, Laurence Oberman lober...@redhat.com wrote: From: Kai Mäkisara (Kolumbus) kai.makis...@kolumbus.fi I still think that the tape statistics should be exported like the statistics of “real” block

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread James Bottomley
On Thu, 2015-02-05 at 18:50 +, Bryn M. Reeves wrote: On Thu, Feb 05, 2015 at 07:46:32PM +0200, Kai Mäkisara (Kolumbus) wrote: On 5.2.2015, at 19.40, Laurence Oberman lober...@redhat.com wrote: From: Kai Mäkisara (Kolumbus) kai.makis...@kolumbus.fi I still think that the tape

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread Bryn M. Reeves
On Thu, Feb 05, 2015 at 10:55:50AM -0800, James Bottomley wrote: OK, the sysfs bikeshedders hang out on linux-api https://www.kernel.org/doc/man-pages/linux-api-ml.html If you can convince them, we'll do the single file approach. Will do - I've got a couple of stats projects on the go at

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread Laurence Oberman
...@parallels.com, je...@suse.com Sent: Thursday, February 5, 2015 12:46:32 PM Subject: Re: [PATCH] st: implement sysfs based tape statistics v2 On 5.2.2015, at 19.40, Laurence Oberman lober...@redhat.com wrote: - Original Message - From: Kai Mäkisara (Kolumbus) kai.makis...@kolumbus.fi

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-02 Thread Laurence Oberman
I pulled this this morning and will be testing. The prior version was stable for me on the upstream and RHEL 6.5 kernel without exhaustive testing. We also just received more requests to get this into RHEL from HP / Red Hat customers. Kai, what are your thoughts. I realize this is a large amount

RE: [PATCH] st: implement sysfs based tape statistics v2

2015-01-26 Thread Seymour, Shane M
: kai.makis...@kolumbus.fi; James E.J. Bottomley (jbottom...@parallels.com); je...@suse.com Subject: [PATCH] st: implement sysfs based tape statistics v2 Some small changes since the last version - this version removes two files from sysfs compared to the last version (read and write block counts

[PATCH] st: implement sysfs based tape statistics v2

2015-01-12 Thread Seymour, Shane M
Some small changes since the last version - this version removes two files from sysfs compared to the last version (read and write block counts since they're derived from the byte counts they can be calculated in user space) but that's the only change. This version has been rebased to