Re: [PATCH 1/1] dpt_i2o: delete unnecessary null test on array

2014-08-09 Thread Julia Lawall
From nobody Sat Aug 9 08:17:15 CEST 2014 From: Julia Lawall julia.law...@lip6.fr To: Adaptec OEM Raid Solutions aacr...@adaptec.com Cc: James E.J. Bottomley jbottom...@parallels.com,linux-scsi@vger.kernel.org,linux-ker...@vger.kernel.org Subject: [PATCH] dpt_i2o: delete unnecessary null test on

Re: [PATCH 1/1] dpt_i2o: delete unnecessary null test on array

2014-08-08 Thread walter harms
Am 06.08.2014 12:39, schrieb Julia Lawall: From: Julia Lawall julia.law...@lip6.fr Delete NULL test on array (always false). A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ type T; T [] e; position p; @@

Re: [PATCH 1/1] dpt_i2o: delete unnecessary null test on array

2014-08-08 Thread James Bottomley
On Wed, 2014-08-06 at 12:39 +0200, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Delete NULL test on array (always false). A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ type T; T [] e;

Re: [PATCH 1/1] dpt_i2o: delete unnecessary null test on array

2014-08-08 Thread Julia Lawall
diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c index 67283ef..62e276b 100644 --- a/drivers/scsi/dpt_i2o.c +++ b/drivers/scsi/dpt_i2o.c @@ -1169,11 +1169,6 @@ static struct adpt_device* adpt_find_device(adpt_hba* pHba, u32 chan, u32 id, u6 if(chan 0 || chan =

Re: [PATCH 1/1] dpt_i2o: delete unnecessary null test on array

2014-08-08 Thread James Bottomley
On Fri, 2014-08-08 at 19:03 +0200, Julia Lawall wrote: diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c index 67283ef..62e276b 100644 --- a/drivers/scsi/dpt_i2o.c +++ b/drivers/scsi/dpt_i2o.c @@ -1169,11 +1169,6 @@ static struct adpt_device*

Re: [PATCH 1/1] dpt_i2o: delete unnecessary null test on array

2014-08-08 Thread Julia Lawall
On Fri, 8 Aug 2014, James Bottomley wrote: On Fri, 2014-08-08 at 19:03 +0200, Julia Lawall wrote: diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c index 67283ef..62e276b 100644 --- a/drivers/scsi/dpt_i2o.c +++ b/drivers/scsi/dpt_i2o.c @@ -1169,11 +1169,6 @@ static

[PATCH 1/1] dpt_i2o: delete unnecessary null test on array

2014-08-06 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr Delete NULL test on array (always false). A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ type T; T [] e; position p; @@ e ==@p NULL @ disable fld_to_ptr@ expression e; identifier