Re: [PATCH 2/3] m68k/atari - atari_scsi: change abort/reset return codes

2014-04-11 Thread Sam Creasey
Acked-by: Sam Creasey sa...@sammy.net On Thu, Mar 13, 2014 at 01:30:15AM +1100, Finn Thain wrote: This is a larger version of Michael's patch. It takes care of the header files and comments and it addresses sun3_NCR5380 as well as atari_NCR5380. This means that the initio.h include (!) can

Re: [PATCH 2/3] m68k/atari - atari_scsi: change abort/reset return codes

2014-03-12 Thread Michael Schmitz
Finn, nothings' been merged yet, still pending review from the SCSI team. Comments below. This is a larger version of Michael's patch. It takes care of the header files and comments and it addresses sun3_NCR5380 as well as atari_NCR5380. This means that the initio.h include (!) can be

Re: [PATCH 2/3] m68k/atari - atari_scsi: change abort/reset return codes

2014-03-12 Thread Michael Schmitz
Bugger - forgot to CC Sammy as well. My only comment of substance is that the reset handling doesn't need to be done the same way as on Atari, as there's no special locking to account for. Cheers, Michael Am 11.03.2014 um 21:28 schrieb Geert Uytterhoeven: CC Sammy On Tue, Mar

Re: [PATCH 2/3] m68k/atari - atari_scsi: change abort/reset return codes

2014-03-12 Thread Finn Thain
This is a larger version of Michael's patch. It takes care of the header files and comments and it addresses sun3_NCR5380 as well as atari_NCR5380. This means that the initio.h include (!) can be dropped from sun3_scsi.h. Signed-off-by: Finn Thain fth...@telegraphics.com.au --- This version

Re: [PATCH 2/3] m68k/atari - atari_scsi: change abort/reset return codes

2014-03-11 Thread Geert Uytterhoeven
CC Sammy On Tue, Mar 11, 2014 at 9:21 AM, Finn Thain fth...@telegraphics.com.au wrote: This is a larger version of Michael's patch. It takes care of the header files and comments and it addresses sun3_NCR5380 as well as atari_NCR5380. This means that the initio.h include (!) can be dropped

Re: [PATCH 2/3] m68k/atari - atari_scsi: change abort/reset return codes

2014-03-11 Thread Finn Thain
This is a larger version of Michael's patch. It takes care of the header files and comments and it addresses sun3_NCR5380 as well as atari_NCR5380. This means that the initio.h include (!) can be dropped from sun3_scsi.h. Signed-off-by: Finn Thain fth...@telegraphics.com.au --- Michael, I'm

[PATCH 2/3] m68k/atari - atari_scsi: change abort/reset return codes

2014-02-28 Thread Michael Schmitz
The abort/reset lowlevel return codes had changed with the new error SCSI handling - update Atari NCR5380 driver to reflect this. Change reset handling to clear queues only, do not attempt to call done() on each command aborted by the reset. The EH code should do that for us. Queues _must_ be

[PATCH 2/3] m68k/atari - atari_scsi: change abort/reset return codes

2014-01-28 Thread Michael Schmitz
The abort/reset lowlevel return codes had changed with the new error SCSI handling - update Atari NCR5380 driver to reflect this. Change reset handling to clear queues only, do not attempt to call done() on each command aborted by the reset. The EH code should do that for us. Queues _must_ be