Re: [PATCH 5/6] [SCSI] Look up and store NAA if VPD page 0x83 is present

2014-07-17 Thread Bart Van Assche
On 05/29/14 05:52, Martin K. Petersen wrote: Copy offloading requires us to know the NAA descriptor for both source target device. This descriptor is mandatory in the Device Identification VPD page. Locate this descriptor in the returned VPD data so we don't have to do lookups for every copy

Re: [PATCH 5/6] [SCSI] Look up and store NAA if VPD page 0x83 is present

2014-07-17 Thread Martin K. Petersen
Bart == Bart Van Assche bvanass...@acm.org writes: Bart Sorry for the late reply but it's only now that I noticed this Bart patch. Are you sure that presence of a NAA descriptor is Bart mandatory ? This is what I found in SPC-4 r37 paragraph 7.8.6.2.1: Bart quote At least one designation

Re: [PATCH 5/6] [SCSI] Look up and store NAA if VPD page 0x83 is present

2014-06-03 Thread Paolo Bonzini
Il 03/06/2014 03:00, Martin K. Petersen ha scritto: Paolo == Paolo Bonzini pbonz...@redhat.com writes: + sdev_printk(KERN_ERR, sdev, + %s: VPD page 0x83 NAA descriptor not found\n, __func__); + + return; Paolo I suspect this error will be relatively common. You're right. But we would like

Re: [PATCH 5/6] [SCSI] Look up and store NAA if VPD page 0x83 is present

2014-06-02 Thread Nicholas A. Bellinger
On Wed, 2014-05-28 at 23:52 -0400, Martin K. Petersen wrote: Copy offloading requires us to know the NAA descriptor for both source target device. This descriptor is mandatory in the Device Identification VPD page. Locate this descriptor in the returned VPD data so we don't have to do lookups

Re: [PATCH 5/6] [SCSI] Look up and store NAA if VPD page 0x83 is present

2014-06-02 Thread Paolo Bonzini
Il 29/05/2014 05:52, Martin K. Petersen ha scritto: + sdev_printk(KERN_ERR, sdev, + %s: VPD page 0x83 NAA descriptor not found\n, __func__); + + return; I suspect this error will be relatively common. libata for example has if (ata_id_has_wwn(args-id)) {

[PATCH 5/6] [SCSI] Look up and store NAA if VPD page 0x83 is present

2014-05-28 Thread Martin K. Petersen
Copy offloading requires us to know the NAA descriptor for both source target device. This descriptor is mandatory in the Device Identification VPD page. Locate this descriptor in the returned VPD data so we don't have to do lookups for every copy command. Signed-off-by: Martin K. Petersen