Re: [PATCH v2] mpt3sas: correct reset of smid while clearing scsi tracker

2018-08-03 Thread Bart Van Assche
On Fri, 2018-08-03 at 18:55 +0300, Andy Shevchenko wrote: > On Fri, Aug 3, 2018 at 5:06 PM, Bart Van Assche > wrote: > > On Fri, 2018-08-03 at 06:31 -0400, Sreekanth Reddy wrote: > > > + /* Added memory barrier to make sure that correct chain tracker > > > + * is retrieved before

Re: [PATCH v2] mpt3sas: correct reset of smid while clearing scsi tracker

2018-08-03 Thread Andy Shevchenko
On Fri, Aug 3, 2018 at 5:06 PM, Bart Van Assche wrote: > On Fri, 2018-08-03 at 06:31 -0400, Sreekanth Reddy wrote: >> + /* Added memory barrier to make sure that correct chain tracker >> + * is retrieved before incrementing the smid pool's chain_offset >> + * value in chain lookup

Re: [PATCH v2] mpt3sas: correct reset of smid while clearing scsi tracker

2018-08-03 Thread Bart Van Assche
On Fri, 2018-08-03 at 06:31 -0400, Sreekanth Reddy wrote: > In mpt3sas_base_clear_st() function smid value is reseted in ^^^ That's not an English word. Please read

[PATCH v2] mpt3sas: correct reset of smid while clearing scsi tracker

2018-08-03 Thread Sreekanth Reddy
In mpt3sas_base_clear_st() function smid value is reseted in wrong line, i.e. driver should reset smid value to zero after decrementing chain_offset counter in chain_lookup table but in current code, driver is resetting smid value before decrementing the chain_offset counter. which we are