Re: [PATCH v2 04/12] scsi_tcq.h: Add support for multiple hardware queues

2014-10-21 Thread Christoph Hellwig
On Mon, Oct 20, 2014 at 02:01:25PM +0200, Bart Van Assche wrote: On 10/19/14 18:12, Sagi Grimberg wrote: On 10/7/2014 4:04 PM, Bart Van Assche wrote: -req = blk_queue_find_tag(sdev-request_queue, tag); +req = blk_queue_find_tag(sdev-request_queue, tag); Why is this line

Re: [PATCH v2 04/12] scsi_tcq.h: Add support for multiple hardware queues

2014-10-21 Thread Sagi Grimberg
On 10/21/2014 11:49 AM, Christoph Hellwig wrote: On Mon, Oct 20, 2014 at 02:01:25PM +0200, Bart Van Assche wrote: On 10/19/14 18:12, Sagi Grimberg wrote: On 10/7/2014 4:04 PM, Bart Van Assche wrote: -req = blk_queue_find_tag(sdev-request_queue, tag); +req =

Re: [PATCH v2 04/12] scsi_tcq.h: Add support for multiple hardware queues

2014-10-20 Thread Bart Van Assche
On 10/19/14 18:12, Sagi Grimberg wrote: On 10/7/2014 4:04 PM, Bart Van Assche wrote: -req = blk_queue_find_tag(sdev-request_queue, tag); +req = blk_queue_find_tag(sdev-request_queue, tag); Why is this line different? This is because the indentation has been modified from

Re: [PATCH v2 04/12] scsi_tcq.h: Add support for multiple hardware queues

2014-10-19 Thread Sagi Grimberg
On 10/7/2014 4:04 PM, Bart Van Assche wrote: Modify scsi_find_tag() and scsi_host_find_tag() such that these fuctions can translate a tag generated by blk_mq_unique_tag(). Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Christoph Hellwig h...@lst.de Cc: Sagi Grimberg sa...@mellanox.com

[PATCH v2 04/12] scsi_tcq.h: Add support for multiple hardware queues

2014-10-07 Thread Bart Van Assche
Modify scsi_find_tag() and scsi_host_find_tag() such that these fuctions can translate a tag generated by blk_mq_unique_tag(). Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Christoph Hellwig h...@lst.de Cc: Sagi Grimberg sa...@mellanox.com --- include/scsi/scsi_tcq.h | 19