RE: [PATCH v2 7/8] scsi: ufs-bsg: Add support for raw upiu in ufs_bsg_request()

2018-08-09 Thread Avri Altman
nayak Holikatti ; Avi Shchislowski ; Alex Lemberg ; Stanislav Nijnikov ; > subha...@codeaurora.org > Subject: Re: [PATCH v2 7/8] scsi: ufs-bsg: Add support for raw upiu in > ufs_bsg_request() > > On Sun, 2018-08-05 at 14:39 +0300, Avri Altman wrote: > > + if (ret || !(

Re: [PATCH v2 7/8] scsi: ufs-bsg: Add support for raw upiu in ufs_bsg_request()

2018-08-08 Thread Bart Van Assche
On Sun, 2018-08-05 at 14:39 +0300, Avri Altman wrote: > + if (ret || !(*desc_len)) > + return -EINVAL; No parentheses around *desc_len please. Thanks, Bart.

[PATCH v2 7/8] scsi: ufs-bsg: Add support for raw upiu in ufs_bsg_request()

2018-08-05 Thread Avri Altman
Do that for the currently supported UPIUs: query, nop out, and task management. We do not support UPIU of type scsi command yet, while we are using the job's request and reply pointers to hold the payload. We will look into it in later patches. We might need to elaborate the raw upiu api for