Re: [PATCH v3 1/6] virtio_scsi: remove ACCESS_ONCE() and smp_read_barrier_depends()

2014-06-05 Thread Christoph Hellwig
On Wed, Jun 04, 2014 at 01:34:54PM +0200, Paolo Bonzini wrote: From: Ming Lei tom.leim...@gmail.com Access to tgt-req_vq is strictly serialized by spin_lock of tgt-tgt_lock, so the ACCESS_ONCE() isn't necessary. smp_read_barrier_depends() in virtscsi_req_done was introduced to order

[PATCH v3 1/6] virtio_scsi: remove ACCESS_ONCE() and smp_read_barrier_depends()

2014-06-04 Thread Paolo Bonzini
From: Ming Lei tom.leim...@gmail.com Access to tgt-req_vq is strictly serialized by spin_lock of tgt-tgt_lock, so the ACCESS_ONCE() isn't necessary. smp_read_barrier_depends() in virtscsi_req_done was introduced to order reading req_vq and decreasing tgt-reqs, but it isn't needed now because