Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq()

2017-04-25 Thread Martin K. Petersen
Bart, >> I was merely objecting to the fact that we already have umpteen existing >> interfaces for displaying SCSI command information. > Do you perhaps want me to change the for-loop into a call to > __scsi_format_command()? If possible, I would love to see some commonality in the

Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq()

2017-04-24 Thread Bart Van Assche
On Mon, 2017-04-24 at 19:33 -0400, Martin K. Petersen wrote: > > The debugfs infrastructure is already there, and it already supports > > showing requests. Bart is just exposing the SCSI information. > > That's fine. > > I was merely objecting to the fact that we already have umpteen existing >

Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq()

2017-04-24 Thread Martin K. Petersen
Omar, > The debugfs infrastructure is already there, and it already supports > showing requests. Bart is just exposing the SCSI information. That's fine. I was merely objecting to the fact that we already have umpteen existing interfaces for displaying SCSI command information. -- Martin K.

Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq()

2017-04-24 Thread Omar Sandoval
On Mon, Apr 24, 2017 at 07:19:50PM -0400, Martin K. Petersen wrote: > > Bart, > > > SCSI tracing has to be enabled before a test is started, produces a > > huge amount of data, and deriving state information from a huge trace > > is far from easy. The information in debugfs provides an easy to

Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq()

2017-04-24 Thread Martin K. Petersen
Bart, > SCSI tracing has to be enabled before a test is started, produces a > huge amount of data, and deriving state information from a huge trace > is far from easy. The information in debugfs provides an easy to read > overview of the current state without having to analyze megabytes of >

Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq()

2017-04-24 Thread Bart Van Assche
On Mon, 2017-04-24 at 17:35 -0400, Martin K. Petersen wrote: > > Show the SCSI CDB, .eh_eflags and .result for pending SCSI commands > > in /sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. > > Why not use SCSI tracing if you are interested in these? Hello Martin, SCSI tracing has to be

Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq()

2017-04-24 Thread Martin K. Petersen
Bart, > Show the SCSI CDB, .eh_eflags and .result for pending SCSI commands > in /sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. Why not use SCSI tracing if you are interested in these? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq()

2017-04-24 Thread Hannes Reinecke
On 04/22/2017 01:40 AM, Bart Van Assche wrote: > Show the SCSI CDB, .eh_eflags and .result for pending SCSI commands > in /sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. > > Signed-off-by: Bart Van Assche > Cc: Martin K. Petersen >

[PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq()

2017-04-21 Thread Bart Van Assche
Show the SCSI CDB, .eh_eflags and .result for pending SCSI commands in /sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. Signed-off-by: Bart Van Assche Cc: Martin K. Petersen Cc: James Bottomley