Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_rtpg()

2016-04-15 Thread Martin K. Petersen
> "Dan" == Dan Carpenter writes: Dan> It's possible to use "err" without initializing it. If it happens Dan> to be a 2 which is SCSI_DH_RETRY then that could cause a bug. Bart Dan> Van Assche pointed out that we should probably re-initialize it for Dan> every

Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_rtpg()

2016-04-15 Thread Hannes Reinecke
On 04/14/2016 08:20 PM, Dan Carpenter wrote: > It's possible to use "err" without initializing it. If it happens to be > a 2 which is SCSI_DH_RETRY then that could cause a bug. Bart Van Assche > pointed out that we should probably re-initialize it for every iteration > through the retry loop. >

Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_rtpg()

2016-04-14 Thread Bart Van Assche
On 04/14/2016 11:20 AM, Dan Carpenter wrote: It's possible to use "err" without initializing it. If it happens to be a 2 which is SCSI_DH_RETRY then that could cause a bug. Bart Van Assche pointed out that we should probably re-initialize it for every iteration through the retry loop.

[patch v2] scsi_dh_alua: uninitialized variable in alua_rtpg()

2016-04-14 Thread Dan Carpenter
It's possible to use "err" without initializing it. If it happens to be a 2 which is SCSI_DH_RETRY then that could cause a bug. Bart Van Assche pointed out that we should probably re-initialize it for every iteration through the retry loop. Signed-off-by: Dan Carpenter