Re: [PATCH] drop some attibutes from the FC transport class

2005-01-20 Thread Greg KH
On Wed, Jan 19, 2005 at 11:12:00PM -0600, Matt Domsch wrote: On Wed, Jan 19, 2005 at 03:42:19PM -0800, Greg KH wrote: Here it was against 2.6.9. Odds are it doesn't apply anymore due to some recent changes in this area. If anyone wants to take it and fix it up, please do so. Note,

RE: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread James . Smart
True. The only thing that made them FC-ish is that they were mandated by HBAAPI. The only other desire was to place all hbaapi-related data in a single place so users/applications don't have to trapse through the multiple directories in the class and device trees. I'll ping Greg on adding them

Re: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread Greg KH
On Wed, Jan 19, 2005 at 06:13:57PM +0100, Christoph Hellwig wrote: I think the hardware_version, firmware_version, rom_version and driver_version don't belong into the FC transport class, there's nothign specific to FC or even SCSI specific in them. Then put them in the individual driver (not

Re: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread Brian King
Greg KH wrote: On Wed, Jan 19, 2005 at 06:13:57PM +0100, Christoph Hellwig wrote: I think the hardware_version, firmware_version, rom_version and driver_version don't belong into the FC transport class, there's nothign specific to FC or even SCSI specific in them. Then put them in the individual

Re: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread Greg KH
On Wed, Jan 19, 2005 at 12:38:31PM -0600, Brian King wrote: Greg KH wrote: On Wed, Jan 19, 2005 at 06:13:57PM +0100, Christoph Hellwig wrote: I think the hardware_version, firmware_version, rom_version and driver_version don't belong into the FC transport class, there's nothign specific to

Re: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread Mike Anderson
Greg KH [EMAIL PROTECTED] wrote: On Wed, Jan 19, 2005 at 06:13:57PM +0100, Christoph Hellwig wrote: I think the hardware_version, firmware_version, rom_version and driver_version don't belong into the FC transport class, there's nothign specific to FC or even SCSI specific in them. Then

Re: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread Greg KH
On Wed, Jan 19, 2005 at 11:03:50PM +, Christoph Hellwig wrote: On Wed, Jan 19, 2005 at 02:40:16PM -0800, Greg KH wrote: I had a patch to do that around here somewhere, but I think it was rejected as people can get the same info by using 'modinfo' instead. You know, the old, use a

Re: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread Matt Domsch
On Wed, Jan 19, 2005 at 03:42:19PM -0800, Greg KH wrote: Here it was against 2.6.9. Odds are it doesn't apply anymore due to some recent changes in this area. If anyone wants to take it and fix it up, please do so. Note, this patch needs the evil strdup() function to work properly. That's