Re: [PATCH 2/2] fusion - honour return value of pci_enable_device() in mpt_resume()

2007-03-18 Thread Horms
On Fri, Mar 16, 2007 at 09:27:26AM -0500, James Bottomley wrote: On Fri, 2007-03-16 at 16:05 +0900, Horms wrote: + err = pci_enable_device(pdev); + if (err 0) + return err; Traditionally, this should be if (err) return err; The reason is that 0 is

Re: [PATCH 2/2] fusion - honour return value of pci_enable_device() in mpt_resume()

2007-03-16 Thread James Bottomley
On Fri, 2007-03-16 at 16:05 +0900, Horms wrote: + err = pci_enable_device(pdev); + if (err 0) + return err; Traditionally, this should be if (err) return err; The reason is that 0 is a signed comparison which can be slightly more expensive on some

Re: [PATCH 2/2] fusion - honour return value of pci_enable_device() in mpt_resume()

2007-03-16 Thread Randy Dunlap
On Fri, 16 Mar 2007 09:27:26 -0500 James Bottomley wrote: On Fri, 2007-03-16 at 16:05 +0900, Horms wrote: + err = pci_enable_device(pdev); + if (err 0) + return err; Traditionally, this should be if (err) return err; The reason is that 0 is a

Re: [PATCH 2/2] fusion - honour return value of pci_enable_device() in mpt_resume()

2007-03-16 Thread James Bottomley
On Fri, 2007-03-16 at 08:06 -0700, Randy Dunlap wrote: On Fri, 16 Mar 2007 09:27:26 -0500 James Bottomley wrote: On Fri, 2007-03-16 at 16:05 +0900, Horms wrote: + err = pci_enable_device(pdev); + if (err 0) + return err; Traditionally, this should be

Re: [PATCH 2/2] fusion - honour return value of pci_enable_device() in mpt_resume()

2007-03-16 Thread Randy Dunlap
On Fri, 16 Mar 2007 11:14:51 -0500 James Bottomley wrote: On Fri, 2007-03-16 at 08:06 -0700, Randy Dunlap wrote: On Fri, 16 Mar 2007 09:27:26 -0500 James Bottomley wrote: On Fri, 2007-03-16 at 16:05 +0900, Horms wrote: + err = pci_enable_device(pdev); + if (err 0)

Re: [PATCH 2/2] fusion - honour return value of pci_enable_device() in mpt_resume()

2007-03-16 Thread Douglas Gilbert
Randy Dunlap wrote: On Fri, 16 Mar 2007 11:14:51 -0500 James Bottomley wrote: On Fri, 2007-03-16 at 08:06 -0700, Randy Dunlap wrote: On Fri, 16 Mar 2007 09:27:26 -0500 James Bottomley wrote: On Fri, 2007-03-16 at 16:05 +0900, Horms wrote: + err = pci_enable_device(pdev); + if

RE: [PATCH 2/2] fusion - honour return value of pci_enable_device() in mpt_resume()

2007-03-16 Thread Moore, Eric
On Friday, March 16, 2007 1:06 AM, Horms wrote: Honour the return value of pci_enable_device(), which seems to be a desirable thing to do: Both patch's look good. Thanks, Eric - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED]