Re: tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module - revision4

2016-04-02 Thread Nicholas A. Bellinger
Hi Laurence, On Sat, 2016-04-02 at 13:10 -0400, Laurence Oberman wrote: > Hello Himanshu > > I noticed a typo in the patch I submitted here is the corrected patch. > Please ignore the prior patch > > I was missing the full CONFIG name in the #ifdef check > > Corrected Patch Two quick process

Re: tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module - revision4

2016-04-02 Thread Laurence Oberman
ot; <n...@linux-iscsi.org>, "Bart Van Assche" <bart.vanass...@sandisk.com>, "linux-scsi" <linux-scsi@vger.kernel.org>, "target-devel" <target-de...@vger.kernel.org>, "Quinn Tran" <quinn.t...@qlogic.com> Sent: Saturday, Ap

Re: tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module - revision4

2016-04-02 Thread Laurence Oberman
Hello Himanshu This patch was reworked to only include the jammer code if the parameter TCM_QLA2XXX_DEBUG=Y is set. The default is to not provide this functionality at all. I looked at using attributes but this code is in the fastpath and the overhead or fetching the attribute each time is not