[PATCH] tcm_fc: move the dereference below the NULL test

2012-09-07 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn The dereference should be moved below the NULL test. spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/target/tcm_fc/tfc_io.c | 3 ++- 1 file

[PATCH] target: move the dereference below the NULL test

2012-09-07 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn The dereference should be moved below the NULL test. spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/target/target_core_pr.c | 10 ++ 1

Re: [PATCH] Fix a use-after-free triggered by device removal

2012-09-07 Thread Bart Van Assche
On 09/07/12 01:20, Tejun Heo wrote: I think Mike is wondering whether your patch in isolation is enough or we also need to have DEAD check there too. The proposed patch can't handle the case where q-request_fn() is invoked after drain is complete. I'm not really sure whether that can happen

[PATCH] [SCSI] bnx2fc: move the dereference below the NULL test

2012-09-07 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn The dereference should be moved below the NULL test. spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/scsi/bnx2fc/bnx2fc_io.c | 4 +++- 1 file

RE: [PATCH] [SCSI] bnx2fc: move the dereference below the NULL test

2012-09-07 Thread yongjun_...@trendmicro.com.cn
Sorry, I see the patch fix this issue has already exists in the maillist, please ignore it, thanks. -Original Message- From: Wei Yongjun [mailto:weiyj...@gmail.com] Sent: 2012年9月7日 15:00 To: bprak...@broadcom.com; jbottom...@parallels.com Cc: Yongjun Wei (RD-CN);

Re: Linux kernel crash (3.2.0-2-amd64) when trying to play audio CD

2012-09-07 Thread Thomas Schwinge
Hi Borislav! I'm sorry for the late answer. On Mon, 18 Jun 2012 17:51:41 +0200, Borislav Petkov b...@amd64.org wrote: On Mon, Jun 18, 2012 at 04:52:36PM +0200, Thomas Schwinge wrote: Ok, can you do the following: $ setpci -s 18.0 0x68.l $ sudo setpci -s 18.0 0x68.l

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-07 Thread Aaron Lu
On 09/06/2012 11:06 PM, Alan Stern wrote: On Thu, 6 Sep 2012, Aaron Lu wrote: That's why we have an autosuspend delay. Although for some reason the SCSI subsystem doesn't use it currently... We need to add a call to pm_runtime_use_autosuspend() in scsi_sysfs_add_sdev(). Likewise, the

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-07 Thread Alan Stern
On Fri, 7 Sep 2012, Aaron Lu wrote: What I'd really like is a way to do the status polling without having it reset the idle timer. I like this, I'll try to see if this can be done. If we idle the device immediately, we would suspend/resume the ODD every 2 seconds, which may not be a

Re: [PATCH] scsi/ibmvscsi: add module alias for ibmvscsic

2012-09-07 Thread Robert Jennings
On Sun, Jul 29, 2012 at 8:32 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2012-07-18 at 18:49 +0200, o...@aepfle.de wrote: From: Olaf Hering o...@aepfle.de The driver is named ibmvscsic, at runtime it its name is advertised as ibmvscsi. For this reason mkinitrd wont

Re: [PATCH] scsi/ibmvscsi: /sys/class/scsi_host/hostX/config doesn't show any information

2012-09-07 Thread Robert Jennings
On Sun, Jul 29, 2012 at 8:33 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: scsi/ibmvscsi: Fix host config length field overflow The length field in the host config packet is only 16-bit long, so passing it 0x1 (64K which is our standard PAGE_SIZE) doesn't work and result in

[PATCH 3/4] scsi: make pci error handlers const

2012-09-07 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- Depends on first patch that changes PCI core. drivers/scsi/ipr.c |2 +- drivers/scsi/lpfc/lpfc_init.c|2 +- drivers/scsi/mpt2sas/mpt2sas_scsih.c |2 +- drivers/scsi/qla2xxx/qla_os.c|2

Re: [PATCH 2/5] drivers/scsi/bnx2fc/bnx2fc_io.c: Remove potential NULL dereference

2012-09-07 Thread Bhanu Prakash Gollapudi
On 8/14/2012 8:49 AM, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr If the NULL test is necessary, the initialization involving a dereference of the tested value should be moved after the NULL test. The sematic patch that fixes this problem is as follows:

Re: [PATCH 0/4] PCI error handler const

2012-09-07 Thread Bjorn Helgaas
On Fri, Sep 7, 2012 at 9:33 AM, Stephen Hemminger shemmin...@vyatta.com wrote: This is a trivial patch to make PCI error handler function tables const. Split into pieces so that core changes are first. I put all four of these on this branch: