Re: [PATCHv2 0/7] Limit overall SCSI EH runtime

2013-07-02 Thread James Bottomley
On Mon, 2013-07-01 at 16:55 -0400, Jörn Engel wrote: On Mon, 1 July 2013 19:23:25 +, James Bottomley wrote: On Mon, 2013-07-01 at 13:44 -0400, Jörn Engel wrote: If a single device is bad, don't ever do a host reset. This isn't a tenable position. Sometimes a device looks bad

RE: Linux boot Support for 4KB sector drives ?

2013-07-02 Thread Kishore Babu Lukka
Adding Asha also. -Original Message- From: Mahesh Rajashekhara Sent: Monday, July 01, 2013 11:41 AM To: jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: Tony Ruiz; Achim Leubner; Mahesh Rajashekhara; Kishore Babu Lukka Subject: Linux boot Support for 4KB sector drives ? Hello,

Re: Linux boot Support for 4KB sector drives ?

2013-07-02 Thread Aaron Lu
On 07/02/2013 03:11 PM, Kishore Babu Lukka wrote: Adding Asha also. -Original Message- From: Mahesh Rajashekhara Sent: Monday, July 01, 2013 11:41 AM To: jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: Tony Ruiz; Achim Leubner; Mahesh Rajashekhara; Kishore Babu Lukka

[PATCH v13 0/4] SCSI device removal fixes

2013-07-02 Thread Bart Van Assche
Fix a few issues related to SCSI device removal: - Fix a race between starved list processing and device removal that can trigger a kernel oops. - Avoid that __scsi_remove_device() is called twice for the same SCSI device, which also can cause a kernel oops. - Restrict the SCSI device state

[PATCH 1/4] Fix race between starved list and device removal

2013-07-02 Thread Bart Van Assche
From: James Bottomley jbottom...@parallels.com scsi_run_queue() examines all SCSI devices that are present on the starved list. Since scsi_run_queue() unlocks the SCSI host lock a SCSI device can get removed after it has been removed from the starved list and before its queue is run. Protect

[PATCH 2/4] Avoid calling __scsi_remove_device() twice

2013-07-02 Thread Bart Van Assche
If something goes wrong during LUN scanning, e.g. a transport layer failure occurs, then __scsi_remove_device() can get invoked by the LUN scanning code for a SCSI device in state SDEV_CREATED_BLOCK and before the SCSI device has been added to sysfs (is_visible == 0). Make sure that even in this

[PATCH 3/4] Avoid re-enabling I/O after the transport became offline

2013-07-02 Thread Bart Van Assche
Disallow the SDEV_TRANSPORT_OFFLINE to SDEV_CANCEL transition such that no I/O is sent to devices for which the transport is offline. Notes: - Functions like sd_shutdown() use scsi_execute_req() and hence set the REQ_PREEMPT flag. Such requests are passed to the LLD queuecommand callback in

[PATCH 4/4] Disallow changing the device state via sysfs into deleted

2013-07-02 Thread Bart Van Assche
Changing the state of a SCSI device via sysfs into cancel or deleted prevents removal of these devices by scsi_remove_host(). Hence do not allow this. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Tejun Heo t...@kernel.org Cc: James Bottomley jbottom...@parallels.com Cc: Mike Christie

Re: [PATCH 3/4] Avoid re-enabling I/O after the transport became offline

2013-07-02 Thread James Bottomley
On Tue, 2013-07-02 at 15:07 +0200, Bart Van Assche wrote: Disallow the SDEV_TRANSPORT_OFFLINE to SDEV_CANCEL transition such that no I/O is sent to devices for which the transport is offline. Notes: - Functions like sd_shutdown() use scsi_execute_req() and hence set the REQ_PREEMPT flag.

[GIT PULL] First round of SCSI updates for the 3.10+ merge window

2013-07-02 Thread James Bottomley
The patch set is mostly driver updates (usf, zfcp, lpfc, mpt2sas, megaraid_sas, bfa, ipr) and a few bug fixes. Also of note is that the Buslogic driver has been rewritten to a better coding style and 64 bit support added. We also removed the libsas limitation on 16 bytes for the command size

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-07-02 Thread Santosh Y
On Fri, Jun 28, 2013 at 5:02 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 6/27/2013 4:49 PM, Santosh Y wrote: + spin_lock_irqsave(host-host_lock, flags); task_req_descp = hba-utmrdl_base_addr; task_req_descp += free_slot; @@ -2353,38 +2387,39 @@

Re: [PATCHv2 0/7] Limit overall SCSI EH runtime

2013-07-02 Thread Jörn Engel
On Tue, 2 July 2013 06:37:05 +, James Bottomley wrote: I don't understand what you're getting at. In a dual HBA situation, whether the second HBA is implicated or not depends on configuration and what the first HBA is doing. If it's just passively lost device state, then the second HBA

Re: [PATCHv2 0/7] Limit overall SCSI EH runtime

2013-07-02 Thread James Bottomley
On Tue, 2013-07-02 at 10:58 -0400, Jörn Engel wrote: On Tue, 2 July 2013 06:37:05 +, James Bottomley wrote: I don't understand what you're getting at. In a dual HBA situation, whether the second HBA is implicated or not depends on configuration and what the first HBA is doing. If

Re: [PATCHv2 0/7] Limit overall SCSI EH runtime

2013-07-02 Thread Jörn Engel
On Tue, 2 July 2013 16:33:40 +, James Bottomley wrote: On Tue, 2013-07-02 at 10:58 -0400, Jörn Engel wrote: On Tue, 2 July 2013 06:37:05 +, James Bottomley wrote: I don't understand what you're getting at. In a dual HBA situation, whether the second HBA is implicated or not

[Bug 59601] commit 97dec564fd4948e0e560869c80b76e166ca2a83e breaks communication with XYRATEX disk shelves

2013-07-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=59601 --- Comment #7 from Jack Hill jackh...@jackhill.us 2013-07-02 22:13:28 --- Created an attachment (id=106661) -- (https://bugzilla.kernel.org/attachment.cgi?id=106661) dmesg output with packet dumps I have attached the dmesg output after

[Bug 59601] commit 97dec564fd4948e0e560869c80b76e166ca2a83e breaks communication with XYRATEX disk shelves

2013-07-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=59601 --- Comment #8 from Jack Hill jackh...@jackhill.us 2013-07-02 22:15:42 --- Also, I think the commit that I claimed introduced the problem after my bisect run was the wrong one, it appears to be the last good commit. I think the one that

[Bug 59301] mpt2sas0 fails after short time of work

2013-07-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=59301 Marian Marinov m...@yuhu.biz changed: What|Removed |Added CC||m...@yuhu.biz ---

[Bug 59301] mpt2sas0 fails after short time of work

2013-07-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=59301 --- Comment #3 from Marian Marinov m...@yuhu.biz 2013-07-03 00:36:39 --- [root@BlackPearl ~]# uname -a Linux BlackPearl.yuhu.biz 2.6.32-358.11.1.el6.i686 #1 SMP Wed Jun 12 01:01:27 UTC 2013 i686 i686 i386 GNU/Linux [root@BlackPearl ~]# cat

Re: [PATCH V2 3/4] scsi: ufs: Fix device and host reset methods

2013-07-02 Thread Santosh Y
+ +/** + * ufshcd_eh_device_reset_handler - device reset handler registered to + *scsi layer. + * @cmd - SCSI command pointer + * + * Returns SUCCESS/FAILED + */ +static int ufshcd_eh_device_reset_handler(struct scsi_cmnd *cmd) +{ + struct