Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

On Sun, Jan 15, 2017 at 8:11 AM, James Bottomley wrote: > > We're not reverting a fix that would cause regressions for others. Oh HELL YES we are. The rule is that we never break old stuff. Some new fix that fixes something that never used to work, but

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

On Sun, 2017-01-15 at 11:49 -0800, James Bottomley wrote: > On Sun, 2017-01-15 at 11:41 -0800, Linus Torvalds wrote: > > On Sun, Jan 15, 2017 at 11:13 AM, James Bottomley > > wrote: > > > > > > Can we compromise on "try not to revert a fix ...". > > > >

Re: iscsi_trx going into D state

- Original Message - > From: "Robert LeBlanc" > To: "Laurence Oberman" > Cc: "Doug Ledford" , "Nicholas A. Bellinger" > , "Zhu Lingshan" > , "linux-rdma" ,

[PATCH 6/6] atari_scsi: Reset DMA during bus reset only under ST-DMA lock

The atari_scsi driver should not access Falcon DMA chip registers unless it has acquired exclusive access to that chip. If the driver doesn't have exclusive access then there's no need for a DMA reset as there are no scsi commands in progress. Signed-off-by: Finn Thain

[PATCH 0/6] ncr5380: Miscellaneous minor patches

This series removes some unused code and related comments, addresses the warnings generated by 'make W=1' and 'make C=1' and fixes a theoretical bug in the bus reset method in atari_scsi. There's also a patch to add a missing error check during target selection. The only target I tested was a

[PATCH 5/6] ncr5380: Improve target selection robustness

Handle timeout or bus phase change errors that could occur when sending the IDENTIFY message. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/NCR5380.c

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

On Sun, Jan 15, 2017 at 11:13 AM, James Bottomley wrote: > > Can we compromise on "try not to revert a fix ...". No. It's about timing, and about how serious the regression is. For example, if this happened in rc7, I would have reverted immediately. No

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

On Sun, 2017-01-15 at 11:41 -0800, Linus Torvalds wrote: > On Sun, Jan 15, 2017 at 11:13 AM, James Bottomley > wrote: > > > > Can we compromise on "try not to revert a fix ...". > > No. > > It's about timing, and about how serious the regression is. > >

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

On Sun, 2017-01-15 at 10:54 -0800, Linus Torvalds wrote: > On Sun, Jan 15, 2017 at 8:11 AM, James Bottomley > wrote: > > > > We're not reverting a fix that would cause regressions for others. > > Oh HELL YES we are. > > The rule is that we never break old

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

On Tue, 2017-01-03 at 15:46 -0500, Jason Baron wrote: > On 01/01/2017 12:39 PM, James Bottomley wrote: > > + /* > > +* Bug work around for firmware SATL handling > > +*/ > > + if (sas_device_priv_data->ata_command_pending) { > > + scmd->result = SAM_STAT_BUSY; > > +

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

On Sun, 2017-01-15 at 10:19 +0100, Ingo Molnar wrote: > So there's a new mpt3sas SCSI driver boot regression, introduced in > this merge window, which made one of my servers unbootable. We're not reverting a fix that would cause regressions for others. However, The fix was manifestly wrong, so

[Bug 151661] Adaptec 3405 3805 prints "AAC: Host adapter dead -1" every 10 seconds but works fine anyway

https://bugzilla.kernel.org/show_bug.cgi?id=151661 --- Comment #18 from Arkadiusz Miskiewicz --- The problem was introduced with commit below. Reverting this commit from kernel 4.9.3 makes the problem go away. https://lkml.org/lkml/2017/1/15/47 commit

aacraid: kernel: AAC: Host adapter dead -1 (bisected)

Hi. There is a bug with handling of adaptec raid cards (in my case it is Adaptec 3405) where kernel logs hundreds of "AAC: Host adapter dead -1" messages. Bug was reported previously on lkml but there was no progres in solving it. There is also bugzilla entry:

[PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

So there's a new mpt3sas SCSI driver boot regression, introduced in this merge window, which made one of my servers unbootable. The kernel, starting at upstream commit a829a8445f09, would hang thusly: [6.230363] Linux agpgart interface v0.103 [6.245029] brd: module loaded [

[PATCH 1/6] ncr5380: Shorten host info string by removing unused option macros

The DIFFERENTIAL and PARITY option macros are unused: no supported hardware uses differential signalling and the core driver never implemented parity checking. These options just waste space in the host info string. While we are here, fix a typo in the NCR5380_info() kernel-doc comment.

[PATCH 2/6] ncr5380: Clean up dead code and redundant macro usage

Remove dead code inside #if 0 conditionals. Remove the #ifdef __KERNEL__ test, since NCR5380.h has no definitions that relate to userspace code. Remove two redundant macro definitions which were overlooked in commit e9db3198e08b ("sun3_scsi: Adopt NCR5380.c core driver"). Signed-off-by: Finn

[PATCH 4/6] ncr5380: Resolve various static checker warnings

Avoid various warnings from "make C=1" by annotating a couple of unlock-then-lock sequences, replacing a zero with NULL and correcting some type casts. Also avoid a warning from "make W=1" by adding braces. Signed-off-by: Finn Thain --- These are the warning messages

[PATCH 3/6] ncr5380: Reduce #include files

The NCR5380 wrapper drivers don't export symbols or declarations and don't actually need separate header files. Most of these header files were removed already; only sun3_scsi.h and g_NCR5380.h remain. Move the remaining definitions to the corresponding .c files to improve readability and

Re: [PATCH v2] virtio_scsi: Reject commands when virtqueue is broken

On Fri, 01/13 12:48, Eric Farman wrote: > In the case of a graceful set of detaches, where the virtio-scsi-ccw > disk is removed from the guest prior to the controller, the guest > behaves quite normally. Specifically, the detach gets us into > sd_sync_cache to issue a Synchronize Cache(10)