Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

* James Bottomley wrote: > On Sun, 2017-01-15 at 10:19 +0100, Ingo Molnar wrote: > > So there's a new mpt3sas SCSI driver boot regression, introduced in > > this merge window, which made one of my servers unbootable. > > We're not reverting a fix that

Re: [PATCH V2] mpt3sas: disable ASPM for MPI2 controllers

On 2017/01/06 15:48, Sreekanth Reddy wrote: On Fri, Jan 6, 2017 at 7:24 AM, Martin K. Petersen wrote: Matin, We need some time to review this patch. I will provide my review comments by end of next week. ping? //wbr ojab Thanks, Sreekanth -- To unsubscribe

Re: [PATCH V2] mpt3sas: disable ASPM for MPI2 controllers

Ojab, I am checking internally with our FW team and Architect to known whether they aware/observed any issues similar to this (since this issue is nothing to do with driver). Meanwhile is it possible to provide us the PCI config space and FW logs when issue occurs? Thanks, Sreekanth On Mon,

Re: [PATCH V2] mpt3sas: disable ASPM for MPI2 controllers

On Mon, Jan 16, 2017 at 6:15 PM, ojab wrote: > On 2017/01/16 12:36, Sreekanth Reddy wrote: >> >> Ojab, >> >> I am checking internally with our FW team and Architect to known >> whether they aware/observed any issues similar to this (since this >> issue is nothing to do with driver).

RE: [PATCH] preview - block layer help to detect sequential IO

> Hi, Kashyap, > > I'm CC-ing Kent, seeing how this is his code. Hi Jeff and Kent, See my reply inline. > > Kashyap Desai writes: > > > Objective of this patch is - > > > > To move code used in bcache module in block layer which is used to > > find IO stream.

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

On Mon, 2017-01-16 at 10:22 +0100, Ingo Molnar wrote: > * James Bottomley wrote: > > > On Sun, 2017-01-15 at 10:19 +0100, Ingo Molnar wrote: > > > So there's a new mpt3sas SCSI driver boot regression, introduced > > > in > > > this merge window, which made

Re: [PATCH V2] mpt3sas: disable ASPM for MPI2 controllers

On 2017/01/16 12:36, Sreekanth Reddy wrote: Ojab, I am checking internally with our FW team and Architect to known whether they aware/observed any issues similar to this (since this issue is nothing to do with driver). Meanwhile is it possible to provide us the PCI config space and FW logs

Re: [PATCH V2] mpt3sas: disable ASPM for MPI2 controllers

On 2017/01/16 13:31, Sreekanth Reddy wrote: On Mon, Jan 16, 2017 at 6:15 PM, ojab wrote: On 2017/01/16 12:36, Sreekanth Reddy wrote: Ojab, I am checking internally with our FW team and Architect to known whether they aware/observed any issues similar to this (since this issue

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

On Sun, Jan 15, 2017 at 10:02:51PM +, Bart Van Assche wrote: > I disagree. Even if my patch would be reverted that still wouldn't fix > the severe race condition that was introduced in the mpt3sas driver by > the patch that triggers the lockup during boot. As I explained two > weeks ago (see

[PATCH 0/2] virtio-scsi: Implement FC_HOST feature

This series implements the proposed fc_host feature of virtio-scsi. The first patch updates the data structure changes according to the spec proposal; the second patch actually implements the operations. Fam Zheng (2): virtio_scsi: Add fc_host definitions virtio_scsi: Implement fc_host

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

On Mon, 2017-01-16 at 07:27 -0800, Christoph Hellwig wrote: > On Sun, Jan 15, 2017 at 10:02:51PM +, Bart Van Assche wrote: > > I disagree. Even if my patch would be reverted that still wouldn't > > fix the severe race condition that was introduced in the mpt3sas > > driver by the patch that

[PATCH 2/2] virtio_scsi: Implement fc_host

This implements the VIRTIO_SCSI_F_FC_HOST feature by reading the config fields and presenting them as sysfs fc_host attributes. The config change handler is added here because primary_active will toggle during migration. Signed-off-by: Fam Zheng --- drivers/scsi/virtio_scsi.c |

[PATCH 1/2] virtio_scsi: Add fc_host definitions

Signed-off-by: Fam Zheng --- include/uapi/linux/virtio_scsi.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/uapi/linux/virtio_scsi.h b/include/uapi/linux/virtio_scsi.h index cc18ef8..a26fb31 100644 --- a/include/uapi/linux/virtio_scsi.h +++

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

On Sun, 2017-01-15 at 09:01 -0800, James Bottomley wrote: > From b47c28434e9cee9cbb95a794c97ec53657408111 Mon Sep 17 00:00:00 2001 > From: James Bottomley > Date: Sun, 1 Jan 2017 09:39:24 -0800 > Subject: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands > >

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

* James Bottomley wrote: > On Mon, 2017-01-16 at 10:22 +0100, Ingo Molnar wrote: > > * James Bottomley wrote: > > > > > On Sun, 2017-01-15 at 10:19 +0100, Ingo Molnar wrote: > > > > So there's a new mpt3sas SCSI

Re: [PATCH 0/2] virtio-scsi: Implement FC_HOST feature

On Tue, Jan 17, 2017 at 12:04:28AM +0800, Fam Zheng wrote: > This series implements the proposed fc_host feature of virtio-scsi. Yikes. Why? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 0/2] virtio-scsi: Implement FC_HOST feature

On 01/16/2017 05:04 PM, Fam Zheng wrote: > This series implements the proposed fc_host feature of virtio-scsi. > > The first patch updates the data structure changes according to the spec > proposal; the second patch actually implements the operations. > > Fam Zheng (2): > virtio_scsi: Add

Re: [PATCH 2/2] virtio_scsi: Implement fc_host

Hi Fam, [auto build test ERROR on linus/master] [also build test ERROR on v4.10-rc4 next-20170116] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Fam-Zheng/virtio-scsi-Implement-FC_HOST-feature

Re: [PATCH 2/2] virtio_scsi: Implement fc_host

On Mon, 01/16 17:45, Paolo Bonzini wrote: > > > On 16/01/2017 17:04, Fam Zheng wrote: > > + node_name = virtio_cread64(vdev, > > + offsetof(struct virtio_scsi_config, primary_wwnn)); > > + port_name = virtio_cread64(vdev, > > +

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

On Mon, Jan 16, 2017 at 08:14:39AM -0800, James Bottomley wrote: > So how about, instead of arguing about reversion, one or other of you > reviews the proposed fix of the fix which would avoid having to revert > anything? As far as I can tell everyone is waiting for you to resend it with the

Re: [Qemu-devel] [RFC PATCH 0/3] scsi-generic and BLKSECTGET

On Mon, 01/16 22:11, Eric Farman wrote: > (cc'ing linux-scsi for the cover-letter; patches only to QEMU lists.) > > In the Linux kernel, I see two (three) places where the BLKSECTGET ioctl is > handled: > > (1) block/(compat_)ioctl.c -- (compat_)blkdev_ioctl > (2) drivers/scsi/sg.c -- sg_ioctl >

Re: [PATCH] ses: Fix SAS device detection in enclosure

On Mon, Jan 16, 2017 at 04:02:24PM -0500, Martin K . Petersen wrote: > > "Ewan" == Ewan D Milne writes: > > Ewan> The call to scsi_is_sas_rphy() needs to be made on the SAS > Ewan> end_device, not on the SCSI device. > > Ewan> Fixes: 835831c57e9b ("ses: use

Re: [PATCH 0/2] virtio-scsi: Implement FC_HOST feature

On Mon, 01/16 09:34, Christoph Hellwig wrote: > On Tue, Jan 17, 2017 at 12:04:28AM +0800, Fam Zheng wrote: > > This series implements the proposed fc_host feature of virtio-scsi. > > Yikes. Why? Hi Christoph, this is mostly to "passthrough" a host NPIV vport (leaving libvirt doing the heavy

Re: [PATCH 2/2] virtio_scsi: Implement fc_host

On Tue, 01/17 03:02, kbuild test robot wrote: > Hi Fam, > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.10-rc4 next-20170116] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: &

Re: [PATCH 0/2] virtio-scsi: Implement FC_HOST feature

> How it this supposed to work? > You do export the WWPN/WWNN of the associated host to the guest (nb: > will get interesting for non NPIV setups ...), but virtio scsi will > still do a LUN remapping. > IE the LUNs you see on the host will be different from the LUNs > presented to the guest.

Re: [PATCH 2/2] virtio_scsi: Implement fc_host

Hi Fam, [auto build test ERROR on linus/master] [also build test ERROR on v4.10-rc4 next-20170116] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Fam-Zheng/virtio-scsi-Implement-FC_HOST-feature

[PATCH v2 12/12] qla2xxx: Simplify usage of SRB structure in driver.

From: Joe Carnuccio This patch simplifies SRB structure usage in driver. - Simplify sp->done() and sp->free() interfaces. - Remove sp->fcport->vha to use vha pointer from sp. - Use sp->vha context in qla2x00_rel_sp(). Signed-off-by: Joe Carnuccio

[PATCH v2 11/12] qla2xxx: Improve RSCN handling in driver

From: Quinn Tran Current code blindly does State Change Registration when the link is up. Move SCR behind fabric scan, so that arbitrated loop scan would not get erroneous error message. Some of the other improvements are as follows - Add session deletion for TPRLO and

[PATCH v2 03/12] qla2xxx: Make trace flags more readable.

From: Quinn Tran Trace flags are useful during debugging crash dumps using crash utility. These trace flags makes it easier to understand various states a command has successfully completed. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani

[PATCH v2 04/12] qla2xxx: Remove SRR code.

During initial implementation, tape support was included but not enabled by default on target. So far, we don't see any target customer requesting this support. Since this code is not being used actively, we want to remove it and we will add back if there are any request in future for SRR support.

[PATCH v2 02/12] qla2xxx: Cleanup TMF code translation from qla_target.

From: Quinn Tran Move code code which converts Task Mgmt Command flags for ATIO to TCM #defines, from qla2xxx driver to tcm_qla2xxx driver. Reviewed-by: Christoph Hellwig Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani

[PATCH v2 01/12] qla2xxx: Remove direct access of scsi_status field in se_cmd

From: Quinn Tran Reviewed-by: Christoph Hellwig Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 1 + drivers/scsi/qla2xxx/qla_target.c | 2 +- 2 files

[PATCH v2 00/12] qla2xxx: Feature updates for target.

Hi Bart, Christoph, Please consider this updated series for inclusion in target-pending. Changes from v1 --> v2 o Updated review comments and added Reviewed-by tags for necessary patches. o We left the one particular review comment to add helper routine to be addressed at later time in the

Re: [PATCH] libfc: Fix variable name in fc_set_wwpn

> "Fam" == Fam Zheng writes: Fam> The parameter name should be wwpn instead of wwnn. Applied to 4.10/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

[PATCH 1/2] qed: Add support for hardware offloaded FCoE.

From: Arun Easi This adds the backbone required for the various HW initalizations which are necessary for the FCoE driver (qedf) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi

[PATCH 0/2] Add QLogic FastLinQ FCoE (qedf) driver

From: "Dupuis, Chad" This series introduces the hardware offload FCoE initiator driver for the 41000 Series Converged Network Adapters (579xx chip) by Cavium. The overall driver design includes a common module ('qed') and protocol specific dependent modules ('qedf' for

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

>From 91d249409546569444897a1ffde65c421e064899 Mon Sep 17 00:00:00 2001 From: James Bottomley Date: Sun, 1 Jan 2017 09:39:24 -0800 Subject: [PATCH] scsi: mpt3sas: fix hang on ata passthrough commands mpt3sas has a firmware failure where it can only handle

[PATCH v2 07/12] qla2xxx: Track I-T nexus as single fc_port struct.

From: Quinn Tran Current code merges qla_tgt_sess and fc_port structure into single fc_port structure represeting same I-T nexus. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani ---

[PATCH v2 06/12] qla2xxx: Use d_id instead of s_id for more clarity.

From: Quinn Tran Updated code with d_id from s_id for better readabilty and clarity. Reviewed-by: Christoph Hellwig Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani ---

[PATCH v2 09/12] qla2xxx: Add Dual mode support in the driver

From: Quinn Tran Add switch to allow both Initiator Mode & Target mode to operate at the same time. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 +

[PATCH v2 10/12] qla2xxx: Remove unused reverse_ini_mode.

With support for dual mode in the driver, this mode becomes dead code. Remove reverse_ini_mode from code. Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 1 - drivers/scsi/qla2xxx/qla_target.c | 10 --

[PATCH v2 05/12] qla2xxx: Fix wrong argument in sp done callback.

From: Quinn Tran Callback for sp->done expects scsi_qla_host is passed in as argument, Instead qla_hw_data is passed in. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_isr.c | 8

[RFC PATCH 0/3] scsi-generic and BLKSECTGET

(cc'ing linux-scsi for the cover-letter; patches only to QEMU lists.) In the Linux kernel, I see two (three) places where the BLKSECTGET ioctl is handled: (1) block/(compat_)ioctl.c -- (compat_)blkdev_ioctl (2) drivers/scsi/sg.c -- sg_ioctl The former has been around forever[1], and returns a

Re: [PATCH V2] mpt3sas: disable ASPM for MPI2 controllers

On 2017/01/16 14:03, ojab wrote: On 2017/01/16 13:31, Sreekanth Reddy wrote: On Mon, Jan 16, 2017 at 6:15 PM, ojab wrote: On 2017/01/16 12:36, Sreekanth Reddy wrote: Ojab, I am checking internally with our FW team and Architect to known whether they aware/observed any issues

Re: [PATCH] ses: Fix SAS device detection in enclosure

> "Ewan" == Ewan D Milne writes: Ewan> The call to scsi_is_sas_rphy() needs to be made on the SAS Ewan> end_device, not on the SCSI device. Ewan> Fixes: 835831c57e9b ("ses: use scsi_is_sas_rphy instead of Ewan> is_sas_attached") Reviewed-by: Johannes Thumshirn Ewan>

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

> "James" == James Bottomley writes: James> Subject: [PATCH] scsi: mpt3sas: fix hang on ata passthrough James> commands James> mpt3sas has a firmware failure where it can only handle one pass James> through ATA command at a time. If another comes in,

Re: [PATCH 1/2] qed: Add support for hardware offloaded FCoE.

I forgot to add netdev-next to the subject line. Is a repost needed here? On Mon, 16 Jan 2017, 7:53pm -, Dupuis, Chad wrote: > From: Arun Easi > > This adds the backbone required for the various HW initalizations > which are necessary for the FCoE driver (qedf) for

Re: [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2

> "Don" == Don Brace writes: Don, Don> Wondering what has happened to this patch? According to my notes, there were some concerns with the series that did not get addressed. And only patch 3 actually got a reviewed-by tag. I suggest you repost the series. --

Re: [PATCH 1/2] qed: Add support for hardware offloaded FCoE.

From: Chad Dupuis Date: Mon, 16 Jan 2017 16:47:52 -0500 > I forgot to add netdev-next to the subject line. Is a repost needed > here? Not this time, no. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

RE: Survey for Incident [INC0903501]

From: Jones, Cherine Sent: Monday, January 16, 2017 11:10 AM To: Jones, Cherine Subject: Survey for Incident [INC0903501] Please take a moment to complete a survey on incident INC0903501 regarding "help desk survey on your email" Your feedback is extremely

Re: [PATCH 2/2] virtio_scsi: Implement fc_host

On 16/01/2017 17:04, Fam Zheng wrote: > + node_name = virtio_cread64(vdev, > + offsetof(struct virtio_scsi_config, primary_wwnn)); > + port_name = virtio_cread64(vdev, > + offsetof(struct virtio_scsi_config, primary_wwpn)); > +