Re: [PATCH] qedf: fix wrong le16 conversion

2017-03-23 Thread Martin K. Petersen
David Miller writes: >> Dave: Since you queued the firmware patch, mind taking this fix through >> your tree? > > Ok, applied to net-next, thanks. Great, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: iscsi (?): Unknown VPD Code: 0xc7

2017-03-23 Thread Martin K. Petersen
Harald Dunkel writes: > Mar 23 19:06:30 nasl003b kernel: [38396.624678] Unknown VPD Code: 0xc7 > > What is it trying to tell me? That is an IBM-specific VPD page containing device-unique configuration data. I guess it is a prerequisite for installing AIX. -- Martin K.

Re: RFC: always use REQ_OP_WRITE_ZEROES for zeroing offload

2017-03-23 Thread Lars Ellenberg
On Thu, Mar 23, 2017 at 01:02:22PM -0400, Mike Snitzer wrote: > On Thu, Mar 23 2017 at 11:54am -0400, > Lars Ellenberg wrote: > > > On Thu, Mar 23, 2017 at 10:33:18AM -0400, Christoph Hellwig wrote: > > > This series makes REQ_OP_WRITE_ZEROES the only zeroing offload >

[PATCH] scsi: ufs: fix wrong/ambiguous fall through comments

2017-03-23 Thread kusumi . tomohiro
From: Tomohiro Kusumi These aren't really falling through to anywhere meaningful. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c

Re: [PATCH] scsi: pm8001: build in relevant functions and code on PM8001_USE_MSIX

2017-03-23 Thread walter harms
Am 22.03.2017 19:50, schrieb Colin King: > From: Colin Ian King > > Currently the misx and intx variables of the interrupt enable/disable > helper functions are built in no matter what the setting of the > macro PM8001_USE_MSIX. Clean this up by just building in the

Re: [PATCH] scsi: pm8001: build in relevant functions and code on PM8001_USE_MSIX

2017-03-23 Thread Jinpu Wang
On Thu, Mar 23, 2017 at 9:34 AM, walter harms wrote: >> @@ -4613,15 +4616,15 @@ static int pm8001_chip_phy_ctl_req(struct >> pm8001_hba_info *pm8001_ha, >> >> static u32 pm8001_chip_is_our_interupt(struct pm8001_hba_info *pm8001_ha) >> { >> - u32 value; >> #ifdef

Re: [PATCH] scsi: pm8001: build in relevant functions and code on PM8001_USE_MSIX

2017-03-23 Thread Jinpu Wang
On Wed, Mar 22, 2017 at 7:50 PM, Colin King wrote: > From: Colin Ian King > > Currently the misx and intx variables of the interrupt enable/disable > helper functions are built in no matter what the setting of the > macro PM8001_USE_MSIX.

[PATCH] scsi: osd_uld: remove an unneeded NULL check

2017-03-23 Thread Dan Carpenter
We don't call the remove() function unless probe() succeeds so "oud" can't be NULL here. Plus, if it were NULL, we dereference it on the next line so it would crash anyway. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/osd/osd_uld.c

Re: [PATCH] lsscsi: Fix truncation of 128-bit wwn

2017-03-23 Thread Vaibhav Jain
Hi Gris, Thanks for reviewing the patch. I have posted a v2 patch addressing your review comments. Can you please take a look. Patch-Link: https://www.mail-archive.com/linux-scsi@vger.kernel.org/msg59720.html Gris Ge writes: > On Fri, Mar 17, 2017 at 10:08:40AM +0530, Vaibhav

Re: [PATCHv3 4/6] scsi_error: do not escalate failed EH command

2017-03-23 Thread Hannes Reinecke
On 03/21/2017 08:05 PM, Benjamin Block wrote: > On Thu, Mar 16, 2017 at 12:53:45PM +0100, Hannes Reinecke wrote: >> On 03/16/2017 12:01 PM, Benjamin Block wrote: >>> On Wed, Mar 15, 2017 at 02:54:16PM +0100, Hannes Reinecke wrote: On 03/14/2017 06:56 PM, Benjamin Block wrote: > Hello

[PATCH] qla2xxx: use sg_virt()

2017-03-23 Thread Geliang Tang
Use sg_virt() instead of open-coding it. Signed-off-by: Geliang Tang --- drivers/scsi/qla2xxx/qla_isr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index 3203367..9610d85 100644 ---

Re: [PATCH] scsi: fcoe: sanity check string size for store_ctrl_mode option

2017-03-23 Thread Dan Carpenter
On Wed, Mar 22, 2017 at 07:42:08PM +, Colin Ian King wrote: > On 22/03/17 19:39, Dan Carpenter wrote: > > On Wed, Mar 22, 2017 at 02:01:37PM +, Colin King wrote: > >> From: Colin Ian King > >> > >> Reading and writing to mode[count - 1] implies the count should

Re: [PATCH v2 01/10] be2iscsi: Check tag in beiscsi_mccq_compl_wait

2017-03-23 Thread Tomas Henzl
On 16.3.2017 04:24, Jitendra Bhivare wrote: > scsi host12: BS_1377 : mgmt_invalidate_connection Failed for cid=256 > BUG: unable to handle kernel NULL pointer dereference at 0008 > IP: [] __list_add+0xf/0xc0 > PGD 0 > Oops: [#1] SMP > Modules linked in: > ... > CPU: 9 PID: 1542

Re: RFC: always use REQ_OP_WRITE_ZEROES for zeroing offload

2017-03-23 Thread Mike Snitzer
On Thu, Mar 23 2017 at 11:54am -0400, Lars Ellenberg wrote: > On Thu, Mar 23, 2017 at 10:33:18AM -0400, Christoph Hellwig wrote: > > This series makes REQ_OP_WRITE_ZEROES the only zeroing offload > > supported by the block layer, and switches existing implementations >

Re: [PATCH] Fix PT2PT PRLI reject.

2017-03-23 Thread Martin K. Petersen
Dick Kennedy writes: Dick, > lpfc cannot establish connection with targets that send PRLI in P2P > configurations. > > If lpfc rejects a PRLI that is sent from a target the target will not > resend and will reject the PRLI send from the initiator. Applied to

Re: [PATCH v2 03/10] be2iscsi: Replace spin_unlock_bh with spin_lock

2017-03-23 Thread Tomas Henzl
On 16.3.2017 04:24, Jitendra Bhivare wrote: > spin_unlock_bh back_lock is used in beiscsi_eh_device_reset instead of > spin_lock. > > Signed-off-by: Jitendra Bhivare Reviewed-by: Tomas Henzl tomash

Re: [PATCH 1/6] ipr: Fix missed EH wakeup

2017-03-23 Thread Martin K. Petersen
Brian King writes: > Following a command abort or device reset, ipr's EH handlers wait > for the commands getting aborted to get sent back from the adapter > prior to returning from the EH handler. This fixes up some cases > where the completion handler was not getting

Re: [PATCH v2 00/10] be2iscsi: driver update 11.4.0.0

2017-03-23 Thread Martin K. Petersen
Jitendra Bhivare writes: Somebody please review! Thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH 12/23] sd: handle REQ_UNMAP

2017-03-23 Thread Christoph Hellwig
Try to use a write same with unmap bit variant if the device supports it and the caller asks for it. Signed-off-by: Christoph Hellwig --- drivers/scsi/sd.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index

[PATCH 05/23] dm: support REQ_OP_WRITE_ZEROES

2017-03-23 Thread Christoph Hellwig
Copy & paste from the REQ_OP_WRITE_SAME code. Signed-off-by: Christoph Hellwig --- drivers/md/dm-core.h | 1 + drivers/md/dm-io.c| 10 +++--- drivers/md/dm-linear.c| 1 + drivers/md/dm-mpath.c | 1 + drivers/md/dm-rq.c| 11

[PATCH 04/23] md: support REQ_OP_WRITE_ZEROES

2017-03-23 Thread Christoph Hellwig
Copy & paste from the REQ_OP_WRITE_SAME code. Signed-off-by: Christoph Hellwig --- drivers/md/linear.c| 1 + drivers/md/md.h| 7 +++ drivers/md/multipath.c | 1 + drivers/md/raid0.c | 2 ++ drivers/md/raid1.c | 4 +++- drivers/md/raid10.c| 1 +

[PATCH 15/23] loop: implement REQ_OP_WRITE_ZEROES

2017-03-23 Thread Christoph Hellwig
It's identical to discard as hole punches will always leave us with zeroes on reads. Signed-off-by: Christoph Hellwig --- drivers/block/loop.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 0ecb6461ed81..265cd2e33ff0 100644

[PATCH 10/23] block: add a new BLKDEV_ZERO_NOFALLBACK flag

2017-03-23 Thread Christoph Hellwig
This avoids fallbacks to explicit zeroing in (__)blkdev_issue_zeroout if the caller doesn't want them. Also clean up the convoluted check for the return condition that this new flag is added to. Signed-off-by: Christoph Hellwig --- block/blk-lib.c| 5 -

[PATCH 07/23] block: stop using blkdev_issue_write_same for zeroing

2017-03-23 Thread Christoph Hellwig
We'll always use the WRITE ZEROES code for zeroing now. Signed-off-by: Christoph Hellwig --- block/blk-lib.c | 4 1 file changed, 4 deletions(-) diff --git a/block/blk-lib.c b/block/blk-lib.c index ed1e78e24db0..a93115ccf461 100644 --- a/block/blk-lib.c +++ b/block/blk-lib.c

[PATCH 08/23] block: add a flags argument to (__)blkdev_issue_zeroout

2017-03-23 Thread Christoph Hellwig
Turn the existin discard flag into a new BLKDEV_ZERO_UNMAP flag with similar semantics, but without referring to diѕcard. Signed-off-by: Christoph Hellwig --- block/blk-lib.c | 31 ++- block/ioctl.c| 3 +--

[PATCH 13/23] nvme: implement REQ_OP_WRITE_ZEROES

2017-03-23 Thread Christoph Hellwig
But now for the real NVMe Write Zeroes yet, just to get rid of the discard abuse for zeroing. Also rename the quirk flag to be a bit more self-explanatory. Signed-off-by: Christoph Hellwig --- drivers/nvme/host/core.c | 10 +- drivers/nvme/host/nvme.h | 6 +++---

[PATCH 03/23] sd: implement REQ_OP_WRITE_ZEROES

2017-03-23 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- drivers/scsi/sd.c | 45 - drivers/scsi/sd_zbc.c | 1 + 2 files changed, 41 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index af632e350ab4..b6f70a09a301 100644

[PATCH 11/23] block_dev: use blkdev_issue_zerout for hole punches

2017-03-23 Thread Christoph Hellwig
This gets us support for non-discard efficient write of zeroes (e.g. NVMe) and preparse for removing the discard_zeroes_data flag. Also remove a pointless discard support check, which is done in blkdev_issue_discard already. Signed-off-by: Christoph Hellwig --- fs/block_dev.c | 16

Re: [PATCH] hpsa: fix volume offline state

2017-03-23 Thread Martin K. Petersen
Tomas Henzl writes: > In a previous patch a hpsa_scsi_dev_t.volume_offline update line > has been removed, so let us put it back.. > > Fixes: 85b29008d8 (hpsa: update check for logical volume status) Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux

[PATCH 02/23] block: implement splitting of REQ_OP_WRITE_ZEROES bios

2017-03-23 Thread Christoph Hellwig
Copy and past the REQ_OP_WRITE_SAME code to prepare to implementations that limit the write zeroes size. Signed-off-by: Christoph Hellwig --- block/blk-merge.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/block/blk-merge.c

[PATCH 06/23] dm-kcopyd: switch to use REQ_OP_WRITE_ZEROES

2017-03-23 Thread Christoph Hellwig
It seems like the code currently passes whatever it was using for writes to WRITE SAME. Just switch it to WRITE ZEROES, although that doesn't need any payload. Untested, and confused by the code, maybe someone who understands it better than me can help.. Not-yet-signed-off-by: Christoph Hellwig

RFC: always use REQ_OP_WRITE_ZEROES for zeroing offload

2017-03-23 Thread Christoph Hellwig
This series makes REQ_OP_WRITE_ZEROES the only zeroing offload supported by the block layer, and switches existing implementations of REQ_OP_DISCARD that correctly set discard_zeroes_data to it, removes incorrect discard_zeroes_data, and also switches WRITE SAME based zeroing in SCSI to this new

Re: support ranges TRIM for libata

2017-03-23 Thread James Bottomley
On Wed, 2017-03-22 at 19:19 +0100, Christoph Hellwig wrote: > On Tue, Mar 21, 2017 at 02:59:01PM -0400, Tejun Heo wrote: > > I do like the fact that this is a lot simpler than the previous > > implementation but am not quite sure we want to deviate > > significantly from what we do for other

Re: support ranges TRIM for libata

2017-03-23 Thread James Bottomley
On Thu, 2017-03-23 at 14:55 +0100, Christoph Hellwig wrote: > On Thu, Mar 23, 2017 at 09:47:41AM -0400, James Bottomley wrote: > > > The current implementation already has the issue of that it does > > > corrupt user data reliably if the using SG_IO for WRITE SAME > > > commands. > > > > That

[PATCH 01/23] block: renumber REQ_OP_WRITE_ZEROES

2017-03-23 Thread Christoph Hellwig
Make life easy for implementations that needs to send a data buffer to the device (e.g. SCSI) by numbering it as a data out command. Signed-off-by: Christoph Hellwig --- include/linux/blk_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 22/23] drbd: implement REQ_OP_WRITE_ZEROES

2017-03-23 Thread Christoph Hellwig
It seems like DRBD assumes its on the wire TRIM request always zeroes data. Use that fact to implement REQ_OP_WRITE_ZEROES. XXX: will need a careful audit from the drbd team! Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_main.c | 3 ++-

[PATCH] qedf: Fix crash due to unsolicited FIP VLAN response.

2017-03-23 Thread Dupuis, Chad
From: Chad Dupuis We need to initialize qedf->fipvlan_compl in __qedf_probe so that if we receive an unsolicited FIP VLAN response, the system doesn't crash due to trying to complete an uninitialized completion. Also add a check to see if there are any waiters on the

Re: support ranges TRIM for libata

2017-03-23 Thread Christoph Hellwig
On Thu, Mar 23, 2017 at 09:47:41AM -0400, James Bottomley wrote: > > The current implementation already has the issue of that it does > > corrupt user data reliably if the using SG_IO for WRITE SAME > > commands. > > That does need fixing. I don't think it's fixable as long as we translate the

Re: [PATCH 1/1] fnic: Adding Check Condition counter to misc fnicstats

2017-03-23 Thread Martin K. Petersen
"Satish Kharat (satishkh)" writes: Satish, > Apologies for the delay. I was not able to verify this because of > another fnic issue blocking this test. Just now submitted a fix for > that 'fnic issue' (in the patch => [PATCH 1/1] fnic: bug fix for > fip.fip_subcode in

Re: [PATCH] qedf: fix wrong le16 conversion

2017-03-23 Thread Martin K. Petersen
Arnd Bergmann writes: > gcc points out that we are converting a 16-bit integer into a 32-bit > little-endian type and assigning that to 16-bit little-endian > will end up with a zero: > > drivers/scsi/qedf/drv_fcoe_fw_funcs.c: In function > 'init_initiator_rw_fcoe_task': >

[PATCH 17/23] rbd: remove the discard_zeroes_data flag

2017-03-23 Thread Christoph Hellwig
rbd only supports discarding on large alignments, so the zeroing code would always fall back to explicit writings of zeroes. Signed-off-by: Christoph Hellwig --- drivers/block/rbd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index

[PATCH 19/23] mmc: remove the discard_zeroes_data flag

2017-03-23 Thread Christoph Hellwig
mmc only supports discarding on large alignments, so the zeroing code would always fall back to explicit writings of zeroes. Signed-off-by: Christoph Hellwig --- drivers/mmc/core/queue.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/core/queue.c

[PATCH 21/23] drbd: make intelligent use of blkdev_issue_zeroout

2017-03-23 Thread Christoph Hellwig
drbd always wants its discard wire operations to zero the blocks, so use blkdev_issue_zeroout with the BLKDEV_ZERO_UNMAP flag instead of reinventing it poorly. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_debugfs.c | 3 -- drivers/block/drbd/drbd_int.h | 6

[PATCH 23/23] block: remove the discard_zeroes_data flag

2017-03-23 Thread Christoph Hellwig
Now that we use the proper REQ_OP_WRITE_ZEROES operation everywhere we can kill this hack. Signed-off-by: Christoph Hellwig --- Documentation/ABI/testing/sysfs-block | 10 ++ Documentation/block/queue-sysfs.txt | 5 - block/blk-lib.c | 7

[PATCH 20/23] block: stop using discards for zeroing

2017-03-23 Thread Christoph Hellwig
Now that we have REQ_OP_WRITE_ZEROES implemented for all devices that support efficient zeroing of devices we can remove the call to blkdev_issue_discard. This means we only have two ways of zeroing left and can simply the code. Signed-off-by: Christoph Hellwig --- block/blk-lib.c

[PATCH 14/23] zram: implement REQ_OP_WRITE_ZEROES

2017-03-23 Thread Christoph Hellwig
Just the same as discard if the block size equals the system page size. Signed-off-by: Christoph Hellwig --- drivers/block/zram/zram_drv.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c

[PATCH 18/23] rsxx: remove the discard_zeroes_data flag

2017-03-23 Thread Christoph Hellwig
rsxx only supports discarding on large alignments, so the zeroing code would always fall back to explicit writings of zeroes. Signed-off-by: Christoph Hellwig --- drivers/block/rsxx/dev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/rsxx/dev.c

[PATCH 09/23] block: add a REQ_UNMAP flag for REQ_OP_WRITE_ZEROES

2017-03-23 Thread Christoph Hellwig
If this flag is set logical provisioning capable device should release space for the zeroed blocks if possible, if it is not set devices should keep the blocks anchored. Also remove an out of sync kerneldoc comment for a static function that would have become even more out of data with this

Re: support ranges TRIM for libata

2017-03-23 Thread Christoph Hellwig
On Thu, Mar 23, 2017 at 10:35:06AM -0400, James Bottomley wrote: > I'm certainly not saying we blindly follow t10, but I believe their > intent is to issue the next command from the completion of the first > (we can do this using qc->complete_fn, like atapi_request_sense). That > way we don't get

Re: [PATCH 06/23] dm-kcopyd: switch to use REQ_OP_WRITE_ZEROES

2017-03-23 Thread Mike Snitzer
On Thu, Mar 23 2017 at 10:33am -0400, Christoph Hellwig wrote: > It seems like the code currently passes whatever it was using for writes > to WRITE SAME. Just switch it to WRITE ZEROES, although that doesn't > need any payload. > > Untested, and confused by the code, maybe

[PATCH] scsi: advansys: fix uninitialized data access

2017-03-23 Thread Arnd Bergmann
gcc-7.0.1 now warns about a previously unnoticed access of uninitialized struct members: drivers/scsi/advansys.c: In function 'AscMsgOutSDTR': drivers/scsi/advansys.c:3860:26: error: '*((void *)_buf+5)' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Re: support ranges TRIM for libata

2017-03-23 Thread Tejun Heo
Hello, Christoph. On Thu, Mar 23, 2017 at 03:43:30PM +0100, Christoph Hellwig wrote: > > That's up to you ... from the point of view of code documenting itself, > > forming the ATA_16 TRIM in sd and not doing any satl transformation is > > easier for others to follow, but if it's going to cause

Re: [PATCH 06/23] dm-kcopyd: switch to use REQ_OP_WRITE_ZEROES

2017-03-23 Thread Mike Snitzer
On Thu, Mar 23 2017 at 10:56am -0400, Christoph Hellwig wrote: > On Thu, Mar 23, 2017 at 10:55:22AM -0400, Mike Snitzer wrote: > > See commit 70d6c400a ("dm kcopyd: add WRITE SAME support to dm_kcopyd_zero") > > drivers/md/dm-io.c:do_region() adjusts the WRITE SAME payload to be a >

Re: [PATCH 1/6] ipr: Fix missed EH wakeup

2017-03-23 Thread wenxiong
On 2017-03-15 16:58, Brian King wrote: I have reviewed this serial of patches and tested them on IBM systems successfully Thanks for your help! Wendy Following a command abort or device reset, ipr's EH handlers wait for the commands getting aborted to get sent back from the adapter prior to

sg: random memory corruptions

2017-03-23 Thread Dmitry Vyukov
Hello, The following program causes random assorted memory corruptions: https://gist.githubusercontent.com/dvyukov/da3463af2d1ff8c7d3624891b5d7427f/raw/09cf0f4af529f4506f9e0a9fa6bdb066a8777b9d/gistfile1.txt It does some ioctl's on /dev/sg0. general protection fault: [#1] SMP KASAN Modules

[PATCH] qla2xxx: remove redundant check on sess being non-null

2017-03-23 Thread Colin King
From: Colin Ian King All error paths to label out_term2 result in sess being null, so the check for sess being non-null and the call to put_sess is dead code and can therefore be removed. Detected with CoverityScan, CID#1420664 ("Logically dead code") Signed-off-by:

[PATCH 16/23] brd: remove discard support

2017-03-23 Thread Christoph Hellwig
It's just a in-driver reimplementation of writing zeroes to the pages, which fails if the discards aren't page aligned. Signed-off-by: Christoph Hellwig --- drivers/block/brd.c | 56 - 1 file changed, 56 deletions(-) diff --git

Re: [PATCH 06/23] dm-kcopyd: switch to use REQ_OP_WRITE_ZEROES

2017-03-23 Thread Christoph Hellwig
On Thu, Mar 23, 2017 at 10:55:22AM -0400, Mike Snitzer wrote: > See commit 70d6c400a ("dm kcopyd: add WRITE SAME support to dm_kcopyd_zero") > drivers/md/dm-io.c:do_region() adjusts the WRITE SAME payload to be a > single page. > > So you'd want to tweak dm-io.c accordingly for WRITE ZEROES

Re: support ranges TRIM for libata

2017-03-23 Thread Christoph Hellwig
On Thu, Mar 23, 2017 at 11:04:58AM -0400, Tejun Heo wrote: > I kinda like the idea of sticking with satl as that's how libata has > been doing most things even if the implementation is uglier. It'd be > great to find out whether the ugliness would be acceptable or too > much. The SATL way is

Re: support ranges TRIM for libata

2017-03-23 Thread Martin K. Petersen
Christoph Hellwig writes: > Meh, I remember why I gave up on it - to support queued trim passthrough > we'd need to implement ATA 32 for the auxiliary fields and thus support > 32-bit CDBs. I don't really want to go there.. I wish we could stick with SATL. However, I have

[PATCH] scsi: lpfc: fix building without debugfs support

2017-03-23 Thread Arnd Bergmann
On a randconfig build without CONFIG_SCSI_LPFC_DEBUG_FS, I ran into multiple compile failures: drivers/scsi/lpfc/lpfc_debugfs.h: In function 'lpfc_debug_dump_wq': drivers/scsi/lpfc/lpfc_debugfs.h:405:15: error: 'DUMP_FCP' undeclared (first use in this function); did you mean 'DUMP_VAR'?

Re: [PATCH 00/23] hisi_sas: error handling and other misc fixes and improvements

2017-03-23 Thread Martin K. Petersen
John Garry writes: John, > This patchset introduces a range of error handling > and other misc improvements for the HiSilicon SAS > controller, including: > - controller reset function > - softreset for SATA error handling > - fixes for slot free'ing > - v2 hw error

Re: support ranges TRIM for libata

2017-03-23 Thread Christoph Hellwig
On Thu, Mar 23, 2017 at 03:43:30PM +0100, Christoph Hellwig wrote: > I tried this earlier before giving up on it because it looked to ugly. > But I can complete that version of it and post it for people to compare. Meh, I remember why I gave up on it - to support queued trim passthrough we'd need

Re: RFC: always use REQ_OP_WRITE_ZEROES for zeroing offload

2017-03-23 Thread Lars Ellenberg
On Thu, Mar 23, 2017 at 10:33:18AM -0400, Christoph Hellwig wrote: > This series makes REQ_OP_WRITE_ZEROES the only zeroing offload > supported by the block layer, and switches existing implementations > of REQ_OP_DISCARD that correctly set discard_zeroes_data to it, > removes incorrect

Re: [PATCH v2 02/10] be2iscsi: Fix closing of connection

2017-03-23 Thread Tomas Henzl
On 16.3.2017 04:24, Jitendra Bhivare wrote: > CID needs to be freed even when invalidate or upload connection fails. > Attempt to close connection 3 times before freeing CID. > > Set cleanup_type to INVALIDATE instead of force TCP_RST. > This unnecessarily is terminating connection with reset

Re: [PATCH 1/6] ipr: Fix missed EH wakeup

2017-03-23 Thread Martin K. Petersen
Brian King writes: > Following a command abort or device reset, ipr's EH handlers wait > for the commands getting aborted to get sent back from the adapter > prior to returning from the EH handler. This fixes up some cases > where the completion handler was not getting

Re: [PATCHv4 0/4] tcmu: bug fix and dynamic growing data area support

2017-03-23 Thread Ilias Tsitsimpis
Hi Xiubo, On Tue, Mar 21, 2017 at 04:36PM, lixi...@cmss.chinamobile.com wrote: > [...] > tcmu: Fix possible overwrite of t_data_sg's last iov[] > tcmu: Fix wrongly calculating of the base_command_size I tested these two patches, which try to fix the broken support for BIDI commands in

iscsi (?): Unknown VPD Code: 0xc7

2017-03-23 Thread Harald Dunkel
Hi folks, I am trying to use LIO on amd64 to provide block devices to some AIX 6.1 and 7.1 hosts. It works pretty well, except that I cannot create rootvg wpars on AIX 7.1. (rootvg wpars are containers running on their own volume group.) The error message on AIX is bash-4.3# mkwpar -O -D

Re: [PATCH] scsi: osd_uld: remove an unneeded NULL check

2017-03-23 Thread Boaz Harrosh
On 03/23/2017 12:41 PM, Dan Carpenter wrote: > We don't call the remove() function unless probe() succeeds so "oud" > can't be NULL here. Plus, if it were NULL, we dereference it on the > next line so it would crash anyway. > > Signed-off-by: Dan Carpenter > Thanks

Re: [PATCH] qedf: fix wrong le16 conversion

2017-03-23 Thread David Miller
From: "Martin K. Petersen" Date: Thu, 23 Mar 2017 10:19:03 -0400 > Arnd Bergmann writes: > >> gcc points out that we are converting a 16-bit integer into a 32-bit >> little-endian type and assigning that to 16-bit little-endian >> will end up with a