[PATCH v7 00/15] Replace PCI pool by DMA pool API

2017-04-07 Thread Romain Perier
The current PCI pool API are simple macro functions direct expanded to the appropriate dma pool functions. The prototypes are almost the same and semantically, they are very similar. I propose to use the DMA pool API directly and get rid of the old API. This set of patches, replaces the old API

[PATCH v7 07/15] wireless: ipw2200: Replace PCI pool old API

2017-04-07 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/net/wireless/intel/ipw2x00/ipw2200.c |

[PATCH v7 09/15] scsi: csiostor: Replace PCI pool old API

2017-04-07 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. It also updates the name of some variables and the content of comments, accordingly. Signed-off-by: Romain Perier Reviewed-by: Peter Senna

[PATCH v7 06/15] mlx5: Replace PCI pool old API

2017-04-07 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin Acked-by: Doug Ledford

Re: [PATCH 2/4] mm: introduce memalloc_noreclaim_{save,restore}

2017-04-07 Thread Hillf Danton
On April 05, 2017 3:47 PM Vlastimil Babka wrote: > > The previous patch has shown that simply setting and clearing PF_MEMALLOC in > current->flags can result in wrongly clearing a pre-existing PF_MEMALLOC flag > and potentially lead to recursive reclaim. Let's introduce helpers that > support

[PATCHv4 6/6] sg: close race condition in sg_remove_sfp_usercontext()

2017-04-07 Thread Hannes Reinecke
sg_remove_sfp_usercontext() is clearing any sg requests, but needs to take 'rq_list_lock' when modifying the list. Reported-by: Christoph Hellwig Signed-off-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn Tested-by: Johannes Thumshirn

[PATCHv4 3/6] sg: protect accesses to 'reserved' page array

2017-04-07 Thread Hannes Reinecke
The 'reserved' page array is used as a short-cut for mapping data, saving us to allocate pages per request. However, the 'reserved' array is only capable of holding one request, so this patch introduces a mutex for protect 'sg_fd' against concurrent accesses. Signed-off-by: Hannes Reinecke

[PATCHv4 4/6] sg: check for valid direction before starting the request

2017-04-07 Thread Hannes Reinecke
From: Johannes Thumshirn Check for a valid direction before starting the request, otherwise we risk running into an assertion in the scsi midlayer checking for vaild requests. Signed-off-by: Johannes Thumshirn Link:

[PATCHv4 5/6] sg: use standard lists for sg_requests

2017-04-07 Thread Hannes Reinecke
'Sg_request' is using a private list implementation; convert it to standard lists. Signed-off-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn Tested-by: Johannes Thumshirn --- drivers/scsi/sg.c | 147

[PATCHv4 2/6] sg: remove 'save_scat_len'

2017-04-07 Thread Hannes Reinecke
Unused. Signed-off-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn Tested-by: Johannes Thumshirn Reviewed-by: Christoph Hellwig --- drivers/scsi/sg.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/sg.c

Re: [PATCH 1/4] mm: prevent potential recursive reclaim due to clearing PF_MEMALLOC

2017-04-07 Thread Hillf Danton
On April 05, 2017 3:47 PM Vlastimil Babka wrote: > > The function __alloc_pages_direct_compact() sets PF_MEMALLOC to prevent > deadlock during page migration by lock_page() (see the comment in > __unmap_and_move()). Then it unconditionally clears the flag, which can clear > a > pre-existing

[PATCH v7 11/15] scsi: megaraid: Replace PCI pool old API

2017-04-07 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin Acked-by: Sumit Saxena

[PATCH v7 14/15] scsi: pmcraid: Replace PCI pool old API

2017-04-07 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH v7 12/15] scsi: mpt3sas: Replace PCI pool old API

2017-04-07 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/scsi/mpt3sas/mpt3sas_base.c | 73

[PATCH v7 03/15] IB/mthca: Replace PCI pool old API

2017-04-07 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH v7 01/15] block: DAC960: Replace PCI pool old API

2017-04-07 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH v7 02/15] dmaengine: pch_dma: Replace PCI pool old API

2017-04-07 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH v7 04/15] net: e100: Replace PCI pool old API

2017-04-07 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Acked-by: Jeff Kirsher

[PATCH v7 05/15] mlx4: Replace PCI pool old API

2017-04-07 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

Re: [PATCH 1/4] mm: prevent potential recursive reclaim due to clearing PF_MEMALLOC

2017-04-07 Thread Vlastimil Babka
On 04/05/2017 01:40 PM, Andrey Ryabinin wrote: > On 04/05/2017 10:46 AM, Vlastimil Babka wrote: >> The function __alloc_pages_direct_compact() sets PF_MEMALLOC to prevent >> deadlock during page migration by lock_page() (see the comment in >> __unmap_and_move()). Then it unconditionally clears the

[PATCHv4 0/6] sanitize sg

2017-04-07 Thread Hannes Reinecke
Hi all, the infamous syzkaller incovered some more issues in the sg driver. This patchset fixes those two issues (and adds a fix for yet another potential issue; checking for a NULL dxferp when dxfer_len is not 0). It also removes handling of the SET_FORCE_LOW_DMA ioctl, which never worked since

[PATCHv4 1/6] sg: disable SET_FORCE_LOW_DMA

2017-04-07 Thread Hannes Reinecke
The ioctl SET_FORCE_LOW_DMA has never worked since the initial git check-in, and the respective setting is nowadays handled correctly. So disable it entirely. Signed-off-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn Tested-by: Johannes Thumshirn

Re: [RFC 6/8] nvmet: Be careful about using iomem accesses when dealing with p2pmem

2017-04-07 Thread Stephen Bates
On 2017-04-06, 6:33 AM, "Sagi Grimberg" wrote: > Say it's connected via 2 legs, the bar is accessed from leg A and the > data from the disk comes via leg B. In this case, the data is heading > towards the p2p device via leg B (might be congested), the completion > goes directly

[PATCH v7 10/15] scsi: lpfc: Replace PCI pool old API

2017-04-07 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. It also updates some comments, accordingly. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin ---

[PATCH v7 15/15] PCI: Remove PCI pool macro functions

2017-04-07 Thread Romain Perier
Now that all the drivers use dma pool API, we can remove the macro functions for PCI pool. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- include/linux/pci.h | 9 - 1 file changed, 9 deletions(-) diff --git

[PATCH v7 13/15] scsi: mvsas: Replace PCI pool old API

2017-04-07 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/scsi/mvsas/mv_init.c | 6 +++---

[PATCH v7 08/15] scsi: be2iscsi: Replace PCI pool old API

2017-04-07 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH] scsi: smartpqi: remove writeq/readq function definitions

2017-04-07 Thread Corentin Labbe
Instead of rewriting write/readq, use linux/io-64-nonatomic-lo-hi.h which already have them. Signed-off-by: Corentin Labbe --- drivers/scsi/smartpqi/smartpqi.h | 31 ++- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git

[PATCH] scsi: libfc: directly call ELS request handlers

2017-04-07 Thread Johannes Thumshirn
Directly call ELS request handler functions in fc_lport_recv_els_req instead of saving the pointer to the handler's receive function and then later dereferencing this pointer. This makes the code a bit more obvious. Signed-off-by: Johannes Thumshirn ---

[PATCH 03/12] hpsa: update reset handler

2017-04-07 Thread Don Brace
Use the return from TUR as a check for the device state. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |

[PATCH 05/12] hpsa: rescan later if reset in progress

2017-04-07 Thread Don Brace
- schedule another scan. - mark current scan as completed Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 04/12] hpsa: do not reset enclosures

2017-04-07 Thread Don Brace
Prevent enclosure resets. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |3 +++ 1 file changed, 3

[PATCH 00/12] hpsa updates

2017-04-07 Thread Don Brace
These patches are based on Linus's tree These patches are for: - Multipath failover support in general. The changes are: - update identify physical device structure - align with FW - stop getting enclosure info for externals - no BMIC support - update reset handler - update to match

[Bug 195285] New: qla2xxx FW immediatly crashing after target start

2017-04-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=195285 Bug ID: 195285 Summary: qla2xxx FW immediatly crashing after target start Product: SCSI Drivers Version: 2.5 Kernel Version: 4.9.10-200.fc25.x86_64 Hardware: x86-64 OS:

Re: [PATCH 1/2] block: Implement global tagset

2017-04-07 Thread Arun Easi
On Thu, 6 Apr 2017, 1:49am, Hannes Reinecke wrote: > On 04/06/2017 08:27 AM, Arun Easi wrote: > > Hi Hannes, > > > > Thanks for taking a crack at the issue. My comments below.. > > > > On Tue, 4 Apr 2017, 5:07am, Hannes Reinecke wrote: > > > >> Most legacy HBAs have a tagset per HBA, not per

Re: kill req->errors

2017-04-07 Thread Christoph Hellwig
On Thu, Apr 06, 2017 at 04:00:24PM -0400, Konrad Rzeszutek Wilk wrote: > You wouldn't have a git tree to easily test it? Thanks. git://git.infradead.org/users/hch/block.git request-errors Gitweb: http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/request-errors

Re: [PATCH] scsi: libfc: directly call ELS request handlers

2017-04-07 Thread Chad Dupuis
On Fri, 7 Apr 2017, 1:42pm -, Johannes Thumshirn wrote: > Directly call ELS request handler functions in fc_lport_recv_els_req > instead of saving the pointer to the handler's receive function and then > later dereferencing this pointer. > > This makes the code a bit more obvious. > >

[PATCH] scsi: mpt3sas: remove redundant wmb on arm/arm64

2017-04-07 Thread Sinan Kaya
Due to relaxed ordering requirements on multiple architectures, drivers are required to use wmb/rmb/mb combinations when they need to guarantee observability between the memory and the HW. The mpt3sas driver is already using wmb() for this purpose. However, it issues a writel following wmb().

Re: linux-next: manual merge of the scsi-mkp tree with the char-misc tree

2017-04-07 Thread Bart Van Assche
On 04/06/2017 10:33 PM, Stephen Rothwell wrote: > Hi Martin, > > Today's linux-next merge of the scsi-mkp tree got a conflict in: > > drivers/scsi/osd/osd_uld.c > > between commit: > > ac1ddc584e98 ("scsi: utilize new cdev_device_add helper function") > > from the char-misc tree and

[PATCH] ibmvscsis: Do not send aborted task response

2017-04-07 Thread Bryant G. Ly
The driver is sending a response to the aborted task response along with LIO sending the tmr response. SCSI spec says that the initiator that sends the abort task TM NEVER gets a response to the aborted op and with the current code it will send a response. Thus this fix will remove that response

Re: [PATCH] ibmvscsis: Do not send aborted task response

2017-04-07 Thread Bart Van Assche
On Fri, 2017-04-07 at 11:12 -0500, Bryant G. Ly wrote: > So from this stack trace it looks like the ibmvscsis driver is sending an > extra response through send_messages even though an abort was issued. > IBMi, reported this issue internally when they were testing the driver, > because their

Re: [PATCH] scsi: mpt3sas: remove redundant wmb on arm/arm64

2017-04-07 Thread Sinan Kaya
On 4/7/2017 12:41 PM, Sinan Kaya wrote: > The right thing was to either call __raw_writel/__raw_readl or > write_relaxed/read_relaxed for multi-arch compatibility. One can also argue to get rid of wmb(). I can go either way based on the recommendation. -- Sinan Kaya Qualcomm Datacenter

Re: [PATCH v4 0/6] Avoid that scsi-mq and dm-mq queue processing stalls sporadically

2017-04-07 Thread Bart Van Assche
On Fri, 2017-04-07 at 12:23 -0600, Jens Axboe wrote: > On 04/07/2017 12:16 PM, Bart Van Assche wrote: > > Hello Jens, > > > > The six patches in this patch series fix the queue lockup I reported > > recently on the linux-block mailing list. Please consider these patches > > for inclusion in the

Re: [PATCH v4 0/6] Avoid that scsi-mq and dm-mq queue processing stalls sporadically

2017-04-07 Thread Bart Van Assche
On Fri, 2017-04-07 at 11:33 -0700, Bart Van Assche wrote: > On Fri, 2017-04-07 at 12:23 -0600, Jens Axboe wrote: > > On 04/07/2017 12:16 PM, Bart Van Assche wrote: > > > Hello Jens, > > > > > > The six patches in this patch series fix the queue lockup I reported > > > recently on the linux-block

Re: [PATCH v4 0/6] Avoid that scsi-mq and dm-mq queue processing stalls sporadically

2017-04-07 Thread Jens Axboe
On 04/07/2017 12:39 PM, Bart Van Assche wrote: > On Fri, 2017-04-07 at 11:33 -0700, Bart Van Assche wrote: >> On Fri, 2017-04-07 at 12:23 -0600, Jens Axboe wrote: >>> On 04/07/2017 12:16 PM, Bart Van Assche wrote: Hello Jens, The six patches in this patch series fix the queue lockup

Re: [PATCH] scsi: mpt3sas: remove redundant wmb on arm/arm64

2017-04-07 Thread Sinan Kaya
On 4/7/2017 1:25 PM, James Bottomley wrote: >> The right thing was to either call __raw_writel/__raw_readl or >> write_relaxed/read_relaxed for multi-arch compatibility. > writeX_relaxed and thus your patch is definitely wrong. The reason is > that we have two ordering domains: the CPU and the

[PATCH v4 2/6] blk-mq: Restart a single queue if tag sets are shared

2017-04-07 Thread Bart Van Assche
To improve scalability, if hardware queues are shared, restart a single hardware queue in round-robin fashion. Rename blk_mq_sched_restart_queues() to reflect the new semantics. Remove blk_mq_sched_mark_restart_queue() because this function has no callers. Remove flag QUEUE_FLAG_RESTART because

[PATCH v4 1/6] blk-mq: Make it safe to use RCU to iterate over blk_mq_tag_set.tag_list

2017-04-07 Thread Bart Van Assche
Since the next patch in this series will use RCU to iterate over tag_list, make this safe. Add lockdep_assert_held() statements in functions that iterate over tag_list to make clear that using list_for_each_entry() instead of list_for_each_entry_rcu() is fine in these functions. Signed-off-by:

[PATCH v4 5/6] scsi: Avoid that SCSI queues get stuck

2017-04-07 Thread Bart Van Assche
If a .queue_rq() function returns BLK_MQ_RQ_QUEUE_BUSY then the block driver that implements that function is responsible for rerunning the hardware queue once requests can be queued again successfully. commit 52d7f1b5c2f3 ("blk-mq: Avoid that requeueing starts stopped queues") removed the

[PATCH v4 4/6] blk-mq: Introduce blk_mq_delay_run_hw_queue()

2017-04-07 Thread Bart Van Assche
Introduce a function that runs a hardware queue unconditionally after a delay. Note: there is already a function that stops and restarts a hardware queue after a delay, namely blk_mq_delay_queue(). This function will be used in the next patch in this series. Signed-off-by: Bart Van Assche

[PATCH v4 6/6] dm rq: Avoid that request processing stalls sporadically

2017-04-07 Thread Bart Van Assche
While running the srp-test software I noticed that request processing stalls sporadically at the beginning of a test, namely when mkfs is run against a dm-mpath device. Every time when that happened the following command was sufficient to resume request processing: echo run

[PATCH v4 3/6] blk-mq: Clarify comments in blk_mq_dispatch_rq_list()

2017-04-07 Thread Bart Van Assche
The blk_mq_dispatch_rq_list() implementation got modified several times but the comments in that function were not updated every time. Since it is nontrivial what is going on, update the comments in blk_mq_dispatch_rq_list(). Signed-off-by: Bart Van Assche Cc: Omar

[PATCH v4 0/6] Avoid that scsi-mq and dm-mq queue processing stalls sporadically

2017-04-07 Thread Bart Van Assche
Hello Jens, The six patches in this patch series fix the queue lockup I reported recently on the linux-block mailing list. Please consider these patches for inclusion in the upstream kernel. Thanks, Bart. Changes between v3 and v4: - Addressed the review comments on version three of this

[PATCH V2] scsi: mpt3sas: remove redundant wmb

2017-04-07 Thread Sinan Kaya
Due to relaxed ordering requirements on multiple architectures, drivers are required to use wmb/rmb/mb combinations when they need to guarantee observability between the memory and the HW. The mpt3sas driver is already using wmb() for this purpose. However, it issues a writel following wmb().

Re: [PATCH] scsi: mpt3sas: remove redundant wmb on arm/arm64

2017-04-07 Thread James Bottomley
On Fri, 2017-04-07 at 12:41 -0400, Sinan Kaya wrote: > Due to relaxed ordering requirements on multiple architectures, > drivers are required to use wmb/rmb/mb combinations when they > need to guarantee observability between the memory and the HW. > > The mpt3sas driver is already using wmb() for

Re: [PATCH 2/2] scsi: sd: Remove LBPRZ dependency for discards

2017-04-07 Thread Bart Van Assche
On Wed, 2017-04-05 at 07:41 -0400, Martin K. Petersen wrote: > Separating discards and zeroout operations allows us to remove the LBPRZ > block zeroing constraints from discards and honor the device preferences > for UNMAP commands. > > If supported by the device, we'll also choose UNMAP over one

Re: [RFC 5/8] scatterlist: Modify SG copy functions to support io memory.

2017-04-07 Thread Logan Gunthorpe
Hi Dan, On 03/04/17 06:07 PM, Dan Williams wrote: > The completely agnostic part is where I get worried, but I shouldn't > say anymore until I actually read the patch.The worry is cases where > this agnostic enabling allows unsuspecting code paths to do the wrong > thing. Like bypass iomem

Re: [PATCH v4 0/6] Avoid that scsi-mq and dm-mq queue processing stalls sporadically

2017-04-07 Thread Jens Axboe
On 04/07/2017 12:16 PM, Bart Van Assche wrote: > Hello Jens, > > The six patches in this patch series fix the queue lockup I reported > recently on the linux-block mailing list. Please consider these patches > for inclusion in the upstream kernel. Some of this we need in 4.11, but not all of it.

Re: [PATCH 1/2] scsi: sd: Separate zeroout and discard command choices

2017-04-07 Thread Bart Van Assche
On Wed, 2017-04-05 at 07:41 -0400, Martin K. Petersen wrote: > +static const char *zeroing_mode[] = { > + [SD_ZERO_WRITE] = "write", > + [SD_ZERO_WS]= "writesame", > + [SD_ZERO_WS16_UNMAP]= "writesame_16_unmap", > + [SD_ZERO_WS10_UNMAP]=

Re: [PATCH] ibmvscsis: Do not send aborted task response

2017-04-07 Thread Bryant G. Ly
On 4/7/17 10:49 AM, Bryant G. Ly wrote: The driver is sending a response to the aborted task response along with LIO sending the tmr response. SCSI spec says that the initiator that sends the abort task TM NEVER gets a response to the aborted op and with the current code it will send a

Re: [PATCH] ibmvscsis: Do not send aborted task response

2017-04-07 Thread Bryant G. Ly
On 4/7/17 11:36 AM, Bart Van Assche wrote: On Fri, 2017-04-07 at 11:12 -0500, Bryant G. Ly wrote: So from this stack trace it looks like the ibmvscsis driver is sending an extra response through send_messages even though an abort was issued. IBMi, reported this issue internally when they were

Re: [PATCH] ibmvscsis: Do not send aborted task response

2017-04-07 Thread Bart Van Assche
On 04/07/2017 08:49 AM, Bryant G. Ly wrote: > The driver is sending a response to the aborted task response That occurrence of "response" looks extraneous? > along with LIO sending the tmr response. SCSI spec says > that the

Re: linux-next: manual merge of the scsi-mkp tree with the char-misc tree

2017-04-07 Thread Bart Van Assche
On Fri, 2017-04-07 at 13:29 -0600, Logan Gunthorpe wrote: > On 07/04/17 09:49 AM, Bart Van Assche wrote: > > Sorry that I had not yet noticed Logan's patch series. Should my two > > patches that conflict with Logan's patch series be dropped and reworked > > after Logan's patches are upstream? > >

Re: [PATCH 1/2] scsi: sd: Separate zeroout and discard command choices

2017-04-07 Thread Bart Van Assche
On Wed, 2017-04-05 at 07:41 -0400, Martin K. Petersen wrote: > +static ssize_t > +zeroing_mode_store(struct device *dev, struct device_attribute *attr, > +const char *buf, size_t count) > +{ > + struct scsi_disk *sdkp = to_scsi_disk(dev); > + > + if

[PATCH 12/12] hpsa: bump driver version

2017-04-07 Thread Don Brace
Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 11/12] hpsa: remove abort handler

2017-04-07 Thread Don Brace
- simplify the driver - there are a lot of quirky racy conditions not handled - causes more aborts/resets when the number of commands to be aborted is large, such as in multi-path fail-overs. - has been turned off in our internal driver since 8/31/2015 Reviewed-by: Scott Benesh

[PATCH 08/12] hpsa: correct queue depth for externals

2017-04-07 Thread Don Brace
- queue depth assignment not in correct place, had no effect. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 09/12] hpsa: separate monitor events from heartbeat worker

2017-04-07 Thread Don Brace
From: Scott Teel create new worker thread to monitor controller events - detect controller events more frequently. - leave heartbeat check at 30 seconds. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel

[PATCH 02/12] hpsa: do not get enclosure info for external devices

2017-04-07 Thread Don Brace
external shelves do not support BMICs. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |5 + 1

[PATCH 01/12] hpsa: update identify physical device structure

2017-04-07 Thread Don Brace
- align with latest spec. - added __attribute((aligned(512))) Reviewed-by: Scott Teel Reviewed-by: Scott Benesh Reviewed-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 06/12] hpsa: correct resets on retried commands

2017-04-07 Thread Don Brace
- call scsi_done when the command completes. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1

[PATCH 10/12] hpsa: send ioaccel requests with 0 length down raid path

2017-04-07 Thread Don Brace
- Block I/O requests with 0 length transfers which go down the ioaccel path. This causes lockup issues down in the basecode. - These issues have been fixed, but there are customers who are experiencing the issues when running older firmware. Reviewed-by: Scott Benesh

[PATCH 07/12] hpsa: cleanup reset handler

2017-04-07 Thread Don Brace
- mark device state sooner. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 44

[PATCH 00/12] hpsa updates

2017-04-07 Thread Don Brace
These patches are based on Linus's tree These patches are for: - Multipath failover support in general. The changes are: - update identify physical device structure - align with FW - stop getting enclosure info for externals - no BMIC support - update reset handler - update to

Re: [PATCH] ibmvscsis: Do not send aborted task response

2017-04-07 Thread Bart Van Assche
On Fri, 2017-04-07 at 16:14 -0500, Michael Cyr wrote: > That then caused this issue, because release_cmd is always called, even > if queue_status is not. Perhaps it would be cleaner to set some sort of > status valid flag during queue_status instead of setting a flag in > aborted_task? Hello

Re: linux-next: manual merge of the scsi-mkp tree with the char-misc tree

2017-04-07 Thread Logan Gunthorpe
Hi Bart, On 07/04/17 09:49 AM, Bart Van Assche wrote: > Sorry that I had not yet noticed Logan's patch series. Should my two > patches that conflict with Logan's patch series be dropped and reworked > after Logan's patches are upstream? Yeah, Greg took my patchset around a few maintainers

Re: [PATCH] ibmvscsis: Do not send aborted task response

2017-04-07 Thread Michael Cyr
On 4/7/17 12:01 PM, Bryant G. Ly wrote: On 4/7/17 11:36 AM, Bart Van Assche wrote: On Fri, 2017-04-07 at 11:12 -0500, Bryant G. Ly wrote: So from this stack trace it looks like the ibmvscsis driver is sending an extra response through send_messages even though an abort was issued. IBMi,