[PATCH v6 2/2] tcmu: Add global data block pool support

From: Xiubo Li For each target there will be one ring, when the target number grows larger and larger, it could eventually runs out of the system memories. In this patch for each target ring, currently for the cmd area the size will be fixed to 8MB and for the data

[PATCH v6 1/2] tcmu: Add dynamic growing data area feature support

From: Xiubo Li Currently for the TCMU, the ring buffer size is fixed to 64K cmd area + 1M data area, and this will be bottlenecks for high iops. The struct tcmu_cmd_entry {} size is fixed about 112 bytes with iovec[N] & N <= 4, and the size of struct iovec is about

[PATCH v6 0/2] tcmu: Dynamic growing data area support

From: Xiubo Li Changed for V6: - Remove the tcmu_vma_close(). Since the unmap thread will do the same for it - The unmap thread will skip the busy devices. - Using and testing the V5 version 3 weeks and the V6 for about 1 week, all in a higher IOPS environment:

Re: [PATCH] nvme-scsi: Use correct byte ordering for eui64 in Dev ID VPD

On Tue, Apr 25, 2017 at 02:18:09PM -0600, Jon Derrick wrote: > NVME specifies an EUI64/NGUID in little-endian format, while SCSI > specifies that the Device Identification VPD use big-endian for EUI > formats. The current code copies this bytestream directly from the > Identification Namespace

Re: [PATCH 36/37] smartpqi: remove writeq/readq function definitions

Hi Corentin, [auto build test ERROR on scsi/for-next] [also build test ERROR on v4.11-rc8 next-20170424] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Don-Brace/smartpqi-updates/20170426

[PATCH 1/3] scsi_transport_sas: always pass 0 error to blk_end_request_all

The SAS transport queues are only used by bsg, and bsg always looks at the scsi_request results and never add the error passed in the end_io callback. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_transport_sas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

three little req->errors follow ups

While moving forward with the block error work I noticed three more places that pass non-errno values to the end_request variants, and never actually check those return values. This little series fixes those up to always pass 0.

[PATCH 2/3] ide-pm: always pass 0 error to __blk_end_request_all

ide_pm_execute_rq exectures a PM request synchronously, and in the failure case where it calls __blk_end_request_all it never checks the error field passed to the end_io callback, so don't bother setting it. Signed-off-by: Christoph Hellwig --- drivers/ide/ide-pm.c | 2 +- 1 file

[PATCH 3/3] ide-pm: always pass 0 error to ide_complete_rq in ide_do_devset

The caller only looks at the scsi_request result field anyway. Signed-off-by: Christoph Hellwig --- drivers/ide/ide-devsets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/ide-devsets.c b/drivers/ide/ide-devsets.c index b1223234037d..9b69c32ee560

Re: [PATCH v2 02/21] libiscsi: Add an internal error code

On Tue, Apr 25, 2017 at 12:20:49PM -0600, Logan Gunthorpe wrote: > This is a prep patch to add a new error code to libiscsi. We want to > rework some kmap calls to be able to fail. When we do, we'd like to > use this error code. The kmap case in iscsi_tcp_segment_map can already fail. Please add

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

Am 25.04.2017 um 20:20 schrieb Logan Gunthorpe: This patch introduces functions which kmap the pages inside an sgl. These functions replace a common pattern of kmap(sg_page(sg)) that is used in more than 50 places within the kernel. The motivation for this work is to eventually safely support

Re: [PATCH v6 2/2] tcmu: Add global data block pool support

-cmss-chinamobile-com/tcmu-Dynamic-growing-data-area-support/20170426-162910 config: xtensa-allmodconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x

Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

On Tue, Apr 25, 2017 at 12:21:02PM -0600, Logan Gunthorpe wrote: > Straightforward conversion to the new helper, except due to the lack > of error path, we have to use SG_MAP_MUST_NOT_FAIL which may BUG_ON in > certain cases in the future. > > Signed-off-by: Logan Gunthorpe

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

On Tue, Apr 25, 2017 at 12:20:48PM -0600, Logan Gunthorpe wrote: > This patch introduces functions which kmap the pages inside an sgl. > These functions replace a common pattern of kmap(sg_page(sg)) that is > used in more than 50 places within the kernel. > > The motivation for this work is to

Re: [PATCH 3/3] ide-pm: always pass 0 error to ide_complete_rq in ide_do_devset

On Wednesday, April 26, 2017 09:34:22 AM Christoph Hellwig wrote: > The caller only looks at the scsi_request result field anyway. > > Signed-off-by: Christoph Hellwig Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz

Problem with HDDs getting dropped from RAID

Hi, I have a problem with drives in my RAID. Some of drives are getting disconnected whenever I am trying to write significant amount of data to the array. My problematic RAID6 consisting of 7 drives: * 2 x WDC WD15EADS-22P8B0 * 5 x SAMSUNG HD154UI The drives are connected through HP SAS

Re: [PATCH 2/3] ide-pm: always pass 0 error to __blk_end_request_all

On Wednesday, April 26, 2017 09:34:21 AM Christoph Hellwig wrote: > ide_pm_execute_rq exectures a PM request synchronously, and in the failure > case where it calls __blk_end_request_all it never checks the error field > passed to the end_io callback, so don't bother setting it. > >

Re: three little req->errors follow ups

On 04/26/2017 12:34 AM, Christoph Hellwig wrote: > While moving forward with the block error work I noticed three more > places that pass non-errno values to the end_request variants, and > never actually check those return values. This little series fixes > those up to always pass 0. Applied,

Re: [PATCH 2/3] ide-pm: always pass 0 error to __blk_end_request_all

From: Christoph Hellwig Date: Wed, 26 Apr 2017 09:34:21 +0200 > ide_pm_execute_rq exectures a PM request synchronously, and in the failure > case where it calls __blk_end_request_all it never checks the error field > passed to the end_io callback, so don't bother setting it. > >

Re: [PATCH 3/3] ide-pm: always pass 0 error to ide_complete_rq in ide_do_devset

From: Christoph Hellwig Date: Wed, 26 Apr 2017 09:34:22 +0200 > The caller only looks at the scsi_request result field anyway. > > Signed-off-by: Christoph Hellwig Acked-by: David S. Miller

Re: [PATCH 2/2] scsi: ufs: make ufshcd_get_lists_status() register operation obvious

Hi, Thanks for your review. > yes, this makes it more readable, but i am not sure why we will have to type > cast UFSHCD_STATUS_READY macro to u32 type? i think it is redundant, let me > know if you think otherwise. Sorry, nothing really. I'll resend without u32 cast in short (i.e. change to

Re: [PATCH 1/3] scsi: ufs: Use devm_kcalloc() in ufshcd_memory_alloc()

On 2017-04-25 13:26, SF Markus Elfring wrote: From: Markus Elfring Date: Tue, 25 Apr 2017 21:45:25 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the

Re: [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc()

On 2017-04-25 13:28, SF Markus Elfring wrote: From: Markus Elfring Date: Tue, 25 Apr 2017 21:50:43 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus remove such a statement

Re: [PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in ufshcd_exception_event_handler()

On 2017-04-25 13:30, SF Markus Elfring wrote: From: Markus Elfring Date: Tue, 25 Apr 2017 22:00:05 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a

Re: scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc()

> Although i don't know "out of memory" messages will be printed out by > dmam_alloc_coherent() APIs > or not. Would such information belong to the programming interface documentation? Are there any related tags or source code annotations needed? Regards, Markus

Re: [PATCH 1/2] scsi: ufs: use MASK_EE_STATUS

On 2017-04-20 05:01, kusumi.tomoh...@gmail.com wrote: From: Tomohiro Kusumi MASK_EE_STATUS added by 66ec6d59 was unused, but it seems to have been defined to do this. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 4 ++-- 1 file

Re: [PATCH 2/2] scsi: ufs: make ufshcd_get_lists_status() register operation obvious

On 2017-04-20 05:01, kusumi.tomoh...@gmail.com wrote: From: Tomohiro Kusumi It could be just cmp 0xe instead of >>1 and cmp 0x7, with readable code. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 11 +--

[PATCH v2] scsi: ufs: make ufshcd_get_lists_status() register operation obvious

From: Tomohiro Kusumi It could be just cmp 0xe instead of >>1 and cmp 0x7, with readable code. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 11 +-- drivers/scsi/ufs/ufshci.h | 4 2 files changed, 5 insertions(+), 10

Re: [PATCH v2] scsi: ufs: make ufshcd_get_lists_status() register operation obvious

On 2017-04-26 10:28, kusumi.tomoh...@gmail.com wrote: From: Tomohiro Kusumi It could be just cmp 0xe instead of >>1 and cmp 0x7, with readable code. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 11 +--

Re: [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc()

On Wed, 2017-04-26 at 10:57 -0700, Subhash Jadavani wrote: > PS: ufshcd_memory_alloc() also does some DMA coherent memory allocation > (via dmam_alloc_coherent() APIs) and tries to print out the message on > allocation failure. Although i don't know "out of memory" messages will > be printed

Re: Checking error messages for failed memory allocations

> Basically most everything that has a gfp_t argument does a > dump_stack() on OOM unless __GFP_NOWARN is specified by that gfp_t. How do you think about to improve any programming interface documentation around such a function property? Are there any special checks needed for function

Re: [PATCH v5 0/4] Avoid that __scsi_remove_device() hangs

On Tue, 2017-04-25 at 13:53 -0700, Bart Van Assche wrote: > __scsi_remove_device() hangs if it is waiting for the SYNCHRONIZE CACHE > command submitted by the sd driver to finish if the block layer queue is > stopped and does not get restarted. This patch series avoids that that > hang occurs. > [

Re: [PATCH v3 3/4] sd: Make synchronize cache upon shutdown asynchronous

On Tue, 2017-04-18 at 08:56 -0700, James Bottomley wrote: > The priority has got to be the removal we've been ordered to do rather > than waiting around to see if the transport comes back so we can send a > final flush. > > How about this approach. It goes straight to DEL if the device is >

Re: [PATCH v2 1/1] aacraid: pci_alloc_consistent() failures on ARM64

Christoph, > The indentation is weird, and you're also adding memsets of the > allocations which is a behavior change. Please take a look at the the > attached version that fixes this up. Applied to 4.12/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

[PATCH v2] lpfc: Fix panic on BFS configuration.

From: James Smart To select the appropriate shost template, the driver is issuing a mailbox command to retrieve the wwn. Turns out the sending of the command precedes the reset of the function. On SLI-4 adapters, this is inconsequential as the mailbox command location is

[PATCH v6 10/10] scsi: Implement blk_mq_ops.show_rq()

Show the SCSI CDB for pending SCSI commands in /sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. An example of how SCSI commands are displayed by this code: 8801703245c0 {.op=READ, .cmd_flags=META PRIO, .rq_flags=DONTPREP IO_STAT STATS, .tag=14, .internal_tag=-1, .cmd=Read(10) 28 00 2a

RE: [PATCH 07/12] hpsa: cleanup reset handler

> -Original Message- > From: Martin Wilck [mailto:mwi...@suse.com] > Sent: Tuesday, April 11, 2017 7:36 AM > To: Don Brace ; joseph.szczy...@hpe.com; > Gerry Morong ; John Hall > ; j...@linux.vnet.ibm.com; Kevin

Re: [PATCH v2] scsi: ufs: make ufshcd_get_lists_status() register operation obvious

> It could be just cmp 0xe instead of >>1 and cmp 0x7, with readable > code. Applied to 4.12/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/2] scsi: ufs: use MASK_EE_STATUS

> MASK_EE_STATUS added by 66ec6d59 was unused, but it seems to have been > defined to do this. Applied to 4.12/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

Sreekanth, > We need to satisfy this condition on those system where 32 bit dma > consistent mask is not supported and it only supports 64 bit dma > consistent mask. So on these system we can't set > pci_set_consistent_dma_mask() to DMA_BIT_MASK(32). Which systems are you talking about? It

Re: Checking error messages for failed memory allocations

On Wed, 2017-04-26 at 20:50 +0200, SF Markus Elfring wrote: > > Basically most everything that has a gfp_t argument does a > > dump_stack() on OOM unless __GFP_NOWARN is specified by that gfp_t. > > How do you think about to improve any programming interface documentation > around such a function

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

On 26/04/17 01:44 AM, Christoph Hellwig wrote: > I think we'll at least need a draft of those to make sense of these > patches. Otherwise they just look very clumsy. Ok, I'll work up a draft proposal and send it in a couple days. But without a lot of cleanup such as this series it's not going

Re: [PATCH] mac_esp: fix to pass correct device identity to free_irq()

Finn, > free_irq() expects the same device identity that was passed to > corresponding request_irq(), otherwise the IRQ is not freed. Applied to 4.12/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: Checking error messages for failed memory allocations

> Feel free to submit documentation patches. Do involved software developers agree on the functionality for stack dumps because of out of memory situations? Regards, Markus

Re: [PATCH] scsi: stex: make S6flag static

Colin, > This module specific flag can be made static as it does not need to be > in global scope. Applied to 4.12/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

On 26/04/17 02:59 AM, wrote: > Good to know that somebody is working on this. Those problems troubled > us as well. Thanks Christian. It's a daunting problem and a there's a lot of work to do before we will ever be where we need to be so any help, even an ack, is greatly appreciated. Logan

Re: [PATCH v2] lpfc: Fix panic on BFS configuration.

- Original Message - > From: jsmart2...@gmail.com > To: linux-scsi@vger.kernel.org, sta...@vger.kernel.org > Cc: jthumsh...@suse.de, linux-n...@lists.infradead.org, emi...@redhat.com, > "James Smart" , > "Dick Kennedy" , "James Smart" >

Re: [PATCH] qla4xxx: fix spelling mistake: "Tempalate" -> "Template"

Colin, > trivial fix to spelling mistake in DEBUG2 debug message Applied to 4.12/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote: > Very straightforward conversion to the new function in the caam driver > and shash library. > > Signed-off-by: Logan Gunthorpe > Cc: Herbert Xu > Cc: "David S. Miller"