Re: [PATCH v1 4/4] tcmu: Make dev_config configurable

On 05/26/2017 09:27 AM, Bryant G. Ly wrote: > This allows for userspace to change the device path after > it has been created. Thus giving the user the ability to change > the path. The use case for this is to allow for virtual optical > to have media change. > > Signed-off-by: Bryant G. Ly

Re: [PATCH v1 3/4] tcmu: Make dev_size configurable via userspace

On 05/26/2017 09:27 AM, Bryant G. Ly wrote: > Allow tcmu backstores to be able to set the device size > after it has been configured via set attribute. > > Part of support in userspace to support certain backstores > changing device size. > > Signed-off-by: Bryant G. Ly

Re: [PATCH] scsi: lpfc: Fix crash on PCI hotplug remove path

On 05/28/2017 11:45 PM, Guilherme G. Piccoli wrote: > During a PCI hotplug remove event we could have a NULL pointer > dereference on lpfc_sli_abort_iocb(), if pring is NULL. This > patch adds a check for this case and is able to circumvent the > failure and continue the hotplug remove process

Re: Charitable Organization~

`._.. Glad to write to you this message, I seek for your kind help in setting up a charitable organization to help the less privileged people and also the elderly people under your care, I want to use my late husband wealth of $3,000,000.00 to set up a charity foundation to help the needy and

Re: [PATCH] scsi: lpfc: Avoid NULL pointer dereference in lpfc_els_abort()

On 05/24/2017 11:48 PM, Guilherme G. Piccoli wrote: > We might have a NULL pring in lpfc_els_abort(), for example on > error recovery path, since queues are destroyed during error > recovery mechanism. > > In this case, we should just drop the abort since the queues will > be recreated anyway.

Re: [PATCH v2 07/22] scsi: hisi_sas: create hisi_sas_get_fw_info()

On Thu, May 25, 2017 at 2:04 PM, John Garry wrote: > Move the functionality to retrieve the fw info into > a dedicated device type-agnostic function, > hisi_sas_get_fw_info(). > > The reasoning is that this function will be required > for future pci-based platforms. > > -

Re: [PATCH v2 07/22] scsi: hisi_sas: create hisi_sas_get_fw_info()

is On 29/05/2017 11:53, Arnd Bergmann wrote: On Thu, May 25, 2017 at 2:04 PM, John Garry wrote: Move the functionality to retrieve the fw info into a dedicated device type-agnostic function, hisi_sas_get_fw_info(). The reasoning is that this function will be required

Re: [PATCH v2 07/22] scsi: hisi_sas: create hisi_sas_get_fw_info()

On Mon, May 29, 2017 at 1:18 PM, John Garry wrote: > On 29/05/2017 11:53, Arnd Bergmann wrote: >> On Thu, May 25, 2017 at 2:04 PM, John Garry wrote: > > So we only require these properties for platform device with DT firmware. > This code is same as

Re: [PATCH] scsi: lpfc: Fix crash on PCI hotplug remove path

On Mon, May 29, 2017 at 09:56:09AM +0200, Johannes Thumshirn wrote: > On 05/28/2017 11:45 PM, Guilherme G. Piccoli wrote: > > During a PCI hotplug remove event we could have a NULL pointer > > dereference on lpfc_sli_abort_iocb(), if pring is NULL. This > > patch adds a check for this case and is

Re: [PATCH] scsi: lpfc: prevent potential null pointer dereference

Looks good Signed-off-by: James Smart -- james On 5/23/2017 8:09 AM, Gustavo A. R. Silva wrote: Null check at line 966: if (ndlp) {, implies that ndlp might be NULL. Functions lpfc_nlp_set_state() and lpfc_issue_els_prli() dereference pointer ndlp. Include these

Re: [PATCH] scsi: lpfc: Avoid NULL pointer dereference in lpfc_els_abort()

Change looks good Signed-off-by: James Smart -- james On 5/24/2017 2:48 PM, Guilherme G. Piccoli wrote: We might have a NULL pring in lpfc_els_abort(), for example on error recovery path, since queues are destroyed during error recovery mechanism. In this case,

Re: [PATCH] lpfc: nvmet_fc: fix format string

Patch is fine. Signed-off-by: James Smart -- james On 5/19/2017 1:04 AM, Arnd Bergmann wrote: The lpfc_nvmeio_data() tracing helper always takes a format string and three additional arguments. The latest caller has a format string with only two integer arguments,

Re: [PATCH] scsi: lpfc: Fix crash on PCI hotplug remove path

looks good Signed-off-by: James Smart -- james On 5/28/2017 2:45 PM, Guilherme G. Piccoli wrote: During a PCI hotplug remove event we could have a NULL pointer dereference on lpfc_sli_abort_iocb(), if pring is NULL. This patch adds a check for this case and is

Re: [PATCH] scsi: lpfc: fix spelling mistake "entrys" -> "entries"

it's good :) Signed-off-by: James Smart -- james On 5/26/2017 3:11 AM, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in debugfs message Signed-off-by: Colin Ian King

Re: [PATCH] scsi: lpfc: make a couple of functions static

Patch is fine. Signed-off-by: James Smart -- james On 5/18/2017 2:35 AM, Colin King wrote: From: Colin Ian King functions lpfc_nvmet_cleanup_io_context and lpfc_nvmet_setup_io_context can be made static as they do not need to be in