Debug out from SCSI layers

Hi, Is there a way to make the SCSI layers (midlayer, sd, etc.) print out a some debug output to /var/log/messages so that one can see what's going on in those driver real time? Thanks, Chad - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL

[PATCH V3 0/2] Add QLogic FastLinQ FCoE (qedf) driver

From: "Dupuis, Chad" <chad.dup...@cavium.com> Dave, please apply the qed patch to net-next at your earliest convenience. Martin, the qed patch needs to be applied first as the qedf patch is dependent on the FCoE bits in the first qed driver patch. This series introduces the hardw

[PATCH V3 net-next 1/2] qed: Add support for hardware offloaded FCoE.

From: Arun Easi This adds the backbone required for the various HW initalizations which are necessary for the FCoE driver (qedf) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi

[PATCH V2 0/2] Add QLogic FastLinQ FCoE (qedf) driver

From: "Dupuis, Chad" <chad.dup...@cavium.com> This series introduces the hardware offload FCoE initiator driver for the 41000 Series Converged Network Adapters (579xx chip) by Cavium. The overall driver design includes a common module ('qed') and protocol specific dependen

[PATCH V2 net-next 1/2] qed: Add support for hardware offloaded FCoE.

From: Arun Easi This adds the backbone required for the various HW initalizations which are necessary for the FCoE driver (qedf) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi

[PATCH] qedf: fixup compilation warning about atomic_t usage

From: "Dupuis, Chad" <chad.dup...@cavium.com> Based on an original patch by Hannes Reinecke. The driver didn't follow the atomic_t vs refcount_t change, and anyway one should be using kref_read() instead of accessing the counter inside an kref. Fixes: 61d8658b4a435e ("s

[PATCH V4 net-next 1/2] qed: Add support for hardware offloaded FCoE.

From: Arun Easi This adds the backbone required for the various HW initalizations which are necessary for the FCoE driver (qedf) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi

[PATCH V4 0/2] Add QLogic FastLinQ FCoE (qedf) driver

From: "Dupuis, Chad" <chad.dup...@cavium.com> Dave, please apply the qed patch to net-next at your earliest convenience. Martin, the qed patch needs to be applied first as the qedf patch is dependent on the FCoE bits in the first qed driver patch. This series introduces the hardw

[PATCH V5 net-next 1/2] qed: Add support for hardware offloaded FCoE.

From: Arun Easi This adds the backbone required for the various HW initalizations which are necessary for the FCoE driver (qedf) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi

[PATCH V5 0/2] Add QLogic FastLinQ FCoE (qedf) driver

From: "Dupuis, Chad" <chad.dup...@cavium.com> Dave, please apply the qed patch to net-next at your earliest convenience. Martin, the qed patch needs to be applied first as the qedf patch is dependent on the FCoE bits in the first qed driver patch. This series introduces the hardw

[PATCH 1/2] qed: Add support for hardware offloaded FCoE.

From: Arun Easi This adds the backbone required for the various HW initalizations which are necessary for the FCoE driver (qedf) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi

[PATCH 0/2] Add QLogic FastLinQ FCoE (qedf) driver

From: "Dupuis, Chad" <chad.dup...@cavium.com> This series introduces the hardware offload FCoE initiator driver for the 41000 Series Converged Network Adapters (579xx chip) by Cavium. The overall driver design includes a common module ('qed') and protocol specific dependen

[PATCH RFC 0/5] Add QLogic FastLinQ FCoE (qedf) driver

From: "Dupuis, Chad" <chad.dup...@cavium.com> This series introduces the hardware offload FCoE initiator driver for the 41000 Series Converged Network Adapters (579xx chip) by QLogic. The overall driver design includes a common module ('qed') and protocol specific dependen

[PATCH RFC 5/5] qedf: Add FIP request handling

From: "Dupuis, Chad" <chad.dup...@cavium.com> This patch adds handling for FIP requests and responses that are handled by the driver itself and not by libfcoe. Signed-off-by: Nilesh Javali <nilesh.jav...@cavium.com> Signed-off-by: Manish Rangankar <manish.rangan.

[PATCH RFC net-next 1/5] qed: Add support for hardware offloaded FCoE.

From: Arun Easi This adds the backbone required for the various HW initalizations which are necessary for the FCoE driver (qedf) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi

[PATCH RFC 3/5] qedf: Add offloaded I/O request functions.

From: "Dupuis, Chad" <chad.dup...@cavium.com> This patch adds various I/O requests types that are handled in firmware: - Normal I/O requests - ABTS requests - Cleanup requests - Task management requests It also contains: - I/O request initialization - Firmware completion hand

[PATCH RFC 4/5] qedf: Add offload ELS request handling.

From: "Dupuis, Chad" <chad.dup...@cavium.com> This patch adds support for ELS requests that are handled by the firmware for offloaded sessions. Signed-off-by: Nilesh Javali <nilesh.jav...@cavium.com> Signed-off-by: Manish Rangankar <manish.rangan...@cavium.com> S

[PATCH] qedf: Fix crash due to unsolicited FIP VLAN response.

From: Chad Dupuis We need to initialize qedf->fipvlan_compl in __qedf_probe so that if we receive an unsolicited FIP VLAN response, the system doesn't crash due to trying to complete an uninitialized completion. Also add a check to see if there are any waiters on the

[PATCH 7/7] bnx2fc: Update version number to 2.11.8.

Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc.h b/drivers/scsi/bnx2fc/bnx2fc.h index c192840..7e007e1 100644 --- a/drivers/scsi/bnx2fc/bnx2fc.h +++

[PATCH 6/7] bnx2fc: Make rport_terminate_io callback a NOOP.

Do not call the stock libfc terminate rport i/o handler so we won't reset the libfc exchange manager and kill any outstanding discovery requests. Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)

[PATCH 0/7] bnx2fc: Update driver to version 2.11.8.

Hi Martin, Please apply the following patches at your earliest convenience. Thanks, Chad Dupuis, Chad (7): bnx2fc: Add filters to the non-offload FCoE receive path. bnx2fc: Check for connection offload before sending RRQ. bnx2fc: Update copyright for 2017. bnx2fc: Adjust

[PATCH 4/7] bnx2fc: Adjust bnx2fc_npiv_create_vports for WWNNs from NVRAM that are zero.

Some vports addresses stored in NVRAM may have zero for the WWNN. Adjust the WWNN that we'll use to be the same as the WWPN. Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff

[PATCH 1/7] bnx2fc: Add filters to the non-offload FCoE receive path.

Add the following filters to bnx2fc_recv_frame(): 1. Filter out invalid packets - eth->dest_mac[3] matches FC frame's D_ID 2. Filter out packets that are not from our connected target - In FIP_ST_ENABLED mode - eth->src_mac matches fcoe_ctlr->dest_addr 3. Filter out packets where if

[PATCH 3/7] bnx2fc: Update copyright for 2017.

Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/57xx_hsi_bnx2fc.h | 3 ++- drivers/scsi/bnx2fc/bnx2fc.h | 3 ++- drivers/scsi/bnx2fc/bnx2fc_constants.h | 3 ++- drivers/scsi/bnx2fc/bnx2fc_debug.c | 3 ++- drivers/scsi/bnx2fc/bnx2fc_debug.h | 3 ++-

[PATCH 2/7] bnx2fc: Check for connection offload before sending RRQ.

If the connection is not offloaded then the backpointers from the tgt pointer are undefined. Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc_els.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git

[PATCH 5/7] bnx2fc: If IO is still in cleanup then do not return to SCSI layer.

In eh_abort, driver is calling scsi->done() for a IO for which cleanup is pending. As the IO is outstanding with the firmware, it may do DMA associated with the IO. This may lead to heap corruption. Do not complete the IO for which cleanup is still pending. Return failure from eh_abort and let

[PATCH 09/15] qedf: Add bus_reset No-op.

We need to add a bus reset no-op as without it some of the LUNs attached to a vport may go offline when the error handler escalates to host reset due to not having a bus reset handler in the driver. What happens is we escalate to host reset which does a soft link down/link up to reset the adapter.

[PATCH 15/15] qedf: Update version number to 8.18.22.0.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_version.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_version.h b/drivers/scsi/qedf/qedf_version.h index d46c487..6fa4420 100644 ---

[PATCH 07/15] qedf: Set qed logging level to QED_LEVEL_NOTICE.

Reduce the logging level we set for qed messages pertaining to this PCI function so that unnecessary messages are not printed in the kernel message log. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 05/15] qedf: Check that fcport is offloaded before dereferencing pointers in initiate_abts|cleanup.

If an fcport is not offloaded then the members of the qedf_rport struct are undefined which may cause a system crash. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_io.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git

[PATCH 04/15] qedf: Look at all descriptors when processing a clear virtual link.

If there are multiple descriptors for a particular type in a clear virtual link we receive, we will not process it correctly but rather take the last value. This can cause us not to not flap the virtual link as the value from the descriptors that we compare against the our stored FCF or fc_lport

[PATCH 01/15] qedf: Enable basic FDMI information.

For libfc to register FDMI attributes we need to do two things: - Set the appropriate fc_host attributes that libfc will use to form the FDMI registration commands - Set lport->fdmi_enabled to 1 Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 57

[PATCH 08/15] qedf: Use same logic for SCSI host reset and FC lip_reset.

We should be using the same logic to do a soft reset of the FCoE function whether it is initiated via sg_reset or the fc_host issue_lip attribute. Refactor the host reset and fcoe reset handlers to use the preferred logic which is currently contained in qedf_eh_host_reset(). Signed-off-by: Chad

[PATCH 02/15] qedf: Update copyright to 2017.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/drv_fcoe_fw_funcs.c | 2 +- drivers/scsi/qedf/drv_fcoe_fw_funcs.h | 2 +- drivers/scsi/qedf/drv_scsi_fw_funcs.c | 2 +- drivers/scsi/qedf/drv_scsi_fw_funcs.h | 2 +- drivers/scsi/qedf/qedf.h | 2 +-

[PATCH 00/15] qedf: Update driver to version 8.18.22.0.

Hi Martin, Please apply the following patches to the scsi tree at your earliest convenience. Thanks, Chad Dupuis, Chad (15): qedf: Enable basic FDMI information. qedf: Update copyright to 2017. qedf: Honor qed_ops->common->set_fp_int() return code. qedf: Look at all descriptor

[PATCH 12/15] qedf: Move some prints to a debug level so they do not print when no debugging is enabled.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 7d1a953..340cf74 100644 ---

[PATCH 06/15] qedf: Add fka_period SCSI host attribute to show fip keep alive period.

Expose this information for interested applications. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_attr.c | 60 +-- 1 file changed, 41 insertions(+), 19 deletions(-) diff --git a/drivers/scsi/qedf/qedf_attr.c

[PATCH 03/15] qedf: Honor qed_ops->common->set_fp_int() return code.

We need to check the return code the set_fp_int() callback in case we were not allocated any fastpath interrupts or there was an error setting up the fastpath interrupts from the qed perspective. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 2 ++ 1 file

[PATCH 13/15] qedf: Change cmd_per_lun in scsi_host_template to 32 to increase performance.

Increase the default number of commands that the driver tells the SCSI mid-layer it can do to increase the default performance of the driver. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 10/15] qedf: Add non-offload receive filters.

Drop invalid or unexpected FCoE frames that come into the non-offload path since the FCoE firmware would not do the filtering for us. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 46 +++ 1 file changed, 46

[PATCH 11/15] qedf: Fixup unnecessary paratheses around test_bit operations.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_els.c | 6 +++--- drivers/scsi/qedf/qedf_io.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qedf/qedf_els.c b/drivers/scsi/qedf/qedf_els.c index e197fd6..78d9f1c 100644 ---

[PATCH 14/15] qedf: Add change_queue_depth member to scsi_host_template().

Add the change_queue_depth member to our SCSI host template so the queue depth of devices attached to qedf can be changed dynamically. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] qedf: Check if sense buffer has been allocated during completion.

NOTE: This should be applied after the series 'qedf: Update driver to version 8.18.22.0.' sc_cmd->sense_buffer is not guaranteed to be allocated so we need to check if the pointer is NULL before trying to copy anything into it. Fixes the crash: [ 143.793176]

[PATCH V2 04/15] qedf: Look at all descriptors when processing a clear virtual link.

If there are multiple descriptors for a particular type in a clear virtual link we receive, we will not process it correctly but rather take the last value. This can cause us not to not flap the virtual link as the value from the descriptors that we compare against the our stored FCF or fc_lport

[PATCH V2 07/15] qedf: Set qed logging level to QED_LEVEL_NOTICE.

Reduce the logging level we set for qed messages pertaining to this PCI function so that unnecessary messages are not printed in the kernel message log. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH V2 03/15] qedf: Honor qed_ops->common->set_fp_int() return code.

We need to check the return code the set_fp_int() callback in case we were not allocated any fastpath interrupts or there was an error setting up the fastpath interrupts from the qed perspective. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 2 ++ 1 file

[PATCH V2 00/15] qedf: Update driver to version 8.18.22.0.

ode refactoring for fka_period sysfs attribute - Keep newly introduced error message strings on one line Dupuis, Chad (15): qedf: Enable basic FDMI information. qedf: Update copyright to 2017. qedf: Honor qed_ops->common->set_fp_int() return code. qedf: Look at all descriptors when processin

[PATCH V2 01/15] qedf: Enable basic FDMI information.

For libfc to register FDMI attributes we need to do two things: - Set the appropriate fc_host attributes that libfc will use to form the FDMI registration commands - Set lport->fdmi_enabled to 1 Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 56

[PATCH V2 02/15] qedf: Update copyright to 2017.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/drv_fcoe_fw_funcs.c | 2 +- drivers/scsi/qedf/drv_fcoe_fw_funcs.h | 2 +- drivers/scsi/qedf/drv_scsi_fw_funcs.c | 2 +- drivers/scsi/qedf/drv_scsi_fw_funcs.h | 2 +- drivers/scsi/qedf/qedf.h | 2 +-

[PATCH V2 10/15] qedf: Add non-offload receive filters.

Drop invalid or unexpected FCoE frames that come into the non-offload path since the FCoE firmware would not do the filtering for us. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 43 +++ 1 file changed, 43

[PATCH V2 08/15] qedf: Use same logic for SCSI host reset and FC lip_reset.

We should be using the same logic to do a soft reset of the FCoE function whether it is initiated via sg_reset or the fc_host issue_lip attribute. Refactor the host reset and fcoe reset handlers to use the preferred logic which is currently contained in qedf_eh_host_reset(). Signed-off-by: Chad

[PATCH V2 05/15] qedf: Check that fcport is offloaded before dereferencing pointers in initiate_abts|cleanup.

If an fcport is not offloaded then the members of the qedf_rport struct are undefined which may cause a system crash. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_io.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git

[PATCH V2 09/15] qedf: Add bus_reset No-op.

We need to add a bus reset no-op as without it some of the LUNs attached to a vport may go offline when the error handler escalates to host reset due to not having a bus reset handler in the driver. What happens is we escalate to host reset which does a soft link down/link up to reset the adapter.

[PATCH V2 06/15] qedf: Add fka_period SCSI host attribute to show fip keep alive period.

Expose this information for interested applications. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_attr.c | 57 --- 1 file changed, 38 insertions(+), 19 deletions(-) diff --git a/drivers/scsi/qedf/qedf_attr.c

[PATCH V2 11/15] qedf: Fixup unnecessary parantheses around test_bit operations.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_els.c | 6 +++--- drivers/scsi/qedf/qedf_io.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qedf/qedf_els.c b/drivers/scsi/qedf/qedf_els.c index e197fd6..78d9f1c 100644 ---

[PATCH V2 14/15] qedf: Add change_queue_depth member to scsi_host_template().

Add the change_queue_depth member to our SCSI host template so the queue depth of devices attached to qedf can be changed dynamically. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH V2 15/15] qedf: Update version number to 8.18.22.0.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_version.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_version.h b/drivers/scsi/qedf/qedf_version.h index d46c487..6fa4420 100644 ---

[PATCH V2 13/15] qedf: Change cmd_per_lun in scsi_host_template to 32 to increase performance.

Increase the default number of commands that the driver tells the SCSI mid-layer it can do to increase the default performance of the driver. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH V2 12/15] qedf: Move some prints to a debug level so they do not print when no debugging is enabled.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 45c741b..4b688d6 100644 --- a/drivers/scsi/qedf/qedf_main.c

Re: [PATCH 19/28] qedf: fully convert to the generic DMA API

On Sun, 14 Oct 2018, 11:59am, Christoph Hellwig wrote: > External Email > > The driver is currently using an odd mix of legacy PCI DMA API and > generic DMA API calls, switch it over to the generic API entirely. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn > --- >

Re: [PATCH] scsi_error: Remove scsi_block_when_processing_errors: message

On Tue, 16 Oct 2018, 4:39pm, Laurence Oberman wrote: > External Email > > This message floods the log when enabling mask 0x7 for > /proc/sys/dev/scsi/logging_level > kernel: scsi_block_when_processing_errors: rtn: 1 > Its not needed and makes tracing just scsi_eh* messages way too