Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

On 06/02/2017 15:27, Chris Leech wrote: > - Original Message - >> On 09/11/2016 03:21, Chris Leech wrote: >>> On Mon, Nov 07, 2016 at 04:23:10PM -0200, Guilherme G. Piccoli wrote: >>>> >>>> Sure! Count on us to test any patches. I guess the first s

Re: [PATCH] mpt3sas: Force request partial completion alignment

On 01/23/2017 07:05 AM, Sreekanth Reddy wrote: > On Wed, Dec 28, 2016 at 6:21 PM, Guilherme G. Piccoli > <gpicc...@linux.vnet.ibm.com> wrote: >> From: Ram Pai <linux...@us.ibm.com> >> >> The firmware or device, possibly under a heavy I/O load, can return >>

[PATCH v2] mpt3sas: Force request partial completion alignment

ria De Oliveira <mauri...@linux.vnet.ibm.com> Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> Signed-off-by: Ram Pai <linux...@us.ibm.com> --- v1->v2: * Improved printk, by showing some variables too [suggested by Sreekanth]. drivers/scsi/mpt3sas/mpt3sas_scsih.

Re: [PATCH v2] mpt3sas: Force request partial completion alignment

On 01/25/2017 09:46 PM, Martin K. Petersen wrote: >>>>>> "Guilherme" == Guilherme G Piccoli <gpicc...@linux.vnet.ibm.com> writes: > > Hi Guilherme, Hi Martin, thanks for the review! > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c > b/dri

[PATCH v3] mpt3sas: Force request partial completion alignment

ria De Oliveira <mauri...@linux.vnet.ibm.com> Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> Signed-off-by: Ram Pai <linux...@us.ibm.com> Acked-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> --- v2->v3: * Changed division to round_down() [suggestion b

Re: [PATCH v2] mpt3sas: Force request partial completion alignment

On 01/26/2017 03:02 PM, Ram Pai wrote: > On Thu, Jan 26, 2017 at 11:31:53AM -0200, Guilherme G. Piccoli wrote: >> On 01/25/2017 09:46 PM, Martin K. Petersen wrote: >>>>>>>> "Guilherme" == Guilherme G Piccoli <gpicc...@linux.vnet.ibm.com> >&

Re: [PATCH] libiscsi: add lock around task lists to fix list corruption regression

below, most nitpicks heheh Feel free to accept or not the suggestions! Also, you can add my: Reviewed-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> > > - Chris Leech > > - Original Message - >> There's a rather long standing regression from commit >&g

Re: [PATCH v4] sd: Check for unaligned partial completion

On 15/02/2017 05:06, Ram Pai wrote: > On Wed, Feb 15, 2017 at 03:48:52PM +0900, Damien Le Moal wrote: >> Christoph, >> >> On 2/15/17 15:34, Christoph Hellwig wrote: >>> this looks reasonable, but we should ask Guilherme and Ram to confirm >>> it fixes their originally reported issue. I've added

Re: [PATCH v2] libiscsi: add lock around task lists to fix list corruption regression

Thanks very much Chris, really good patch. Hopefully it can reach 4.11! Cheers, Guilherme

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

On 11/07/2016 04:15 PM, Chris Leech wrote: > Hi, > > I'm kicking this old thread because I don't think this ever got > resolved. I wish I had more info, but it seems to involve target > specific behavior that hasn't come up in our test labs. Thanks very much for reopening this thread! We have

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

On 11/09/2016 03:21 AM, Chris Leech wrote: > On Mon, Nov 07, 2016 at 04:23:10PM -0200, Guilherme G. Piccoli wrote: >> >> Sure! Count on us to test any patches. I guess the first step is to >> reproduce on upstream right? We haven't tested specifically this >> scena

Re: [PATCH] scsi: do not requeue requests unaligned with device sector size

tors total, 3072 bytes done. > [...] sd 0:0:0:0: [sda] tag#0 checking 3072 bytes for alignment > (sector size 4096, remainder 3072, resid 1024) > [...] sd 0:0:0:0: [sda] tag#0 sd_done: completed 4096 of 4096 bytes > [...] sd 0:0:0:0: [sda] tag#0 8 sectors tota

[PATCH] mpt3sas: Force request partial completion alignment

ria De Oliveira <mauri...@linux.vnet.ibm.com> Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> Signed-off-by: Ram Pai <linux...@us.ibm.com> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/scsi/mp

[PATCH] scsi: aacraid: fix PCI error recovery path

procedure was able to recover fine. Fixes: 5c63f7f710bd ("aacraid: Added EEH support") Cc: sta...@vger.kernel.org # v4.6+ Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> --- drivers/scsi/aacraid/aacraid.h | 11 --- drivers/scsi/aacraid/commsup.c | 3 ++- 2 f

Re: [PATCH v6] sd: Check for unaligned partial completion

Looks good, thanks for the patch. Reviewed-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> Cheers, Guilherme

Re: nvmf question - synchronization between target/initiator regarding partitions

On 08/10/2017 06:16 AM, Christoph Hellwig wrote: > On Mon, Aug 07, 2017 at 02:29:47PM -0300, Guilherme G. Piccoli wrote: >> Thanks for your feedback Hannes, agreed! > > And btw, you'll see similar results with the SCSI target or nbd, > so it's not really nvme specific. Thanks,

nvmf question - synchronization between target/initiator regarding partitions

We observed that it's possible to perform partition operations in both nvmf target and initiator block devices, like creating and deleting partitions. But there is no sync mechanism between target and initiator regarding the partitions operations. After creating a partition on initiator, for

Re: nvmf question - synchronization between target/initiator regarding partitions

Thanks for your feedback Hannes, agreed! Cheers, Guilherme

Re: [PATCH v2 02/15] lpfc: Fix system crash when port is reset.

On 05/17/2017 03:49 PM, James Smart wrote: > Your patch is still needed. Can you repost your patch with a new > subject and add my signature: > > Signed-off-by: James Smart > > Sorry, I didn't see it to roll it into the set. No problem James, already sent it to

[PATCH] lpfc: Fix NULL pointer dereference during PCI error recovery

a...@linux.vnet.ibm.com> Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- This patch was rebased against 4.12/scsi-fixes on mkp tree. I couldn't figure a better way to refer to commits in this message because

Re: [PATCH 02/15] lpfc: Fix system crash when port is reset.

Hi James and Dick, thanks for this patch. We were investigating a pretty similar issue, and we raised a patch that looks like yours. Since you sent this one, we reviewed and seems it's missing a hunk to prevent the issue we are dealing here, in PCI error recovery. Please see the attached patch.

Re: [PATCH] lpfc: Fix NULL pointer dereference during PCI error recovery

On 05/17/2017 09:21 PM, Martin K. Petersen wrote: > > Guilherme, > >> Recent commit on patchset "lpfc updates for 11.2.0.14" fixed an issue >> about dereferencing a NULL pointer on port reset. The specific commit, >> named "lpfc: Fix system crash when port is reset.", is missing a check >>

[PATCH] scsi: lpfc: Fix crash on PCI hotplug remove path

refactor made on commit 895427bd012c ("scsi: lpfc: NVME Initiator: Base modifications"). Fixes: 895427bd012c ("scsi: lpfc: NVME Initiator: Base modifications") Reported-by: Naresh Bannoth <nbann...@in.ibm.com> Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.co

[PATCH] scsi: lpfc: Avoid NULL pointer dereference in lpfc_els_abort()

Silva <rapha...@linux.vnet.ibm.com> Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> --- * This patch was rebased against Martin's 4.12/scsi-fixes. drivers/scsi/lpfc/lpfc_crtn.h | 2 +- drivers/scsi/lpfc/lpfc_nportdisc.c | 7 +-- 2 files changed, 6 insertions(+), 3 deletions(

Re: [PATCH] scsi: aacraid: Add a small delay after IOP reset

On 09/19/2017 02:05 PM, James Bottomley wrote: > Actually, the whole problem sounds like a posted write. Likely the > write that causes the reset doesn't get flushed until the read checking > if the reset has succeeded, which might explain the 100% initial > failure. Why not throw away that

Re: [PATCH] scsi: aacraid: Add a small delay after IOP reset

On 09/19/2017 12:52 PM, Christoph Hellwig wrote: > On Tue, Sep 19, 2017 at 12:49:21PM -0300, Guilherme G. Piccoli wrote: >> On 09/19/2017 12:37 PM, Christoph Hellwig wrote: >>> On Tue, Sep 19, 2017 at 12:11:55PM -0300, Guilherme G. Piccoli wrote: >>>>

[PATCH] scsi: aacraid: Add a small delay after IOP reset

eriodic checks to see IOP reset status") Cc: sta...@vger.kernel.org # v4.13+ Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> --- drivers/scsi/aacraid/src.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c ind

Re: [PATCH] scsi: aacraid: Add a small delay after IOP reset

On 09/19/2017 12:37 PM, Christoph Hellwig wrote: > On Tue, Sep 19, 2017 at 12:11:55PM -0300, Guilherme G. Piccoli wrote: >> src_writel(dev, MUnit.IDR, IOP_SRC_RESET_MASK); >> + >> +msleep(5000); > > src_writel is a writel, and thus a posted MMIO write. You'

Re: [PATCH] scsi: aacraid: Add a small delay after IOP reset

On 09/21/2017 01:19 PM, Dave Carroll wrote: >> [...] >> --- > Acked-by: Dave Carroll > Thanks Dave! James/Martin, am I expected to send a v2 with some change? Perhaps with Dave's ack? Sorry to annoy, thanks in advance for any advice! Cheers, Guilherme

Re: smp-induced oops/NULL pointer dereference in mpt3sas, from kernel >= 4.11

On 09/04/2017 05:44 PM, Guilherme G. Piccoli wrote: > [Hopefully this messages gets threaded properly...] And of course, I forgot to CC linux-scsi heheh Sorry! > > Chaitra, the following 4 patches fix this issue (the last one is really > the fix, the others are part of

[PATCH 3/3] scsi: aacraid: Prevent crash in case of free interrupt during scsi EH path

, then we free other resources. No functional change intended. Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> --- drivers/scsi/aacraid/commsup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/com

[PATCH 1/3] scsi: aacraid: Check for PCI state of device in a generic way

on-dependent of arch configs - also, it makes the code cleaner. Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> --- drivers/scsi/aacraid/commsup.c | 33 ++--- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/drivers/scsi/aacraid/commsu

[PATCH 2/3] scsi: aacraid: Perform initialization reset only once

of scsi EH path, this patch adds a field to aac_dev struct to keep per-adapter track of the init reset request - once it's done, we set it to false and don't proactively reset anymore in case of reinitializations. Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> --- driv

[PATCH 0/3] Some fixes to aacraid

This series presents 3 small fixes for aacraid driver. The most important is the crash prevention, IMHO. Tested them against v4.14. Guilherme G. Piccoli (3): scsi: aacraid: Check for PCI state of device in a generic way scsi: aacraid: Perform initialization reset only once scsi: aacraid

Re: Should a raid-0 array immediately stop if a component disk is removed?

Thanks for your quick reply Anthony! Inline comments below: On 27/04/2018 19:11, Wols Lists wrote: > On 27/04/18 22:49, Guilherme G. Piccoli wrote: > [...] > Sounds like you're not using mdadm to remove the disk. So why do you > expect mdadm to stop the array immediately? It

Should a raid-0 array immediately stop if a component disk is removed?

Hello, we've noticed an interesting behavior when using a raid-0 md array. Suppose we have a 2-disk raid-0 array that has a mount point set - in our tests, we've used ext4 filesystem. If we remove one of the component disks via sysfs[0], userspace is notified, but mdadm tool fails to stop the

Re: [PATCH 03/29] scsi: aacraid: Fix hang in kdump

1dd532901e (scsi: aacraid: Reload offlined drives after > controller reset) > Cc: <sta...@vger.kernel.org> > Reported-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> (Sorry in advance for flooding the thread heheh) I guess it'd be more appropriate to: Reported-by:

Re: [PATCH 00/28] aacraid: Refactor for sas transport and bug fixes

On 12/21/2017 03:33 PM, Raghava Aditya Renukunta wrote: > This patchset primarily lays the foundation for adding sas transport > support to the aacraid driver. Being said these patches are mainly code > refactors, bug fixes and improvements. I was thinking...if possible, and just in case you plan

Re: [PATCH 00/28] aacraid: Refactor for sas transport and bug fixes

On 12/26/2017 11:27 PM, Raghava Aditya Renukunta wrote: > [...] >> I was thinking...if possible, and just in case you plan to send a V2 >> after Bart's comments (or any other future reviews this patchset gets), >> how about splitting in 2 patchsets, one for bug fixes and the other for >>

Re: [PATCH 03/29] scsi: aacraid: Fix hang in kdump

1dd532901e (scsi: aacraid: Reload offlined drives after > controller reset) > Cc: <sta...@vger.kernel.org> > Reported-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> > Tested-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> > Fixes: a2d0321dd532901