Re: qla2xxx: Add FDMI-2 functionality.

On 9/26/14, 8:08 AM, Dan Carpenter dan.carpen...@oracle.com wrote: Hello Himanshu Madhani, The patch df57cabac41f: qla2xxx: Add FDMI-2 functionality. from Sep 25, 2014, leads to the following static checker warnings: drivers/scsi/qla2xxx/qla_gs.c:1339 qla2x00_fdmi_rhba() error: snprintf

[PATCH 11/14] qla2xxx: Prevent multiple firmware dump collection for ISP27XX.

For ISP27XX, driver will capture new firmware dump even if there is one already collected. Prevent this from happening by checking fw_dumped flag. Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx

[PATCH 06/14] qla2xxx: Add message for sucessful FW dump collected for ISP27XX.

o Added message indicating firmware dump was sucessfully collected for ISP27XX. o Improve logging to help debug firmware dump process for ISP27XX. Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx

[PATCH 10/14] qla2xxx: Disable Interrupt handshake for ISP27XX.

Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_def.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h

[PATCH 03/14] qla2xxx: Increase the wait time for firmware to be ready for P3P.

From: Chad Dupuis chad.dup...@qlogic.com Signed-off-by: Chad Dupuis chad.dup...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_init.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx

[PATCH 08/14] qla2xxx: Add serdes read/write support for ISP27XX

From: Andrew Vasquez andrew.vasq...@qlogic.com Signed-off-by: Andrew Vasquez andrew.vasq...@qlogic.com Signed-off-by: Harish Zunjarrao harish.zunjar...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_mbx.c | 15 +++ 1 files

[PATCH 02/14] qla2xxx: Fix crash due to wrong casting of reg for ISP27XX.

Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_tmpl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c

[PATCH 00/14] qla2xxx: Patches for scsi misc branch.

to be ready for P3P. Himanshu Madhani (8): qla2xxx: Fix warnings reported by static checker. qla2xxx: Fix crash due to wrong casting of reg for ISP27XX. qla2xxx: Add message for sucessful FW dump collected for ISP27XX. qla2xxx: Add udev notification to save fw dump for ISP27XX qla2xxx

[PATCH 07/14] qla2xxx: Add udev notification to save fw dump for ISP27XX

Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_tmpl.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx

[PATCH 04/14] qla2xxx: Fix beacon blink for ISP27XX.

From: Nigel Kirkland nigel.kirkl...@qlogic.com Signed-off-by: Nigel Kirkland nigel.kirkl...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_sup.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/scsi

[PATCH 13/14] qla2xxx: Restore physical port WWPN only, when port down detected for FA-WWPN port.

refreshing ports information will not be able to scan NPIV port because of this behavior. So while restoring WWPN, only restore physical port WWPN. Signed-off-by: Sawan Chandak sawan.chan...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_isr.c | 17

[PATCH 12/14] qla2xxx: Fix virtual port configuration, when switch port is disabled/enabled.

fix in driver to make driver wait, for FW to be ready state before Signed-off-by: Sawan Chandak sawan.chan...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_def.h |1 + drivers/scsi/qla2xxx/qla_isr.c |2 ++ drivers/scsi/qla2xxx/qla_mid.c

[PATCH 14/14] qla2xxx: Update driver version to 8.07.00.18-k

Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx

Re: [PATCH 00/14] qla2xxx: Patches for scsi misc branch.

On 4/9/15, 10:53 PM, Bart Van Assche bart.vanass...@sandisk.com wrote: On 04/09/15 20:59, Himanshu Madhani wrote: Hi James, Please apply the following patches to the scsi tree at your earliest convenience for inclusion in the next mainline merge window. Thanks, Himanshu Hello Himanshu

Re: [PATCH 0/10] qla2xxx: Fix various warnings reported by static source code analysis tools

available from the regression tests ? Hello Bart, Replying to correct email thread. We have concluded our regression cycle. The series looks good. Acked-by: Himanshu Madhani himanshu.madh...@qlogic.com Thanks, Bart. -- To unsubscribe from this list: send the line unsubscribe linux-scsi

[PATCH 02/11] qla2xxx: cleanup cmd in qla workqueue before processing TMR

quinn.t...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_dbg.c |2 +- drivers/scsi/qla2xxx/qla_def.h |5 ++ drivers/scsi/qla2xxx/qla_os.c |3 + drivers/scsi/qla2xxx/qla_target.c | 123

[PATCH 00/11] qla2xxx: Updates for Target Mode driver

scsi_transport_fc registration in target mode qla2xxx: drop cmds/tmrs arrived while session is being deleted qla2xxx: terminate exchange when command is aborted by LIO qla2xxx: delete session if initiator is gone from FW qla2xxx: wait for all conflicts before ack'ing PLOGI Himanshu Madhani (1

[PATCH 01/11] qla2xxx: kill sessions/log out initiator on RSCN and port down events

Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_dbg.c|2 +- drivers/scsi/qla2xxx/qla_init.c | 137 ++--- drivers/scsi/qla2xxx/qla_target.c |9 ++- 3 files changed, 117 insertions(+), 31 deletions(-) diff --git

[PATCH 11/11] qla2xxx: wait for all conflicts before ack'ing PLOGI

by many sessions. Cc: sta...@vger.kernel.org Signed-off-by: Alexei Potashnik ale...@purestorage.com Acked-by: Quinn Tran quinn.t...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_dbg.c|4 +- drivers/scsi/qla2xxx/qla_def.h|2 + drivers

[PATCH 06/11] qla2xxx: disable scsi_transport_fc registration in target mode

: sta...@vger.kernel.org Signed-off-by: Alexei Potashnik ale...@purestorage.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_init.c | 14 +++--- drivers/scsi/qla2xxx/qla_os.c |3 ++- 2 files changed, 13 insertions(+), 4 deletions(-) diff

[PATCH 10/11] qla2xxx: delete session if initiator is gone from FW

scenarios it's impossible to tell whether command was received in logged in or logged out state. Cc: sta...@vger.kernel.org Signed-off-by: Alexei Potashnik ale...@purestorage.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_def.h|2 + drivers/scsi

[PATCH 04/11] qla2xxx: Abort stale cmds on qla_tgt_wq when plogi arrives

From: Alexei Potashnik ale...@purestorage.com cancel any commands from initiator's s_id that are still waiting on qla_tgt_wq when PLOGI arrives. Cc: sta...@vger.kernel.org Signed-off-by: Alexei Potashnik ale...@purestorage.com Acked-by: Quinn Tran quinn.t...@qlogic.com Signed-off-by: Himanshu

[PATCH 03/11] qla2xxx: delay plogi/prli ack until existing sessions are deleted

sessions (unless deletion is already IN_PROGRESS): - different port_name, different port_id, but the same loop_id (without logout) Cc: sta...@vger.kernel.org Signed-off-by: Alexei Potashnik ale...@purestorage.com Acked-by: Quinn Tran quinn.t...@qlogic.com Signed-off-by: Himanshu Madhani

[PATCH 07/11] qla2xxx: drop cmds/tmrs arrived while session is being deleted

session's commands will keep finding old session in the fcport map. This patch drops cmds/tmrs if they find session in the progress of being deleted. Cc: sta...@vger.kernel.org Signed-off-by: Alexei Potashnik ale...@purestorage.com Acked-by: Quinn Tran quinn.t...@qlogic.com Signed-off-by: Himanshu

[PATCH 05/11] qla2xxx: added sess generations to detect RSCN update races

. Cc: sta...@vger.kernel.org Signed-off-by: Alexei Potashnik ale...@purestorage.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_dbg.c|2 +- drivers/scsi/qla2xxx/qla_def.h|5 +++ drivers/scsi/qla2xxx/qla_init.c | 32

[PATCH 08/11] qla2xxx: terminate exchange when command is aborted by LIO

to the aborted_task handler. Changed iSCSI aborted_task logic to satisfy the above requirement. Cc: sta...@vger.kernel.org Signed-off-by: Alexei Potashnik ale...@purestorage.com Acked-by: Quinn Tran quinn.t...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi

[PATCH 09/11] qla2xxx: Added interface to send ELS commands from driver.

Cc: sta...@vger.kernel.org Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com --- drivers/scsi/qla2xxx/qla_attr.c | 36 +++ drivers/scsi/qla2xxx/qla_dbg.c|5 +- drivers/scsi/qla2xxx/qla_def.h| 19

Re: [PATCH] [RESEND] qla2xxx: prevent board_disable from running during EEH

) !test_bit(PFLG_DRIVER_REMOVING, vha-pci_flags) !test_bit(PFLG_DRIVER_PROBING, vha-pci_flags)) { -- 1.7.10.4 Looks good. Acked-by: Himanshu Madhani himanshu.madh...@qlogic.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

[PATCH 5/9] qla2xxx: adjust debug flags

From: Quinn Tran quinn.t...@qlogic.com Adjust debug flag to match debug comment. Signed-off-by: Quinn Tran quinn.t...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_target.c |7 --- drivers/scsi/qla2xxx/qla_target.h |3

[PATCH 8/9] qla2xxx: Enable Target counters in DebugFS.

Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com --- drivers/scsi/qla2xxx/qla_def.h | 15 + drivers/scsi/qla2xxx/qla_dfs.c | 56 drivers/scsi/qla2xxx/qla_iocb.c

[PATCH 6/9] qla2xxx: Remove msleep in qlt_send_term_exchange

Remove unnecessary msleep from qlt_send_term_exchange as it adds latency of 250 msec while sending terminate exchange to an aborted task. Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com --- drivers/scsi/qla2xxx

[PATCH 9/9] qla2xxx: Add FW resource count in DebugFS.

count[254] MAX FCF count[0] Signed-off-by: Quinn Tran quinn.t...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_def.h | 13 +++-- drivers/scsi/qla2xxx/qla_dfs.c | 50 drivers/scsi/qla2xxx

[PATCH 7/9] qla2xxx: fix command initialization in target mode.

From: Kanoj Sarcar kanoj.sar...@qlogic.com Signed-off-by: Kanoj Sarcar kanoj.sar...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_target.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qla2xxx

[PATCH 4/9] qla2xxx: release request queue reservation.

From: Quinn Tran quinn.t...@qlogic.com Request IOCB queue element(s) is reserved during good path IO. Under error condition such as unable to allocate IOCB handle condition, the IOCB count that was reserved is not released. Signed-off-by: Quinn Tran quinn.t...@qlogic.com Signed-off-by: Himanshu

[PATCH 1/9] qla2xxx: Fix hardware lock/unlock issue causing kernel panic.

saurav.kash...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_init.c |4 drivers/scsi/qla2xxx/qla_target.c |6 -- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi

[PATCH 3/9] qla2xxx: Add flush after updating ATIOQ consumer index.

From: Quinn Tran quinn.t...@qlogic.com After updating the consumer index of ATIO Q, a read is required to flush the write to the adapter register. Signed-off-by: Quinn Tran quinn.t...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_target.c

[PATCH 2/9] qla2xxx: Enable target mode for ISP27XX

Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com --- drivers/scsi/qla2xxx/qla_attr.c |2 +- drivers/scsi/qla2xxx/qla_def.h|8 drivers/scsi/qla2xxx/qla_init.c |4 ++-- drivers/scsi/qla2xxx

[PATCH 0/9] qla2xxx: Patches for scsi misc branch.

Hi James, Please apply the following patches to the scsi tree at your earliest convenience for inclusion in the next mainline merge window. Thanks, Himanshu Himanshu Madhani (3): qla2xxx: Enable target mode for ISP27XX qla2xxx: Remove msleep in qlt_send_term_exchange qla2xxx: Enable

Re: [PATCH 09/10] qla2xxx: Comment out unreachable code

...@sandisk.com Cc: Himanshu Madhani himanshu.madh...@qlogic.com Cc: Quinn Tran quinn.t...@qlogic.com Cc: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_os.c | 7 ++- drivers/scsi/qla2xxx/qla_target.c | 16 +--- 2 files changed, 15 insertions(+), 8

Re: [PATCH 10/10] qla2xxx: Fix indentation

On 6/4/15, 3:58 PM, Bart Van Assche bart.vanass...@sandisk.com wrote: Detected by smatch. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Himanshu Madhani himanshu.madh...@qlogic.com Cc: Quinn Tran quinn.t...@qlogic.com Cc: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi

Re: [PATCH 0/10] qla2xxx: Fix various warnings reported by static source code analysis tools

On 6/2/15, 3:44 PM, Bart Van Assche bart.vanass...@sandisk.com wrote: On 06/02/2015 01:09 PM, Himanshu Madhani wrote: On 2/23/15, 12:49 AM, Bart Van Assche bart.vanass...@sandisk.com wrote: On 02/02/15 05:52, Saurav Kashyap wrote: Thanks for the patches. We will run regression

[PATCH 08/14] qla2xxx: Do not reset ISP for error entry with an out of range handle.

From: Chad Dupuis chad.dup...@qlogic.com Instead of resetting the adapter wait for the login to timeout and retry. Resetting the adapter can cause extended path recovery times. Signed-off-by: Chad Dupuis chad.dup...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com

[PATCH 09/14] qla2xxx: Add support to show MPI and PEP FW version for ISP27xx.

From: Sawan Chandak sawan.chan...@qlogic.com Signed-off-by: Sawan Chandak sawan.chan...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_attr.c | 19 ++- drivers/scsi/qla2xxx/qla_def.h |1 + drivers/scsi/qla2xxx/qla_mbx.c

[PATCH 12/14] qla2xxx: Fix missing device login retries.

-off-by: Arun Easi arun.e...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_os.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 94d7a6d..aca6577 100644

Re: [PATCH 0/9] qla2xxx: Patches for scsi misc branch.

Hi Nic, On 7/23/15, 11:45 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Thu, 2015-07-23 at 23:38 -0700, Nicholas A. Bellinger wrote: Hi Himanshu Co, (Adding target-devel CC') On Wed, 2015-06-10 at 11:05 -0400, Himanshu Madhani wrote: Hi James, SNIP This series contains

Re: [PATCH 0/9] qla2xxx: Patches for scsi misc branch.

Hi Nic, James, On 7/24/15, 7:51 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Thu, 2015-07-23 at 23:38 -0700, Nicholas A. Bellinger wrote: Hi Himanshu Co, (Adding target-devel CC') On Wed, 2015-06-10 at 11:05 -0400, Himanshu Madhani wrote: Hi James, Please

Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ Looks Good. Acked-by: Himanshu Madhani himanshu.madh...@qlogic.com attachment: winmail.dat

[PATCH v2 3/8] qla2xxx: delay plogi/prli ack until existing sessions are deleted

sessions (unless deletion is already IN_PROGRESS): - different port_name, different port_id, but the same loop_id (without logout) Cc: sta...@vger.kernel.org Signed-off-by: Alexei Potashnik ale...@purestorage.com Acked-by: Quinn Tran quinn.t...@qlogic.com Signed-off-by: Himanshu Madhani

[PATCH v2 4/8] qla2xxx: Abort stale cmds on qla_tgt_wq when plogi arrives

From: Alexei Potashnik ale...@purestorage.com cancel any commands from initiator's s_id that are still waiting on qla_tgt_wq when PLOGI arrives. Cc: sta...@vger.kernel.org Signed-off-by: Alexei Potashnik ale...@purestorage.com Acked-by: Quinn Tran quinn.t...@qlogic.com Signed-off-by: Himanshu

[PATCH v2 5/8] qla2xxx: added sess generations to detect RSCN update races

. Cc: sta...@vger.kernel.org Signed-off-by: Alexei Potashnik ale...@purestorage.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_dbg.c|2 +- drivers/scsi/qla2xxx/qla_def.h|5 +++ drivers/scsi/qla2xxx/qla_init.c | 32

[PATCH v2 0/8] qla2xxx: Updates for Target Mode driver

Hi James, This series is applied on top of patch series sent on June 10 [PATCH 0/9] qla2xxx: Patches for scsi misc branch (http://marc.info/?l=linux-scsim=143395156920505w=2) These set of patches addresses issue with reuse of stale command found in a customer enviorment. Here's sequence of

[PATCH v2 6/8] qla2xxx: disable scsi_transport_fc registration in target mode

: sta...@vger.kernel.org Signed-off-by: Alexei Potashnik ale...@purestorage.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_init.c | 14 +++--- drivers/scsi/qla2xxx/qla_os.c |3 ++- 2 files changed, 13 insertions(+), 4 deletions(-) diff

[PATCH v2 7/8] qla2xxx: drop cmds/tmrs arrived while session is being deleted

session's commands will keep finding old session in the fcport map. This patch drops cmds/tmrs if they find session in the progress of being deleted. Cc: sta...@vger.kernel.org Signed-off-by: Alexei Potashnik ale...@purestorage.com Acked-by: Quinn Tran quinn.t...@qlogic.com Signed-off-by: Himanshu

[PATCH v2 2/8] qla2xxx: cleanup cmd in qla workqueue before processing TMR

quinn.t...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_dbg.c |2 +- drivers/scsi/qla2xxx/qla_def.h |5 ++ drivers/scsi/qla2xxx/qla_os.c |3 + drivers/scsi/qla2xxx/qla_target.c | 123

[PATCH v2 8/8] qla2xxx: terminate exchange when command is aborted by LIO

to the aborted_task handler. Changed iSCSI aborted_task logic to satisfy the above requirement. Cc: sta...@vger.kernel.org Signed-off-by: Alexei Potashnik ale...@purestorage.com Acked-by: Quinn Tran quinn.t...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi

[PATCH v2 1/8] qla2xxx: kill sessions/log out initiator on RSCN and port down events

Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_dbg.c|2 +- drivers/scsi/qla2xxx/qla_init.c | 137 ++--- drivers/scsi/qla2xxx/qla_target.c |9 ++- 3 files changed, 117 insertions(+), 31 deletions(-) diff --git

Re: [PATCH v3 0/10] qla2xxx: Fix various warnings reported by static source code analysis tools

compared to v1 of this series are: - Rebased this patch series onto kernel v4.1-rc6. - Also removed variable 'd2' in patch 3. - Also remove the recently introduced dead code in patch 10. Series Looks good Acked-by: Himanshu Madhani himanshu.madh...@qlogic.com attachment: winmail.dat

Re: [PATCH 2/2] qla2xxx: fix rwlock recursion

Hi Bart, On 10/14/15, 4:07 PM, "linux-scsi-ow...@vger.kernel.org on behalf of Himanshu Madhani" <linux-scsi-ow...@vger.kernel.org on behalf of himanshu.madh...@qlogic.com> wrote: >Hi Bart, > >> On Oct 14, 2015, at 10:33 AM, Bart Van Assche >><bart.vanass..

Re: [PATCH, RESEND] qla2xxx: Fix rwlock recursion

odule+0x92/0xc0 >kernel: [] entry_SYSCALL_64_fastpath+0x12/0x6f > >Fixes: 8dfa4b5a9b44 ("qla2xxx: Fix sparse annotation") >Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com> >Reported-by: Himanshu Madhani <himanshu.madh...@qlogic.com> >Test

[PATCH 0/2] qla2xxx: Patches for 4.3.0-rc5+ scsi "misc" branch.

Hi James, Christoph, Please apply the following patches to the scsi tree, misc branch at your earliest convenience. Thanks, -Himanshu Himanshu Madhani (2): qla2xxx: Remove unavailable firmware files qla2xxx: fix rwlock recursion drivers/scsi/qla2xxx/qla_nx.c | 58

[PATCH 2/2] qla2xxx: fix rwlock recursion

x10 kernel: [] ? module_sect_show+0x30/0x30 kernel: [] ? copy_module_from_user+0x8d/0xf0 kernel: [] SyS_init_module+0x92/0xc0 kernel: [] entry_SYSCALL_64_fastpath+0x12/0x6f Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com

[PATCH 1/2] qla2xxx: Remove unavailable firmware files

Remove firmware binary names for the ISPs, which are not submitted to linux-firmware Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> --- drivers/scsi/qla2xxx/qla_os.c | 29 --

Re: [PATCH 2/2] qla2xxx: fix rwlock recursion

Hi Bart, > On Oct 14, 2015, at 10:33 AM, Bart Van Assche <bart.vanass...@sandisk.com> > wrote: > > On 10/14/2015 08:57 AM, Himanshu Madhani wrote: >> This patch fixes rwlock recursion introduced for ISP82XX by >> commit 8dfa4b5a ("qla2xxx: Fix spars

Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

t;> >> >> What is state of this patch ? > >Apparently nobody cared, either from qLogic or linux-scsi. > >I'm not overly fussed whether it goes in or not, it was more a point >in the discussion that proceeded it, however it does solve the >problems in the discussion t

Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

Hi James, On 10/8/15, 9:17 AM, "James Bottomley" <james.bottom...@hansenpartnership.com> wrote: >On Thu, 2015-10-08 at 15:46 +0000, Himanshu Madhani wrote: >> >> On 10/7/15, 4:41 PM, "Julian Calaby" <julian.cal...@gmail.com> wrote: >>

Re: [PATCH 00/11] qla2xxx: Updates for Target Mode driver

Hi Nic, On 7/6/15, 6:16 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: Hi Himanshu Co, (Adding target-devel for the qla_target.c bits, please include this list for future target patches :-) Will do that for future submissions. On Thu, 2015-06-25 at 12:33 -0400, Himanshu Madhani

[PATCH] qla2xxx: Remove unavailable firmware files

Remove firmware binary names for the ISPs, which are not submitted to linux-firmware Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> Cc: Hannes Reinecke <h...@suse.de> Cc: Julian Calaby <julian

Re: [PATCH] target/qla2xxx: Honor max_data_sg_nents I/O transfer limit

Hi Nic, Sorry about the delay in response. I have tested with RHEL 6.5 and noticed that IO were not able to complete with 16M and 32M read/write. IO¹s were getting error due to Mid-layer underflow With initiator running upstream kernel version 4.2 as well I was seeing error with Mid-layer

Re: [PATCH 01/20] qla2xxx: Enable Extended Login support

On 12/8/15, 7:51 AM, "Hannes Reinecke" <h...@suse.de> wrote: >On 12/08/2015 01:48 AM, Himanshu Madhani wrote: >> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> >> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> >

[PATCH 09/20] qla2xxx: Change check_stop_free to always return 1

From: Quinn Tran <quinn.t...@qlogic.com> change tcm_qla2xxx_check_stop_free to always return 1 to prevent transport_cmd_finish_abort from accidently taking extra kref_put. Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.co

[PATCH 06/20] qla2xxx: Delete session if initiator is gone from FW

ertain scenarios it's impossible to tell whether command was received in logged in or logged out state. Signed-off-by: Alexei Potashnik <ale...@purestorage.com> Acked-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- driver

[PATCH 10/20] qla2xxx: Fix interaction issue between qla2xxx and Target Core Module

rmware. Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_target.c | 60 + drivers/scsi/qla2xxx/qla_target.h | 59 + drivers/scsi/qla2xxx/tc

[PATCH 03/20] qla2xxx: Enable Target counters in DebugFS.

Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c |2 +- drivers/scsi/qla2xxx/qla_def.h | 15 + drivers/scsi/qla2xxx/qla_dfs.

[PATCH 18/20] qla2xxx: Set all queues to 4k

From: Quinn Tran <quinn.t...@qlogic.com> set ATIO/Request/Response Queues and Default number of outstanding command to 4k. Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h |3

[PATCH 19/20] qla2xxx: Add bulk send for atio & ctio completion paths.

Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h |3 + drivers/scsi/qla2xxx/qla_isr.c |3 + drivers/scsi/qla2xxx/qla_target.c | 65 ++- dr

[PATCH 14/20] qla2xxx: Add irq affinity notification

From: Quinn Tran <quinn.t...@qlogic.com> Register to receive notification of when irq setting change occured. Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h|6 +++ dr

[PATCH 07/20] qla2xxx: Wait for all conflicts before ack'ing PLOGI

I ack being held by many sessions. Signed-off-by: Alexei Potashnik <ale...@purestorage.com> Acked-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c|4 +- drivers/scsi/qla2xxx/qla_def.h

[PATCH 05/20] qla2xxx: Added interface to send ELS commands from driver.

Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> --- drivers/scsi/qla2xxx/qla_attr.c | 36 +++ drivers/scsi/qla2xxx/qla_dbg.c|5 +- drivers/scsi/qla2xxx/qla_def.h| 19 - drivers/

[PATCH 04/20] qla2xxx: Add FW resource count in DebugFS.

7] MAX VP count[254] MAX FCF count[0] Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h | 13 +++-- drivers/scsi/qla2xxx/qla_dfs.c | 50

[PATCH 01/20] qla2xxx: Enable Extended Login support

Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c |9 +-- drivers/scsi/qla2xxx/qla_def.h | 13 - drivers/scsi/qla2xxx/qla_gbl.h |7 ++ drivers/scsi/qla2xx

[PATCH 20/20] qla2xxx: Check for online flag instead of active reset when transmitting responses

1, so ATIO's won't be missed and hence no need to process ATIO's after setting the online flag. Signed-off-by: Dilip Kumar Uppugandla <di...@purestorage.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/q

[PATCH 02/20] qla2xxx: Enable Exchange offload support.

Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c |9 +-- drivers/scsi/qla2xxx/qla_def.h | 12 - drivers/scsi/qla2xxx/qla_gbl.h |6 ++ drivers/scsi/qla2xx

[PATCH 00/20] qla2xxx: Patches for target-pending branch

before ack'ing PLOGI Dilip Kumar Uppugandla (1): qla2xxx: Check for online flag instead of active reset when transmitting responses Himanshu Madhani (4): qla2xxx: Enable Extended Login support qla2xxx: Enable Exchange offload support. qla2xxx: Enable Target counters in DebugFS. qla2xxx

[PATCH 17/20] qla2xxx: Disable ZIO at start time.

From: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_target.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --

[PATCH 12/20] target/tmr: LUN reset cause cmd premature free.

completion. - if cmd reach Fabric Layer at Lun Reset time, add an extra cmd_kref count to prevent premature free. Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/target/target_core_tmr.c | 33 +

[PATCH 15/20] qla2xxx: Add selective command queuing

From: Quinn Tran <quinn.t...@qlogic.com> queue work element to specific process lessen cache miss Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_isr.c |2 +- dr

[PATCH 11/20] qla2xxx: Add TAS detection for kernel 3.15 n newer

o_fw=0) Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_target.c | 36 +--- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 20 2 files changed, 37

[PATCH 16/20] qla2xxx: Move atioq to a different lock to reduce lock contention

Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h|1 + drivers/scsi/qla2xxx/qla_gbl.h|1 + drivers/scsi/qla2xxx/qla_init.c |6 ++- drivers/scsi/qla2xxx/q

[PATCH 08/20] qla2xxx: Replace QLA_TGT_STATE_ABORTED with a bit.

From: Quinn Tran <quinn.t...@qlogic.com> Replace QLA_TGT_STATE_ABORTED state with a bit because the current state of the command is lost when an abort is requested by upper layer. Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.mad

[PATCH 13/20] qla2xxx: Remove dependency on hardware_lock to reduce lock contention.

lock call sess_lock. This is done to reduce lock contention and increase traffic throughput. Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h |1 + drivers/scsi/qla2xxx/qla_os.c

Re: [patch] qla2xxx: fix a timeout loop

Hi Dan, On 12/16/15, 3:07 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Dan Carpenter" wrote: >After the loop we test for "if (!retries) " as a failure, but actually >the post-op here will end with retries set to -1.

[PATCH v2 14/16] qla2xxx: Set all queues to 4k

From: Quinn Tran <quinn.t...@qlogic.com> set ATIO/Request/Response Queues and Default number of outstanding command to 4k. Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h |3

[PATCH v2 09/16] qla2xxx: Remove dependency on hardware_lock to reduce lock contention.

lock call sess_lock. This is done to reduce lock contention and increase traffic throughput. Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h |1 + drivers/scsi/qla2xxx/qla_os.c

[PATCH v2 16/16] qla2xxx: Check for online flag instead of active reset when transmitting responses

1, so ATIO's won't be missed and hence no need to process ATIO's after setting the online flag. Signed-off-by: Dilip Kumar Uppugandla <di...@purestorage.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/q

[PATCH v2 15/16] qla2xxx: Add bulk send for atio & ctio completion paths.

Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h |3 ++ drivers/scsi/qla2xxx/qla_isr.c |3 ++ drivers/scsi/qla2xxx/qla_target.c | 65 - dr

[PATCH v2 11/16] qla2xxx: Add selective command queuing

From: Quinn Tran <quinn.t...@qlogic.com> queue work element to specific process lessen cache miss Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_isr.c |2 +- dr

[PATCH v2 07/16] qla2xxx: Wait for all conflicts before ack'ing PLOGI

I ack being held by many sessions. Signed-off-by: Alexei Potashnik <ale...@purestorage.com> Acked-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Reviewed-by: Hannes Reinecke <h...@suse.com> --- drivers/scsi/qla2xxx/qla_

[PATCH v2 12/16] qla2xxx: Move atioq to a different lock to reduce lock contention

Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h|1 + drivers/scsi/qla2xxx/qla_gbl.h|1 + drivers/scsi/qla2xxx/qla_init.c |6 ++- drivers/scsi/qla2xxx/q

[PATCH v2 10/16] qla2xxx: Add irq affinity notification

From: Quinn Tran <quinn.t...@qlogic.com> Register to receive notification of when irq setting change occured. Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h|6 +++ dr

[PATCH v2 13/16] qla2xxx: Disable ZIO at start time.

From: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_target.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --

  1   2   3   4   5   6   7   8   9   10   >