Re: [PATCH] phy: qcom-ufs: export symbols needed by main drivers

2015-02-02 Thread James Bottomley
On Wed, 2015-01-28 at 17:18 +0100, Arnd Bergmann wrote: The qcom ufs phy support is split into three separate loadable modules, however none of the interfaces are exported, resulting in a link error: ERROR: ufs_qcom_phy_power_off [drivers/phy/phy-qcom-ufs-qmp-20nm.ko] undefined! ERROR:

Re: linux-next: build failure after merge of the scsi tree

2015-02-04 Thread James Bottomley
On Wed, 2015-02-04 at 17:29 +1100, Stephen Rothwell wrote: Hi James, After merging the scsi tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: drivers/scsi/scsi_logging.c: In function 'sdev_prefix_printk': drivers/scsi/scsi_logging.c:119:6: error: void value not

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-08 Thread James Bottomley
On Sun, 2015-02-08 at 10:45 +0800, Greg KH wrote: On Sat, Feb 07, 2015 at 09:27:05PM -0500, Laurence Oberman wrote: Hello Its not going to be tens of thousands of devices. That count was an aggregate based on 1000's of servers. In reality its unlikely to ever be more than 100 tapes drives

Re: [PATCH] phy: qcom-ufs: export symbols needed by main drivers

2015-02-02 Thread James Bottomley
On Mon, 2015-02-02 at 17:26 +0100, h...@lst.de wrote: On Mon, Feb 02, 2015 at 03:30:27PM +, James Bottomley wrote: Cc added for linux-scsi, since this is the origin of the problem. How important is bisectability in this? It won't affect any non-embedded user, since most don't build

Re: [PATCH 1/1] be2iscsi: add block valid bit to iBFT flag

2015-01-15 Thread James Bottomley
On Thu, 2015-01-15 at 17:16 -0600, Mike Christie wrote: On 01/12/2015 05:05 PM, Minh Duc Tran wrote: From: Minh Duc Tran Sent: Sunday, November 09, 2014 10:52 PM To: 'linux-scsi@vger.kernel.org' Cc: Mike Christie (micha...@cs.wisc.edu); Jayamohan Kallickal Subject: [PATCH 1/1]

Re: module: fix module_refcount() return when running in a module exit routine

2015-01-20 Thread James Bottomley
On Tue, 2015-01-20 at 11:15 +1030, Rusty Russell wrote: James Bottomley james.bottom...@hansenpartnership.com writes: On Mon, 2015-01-19 at 16:21 +1030, Rusty Russell wrote: Masami Hiramatsu masami.hiramatsu...@hitachi.com writes: (2015/01/19 1:55), James Bottomley wrote: From: James

[GIT PULL] SCSI fixes for 3.19-rc4

2015-01-17 Thread James Bottomley
This is one fix for a Multiqueue sleeping in invalid context problem and a MAINTAINER file update for Qlogic. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Christoph Hellwig (1): scsi: -queue_rq can't sleep

Re: module: fix module_refcount() return when running in a module exit routine

2015-01-19 Thread James Bottomley
On Mon, 2015-01-19 at 00:28 -0800, Christoph Hellwig wrote: On Mon, Jan 19, 2015 at 04:21:15PM +1030, Rusty Russell wrote: The first one I think should be eliminated, and the second one is simply an assertion before calling module_put() (which should probably be eliminated). The others are

Re: module: fix module_refcount() return when running in a module exit routine

2015-01-19 Thread James Bottomley
On Mon, 2015-01-19 at 16:21 +1030, Rusty Russell wrote: Masami Hiramatsu masami.hiramatsu...@hitachi.com writes: (2015/01/19 1:55), James Bottomley wrote: From: James Bottomley jbottom...@parallels.com After e513cc1 module: Remove stop_machine from module unloading, module_refcount

Re: [PATCH 3/9] scsi: use external buffer for command logging

2015-01-14 Thread James Bottomley
On Wed, 2015-01-14 at 10:36 +0100, h...@lst.de wrote: On Tue, Jan 13, 2015 at 06:56:17PM +, James Bottomley wrote: I really hate using an on-stack buffer here ... we're pretty deep in the call chain already. Since it's just required for printing a command: prefix, why not just use

Re: [linux-devel:devel-lkp-ib03-powerpc-201501140043 30/31] drivers/scsi/scsi_logging.c:254:3: error: format not a string literal and no format arguments

2015-01-14 Thread James Bottomley
On Wed, 2015-01-14 at 01:40 -0800, Christoph Hellwig wrote: On Tue, Jan 13, 2015 at 05:30:20PM +, James Bottomley wrote: Just for everyone's sake the problem is printk format strings (and all the things that indirect there, like pr_xxx and dev_printk). We must never pass a mutable

Re: [PATCH 1/4] scsi: always use format argumets for dev_printk

2015-01-18 Thread James Bottomley
On Sun, 2015-01-18 at 16:11 +0100, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig h...@lst.de Thanks. Ideally I would have preferred them folded into the logging series, but if that's not going to be forthcoming, then this works. For the series: Reviewed-by: James Bottomley jbottom

Re: [PATCH for kernel 3.19] Avoid that scsi_device_put() triggers a kernel warning

2015-01-18 Thread James Bottomley
On Sun, 2015-01-18 at 16:22 +, James Bottomley wrote: On Mon, 2015-01-05 at 12:03 +0100, Bart Van Assche wrote: Avoid that the following warning is reported when a SCSI LLD kernel module is unloaded: WARNING: CPU: 5 PID: 228 at kernel/module.c:954 module_put+0x207/0x220() Call

module: fix module_refcount() return when running in a module exit routine

2015-01-18 Thread James Bottomley
From: James Bottomley jbottom...@parallels.com After e513cc1 module: Remove stop_machine from module unloading, module_refcount() is returning (unsigned long)-1 when called from within a routine that runs in module_exit. This is confusing the scsi device put code which is coded to detect

Re: [PATCH for kernel 3.19] Avoid that scsi_device_put() triggers a kernel warning

2015-01-18 Thread James Bottomley
On Mon, 2015-01-05 at 12:03 +0100, Bart Van Assche wrote: Avoid that the following warning is reported when a SCSI LLD kernel module is unloaded: WARNING: CPU: 5 PID: 228 at kernel/module.c:954 module_put+0x207/0x220() Call Trace: [814d1fcf] dump_stack+0x4c/0x65

Re: module: fix module_refcount() return when running in a module exit routine

2015-01-22 Thread James Bottomley
On Thu, 2015-01-22 at 08:50 -0800, Christoph Hellwig wrote: On Tue, Jan 20, 2015 at 09:23:35AM -0800, James Bottomley wrote: On Tue, 2015-01-20 at 11:15 +1030, Rusty Russell wrote: James Bottomley james.bottom...@hansenpartnership.com writes: On Mon, 2015-01-19 at 16:21 +1030, Rusty

Re: [PATCH] hpsa: correct compiler warnings introduced by hpsa-add-local-workqueue patch

2015-02-10 Thread James Bottomley
On Fri, 2015-02-06 at 17:44 -0600, Don Brace wrote: Correct compiler warning introduced by hpsa-add-local-workqueue patch 6636e7f455b33b957c5ee016daa6de46148026ab hpsa: Use local workqueues instead of system workqueues Suggested-by: Kees Cook keesc...@chromium.org Reviewed-by: Scott Teel

Re: [patch 069/104] lib/string_helpers.c:string_get_size(): remove redundant prefixes

2015-02-12 Thread James Bottomley
On Thu, 2015-02-12 at 15:01 -0800, a...@linux-foundation.org wrote: From: Rasmus Villemoes li...@rasmusvillemoes.dk Subject: lib/string_helpers.c:string_get_size(): remove redundant prefixes While 3c9f3681d0b4 [SCSI] lib: add generic helper to print sizes rounded to the correct SI range says

Re: [patch 069/104] lib/string_helpers.c:string_get_size(): remove redundant prefixes

2015-02-12 Thread James Bottomley
On Thu, 2015-02-12 at 15:40 -0800, Andrew Morton wrote: On Thu, 12 Feb 2015 15:25:08 -0800 James Bottomley james.bottom...@hansenpartnership.com wrote: On Thu, 2015-02-12 at 15:01 -0800, a...@linux-foundation.org wrote: From: Rasmus Villemoes li...@rasmusvillemoes.dk Subject: lib

Re: Concerns about mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2015-02-19 Thread James Bottomley
On Fri, 2015-02-20 at 16:22 +1100, Benjamin Herrenschmidt wrote: On Fri, 2015-02-20 at 16:06 +1100, Benjamin Herrenschmidt wrote: Note that even on powerpc platforms where it would work because we maintain both 32-bit and 64-bit bypass windows in the device address space simultaneously,

Re: module: fix module_refcount() return when running in a module exit routine

2015-01-28 Thread James Bottomley
On Wed, 2015-01-28 at 10:23 +0100, Bart Van Assche wrote: On 01/23/15 19:42, James Bottomley wrote: diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 08c90a7..31ba254 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -965,6 +965,15 @@ int scsi_report_opcode(struct

Re: [PATCH 0/17] Clear up bidi command confusion

2015-01-29 Thread James Bottomley
On Thu, 2015-01-29 at 15:00 +0200, Boaz Harrosh wrote: On 01/23/2015 03:12 PM, Christoph Hellwig wrote: On Fri, Jan 23, 2015 at 01:05:30PM +0100, Bart Van Assche wrote: There is some confusion in the SCSI core and in SCSI LLDs around the meaning of sc_data_direction and whether or not this

Re: [PATCH 3/3] scsi: proper state checking and module refcount handling in scsi_device_get

2015-01-29 Thread James Bottomley
On Thu, 2015-01-29 at 00:00 +0100, Christoph Hellwig wrote: This effectively reverts commits 85b6c7 ([SCSI] sd: fix cache flushing on module removal (and individual device removal) and dc4515ea (scsi: always increment reference count). We now never call scsi_device_get from the shutdown

Re: [Lsf-pc] [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread James Bottomley
On Thu, 2015-01-08 at 21:03 -0800, Nicholas A. Bellinger wrote: On Thu, 2015-01-08 at 15:22 -0800, James Bottomley wrote: On Thu, 2015-01-08 at 14:57 -0800, Nicholas A. Bellinger wrote: On Thu, 2015-01-08 at 14:29 -0800, James Bottomley wrote: On Thu, 2015-01-08 at 14:16 -0800, Nicholas

Re: [Lsf-pc] [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-09 Thread James Bottomley
On Fri, 2015-01-09 at 19:28 +0100, Hannes Reinecke wrote: [...] I think you are assuming we are leaving the iscsi code as it is today. For the non-MCS mq session per CPU design, we would be allocating and binding the session and its resources to specific CPUs. They would only be

Re: [PATCH 2/3] scsi: Move user-shareable stuff in scsi/scsi.h to uapi/scsi/scsi.h

2015-01-09 Thread James Bottomley
On Fri, 2015-01-09 at 17:01 +0100, Christoph Hellwig wrote: On Fri, Jan 09, 2015 at 07:50:38AM -0800, James Bottomley wrote: Right, that's why I'm dubious about this effort. uapi files either have to become the glibc headers or be exported in a way that allows inclusion into glibc headers

Re: [PATCH 2/3] scsi: Move user-shareable stuff in scsi/scsi.h to uapi/scsi/scsi.h

2015-01-09 Thread James Bottomley
On Fri, 2015-01-09 at 18:11 +0100, Christoph Hellwig wrote: On Fri, Jan 09, 2015 at 08:33:00AM -0800, James Bottomley wrote: Yes, but they have to be delivered to users somehow. If you look at debian, they deliver the headers through the linux-dev-libc package which installs into the /usr

Re: [PATCH 2/3] scsi: Move user-shareable stuff in scsi/scsi.h to uapi/scsi/scsi.h

2015-01-09 Thread James Bottomley
On Fri, 2015-01-09 at 11:14 +0100, Christoph Hellwig wrote: On Thu, Jan 08, 2015 at 11:47:58AM -0800, Andy Grover wrote: A great many SCSI codes and ioctl values can be made available to userspace in a uapi header, while the kernel-only definitions stay in scsi/scsi.h. scsi/scsi.h also

Re: [PATCH 2/3] scsi: Move user-shareable stuff in scsi/scsi.h to uapi/scsi/scsi.h

2015-01-09 Thread James Bottomley
On Fri, 2015-01-09 at 16:46 +0100, Christoph Hellwig wrote: On Fri, Jan 09, 2015 at 07:27:46AM -0800, James Bottomley wrote: Actually, they are exported. If you look at what glibc supplies, it has it's own copies of scsi.h and scsi_ioctl.h. If we try to repace those with uapi, we have

[GIT PULL] SCSI fixes for 3.19-rc2

2015-01-09 Thread James Bottomley
Just one fix: a qlogic busy wait regression. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Bruno Prémont (1): qla2xxx: fix busy wait regression And the diffstat: drivers/scsi/qla2xxx/qla_os.c | 4 +++- 1

Re: [linux-devel:devel-lkp-ib03-powerpc-201501140043 30/31] drivers/scsi/scsi_logging.c:254:3: error: format not a string literal and no format arguments

2015-01-13 Thread James Bottomley
On Wed, 2015-01-14 at 01:21 +0800, kbuild test robot wrote: Hi Wu, FYI, this happens on a merge commit, which indicates conflicting changes with one of the below merged branches. d48f782 Merge 'scsi/for-next' into devel-lkp-ib03-powerpc-201501140043 c03f620 Merge 'sound/for-next' into

Re: [PATCH 1/9] scsi: Implement per-cpu logging buffer

2015-01-13 Thread James Bottomley
On Thu, 2015-01-08 at 07:43 +0100, Hannes Reinecke wrote: - sdev_printk(prefix, (scmd)-device, fmt, ##a) +extern int sdev_prefix_printk(const char *, const struct scsi_device *, + const char *, const char *, ...); + +#define sdev_printk(l, sdev, fmt, a...)

Re: [PATCH 3/9] scsi: use external buffer for command logging

2015-01-13 Thread James Bottomley
On Thu, 2015-01-08 at 07:43 +0100, Hannes Reinecke wrote: Use an external buffer for __scsi_print_command() and move command logging over to use the per-cpu logging buffer. With that we can guarantee the command always will always be formatted in one line. So we can even print out a variable

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread James Bottomley
On Thu, 2015-01-08 at 14:16 -0800, Nicholas A. Bellinger wrote: On Thu, 2015-01-08 at 08:50 +0100, Bart Van Assche wrote: On 01/07/15 22:39, Mike Christie wrote: On 01/07/2015 10:57 AM, Hannes Reinecke wrote: On 01/07/2015 05:25 PM, Sagi Grimberg wrote: Hi everyone, Now that

Re: scsi: Implement per-cpu logging buffer

2015-02-14 Thread James Bottomley
On Sat, 2015-02-14 at 15:29 +0100, Hannes Reinecke wrote: On 02/13/2015 04:45 PM, Josh Triplett wrote: On Fri, Feb 13, 2015 at 09:48:36AM +0100, Hannes Reinecke wrote: On 02/12/2015 06:18 PM, Josh Triplett wrote: On Thu, Feb 12, 2015 at 02:29:35PM +0100, Hannes Reinecke wrote: On

[GIT PULL] First round of SCSI updates for the 3.19+ merge window

2015-02-09 Thread James Bottomley
This is the usual grab bag of driver updates (hpsa, storvsc, mp2sas, megaraid_sas, ses) plus an assortment of minor updates. There's also an update to ufs which adds new phy drivers and finally a new logging infrastructure for SCSI. The patch is available here:

Re: [PATCH] [RESEND] wd719x: add missing .module to wd719x_template

2015-02-12 Thread James Bottomley
On Mon, 2015-02-09 at 13:38 +0100, Ondrej Zary wrote: wd719x_template is missing the .module field, causing module refcount not to work, allowing to rmmod the driver while in use (mounted filesystem), causing an oops. Set .module to THIS_MODULE to fix the problem. This requires a cc to

Re: [patch 069/104] lib/string_helpers.c:string_get_size(): remove redundant prefixes

2015-02-13 Thread James Bottomley
On Thu, 2015-02-12 at 15:55 -0800, Andrew Morton wrote: On Thu, 12 Feb 2015 15:45:29 -0800 James Bottomley james.bottom...@hansenpartnership.com wrote: ... I don't get it. As the man says, this is presently dead code and string_get_size() will need to be changed to work for disks

Re: [patch 069/104] lib/string_helpers.c:string_get_size(): remove redundant prefixes

2015-02-13 Thread James Bottomley
On Fri, 2015-02-13 at 17:02 -0800, Andrew Morton wrote: On Fri, 13 Feb 2015 16:05:54 -0800 James Bottomley james.bottom...@hansenpartnership.com wrote: @@ -42,31 +44,60 @@ void string_get_size(u64 size, const enum string_size_units units, [STRING_UNITS_2] = 1024

Re: [PATCH] fixed invalid assignment of 64bit mask to host dma_boundary for scatter gather segment boundary limit.

2015-02-15 Thread James Bottomley
On Mon, 2015-02-09 at 18:54 +, Minh Duc Tran wrote: In reference to bug https://bugzilla.redhat.com/show_bug.cgi?id=1097141 Assert is seen with AMD cpu whenever calling pci_alloc_consistent. [ 29.406183] [ cut here ] [ 29.410505] kernel BUG at

[GIT PULL] SCSI fixes for 3.19-rc7

2015-02-05 Thread James Bottomley
This patch set is fixing two serious problems which have turned up late in the release cycle. The first fixes a problem with 4k sector disks where the transfer length (amount of data sent to the disk) was getting increased every time the disk was revalidated leading to potential for overflows.

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread James Bottomley
On Thu, 2015-02-05 at 19:46 +0200, Kai Mäkisara (Kolumbus) wrote: On 5.2.2015, at 19.40, Laurence Oberman lober...@redhat.com wrote: I missed the earlier conversations with James, I will go search for them. Do you mean add them so they are similar to the /proc/diskstats cat

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread James Bottomley
. I missed the earlier conversations with James, I will go search for them. Do you mean add them so they are similar to the /proc/diskstats http://comments.gmane.org/gmane.linux.scsi/80497 On Fri, Feb 22 2013 James Bottomley wrote: I'm afraid we can't do it the way you're proposing

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread James Bottomley
On Wed, 2015-01-07 at 15:39 -0600, Mike Christie wrote: On 01/07/2015 10:57 AM, Hannes Reinecke wrote: On 01/07/2015 05:25 PM, Sagi Grimberg wrote: Hi everyone, Now that scsi-mq is fully included, we need an iSCSI initiator that would use it to achieve scalable performance. The need is

Re: [PATCH 3/3] scsi: Remove scsi_ioctl.h

2015-01-08 Thread James Bottomley
On Thu, 2015-01-08 at 11:47 -0800, Andy Grover wrote: Now that we have uapi/scsi/scsi.h, that is the logical place for SCSI ioctl definitions to go. The kernel-specific stuff that remains is so little that it can be folded into scsi/scsi.h, and scsi_ioctl.h removed. Remove all scsi_ioctl.h

Re: [PATCH 0/7] aacraid driver updates

2015-03-16 Thread James Bottomley
On Mon, 2015-03-16 at 11:24 +, Mahesh Rajashekhara wrote: Hi James, Can you please let me know the status of this patch set which I submitted sometime back. We're following this: http://marc.info/?l=linux-scsim=142556689315114 So you need a review. James -- To unsubscribe from this

Re: [ANNOUNCE] xfs: Supporting Host Aware SMR Drives

2015-03-16 Thread James Bottomley
[cc to linux-scsi added since this seems relevant] On Mon, 2015-03-16 at 17:00 +1100, Dave Chinner wrote: Hi Folks, As I told many people at Vault last week, I wrote a document outlining how we should modify the on-disk structures of XFS to support host aware SMR drives on the (long) plane

Re: [PATCH RESUBMIT] Enclosure: fix WARN ON when doing dlpar removing an adapter in dual patch devices

2015-03-18 Thread James Bottomley
On Wed, 2015-03-18 at 17:18 -0500, wenxi...@linux.vnet.ibm.com wrote: From: Wen Xiong wenxi...@linux.vnet.ibm.com Hi James, Our test teams still see lots of these errors in error log when dlpar removing the adapter in dual configuration. So I re-submit the patch. OK so in this case you

Re: [ANNOUNCE] xfs: Supporting Host Aware SMR Drives

2015-03-16 Thread James Bottomley
On Mon, 2015-03-16 at 12:23 -0600, Adrian Palmer wrote: [...] == Data zones What we need is a mechanism for tracking the location of zones (i.e. start LBA), free space/write pointers within each zone, and some way of keeping track of that information across mounts. If we assign a

Re: [PATCH 01/21] lpfc: Fix the iteration count to match the 30 sec comment

2015-03-09 Thread James Bottomley
the information in the form I need. Thanks, James -- james On 3/7/2015 11:44 AM, James Bottomley wrote: On Thu, 2015-02-05 at 14:23 -0500, James Smart wrote: --- Could you put the signoffs (and any changelog) above here, please. You seem to be using git to generate the patches, so if you

Re: [PATCH 3.4.106] SCSI: libsas: no expander revalidation for SAS_END_DEV

2015-03-05 Thread James Bottomley
On Thu, 2015-03-05 at 18:57 +, Praveen Murali wrote: The kernel crashed in mutex_lock called from smp_execute_task. The reason is that the mutex is initialized only for devices with type EDGE_DEV or FANOUT_DEV, but in some cases smp_execute_task gets called in the expander revalidation

Re: [PATCH 01/21] lpfc: Fix the iteration count to match the 30 sec comment

2015-03-07 Thread James Bottomley
On Thu, 2015-02-05 at 14:23 -0500, James Smart wrote: --- Could you put the signoffs (and any changelog) above here, please. You seem to be using git to generate the patches, so if you just put them in the git change log the right thing will happen. If you don't do this, all your patches have

Re: [PATCH 06/21] lpfc: Fix host reset escalation killing all IOs.

2015-03-07 Thread James Bottomley
On Thu, 2015-02-05 at 14:23 -0500, James Smart wrote: --- This one really requires more than a one-line explanation because the one liner doesn't really describe what you've done. It looks like the description should be: Only the SLI rev 4 card has a host reset capability, so only activate it

Re: [PATCH 09/21] lpfc: Parse the new 20G, 25G and 40G link speeds in the lpfc driver

2015-03-07 Thread James Bottomley
On Thu, 2015-02-05 at 14:24 -0500, James Smart wrote: --- drivers/scsi/lpfc/lpfc_hw4.h | 5 - drivers/scsi/lpfc/lpfc_init.c | 39 +++ 2 files changed, 31 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_hw4.h

Re: [PATCH 14/21] lpfc: Fix premature release of rpi bit in bitmask

2015-03-07 Thread James Bottomley
On Thu, 2015-02-05 at 14:25 -0500, James Smart wrote: --- This is a bit big for an empty explanation. You're adding a lot of unexplained debug statements, but your own words in the comment seem to be the best changelog: + * lpfc_sli4_unreg_rpi_cmpl_clr - mailbox completion handler + * @phba:

Re: [Lsf] [TOPIC] scsi-queue tree past and future

2015-03-06 Thread James Bottomley
On Fri, 2015-03-06 at 20:22 -0800, Davidlohr Bueso wrote: On Thu, 2015-03-05 at 06:48 -0800, James Bottomley wrote: On Thu, 2015-03-05 at 14:31 +0100, Christoph Hellwig wrote: For about 8 month I've merged almost every scsi commit through the scsi-queue staging tree, and it seems to have

[GIT PULL] SCSI fixes for 4.0-rc3

2015-03-14 Thread James Bottomley
This is a simple fix for a domain revalidation crash which has recently turned up in the libsas code (applies to mvsas, isc and aic94xx). The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: James Bottomley (1

Re: [PATCH 61/86] scsi/qla1280: use uapi/linux/pci_ids.h directly

2015-03-29 Thread James Bottomley
On Sun, 2015-03-29 at 16:36 +0200, Michael S. Tsirkin wrote: On Sun, Mar 29, 2015 at 05:03:36PM +0300, James Bottomley wrote: On Sun, 2015-03-29 at 15:42 +0200, Michael S. Tsirkin wrote: Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, use the new header directly so we can drop

[PATCH] change SCSI Maintainer email

2015-04-01 Thread James Bottomley
We've recently suffered a rebranding and the Service Provider half of Parallels has become Odin. This means my email has changed so update the MAINTAINERS file (and tidy up the pointers to our git trees to be correct). Signed-off-by: James Bottomley jbottom...@odin.com --- diff --git

Re: [PATCH] am53c974: Fix crash during modprobe

2015-03-27 Thread James Bottomley
On Fri, 2015-03-27 at 08:29 +0100, Hannes Reinecke wrote: On systems with shared interrupts the interrupt routine might be called as soon as the interrupt is enabled. As this might happen before pci_set_drvdata() is called the system would crash. Reported-by: Andreas Brogle an...@ok.de

Re: [PATCH v7 2/3] scsi: ufs: add debugfs for ufs

2015-03-27 Thread James Bottomley
On Thu, 2015-03-12 at 17:54 +0200, Gilad Broner wrote: From: Lee Susman lsus...@codeaurora.org Adding debugfs capability for ufshcd. This patch fails to build as a module because you aren't building corectly: ERROR: ufsdbg_add_debugfs [drivers/scsi/ufs/ufshcd.ko] undefined! ERROR:

Re: [PATCH 61/86] scsi/qla1280: use uapi/linux/pci_ids.h directly

2015-03-29 Thread James Bottomley
On Sun, 2015-03-29 at 15:42 +0200, Michael S. Tsirkin wrote: Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, use the new header directly so we can drop the wrapper in include/linux/pci_ids.h. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/scsi/qla1280.c | 2 +-

Re: [libsas] Kernel Crash in smp_execute_task

2015-03-04 Thread James Bottomley
On Wed, 2015-03-04 at 23:29 +, Praveen Murali wrote: On second thoughts, should we even let smp commands/requests thru for sas end devices (dev-dev_type == SAS_END_DEV) ? if so, wont the following patch more sense? (also, in my last mail the kernel logs were all messed up; sorry dint

Re: [TOPIC] scsi-queue tree past and future

2015-03-05 Thread James Bottomley
On Thu, 2015-03-05 at 14:31 +0100, Christoph Hellwig wrote: For about 8 month I've merged almost every scsi commit through the scsi-queue staging tree, and it seems to have worked out well enough. I've been too busy for the next cycle, so 4.1 will probably have to live without it. I'd like

[GIT PULL] Final round of SCSI updates for the 3.19+ merge window

2015-02-21 Thread James Bottomley
This is a short patch set representing a couple of left overs from the merge window (debug leftover removal and MAINTAINER changes) plus one merge window regression (the local workqueue for hpsa) and a set of bug fixes for several issues (two for scsi-mq and the rest an assortment of long standing

Re: [PATCH 5/8] target: Add sanity checks for DPO/FUA bit usage

2015-02-22 Thread James Bottomley
On Sun, 2015-02-22 at 15:19 -0500, Douglas Gilbert wrote: On 15-02-22 11:41 AM, Christoph Hellwig wrote: On Sat, Feb 14, 2015 at 03:27:40AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a sbc_check_dpofua() function that performs sanity

[PATCH] sd, mmc, virtio_blk, string_helpers: fix block size units

2015-03-05 Thread James Bottomley
From: James Bottomley jbottom...@parallels.com The current string_get_size() overflows when the device size goes over 2^64 bytes because the string helper routine computes the suffix from the size in bytes. However, the entirety of Linux thinks in terms of blocks, not bytes, so

Re: [PATCHv2 5/5] scsi: move scsi/sg.h to uapi/linux/sg.h

2015-01-29 Thread James Bottomley
On Thu, 2015-01-29 at 16:56 -0800, Andy Grover wrote: This will enable user programs to have access to the most current definitions. Modify include sites for new path. Signed-off-by: Andy Grover agro...@redhat.com --- block/bio.c| 2 +- block/blk-map.c

Re: [PATCHv2 3/5] scsi: Move user-shareable stuff in scsi/scsi.h to uapi/linux/scsi.h

2015-01-29 Thread James Bottomley
On Thu, 2015-01-29 at 16:56 -0800, Andy Grover wrote: A great many SCSI codes can be made available to userspace in a uapi header, while the kernel-only definitions stay in scsi/scsi.h. This will permit userspace apps to stop using the antiquated definitions available in glibc's scsi/scsi.h,

Re: Concerns about mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2015-04-02 Thread James Bottomley
On Thu, 2015-04-02 at 16:39 +1100, Benjamin Herrenschmidt wrote: On Thu, 2015-02-19 at 21:45 -0800, James Bottomley wrote: Ben, this is legal by design. It was specifically designed for the aic79xx SCSI card, but can be used for a variety of other reasons. The aic79xx hardware problem

Re: [PATCH 19/23] advansys: Remove cmd_per_lun setting

2015-04-26 Thread James Bottomley
On Sun, 2015-04-26 at 16:57 +0200, Ondrej Zary wrote: On Friday 24 April 2015 13:18:38 Hannes Reinecke wrote: Ancient, and pretty much obsolete by now. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/advansys.c | 18 -- 1 file changed, 18 deletions(-)

Re: [PATCH 1/3] block: Return error in rescan_partitions if revalidating disk failed

2015-04-21 Thread James Bottomley
On Tue, 2015-03-24 at 18:16 +0800, Fam Zheng wrote: If the disk can't read capacity, we should return an error. I'm not sure I buy this: you need to justify why. For instance removable media return an error in revalidate that causes the medium not present flag to be set ... do we really want to

Re: [PATCH, RFC] scsi: use host wide tags by default

2015-04-20 Thread James Bottomley
On Fri, 2015-04-17 at 16:40 -0600, Jens Axboe wrote: On 04/17/2015 04:20 PM, James Bottomley wrote: On Fri, 2015-04-17 at 16:07 -0600, Jens Axboe wrote: On 04/17/2015 03:57 PM, James Bottomley wrote: On Fri, 2015-04-17 at 15:47 -0600, Jens Axboe wrote: On 04/17/2015 03:46 PM, James

Re: [PATCH RESEND 13/18] megaraid_sas : add endianess conversions for all ones

2015-04-20 Thread James Bottomley
On Mon, 2015-04-20 at 18:04 +0530, sumit.sax...@avagotech.com wrote: Add noop conversions for all ones to make sparse happy. Signed-off-by: Christoph Hellwig h...@lst.de This isn't the right way to resend someone else's patch: it needs a From: Christoph Hellwig h...@lst.de At the top and a

[GIT PULL] SCSI fixes for the 4.0+ merge window

2015-04-19 Thread James Bottomley
and that now triggers a WARN_ON(). The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-misc The Short Changelog is Christoph Hellwig (1): megaraid_sas: use raw_smp_processor_id() Hannes Reinecke (1): am53c974: Fix crash during modprobe James

Re: [PATCH] scatterlist: enable sg chaining for all architectures

2015-04-28 Thread James Bottomley
On Wed, 2015-04-29 at 09:34 +0900, Akinobu Mita wrote: 2015-04-29 7:16 GMT+09:00 James Bottomley james.bottom...@hansenpartnership.com: On Tue, 2015-04-28 at 14:27 -0700, Andrew Morton wrote: On Sat, 25 Apr 2015 23:56:16 +0900 Akinobu Mita akinobu.m...@gmail.com wrote: Some

[PATCH] scsi_scan: fix queue depth initialisation problem

2015-04-28 Thread James Bottomley
From: James Bottomley jbottom...@odin.com Date: Sun, 26 Apr 2015 11:52:46 -0700 Subject: [PATCH] scsi_scan: fix queue depth initialisation problem Currently we blindly use the value of cmd_per_lun as the initial setting for queue_depth. This fails miserably (hangs the system) if it is zero

Re: [PATCH] sd: always retry READ CAPACITY for ALUA state transition

2015-04-28 Thread James Bottomley
On Mon, 2015-04-27 at 11:35 +0200, Hannes Reinecke wrote: During ALUA state transitions the device might return a sense code 02/04/0a (Logical unit not accessible, asymmetric access state transition). As this is a transient error we should just retry the READ CAPACITY call until the state

Re: [PATCH] scatterlist: enable sg chaining for all architectures

2015-04-28 Thread James Bottomley
On Tue, 2015-04-28 at 14:27 -0700, Andrew Morton wrote: On Sat, 25 Apr 2015 23:56:16 +0900 Akinobu Mita akinobu.m...@gmail.com wrote: Some architectures enable sg chaining option while others do not. The requirement to enable sg chaining is that pages must be aligned at a 32-bit

Re: [PATCH 19/23] advansys: Remove cmd_per_lun setting

2015-04-28 Thread James Bottomley
On Mon, 2015-04-27 at 09:02 +0200, Hannes Reinecke wrote: On 04/26/2015 08:52 PM, James Bottomley wrote: On Sun, 2015-04-26 at 16:57 +0200, Ondrej Zary wrote: On Friday 24 April 2015 13:18:38 Hannes Reinecke wrote: Ancient, and pretty much obsolete by now. Signed-off-by: Hannes Reinecke

Re: [PATCH] mpt2sas: Fall back to 64 bit coherent mask if 64 bit DMA / 32 bit coherent mask not supported

2015-05-13 Thread James Bottomley
On Wed, 2015-05-13 at 15:31 +0200, Arnd Bergmann wrote: On Wednesday 13 May 2015 08:23:41 Brian King wrote: On 05/13/2015 03:10 AM, Arnd Bergmann wrote: On Tuesday 12 May 2015 18:24:43 Brian King wrote: Commit 5fb1bf8aaa832e1e9ca3198de7bbecb8eff7db9c broke 64 bit DMA for mpt2sas on

Re: mvsas panics and dies when attached to a port extender on newer kernels

2015-04-15 Thread James Bottomley
On Tue, 2015-04-14 at 14:41 -0700, Adam Talbot wrote: Removing the sas expander and attaching the SATA drives directly works just fine. I had to limp along with the drives direct attached for a while, while debugging. Well, that narrows it down. It looks like there's a longstanding bug in

[GIT PULL] SCSI updates for the 4.0+ merge window

2015-04-16 Thread James Bottomley
by static checker. James Bottomley (2): change SCSI Maintainer email sd, mmc, virtio_blk, string_helpers: fix block size units James Smart (21): lpfc: Update version to 10.5.0.0 for upstream patch set lpfc: Update copyright to 2015 lpfc: Fix for lun discovery issue

Re: mvsas panics and dies when attached to a port extender on newer kernels

2015-04-16 Thread James Bottomley
On Thu, 2015-04-16 at 10:26 -0700, Adam Talbot wrote: Wow, I forgot how long it takes to compile a full kernel. Glad I ran Gentoo for a few years and knew how to compile and apply patches. I will admit I had to dust off some mental cobwebs. Pre-patched 4.0.0 kernel tree: Oops, as expected

Re: [scsi:misc 14/106] drivers/scsi/storvsc_drv.c:1658 storvsc_queuecommand() warn: curly braces intended?

2015-04-13 Thread James Bottomley
On Mon, 2015-04-13 at 14:56 +0300, Dan Carpenter wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc head: 0351b8f81392c6d036e5c8f73ceff68726e9 commit: be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 [14/106] scsi: storvsc: Set the tablesize based on the information

Re: [PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups

2015-04-13 Thread James Bottomley
On Mon, 2015-04-13 at 10:06 -0400, Joe Lawrence wrote: On 04/12/2015 08:54 PM, James Bottomley wrote: On Sun, 2015-04-12 at 20:11 -0400, Joe Lawrence wrote: On 12/30/2014 09:07 AM, Joe Lawrence wrote: A colleague noticed that the mpt2 and mpt3sas drivers do not correctly check the PCI

Re: [PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups

2015-04-12 Thread James Bottomley
On Sun, 2015-04-12 at 20:11 -0400, Joe Lawrence wrote: On 12/30/2014 09:07 AM, Joe Lawrence wrote: A colleague noticed that the mpt2 and mpt3sas drivers do not correctly check the PCI master abort pattern in _base_wait_for_doorbell_ack. This pattern should be checked *prior* to any valid

Re: [PATCH, RFC] scsi: use host wide tags by default

2015-04-17 Thread James Bottomley
On Fri, 2015-04-17 at 22:11 +0200, Christoph Hellwig wrote: diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c index 82abfce..941a424 100644 --- a/drivers/scsi/53c700.c +++ b/drivers/scsi/53c700.c @@ -325,7 +325,6 @@ NCR_700_detect(struct scsi_host_template *tpnt,

Re: [PATCH, RFC] scsi: use host wide tags by default

2015-04-17 Thread James Bottomley
On Fri, 2015-04-17 at 15:47 -0600, Jens Axboe wrote: On 04/17/2015 03:46 PM, James Bottomley wrote: On Fri, 2015-04-17 at 15:44 -0600, Jens Axboe wrote: On 04/17/2015 03:42 PM, James Bottomley wrote: @@ -662,32 +662,14 @@ void scsi_finish_command(struct scsi_cmnd *cmd) */ int

Re: [PATCH, RFC] scsi: use host wide tags by default

2015-04-17 Thread James Bottomley
On Fri, 2015-04-17 at 15:44 -0600, Jens Axboe wrote: On 04/17/2015 03:42 PM, James Bottomley wrote: @@ -662,32 +662,14 @@ void scsi_finish_command(struct scsi_cmnd *cmd) */ int scsi_change_queue_depth(struct scsi_device *sdev, int depth) { - unsigned long flags

Re: [PATCH, RFC] scsi: use host wide tags by default

2015-04-17 Thread James Bottomley
On Fri, 2015-04-17 at 16:07 -0600, Jens Axboe wrote: On 04/17/2015 03:57 PM, James Bottomley wrote: On Fri, 2015-04-17 at 15:47 -0600, Jens Axboe wrote: On 04/17/2015 03:46 PM, James Bottomley wrote: On Fri, 2015-04-17 at 15:44 -0600, Jens Axboe wrote: On 04/17/2015 03:42 PM, James

Re: mvsas panics and dies when attached to a port extender on newer kernels

2015-04-14 Thread James Bottomley
On Tue, 2015-04-14 at 14:03 -0700, Adam Talbot wrote: To make a very long debugging story short, I think there is an issues/bug with the mvsas driver. It works, with older kernels, and breaks on newer kernels. My Debian Jessie system was running great on a 3.18 kernel. Changed cases to a

Re: Has anyone seen this?

2015-04-14 Thread James Bottomley
On Tue, 2015-04-14 at 19:52 +0300, Sagi Grimberg wrote: When I set up a DIX enabled device for the first time (say scsi_debug) it all works, but when I remove it and set it up again I get the below crash: Reproducer: $modprobe scsi_debug dif=1 dix=1 $modprobe -r scsi_debug $modprobe

Re: [PATCHv2] libsas: Fixup transport protocol definition in sas_get_ata_info()

2015-04-07 Thread James Bottomley
On Tue, 2015-04-07 at 17:45 +0200, Christoph Hellwig wrote: On Tue, Apr 07, 2015 at 10:49:07AM +0200, Hannes Reinecke wrote: 'tproto' specifies the transport protocol, not the device type. So use the correct definitions here. Signed-off-by: Hannes Reinecke h...@suse.de This looks

Re: smp_processor_id warning in megasas driver on 3.19.3

2015-04-08 Thread James Bottomley
On Wed, 2015-04-08 at 11:26 -0700, Andy Lutomirski wrote: On Wed, Apr 8, 2015 at 11:17 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2015-04-08 at 10:59 -0700, Andy Lutomirski wrote: This is a regression somewhere between 3.15 and 3.19.3. Let me know if more

Re: [PATCH V2 0/7] scsi: storvsc: Miscellaneous enhancements and fixes

2015-04-08 Thread James Bottomley
On Fri, 2015-03-27 at 00:26 -0700, K. Y. Srinivasan wrote: This patch-set addresses perf issues discovered on the Azure storage stack. These patches also fix a couple of bugs. As in the first version of this patch-set, some of the patches are simply a resend. I have bumped up the version

[GIT PULL] SCSI fixes for 4.0-rc7

2015-04-10 Thread James Bottomley
-fixes The short changelog is: Bart Van Assche (1): Defer processing of REQ_PREEMPT requests for blocked devices James Bottomley (1): enclosure: fix WARN_ON removing an adapter in multi-path devices John Soni Jose (1): be2iscsi: Fix kernel panic when device initialization fails

Re: [PATCH 5/6] ipr: AF DASD raw mode implementation in ipr driver

2015-04-09 Thread James Bottomley
On Thu, 2015-03-26 at 11:23 -0500, Brian King wrote: From: Wen Xiong wenxi...@linux.vnet.ibm.com This patch implements raw mode support for AF DASD in ipr driver which allows for tools to send commands directly to physical devices which are members of RAID arrays when enabled in the

Re: [PATCH] [RESEND] SCSI: ips: remove pointless #warning

2015-05-19 Thread James Bottomley
On Tue, 2015-05-19 at 15:56 +0200, Arnd Bergmann wrote: On Tuesday 19 May 2015 06:52:52 James Bottomley wrote: On Tue, 2015-05-19 at 15:33 +0200, Arnd Bergmann wrote: The ips driver contains #warning This driver has only been tested on the x86/ia64/x86_64 platforms which

Re: linux-next: build failure after merge of the target-updates tree

2015-06-03 Thread James Bottomley
On Wed, 2015-06-03 at 18:16 +1000, Stephen Rothwell wrote: Hi Nicholas, After merging the target-updates tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/target/target_core_fabric_lib.c: In function 'target_get_pr_transport_id_len':

  1   2   3   4   5   6   7   8   9   10   >