RE: [Announce] Emulex lpfcdriver v8.0.20 available

2005-01-18 Thread James . Smart
-Original Message- From: Christoph Hellwig [mailto:[EMAIL PROTECTED] Sent: Monday, January 17, 2005 5:23 PM To: Smart, James Cc: linux-scsi@vger.kernel.org Subject: Re: [Announce] Emulex lpfcdriver v8.0.20 available I started to look through it, here's some thing I found so

RE: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread James . Smart
True. The only thing that made them FC-ish is that they were mandated by HBAAPI. The only other desire was to place all hbaapi-related data in a single place so users/applications don't have to trapse through the multiple directories in the class and device trees. I'll ping Greg on adding them

RE: [Announce] Emulex lpfcdriver v8.0.20 available

2005-01-20 Thread James . Smart
What console messages do you see? Looks like we'd have to add another allowed state transition from BLOCKED? At one point we were seeing Synchronizing SCSI cache for disk sdc: FAILED status = 0, message = 00, host = 1, driver = 00 5 messages. However, at this point, the

RE: [Announce] Emulex lpfcdriver v8.0.20 available

2005-01-20 Thread James . Smart
No, sorry for have been unclear. I want a pointer to the remote port structure in the fc_target transport data. Every driver needs the linkage of these two, and instead of everyone having it in their private data we'd better move it to the fc_transport data structure. Ok. It's already

RE: [Announce] Emulex lpfcdriver v8.0.20 available

2005-01-20 Thread James . Smart
This sounds like a good idea, but I wonder if we have userland relying on those attributes already. But given that the fc transport class was mostly a joke before you encehanced it it might be worth breaking it.. You and James would have to give the approval for this one. I already

[PATCH 0/3] MidLayer updates

2005-01-29 Thread James . Smart
The following 3 patches extend the scsi midlayer. Changes were prompted by recent discussions with Christoph as part of the Emulex driver thread. Patch 1: Updates the recent transport container patch for : - allow device driver-specific attributes to be added to class objects - exposes

[PATCH 1/3] MidLayer updates - extending transport/attribute container changes

2005-01-29 Thread James . Smart
Patch 1: Updates the recent transport container patch for : - allow device driver-specific attributes to be added to class objects - exposes classdev to transport via setup function -- James S p1_xpt.patch Description: p1_xpt.patch

[PATCH 3/3] MidLayer updates - extending scsi_target support

2005-01-29 Thread James . Smart
Patch 3: This patch extends scsi_target support: - Allows for driver-specific data to be allocated along with the target structure and accessible via the starget-hostdata pointer. - Adds scsi target alloc/configure/destory callbacks to the scsi host template. - Rearranges the

RE: Mid-layer handling of NOT_READY conditions...

2005-01-31 Thread James . Smart
If the transport hits a problem, there's no harm done as long as the problem is resolved within the block timeout. If the timeout is hit - it's because the user dicated that it wanted to know of errors within this time and if the device fails, it fails... In the multipath

[PATCH] fix the fix for multiple HBA problem with transport classes

2005-02-02 Thread James . Smart
Testing was showing transport devices not being enumerated. The reason was the wrong attribute container was being compared against in the match functions. This patch fixes it. -- james s diff -puN a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c ---

RE: [PATCH 3/3] MidLayer updates - extending scsi_target support

2005-02-05 Thread James . Smart
the idea behind this is fine, I just don't like the interface. Really a target device is nothing more than a container to SCSI. We already do the transport add/remove calls for targets, I don't see we need other calls duplicating this. So, I think the implementation would look a whole

RE: [PATCH 3/3] MidLayer updates - extending scsi_target support

2005-02-06 Thread James . Smart
No - there was no discussion of adding scsi targets to linux (per your definition or otherwise). Since the Emulex driver tracks things by target (actually FC remote port) rather than luns, having the ability to have driver data space in the lun didn't help much. Yes, the driver data space could

[PATCH scsi-rc-fixes-2.6] Re-enable FC Transport Host Statistics

2005-02-08 Thread James . Smart
With the conversion to the new attribute containers/transport work, the FC host statistics were lost. This patch re-enables them. This patch adds a statistics group to each attribute container and adds/removes them at the same time the base attributes are added/removed. -- James S

[Repost] [PATCH scsi-rc-fixes-2.6] Re-enable FC Transport Host Statistics

2005-02-09 Thread James . Smart
The patch contained in the original message had a mixed up diff line... Here's the corrected patch. -- James S -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of Smart, James Sent: Tuesday, February 08, 2005 11:04 PM To: linux-scsi@vger.kernel.org

RE: still BUG's for smp_processor_id() on interrupt

2005-02-09 Thread James . Smart
This looks suspiciously like the oops trace that I saw when loading/unloading driver a couple of times. Make sure you have the following patches. http://marc.theaimsgroup.com/?l=linux-scsim=110729104720492w=2 http://marc.theaimsgroup.com/?l=linux-scsim=110737816906830w=2 -- James S

RE: [PATCH 2/2 scsi-rc-fixes-2.6] FC Remote Port patch

2005-02-09 Thread James . Smart
seems like sdev-shost is bogus when fc_remote_port_block() is called... We haven't seen this in our testing lpfc_ext_debug -- residuals from some test code? yep - thought I had everything, guess not. I'm rebacking to scsi-misc-2.6 and will repost. This will be taken care of. -- James -

RE: [RFC] adding per scsi-host workqueues for defered processing

2005-02-21 Thread James . Smart
I'd like to propose the addition of a per-Scsi_Host work-queue to manage these scanning as well as any other (relevant) lower-level-driver differed requests. Why not use the per-host error handler thread for this? brings a deadlock condition to mind - where the error thread is needed

RE: One question about SCSI device hotplug

2005-03-01 Thread James . Smart
On Tue, Mar 01, 2005 at 05:06:55PM +0800, Zhao, Forrest wrote: If I surprisingly hot-remove a SCSI disk from HBA manually without executing echo scsi remove-single-device h b t l /proc/scsi/scsi, can the hotplug event be notified to SCSI mid-layer or user space? I briefly browse

RE: One question about SCSI device hotplug

2005-03-02 Thread James . Smart
Thank you, Matt. Then I have another question: As we know SCSI mid-layer issue a command to LLDD by host-hostt-queuecommand(cmd, scsi_done); and in the meantime a timer is set. When the timer expires, SCSI mid-layer know the execution of command has failed. My question is: when SCSI

RE: [RFC] adding per scsi-host workqueues for defered processing

2005-03-05 Thread James . Smart
Following discussions which resulted from the: [RFC] target code updates to support scanned targets http://marc.theaimsgroup.com/?l=linux-scsim=110850749515984w=2 thread, the overall consensus seems to be that transport-classes should support a 'true-hotplug' mechanism of device discovery and

RE: [RFC] adding per scsi-host workqueues for defered processing

2005-03-05 Thread James . Smart
In thinking this through a little further - if the workq is just for the transport, the transport ought to simply create and use the workq. There would be no need to modify the host structure. If we're trying to avoid the potential for several workq's on a per-host basis (one by the transport,

RE: [RFC] adding per scsi-host workqueues for defered processing

2005-03-08 Thread James . Smart
So, is there a reason we aren't just starting the workq thread upon the first call to queue something to it ? -- james s -Original Message- From: Luben Tuikov [mailto:[EMAIL PROTECTED] Sent: Tuesday, March 08, 2005 8:12 AM To: Andrew Vasquez Cc: Smart, James;

RE: [PATCH] scsi_mid_low_api doesn't mention scsi_scan_host

2005-03-21 Thread James . Smart
A nit on the use of must In the following: /** - * scsi_add_host - perform sysfs registration and SCSI bus scan. + * scsi_add_host - perform sysfs registration and set up transport class * @shost: pointer to scsi host instance * @dev: pointer to struct device of type scsi

RE: [PATCH] scsi_mid_low_api doesn't mention scsi_scan_host

2005-03-21 Thread James . Smart
Thanks for the correction. How does this look? * Notes: Only required in hotplug initialization model after a * successful call to scsi_host_alloc(). This function does not * scan the bus; this can be done by calling scsi_scan_host() or * in some other

[Announce] Emulex lpfcdriver v8.0.28 available

2005-04-14 Thread James . Smart
All, I'd like to announce the availability of the Emulex lpfc driver revision 8.0.28 on SourceForge: http://prdownloads.sourceforge.net/lpfc/lpfcdriver-2.6-8.0.28.tar.gz?download We are extremely pleased that the FC Remote Port support is now part of the kernel for 2.6.12 (as of -rc1). We

RE: Fibre Channel state of the union

2005-04-18 Thread James . Smart
and the Linux Distribution vendors to support and certify this stack in the near future. Special thanks go to Emulex and James Smart in particular for implementing the majority of the new Fibre Channel transport class. We also want to thank Andrew Vasquez at Qlogic for providing valuable

[PATCH] add int_to_scsilun() function

2005-07-13 Thread James . Smart
One of the issues we had was reverting the midlayers lun value into the 8byte lun value that we wanted to send to the device. Historically, there's been some combination of byte swapping, setting high/low, etc. There's also been no common thread between how our driver did it and others. I also

Re: [PATCH -next] [SCSI] lpfc 8.3.36: fix potential NULL pointer dereference in lpfc_sli4_rq_put()

2013-03-18 Thread James Smart
James, Can you please merge this fix into scsi git for merging into 3.9 ? -- james s On 12/6/2012 10:46 AM, James Smart wrote: Acked-By: James Smart james.sm...@emulex.com Thanks -- james s On 12/2/2012 8:33 AM, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn

error handler scheduling

2013-03-26 Thread James Smart
In looking through the error handler, if a command times out and is added to the eh_cmd_q for the shost, the error handler is only awakened once shost-host_busy (total number of i/os posted to the shost) is equal to shost-host_failed (number of i/o that have been failed and put on the

Re: [PATCH] scsi_transport_fc: Make 'port_state' writeable

2013-04-01 Thread James Smart
Hannes, I'm finally going through this thread. I'm a bit uncomfortable about making the rport state writeable. The rport state is tightly tied to the driver's discovery engine, and I'm concerned about some of the callbacks firing, such as the rport_delete(), and the driver taking an action

Re: [PATCH] scsi_transport_fc: Make 'port_state' writeable

2013-04-05 Thread James Smart
/2013 2:26 AM, Hannes Reinecke wrote: On 04/01/2013 11:06 PM, James Smart wrote: I think lpfc survives your rport state change as : part of the lld behavior on the callback, to clean up reference counts, is to abort all i/o that is outstanding to the rport. So the ref checking not only protects lpfc

Re: [PATCH 0/4] scsi: 64-bit LUN support

2013-04-05 Thread James Smart
On 4/4/2013 6:17 AM, Hannes Reinecke wrote: On 03/31/2013 07:44 PM, Tomas Henzl wrote: What we can do is to decode the LUN and compare it to max_lun provided by the driver, I think that sg_luns is able to do that, so what is needed is just to follow the SAM. I have seen reports of problem

[PATCH 0/22] lpfc 8.3.39: Update lpfc to revision 8.3.39

2013-04-17 Thread James Smart
- Reduced tmo value set to FLOGI WQE for quick recovery from FLOGI sequence timeout - Fixed driver handling of CLEAR_LA with NPIV enabled causing SID=0 frames out - Update lpfc version for 8.3.39 driver release The patches were cut against scsi.git, branch misc. -- james s Signed-off-by: James

[PATCH 1/22] lpfc 8.3.39: Fixed VPI allocation issues after firmware dump is performed

2013-04-17 Thread James Smart
Fixed VPI allocation issues after firmware dump is performed Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_hbadisc.c | 14 +- lpfc_init.c| 12 +++- lpfc_sli.c |2 ++ lpfc_vport.c | 25 - lpfc_vport.h |1 + 5

[PATCH 2/22] lpfc 8.3.39: Fixed BlockGuard error reporting

2013-04-17 Thread James Smart
Fixed BlockGuard error reporting Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_logmsg.h |1 lpfc_scsi.c | 279 -- 2 files changed, 255 insertions(+), 25 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_logmsg.h b

[PATCH 3/22] lpfc 8.3.39: Remove driver dependency on HZ

2013-04-17 Thread James Smart
Remove driver dependency on HZ Signed-off-by: James Smart james.sm...@emulex.com --- lpfc.h |6 -- lpfc_bsg.c |6 -- lpfc_ct.c|3 ++- lpfc_els.c | 10 ++ lpfc_hbadisc.c |5 +++-- lpfc_init.c | 45

[PATCH 4/22] lpfc 8.3.39: Fixed pt2pt and loop discovery problems on topology changes.

2013-04-17 Thread James Smart
Fixed pt2pt and loop discovery problems on topology changes. Signed-off-by: James Smart james.sm...@emulex.com --- lpfc.h |1 lpfc_attr.c |2 + lpfc_els.c | 93 +++ lpfc_hbadisc.c | 55

[PATCH 5/22] lpfc 8.3.39: Fix driver issues with large lpfc_sg_seg_cnt values

2013-04-17 Thread James Smart
Fix driver issues with large lpfc_sg_seg_cnt values Signed-off-by: James Smart james.sm...@emulex.com --- lpfc.h |3 +++ lpfc_init.c | 31 +-- 2 files changed, 16 insertions(+), 18 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc.h b/drivers/scsi/lpfc

[PATCH 6/22] lpfc 8.3.39: Fix driver issues with large s/g lists for BlockGuard

2013-04-17 Thread James Smart
Fix driver issues with large s/g lists for BlockGuard Signed-off-by: James Smart james.sm...@emulex.com --- lpfc.h |7 + lpfc_attr.c | 15 ++- lpfc_init.c | 132 -- lpfc_mem.c | 14 ++- lpfc_scsi.c | 229

[PATCH 7/22] lpfc 8.3.39: Doorbell formation information logged in dual-chute mode WQ and RQ setup

2013-04-17 Thread James Smart
Doorbell formation information logged in dual-chute mode WQ and RQ setup Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_sli.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c

[PATCH 8/22] lpfc 8.3.39: Fix driver issues with SCSI Host reset

2013-04-17 Thread James Smart
Fix driver issues with SCSI Host reset Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_attr.c |7 ++- lpfc_hw4.h |2 +- lpfc_init.c |7 ++- 3 files changed, 13 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc

[PATCH 9/22] lpfc 8.3.39: Fix lpfc_fcp_look_ahead module parameter

2013-04-17 Thread James Smart
Fix lpfc_fcp_look_ahead module parameter Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_attr.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c --- a/drivers/scsi/lpfc/lpfc_attr.c 2013

[PATCH 10/22] lpfc 8.3.39: Fixed crash when processing bsg's sg list with high memory pages

2013-04-17 Thread James Smart
Fixed crash when processing bsg's sg list with high memory pages Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_bsg.c | 33 +++-- lpfc_sli.c |3 +-- 2 files changed, 24 insertions(+), 12 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_bsg.c b

[PATCH 11/22] lpfc 8.3.39: Reduced spinlock contention on SCSI buffer list

2013-04-17 Thread James Smart
Reduced spinlock contention on SCSI buffer list Signed-off-by: James Smart james.sm...@emulex.com --- lpfc.h |6 ++- lpfc_init.c | 54 -- lpfc_scsi.c | 93 ++-- 3 files changed, 102

[PATCH 12/22] lpfc 8.3.39: Fixed BlockGuard to take advantage of rdprotect/wrprotect info when available

2013-04-17 Thread James Smart
Fixed BlockGuard to take advantage of rdprotect/wrprotect info when available Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_hw.h |1 lpfc_scsi.c | 181 ++-- 2 files changed, 116 insertions(+), 66 deletions(-) diff

[PATCH 13/22] lpfc 8.3.39: Fixed deadlock between hbalock and nlp_lock use

2013-04-17 Thread James Smart
Fixed deadlock between hbalock and nlp_lock use. Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_hbadisc.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c --- a/drivers/scsi/lpfc

[PATCH 14/22] lpfc 8.3.39: Fixed bad book keeping in posting els sgls to port

2013-04-17 Thread James Smart
Fixed bad book keeping in posting els sgls to port Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_sli.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c --- a/drivers/scsi/lpfc

[PATCH 15/22] lpfc 8.3.39: Fixed not returning FAILED status when SCSI invoking host reset handler failed

2013-04-17 Thread James Smart
Fixed not returning FAILED status when SCSI invoking host reset handler failed Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_crtn.h |1 + lpfc_init.c |2 +- lpfc_scsi.c | 14 +++--- 3 files changed, 13 insertions(+), 4 deletions(-) diff -upNr a/drivers/scsi

[PATCH 16/22] lpfc 8.3.39: Fixed system panic during EEH recovery due to midlayer acting on outstanding I/O

2013-04-17 Thread James Smart
Fixed system panic during EEH recovery due to midlayer acting on outstanding I/O Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_init.c | 12 ++-- lpfc_sli.c |4 2 files changed, 10 insertions(+), 6 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_init.c b

[PATCH 17/22] lpfc 8.3.39: Fixed iocb flags not being reset for scsi commands

2013-04-17 Thread James Smart
Fixed iocb flags not being reset for scsi commands. Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c |2 ++ 1 file changed, 2 insertions(+) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c --- a/drivers/scsi/lpfc/lpfc_scsi.c 2013-04-15 18

[PATCH 18/22] lpfc 8.3.39: Fixed driver vector mapping to CPU affinity

2013-04-17 Thread James Smart
Fixed driver vector mapping to CPU affinity Signed-off-by: James Smart james.sm...@emulex.com --- lpfc.h |1 lpfc_attr.c | 137 + lpfc_hw4.h |5 lpfc_init.c | 322 ++-- lpfc_sli.c | 22

[PATCH 19/22] lpfc 8.3.39: Add log message when completes with clean address bit set to zero

2013-04-17 Thread James Smart
Add log message when completes with clean address bit set to zero Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_els.c |3 +++ 1 file changed, 3 insertions(+) diff -upNr a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c --- a/drivers/scsi/lpfc/lpfc_els.c

[PATCH 20/22] lpfc 8.3.39: Reduced tmo value set to FLOGI WQE for quick recovery from FLOGI sequence timeout

2013-04-17 Thread James Smart
Reduced tmo value set to FLOGI WQE for quick recovery from FLOGI sequence timeout Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_els.c |9 ++--- lpfc_hbadisc.c |7 +-- lpfc_sli.c | 11 ++- 3 files changed, 17 insertions(+), 10 deletions

[PATCH 21/22] lpfc 8.3.39: Fixed driver handling of CLEAR_LA with NPIV enabled causing SID=0 frames out

2013-04-17 Thread James Smart
Fixed driver handling of CLEAR_LA with NPIV enabled causing SID=0 frames out Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_hbadisc.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c

[PATCH 22/22] lpfc 8.3.39: Update lpfc version for 8.3.39 driver release

2013-04-17 Thread James Smart
Update lpfc version for 8.3.39 driver release Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_version.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h --- a/drivers/scsi/lpfc

Re: [PATCH 0/5] scsi: Allow fast io fail without waiting through timeout

2013-05-20 Thread James Smart
Ren, Based on the discussion recently held at LSF 2013, we are reworking the error recovery path to address all the issues you are mentioning. That work contradicts these patches. So for now, these should be held off. -- james s On 5/20/2013 3:14 AM, Ren Mingxin wrote: When there is a

Re: [PATCH 0/5] scsi: Allow fast io fail without waiting through timeout

2013-05-22 Thread James Smart
Mingxin wrote: Hi, James, On 05/20/2013 11:53 PM, James Smart wrote: Based on the discussion recently held at LSF 2013, we are reworking the error recovery path to address all the issues you are mentioning. That work contradicts these patches. So for now, these should be held off. Interesting

Re: SCSI error handling -- one error blocks the whole SCSI host

2013-05-25 Thread James Smart
Roland, I agree, and am already working around that limitation. -- james s On 5/23/2013 2:14 PM, Roland Dreier wrote: At LSF this year, we had a discussion about error handling and in particular the problem that SCSI midlayer error handling waits for the entire SCSI host (HBA) to quiesce

[PATCH 8/17] lpfc 8.3.40: Fixed some logging message fields

2013-05-31 Thread James Smart
Fixed some logging message fields Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_sli.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c --- a/drivers/scsi/lpfc/lpfc_sli.c 2013-05-31 10:58

[PATCH 7/17] lpfc 8.3.40: Fixed list corruption when lpfc_drain_tx runs.

2013-05-31 Thread James Smart
Fixed list corruption when lpfc_drain_tx runs. Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_sli.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c --- a/drivers/scsi/lpfc/lpfc_sli.c

[PATCH 10/17] lpfc 8.3.40: Fix to allow OCM to report FEC status

2013-05-31 Thread James Smart
Fix to allow OCM to report FEC status Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_bsg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c --- a/drivers/scsi/lpfc/lpfc_bsg.c 2013-05-03 09:24

[PATCH 15/17] lpfc 8.3.40: Fixed a race condition between SLI host and port failed FCF rediscovery

2013-05-31 Thread James Smart
Fixed a race condition between SLI host and port failed FCF rediscovery Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_init.c | 97 +--- 1 file changed, 35 insertions(+), 62 deletions(-) diff -upNr a/drivers/scsi/lpfc

[PATCH 4/17] lpfc 8.3.40: Fixed system panic during handling unsolicited receive buffer error condition

2013-05-31 Thread James Smart
Fixed system panic during handling unsolicited receive buffer error condition Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_sli.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c --- a/drivers

[PATCH 6/17] lpfc 8.3.40: Fix starting reference tag when calculating BG error

2013-05-31 Thread James Smart
Fix starting reference tag when calculating BG error Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c --- a/drivers/scsi/lpfc/lpfc_scsi.c

[PATCH 17/17] lpfc 8.3.40: Update lpfc version to driver version 8.3.40

2013-05-31 Thread James Smart
Update lpfc version to driver version 8.3.40 Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_version.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h --- a/drivers/scsi/lpfc/lpfc_version.h

[PATCH 5/17] lpfc 8.3.40: Fix inconsistent list removal causes crash.

2013-05-31 Thread James Smart
Fix inconsistent list removal causes crash. Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_sli.c | 18 -- 1 file changed, 18 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c --- a/drivers/scsi/lpfc/lpfc_sli.c 2013-05

[PATCH 13/17] lpfc 8.3.40: Fixed system panic due to unsafe walking and deleting linked list

2013-05-31 Thread James Smart
Fixed system panic due to unsafe walking and deleting linked list Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c --- a/drivers

[PATCH 16/17] lpfc 8.3.40: Update Copyrights to 2013 for 8.3.38, 8.3.39, and 8.3.40 modifications

2013-05-31 Thread James Smart
Update Copyrights to 2013 for 8.3.38, 8.3.39, and 8.3.40 modifications Signed-off-by: James Smart james.sm...@emulex.com --- lpfc.h |2 +- lpfc_bsg.c |2 +- lpfc_crtn.h |2 +- lpfc_ct.c|2 +- lpfc_els.c |2 +- lpfc_hbadisc.c |2

[PATCH 11/17] lpfc 8.3.40: Clarified the behavior of the lpfc_max_luns module parameter

2013-05-31 Thread James Smart
Clarified the behavior of the lpfc_max_luns module parameter Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_attr.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c

[PATCH 14/17] lpfc 8.3.40: Fixed issue mailbox wait routine failed to issue dump memory mbox command

2013-05-31 Thread James Smart
Fixed issue mailbox wait routine failed to issue dump memory mbox command Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_sli.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c

[PATCH 1/17] lpfc 8.3.40: Fix lpfc_used_cpu to be more dynamic

2013-05-31 Thread James Smart
Fix lpfc_used_cpu to be more dynamic Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_init.c | 30 +++--- lpfc_sli4.h |1 - 2 files changed, 23 insertions(+), 8 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c

[PATCH 9/17] lpfc 8.3.40: Fixed a missing return code in a logging message

2013-05-31 Thread James Smart
Fixed a missing return code in a logging message Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_sli.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c --- a/drivers/scsi/lpfc/lpfc_sli.c 2013

[PATCH 0/17] lpfc 8.3.40: Update lpfc to revision 8.3.40

2013-05-31 Thread James Smart
FCF rediscovery - Update Copyrights to 2013 for 8.3.38, 8.3.39, and 8.3.40 modifications - Update lpfc version to driver version 8.3.40 The patches were cut against scsi.git, branch misc. -- james s Signed-off-by: James Smart james.sm...@emulex.com -- To unsubscribe from this list: send

[PATCH 12/17] lpfc 8.3.40: Fixed FCoE connection list vlan identifier and add FCF list debug

2013-05-31 Thread James Smart
Fixed FCoE connection list vlan identifier and add FCF list debug Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_hbadisc.c | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi

[PATCH 2/17] lpfc 8.3.40: Fixed crash during FCoE failover testing.

2013-05-31 Thread James Smart
Fixed crash during FCoE failover testing. Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c --- a/drivers/scsi/lpfc/lpfc_scsi.c 2013-05

[PATCH 3/17] lpfc 8.3.40: Fix BlockGuard error checking

2013-05-31 Thread James Smart
Fix BlockGuard error checking Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c | 109 ++-- 1 file changed, 62 insertions(+), 47 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c

[PATCH 0/13] lpfc 8.3.41: Update lpfc to revision 8.3.41

2013-07-15 Thread James Smart
burst support to driver - Fixed the format of some log message fields - Update copyrights for 8.3.41 modifications - Update lpfc version to driver version 8.3.41 The patches were cut against scsi.git, branch misc. -- james s Signed-off-by: James Smart james.sm...@emulex.com

[PATCH 1/13] lpfc 8.3.41: Fixed freeing of iocb when internal loopback times out

2013-07-15 Thread James Smart
Fixed freeing of iocb when internal loopback times out Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_bsg.c |8 +--- lpfc_scsi.c |2 +- lpfc_sli.c | 51 +-- lpfc_sli.h |5 - 4 files changed, 55 insertions

[PATCH 2/13] lpfc 8.3.41: Fix mailbox byteswap issue on PPC

2013-07-15 Thread James Smart
Fix mailbox byteswap issue on PPC Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_sli.c |1 - 1 file changed, 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c --- a/drivers/scsi/lpfc/lpfc_sli.c 2013-07-15 07:15:01.997055473 -0400

[PATCH 3/13] lpfc 8.3.41: Fixed Receive Queue varied frame size handling

2013-07-15 Thread James Smart
Fixed Receive Queue varied frame size handling Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_sli.c | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c

[PATCH 5/13] lpfc 8.3.41: Ensure driver properly zeros unused fields in SLI4 mailbox commands

2013-07-15 Thread James Smart
Ensure driver properly zeros unused fields in SLI4 mailbox commands Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_mbox.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_mbox.c b/drivers/scsi/lpfc/lpfc_mbox.c --- a/drivers

[PATCH 6/13] lpfc 8.3.41: Fixed support for 128 byte WQEs

2013-07-15 Thread James Smart
Fixed support for 128 byte WQEs Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_hw4.h | 13 + lpfc_init.c |1 + lpfc_sli.c | 48 +--- lpfc_sli4.h |6 ++ 4 files changed, 65 insertions(+), 3 deletions

[PATCH 4/13] lpfc 8.3.41: Fixed max value of lpfc_lun_queue_depth

2013-07-15 Thread James Smart
Fixed max value of lpfc_lun_queue_depth Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_attr.c |9 ++--- lpfc_init.c | 34 -- lpfc_sli.c | 11 +++ lpfc_vport.c |3 +++ 4 files changed, 44 insertions(+), 13 deletions

[PATCH 8/13] lpfc 8.3.41: Fixed failure in setting SLI3 board mode

2013-07-15 Thread James Smart
Fixed failure in setting SLI3 board mode Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_attr.c |3 --- 1 file changed, 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c --- a/drivers/scsi/lpfc/lpfc_attr.c 2013-07-15 07:15

[PATCH 7/13] lpfc 8.3.41: Fixed SLI3 failing FCP write on check-condition no-sense with residual zero

2013-07-15 Thread James Smart
Fixed SLI3 failing FCP write on check-condition no-sense with residual zero Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c

[PATCH 9/13] lpfc 8.3.41: Fixed not able to perform PCI function reset when board was not in online mode

2013-07-15 Thread James Smart
Fixed not able to perform PCI function reset when board was not in online mode Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_attr.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c

[PATCH 11/13] lpfc 8.3.41: Fixed the format of some log message fields

2013-07-15 Thread James Smart
Fixed the format of some log message fields Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_ct.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c --- a/drivers/scsi/lpfc/lpfc_ct.c 2013-07-15 06

[PATCH 10/13] lpfc 8.3.41: Add first burst support to driver

2013-07-15 Thread James Smart
Add first burst support to driver Signed-off-by: James Smart james.sm...@emulex.com --- lpfc.h |1 + lpfc_attr.c | 11 +++ lpfc_disc.h |1 + lpfc_els.c |2 ++ lpfc_nportdisc.c | 12 ++-- lpfc_scsi.c |5 + 6 files changed

[PATCH 13/13] lpfc 8.3.41: Update lpfc version to driver version 8.3.41

2013-07-15 Thread James Smart
Update lpfc version to driver version 8.3.41 Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_version.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h --- a/drivers/scsi/lpfc

[PATCH 12/13] lpfc 8.3.41: Update copyrights for 8.3.41 modifications

2013-07-15 Thread James Smart
Update copyrights for 8.3.41 modifications Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_disc.h |2 +- lpfc_sli.h |2 +- lpfc_vport.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_disc.h b/drivers/scsi/lpfc

[PATCH] lpfc: Removed obsolete fcp_eq_count and fcp_wq_count driver attributes

2013-08-02 Thread James Smart
Removed obsolete fcp_eq_count and fcp_wq_count driver attributes. The patches were cut against scsi.git, branch misc, plus the lpfc 8.3.41 patch set posted a couple of weeks ago. -- james Signed-off-by: James Smart james.sm...@emulex.com --- lpfc.h |2 -- lpfc_attr.c | 23

Re: [SCSI] lpfc: Don't force CONFIG_GENERIC_CSUM on

2013-08-08 Thread James Smart
I'm good with it. You folks understand the config dependencies better than I. -- james Acked-By: James Smart james.sm...@emulex.com On 8/8/2013 3:47 AM, Anton Blanchard wrote: Hi Randy, I reported: on i386: # CONFIG_CRC_T10DIF is not set drivers/built-in.o: In function `lpfc_bg_crc

Re: [PATCH net-next 2/2] random32: do not feed jiffies as seed from lpfc driver

2014-08-11 Thread James Smart
Acked-by: James Smart james.sm...@emulex.com -- james s On 7/31/2014 4:08 PM, Daniel Borkmann wrote: In prandom we have already reseeding mechanisms that trigger periodically from a much better entropy source than just feeding in jiffies through lpfc_mbx_cmpl_fcf_scan_read_fcf_rec() [what

Re: [PATCH v2 RESEND 12/23] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-08-11 Thread James Smart
pci_enable_msi_range() or pci_enable_msi_exact() and pci_enable_msix_range() or pci_enable_msix_exact() interfaces. Hi James, Could you please review this patch? James? Thanks! Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: James Smart james.sm...@emulex.com Cc: linux-scsi@vger.kernel.org Cc: linux

Re: [PATCH net-next 2/2] random32: do not feed jiffies as seed from lpfc driver

2014-08-11 Thread James Smart
yep. I'll do so. -- james s On 8/11/2014 2:18 PM, Christoph Hellwig wrote: On Mon, Aug 11, 2014 at 01:07:15PM -0400, James Smart wrote: Acked-by: James Smart james.sm...@emulex.com Can you jsut queue this up (and the pci fix as well) together with anything else you have pending for 3.18

Re: [PATCH] lpfc: Avoid to disable pci_dev twice

2014-08-27 Thread James Smart
Mike, Can you confirm - the nulls this patch correct are because the probe_one and error_detect threads are running concurrently, thus battling ? If so - this fix looks insufficient and we should rework it. Q: why are they allowed to run concurrently ? I could see this solved at the

[PATCH 0/19] lpfc 10.4.8000.0: Update lpfc version to driver version 10.4.8000.0

2014-09-03 Thread James Smart
10.4.8000.0 The patches were cut against Christoph's scsi-queue.git, branch drivers-for-3.18. -- james s Signed-off-by: James Smart james.sm...@emulex.com Signed-off-by: Dick Kennedy dick.kenn...@emulex.com James Smart (19): drivers/scsi/lpfc/lpfc_attr.c | 2 +- drivers/scsi/lpfc/lpfc_bsg.c

[PATCH 1/19] lpfc 10.4.8000.0: Mark functions as static in lpfc/lpfc_sli.c

2014-09-03 Thread James Smart
for ‘lpfc_mbx_cmpl_redisc_fcf_table’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria rashika.khe...@gmail.com Reviewed-by: Josh Triplett j...@joshtriplett.org Reviewed-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_sli.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH 6/19] lpfc 10.4.8000.0: Use time_after()

2014-09-03 Thread James Smart
-by: Manuel Schölling manuel.schoell...@gmx.de Reviewed-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_scsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index 3c250e3..6094545 100644 --- a/drivers

[PATCH 4/19] lpfc 10.4.8000.0: Mark functions as static in lpfc/lpfc_scsi.c

2014-09-03 Thread James Smart
for ‘lpfc_calc_bg_err’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria rashika.khe...@gmail.com Reviewed-by: Josh Triplett j...@joshtriplett.org Reviewed-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_scsi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions

  1   2   3   4   5   6   7   8   9   10   >