[PATCH] drivers/scsi/lpfc/lpfc_init.c: adjust code alignment

From: Julia Lawall julia.law...@lip6.fr Adjust code alignment so that each statement is lined up with its neighbor. In the second case, it could be desirable to put the call to lpfc_destroy_vport_work_array under the if. The call, is, however, safe in case vports is NULL, so the patch just

[PATCH 14/29] drivers/scsi/ufs/ufshcd-pltfrm.c: simplify use of devm_ioremap_resource

From: Julia Lawall julia.law...@lip6.fr Remove unneeded error handling on the result of a call to platform_get_resource when the value is passed to devm_ioremap_resource. A debugging statement in the error-handling code is removed as well, as it doesn't seem to give any more information than

[PATCH 0/29] simplify use of devm_ioremap_resource

devm_ioremap_resource often uses the result of a call to platform_get_resource as its last argument. devm_ioremap_resource does appropriate error handling on this argument, so error handling can be removed from the call site. To make the connection between the call to platform_get_resource and

Re: [PATCH 0/10] use safer test on the result of find_first_zero_bit

On Wed, 4 Jun 2014, Geert Uytterhoeven wrote: Hi Julia, On Wed, Jun 4, 2014 at 11:07 AM, Julia Lawall julia.law...@lip6.fr wrote: Find_first_zero_bit considers BITS_PER_LONG bits at a time, and thus may return a larger number than the maximum position argument if that position

RE: [PATCH 0/10] use safer test on the result of find_first_zero_bit

On Wed, 4 Jun 2014, David Laight wrote: From: Julia Lawall On Wed, 4 Jun 2014, Geert Uytterhoeven wrote: Hi Julia, On Wed, Jun 4, 2014 at 11:07 AM, Julia Lawall julia.law...@lip6.fr wrote: Find_first_zero_bit considers BITS_PER_LONG bits at a time, and thus may return

Re: [PATCH 0/10] use safer test on the result of find_first_zero_bit

On Wed, 4 Jun 2014, Geert Uytterhoeven wrote: Hi Julia, On Wed, Jun 4, 2014 at 11:52 AM, Julia Lawall julia.law...@lip6.fr wrote: Maybe the documented return code should be changed to allow for the existing behaviour. Sorry, I'm not sure to understand what you suggest here. include

Re: [PATCH 0/10] use safer test on the result of find_first_zero_bit

On Wed, 4 Jun 2014, Geert Uytterhoeven wrote: Hi Julia, On Wed, Jun 4, 2014 at 1:00 PM, Julia Lawall julia.law...@lip6.fr wrote: OK, thanks. I was only looking at the C code. But the C code contains a loop that is followed by: if (!size) return result

Re: [PATCH 6/10] hpsa: use safer test on the result of find_first_zero_bit

On Wed, 4 Jun 2014, scame...@beardog.cce.hp.com wrote: On Wed, Jun 04, 2014 at 11:07:56AM +0200, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Find_first_zero_bit considers BITS_PER_LONG bits at a time, and thus may return a larger number than the maximum position

RE: [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure

) { ... when != ret = e3 return ret; } // /smpl Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/scsi/qla4xxx/ql4_os.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx

RE: [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure

On Fri, 4 Jul 2014, Julia Lawall wrote: On Fri, 4 Jul 2014, Elliott, Robert (Server Storage) wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Himangi Saraogi Sent: Friday, 04 July, 2014 1:28

[PATCH 5/9] scsi: use correct structure type name in sizeof

From: Julia Lawall julia.law...@lip6.fr Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The semantic patch used

[PATCH 7/9] scsi: use correct structure type name in sizeof

From: Julia Lawall julia.law...@lip6.fr Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The semantic patch used

[PATCH 0/9] use correct structure type name in sizeof

These patches fix typos in the name of a type referenced in a sizeof command. These problems are not caught by the compiler, because they have no impact on execution - the size of a pointer is independent of the size of the pointed value. The semantic patch that finds these problems is shown

[PATCH 1/1] dpt_i2o: delete unnecessary null test on array

From: Julia Lawall julia.law...@lip6.fr Delete NULL test on array (always false). A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ type T; T [] e; position p; @@ e ==@p NULL @ disable fld_to_ptr@ expression e; identifier

[PATCH 0/1] delete unnecessary null test on array

Delete NULL test on array. The complete semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ type T; T [] e; position p; @@ ( e ==@p NULL | e !=@p NULL | !@p e ) @ disable fld_to_ptr@ expression e; identifier f; position r.p; @@ ( * (e.f) ==@p NULL

Re: [PATCH 1/1] dpt_i2o: delete unnecessary null test on array

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c index 67283ef..62e276b 100644 --- a/drivers/scsi/dpt_i2o.c +++ b/drivers/scsi/dpt_i2o.c @@ -1169,11 +1169,6 @@ static struct adpt_device* adpt_find_device(adpt_hba* pHba, u32 chan, u32 id, u6 if(chan 0 || chan =

Re: [PATCH 1/1] dpt_i2o: delete unnecessary null test on array

On Fri, 8 Aug 2014, James Bottomley wrote: On Fri, 2014-08-08 at 19:03 +0200, Julia Lawall wrote: diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c index 67283ef..62e276b 100644 --- a/drivers/scsi/dpt_i2o.c +++ b/drivers/scsi/dpt_i2o.c @@ -1169,11 +1169,6 @@ static

Re: [PATCH 1/1] dpt_i2o: delete unnecessary null test on array

From nobody Sat Aug 9 08:17:15 CEST 2014 From: Julia Lawall julia.law...@lip6.fr To: Adaptec OEM Raid Solutions aacr...@adaptec.com Cc: James E.J. Bottomley jbottom...@parallels.com,linux-scsi@vger.kernel.org,linux-ker...@vger.kernel.org Subject: [PATCH] dpt_i2o: delete unnecessary null test

[PATCH 0/5] fix error return code

The complate semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @ok exists@ identifier f,ret,i; expression e; constant c; @@ // identify a function that returns a negative return value at least once. f(...) { ... when any ( return -c@i; | ret = -c@i; ...

[PATCH 1/5] mptfusion: fix error return code

From: Julia Lawall julia.law...@lip6.fr Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression e1,e2; @@ ( if (\(ret 0\|ret != 0\)) { ... return ret; } | ret

[PATCH 2/4] drivers/scsi/bfa/bfa_svc.c: remove unneeded structure

From: Julia Lawall julia.law...@lip6.fr Delete a local structure that is only used to be initialized by memset. A semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier x,i; @@ { ... when any -struct i x; +... when != x - memset(x

[PATCH 0/4] remove unneeded array

Remove an array or structure that only serves as the first argument to memset. The complete semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier x; type T; @@ { ... when any -T x[...]; +... when != x - memset(x,...); ...+ } @@ identifier x,i;

[PATCH 1/4] target: remove unneeded array

From: Julia Lawall julia.law...@lip6.fr Delete a local array that is only used to be initialized by memset. A semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier x; type T; @@ { ... when any -T x[...]; +... when != x - memset(x

Re: [patch] mpt2sas: issue reset is not uninitialized

On Wed, 3 Dec 2014, Dan Carpenter wrote: The issue_reset variables were never set to zero. This bug was found with static analysis. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c index

[PATCH 3/4] drivers/scsi/lpfc: Use time_before, time_before_eq, etc.

From: Julia Lawall [EMAIL PROTECTED] The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. A simplified version of the semantic patch making this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // smpl

[PATCH 4/4] drivers/scsi/u14-34f.c: Use time_before, time_before_eq, etc.

From: Julia Lawall [EMAIL PROTECTED] The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. A simplified version of the semantic patch making this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // smpl

[PATCH 3/3] drivers/scsi: Use offsetof

From: Julia Lawall [EMAIL PROTECTED] In the patch cc154ac64aa8d3396b187f64cef01ce67f433324, Al Viro observed that the proper way to compute the distance between two structure fields is to use offsetof() or a cast to a pointer to character. The same change can be applied to a few more files

[PATCH 5/16] drivers/scsi: use WARN

From: Julia Lawall julia.law...@lip6.fr Use WARN rather than printk followed by WARN_ON(1), for conciseness. A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression list es; @@ -printk( +WARN(1, es); -WARN_ON

[PATCH 7/16] drivers/scsi/gdth.c: use WARN

From: Julia Lawall julia.law...@lip6.fr Use WARN rather than printk followed by WARN_ON(1), for conciseness. If (count) is also merged into WARN, for further conciseness. A simplified version of the semantic patch that makes part of this transformation is as follows: (http://coccinelle.lip6.fr

[PATCH 2/8] drivers/scsi/bfa/bfa_svc.c: drop if around WARN_ON

From: Julia Lawall julia.law...@lip6.fr Just use WARN_ON rather than an if containing only WARN_ON(1). A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression e; @@ - if (e) WARN_ON(1); + WARN_ON(e); // /smpl

[PATCH 7/8] drivers/scsi/scsi_transport_fc.c: drop if around WARN_ON

From: Julia Lawall julia.law...@lip6.fr Just use WARN_ON rather than an if containing only WARN_ON(1). A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression e; @@ - if (e) WARN_ON(1); + WARN_ON(e); // /smpl

[PATCH 5/8] drivers/scsi/qla2xxx/qla_nx.c: drop if around WARN_ON

From: Julia Lawall julia.law...@lip6.fr Just use WARN_ON rather than an if containing only WARN_ON(1). A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression e; @@ - if (e) WARN_ON(1); + WARN_ON(e); // /smpl

merging printk and WARN

It looks like these patches were not a good idea, because in each case the printk provides an error level, and WARN then provides another one. Sorry for the noise. julia -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org

[PATCH 5/15] drivers/scsi/bnx2fc/bnx2fc_io.c: adjust duplicate test

From: Julia Lawall julia.law...@lip6.fr Delete successive tests to the same location. The code tested the result of a previous allocation, that itself was already tested. It is changed to test the result of the most recent allocation. A simplified version of the semantic match that finds

[PATCH 10/15] drivers/scsi/csiostor/csio_lnode.c: adjust duplicate test

From: Julia Lawall julia.law...@lip6.fr Delete successive tests to the same location. The current value of ln has been tested already, and is clearly not NULL, given the enclosing if condition. Furthermore, the result of csio_lnode_alloc is currently ignored. A simplified version

[PATCH 1/25] fix error return code

From: Julia Lawall julia.law...@lip6.fr Set the return variable to an error code as done elsewhere in the function. Additionally, in each case there is no need to initialize ret to 0, since its value is immediately overwritten. A simplified version of the semantic match that finds the first

[PATCH 19/25] fix error return code

From: Julia Lawall julia.law...@lip6.fr Set the return variable to an error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0\)) { ... return ret; } | ret@p1

[PATCH 9/25] fix error return code

From: Julia Lawall julia.law...@lip6.fr Set the return variable to an error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0\)) { ... return ret; } | ret@p1

[PATCH 24/25] fix error return code

From: Julia Lawall julia.law...@lip6.fr Set the return variable to an error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0\)) { ... return ret; } | ret@p1

[PATCH 0/25] fix error return code

These patches fix cases where the return variable is not set to an error code in an error case. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/13] make return of 0 explicit

Sometimes a local variable is used as a return value in a case where the return value is always 0. The result is more apparent if this variable is just replaced by 0. This is done by the following semantic patch, although some cleanups may be needed. (http://coccinelle.lip6.fr/) // smpl @r

[PATCH 2/13 v2] [SCSI] qla2xxx: make return of 0 explicit

From: Julia Lawall julia.law...@lip6.fr Delete unnecessary use of a local variable to immediately return 0. A simplified version of the semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ local idexpression ret; expression e; position p

Re: [PATCH 2/13 v2] [SCSI] qla2xxx: make return of 0 explicit

On Mon, 19 May 2014, Dan Carpenter wrote: On Mon, May 19, 2014 at 04:07:52PM +, Saurav Kashyap wrote: Hi Julia, Status is already set to 0 at the beginning of the function, I think we should just return status here to be consistent with the rest of the function. return 0; is

[PATCH 2/5] drivers/scsi/bnx2fc/bnx2fc_io.c: Remove potential NULL dereference

From: Julia Lawall julia.law...@lip6.fr If the NULL test is necessary, the initialization involving a dereference of the tested value should be moved after the NULL test. The sematic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ type T; expression E

[PATCH 9/20] drivers/scsi: fix misspelling of current function in string

Replace a misspelled function name by %s and then __func__. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes. Signed-off-by: Julia Lawall julia.law...@lip6.fr --- The semantic patch is difficult to summarize, but is available

[PATCH 0/20] fix misspelling of current function in string

These patches replace what appears to be a reference to the name of the current function but is misspelled in some way by either the name of the function itself, or by %s and then __func__ in an argument list. // smpl // sudo apt-get install python-pip // sudo pip install python-Levenshtein //

Re: [PATCH 0/20] fix misspelling of current function in string

On Mon, 8 Dec 2014, Julian Calaby wrote: Hi Julia, On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall julia.law...@lip6.fr wrote: These patches replace what appears to be a reference to the name of the current function but is misspelled in some way by either the name of the function itself

Re: [PATCH 2/4] SCSI-QLA4...: Less function calls in qla4xxx_is_session_exists() after error detection

On Sat, 7 Feb 2015, Dan Carpenter wrote: On Fri, Feb 06, 2015 at 11:15:13PM +0100, SF Markus Elfring wrote: diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 2a00fd3..a7ca479 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c

[PATCH 0/15] don't export static symbol

These patches remove EXPORT_SYMBOL or EXPORT_SYMBOL_GPL declarations on static functions. This was done using the following semantic patch: (http://coccinelle.lip6.fr/) // smpl @r@ type T; identifier f; @@ static T f (...) { ... } @@ identifier r.f; declarer name EXPORT_SYMBOL; @@

[PATCH 10/15] scsi: don't export static symbol

From: Julia Lawall julia.law...@lip6.fr The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ type T; identifier f; @@ static T f (...) { ... } @@ identifier r.f; declarer name EXPORT_SYMBOL; @@ -EXPORT_SYMBOL(f); // /smpl Signed-off-by: Julia

[PATCH 15/15] iscsi-target: don't export static symbol

From: Julia Lawall julia.law...@lip6.fr The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ type T; identifier f; @@ static T f (...) { ... } @@ identifier r.f; declarer name EXPORT_SYMBOL; @@ -EXPORT_SYMBOL(f); // /smpl Signed-off-by: Julia

[PATCH 5/16] ufs: fix error return code

!= ret *if(...) { ... when != ret = e2 when forall return ret; } // /smpl This patch also changes the subsequent dev_err call to use err rather than recomputing PTR_ERR(hba-devfreq). The format of the error value is changed from %ld to %d to reflect the type or err. Signed-off-by: Julia

[PATCH 0/16] fix error return code

The complate semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @ok exists@ identifier f,ret,i; expression e; constant c; @@ // identify a function that returns a negative return value at least once. f(...) { ... when any ( return -c@i; | ret = -c@i; ...

[PATCH 0/9] constify pci_error_handlers structures

Constify never-modified pci_error_handlers structures. --- drivers/crypto/qat/qat_common/adf_aer.c |2 +- drivers/misc/genwqe/card_base.c |2 +- drivers/net/ethernet/cavium/liquidio/lio_main.c |2 +- drivers/net/ethernet/sfc/efx.c |2 +-

[PATCH 3/9] cxgb4/cxgb4vf/csiostor: constify pci_error_handlers structures

This pci_error_handlers structure is never modified, like all the other pci_error_handlers structures, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- There are no dependencies between these patches. drivers/scsi/cs

[PATCH 6/9] be2iscsi: constify pci_error_handlers structures

This pci_error_handlers structure is never modified, like all the other pci_error_handlers structures, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- There are no dependencies between these patches. drivers/scsi/be

[PATCH 8/9] mpt3sas: constify pci_error_handlers structures

This pci_error_handlers structure is never modified, like all the other pci_error_handlers structures, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- There are no dependencies between these patches. drivers/scsi/m

[PATCH 4/9] bfa: constify pci_error_handlers structures

This pci_error_handlers structure is never modified, like all the other pci_error_handlers structures, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- There are no dependencies between these patches. drivers/scsi/bfa/

[PATCH] drivers/message/fusion: constify mpt_pci_driver structures

The mpt_pci_driver structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/message/fusion/mptbase.c |8 +--- drivers/message/fusion/mptbase.h |3 ++- drivers/message/fusion/mp

Re: [patch RESEND] atp870u: 64 bit bug in atp885_init()

On Wed, 9 Dec 2015, Dan Carpenter wrote: > We should add a tag to indicate that we are sending a patch for a crappy > driver. > > IMHO-this-driver-is-garbage: Your Name > > If it got 10 votes of no confidence it would be moved to staging and > then deleted. Forgive my ignorance, but what is

Re: [PATCH 13/20] qla2xxx: Remove dependency on hardware_lock to reduce lock contention.

Looks suspicious. Please check. julia On Tue, 8 Dec 2015, kbuild test robot wrote: > CC: kbuild-...@01.org > In-Reply-To: <1449535747-2850-14-git-send-email-himanshu.madh...@qlogic.com> > TO: Himanshu Madhani > CC: target-de...@vger.kernel.org,

Re: [PATCH 4/7] iscsi-target: Make a variable initialisation a bit more obvious in iscsi_create_default_params()

On Sat, 12 Dec 2015, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 12 Dec 2015 13:44:06 +0100 > > The variable "pl" was declared and immediately assigned a return value > from a function call in a separate statement. > > * Let us express the

Re: [PATCH 0/7] fix typo

On Tue, 17 May 2016, Kalle Valo wrote: > Julia Lawall <julia.law...@lip6.fr> writes: > > > firmare -> firmware > > > > --- > > > > drivers/media/dvb-frontends/mn88473.c |2 +- > > drivers/net/wireless/ath/ath6kl/core.h |2

[PATCH 0/7] fix typo

firmare -> firmware --- drivers/media/dvb-frontends/mn88473.c |2 +- drivers/net/wireless/ath/ath6kl/core.h |2 +- drivers/net/wireless/marvell/mwifiex/pcie.c |2 +- drivers/scsi/pm8001/pm8001_init.c |2 +- drivers/scsi/snic/snic_fwint.h |2

[PATCH 5/7] pm8001: fix typo

firmare -> firmware Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/scsi/pm8001/pm8001_init.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c index 6bd7bf4..fdbee8b4 100644 ---

[PATCH 1/7] snic: fix typo

firmare -> firmware Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/scsi/snic/snic_fwint.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/snic/snic_fwint.h b/drivers/scsi/snic/snic_fwint.h index c5f9e19..2a045a5 100644 --- a/drivers/

Re: [PATCH 2/2] be2iscsi: Fix some error messages

On Fri, 12 Aug 2016, Christophe JAILLET wrote: > This fixes: >- missing spaces in string split on several lines >- extra spaces after ':' >- missing '\n' at the end of some messages >- too long lines I think that the strings should be concatenated, even if they go past 80 chars.

Re: [PATCH 2/2 v2] be2iscsi: Fix some error messages

On Sat, 13 Aug 2016, Christophe JAILLET wrote: > This fixes: >- missing spaces in string split on several lines >- extra spaces after ':' >- missing '\n' at the end of some messages >- turn a \\n to \n in 1 message (v2) >- concatenate strings on the same line to fix

Re: [PATCH v3 08/12] qla2xxx: Add framework for Async fabric discovery.

Hello, I don't have the compete context, but I have the impression that there should be a goto done at which sp can be NULL. julia -- Forwarded message -- Date: Thu, 19 Jan 2017 12:38:31 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia

Re: [PATCH v2 15/29] be2iscsi: Fix to make boot discovery non-blocking

Please check the return on line 1517. It looks suspicious that it does not release the lock, unlike the return on line 1508. julia --- Hi Jitendra, [auto build test WARNING on scsi/for-next] [also build test WARNING on v4.8-rc3 next-20160822] [if your patch is applied to the wrong git tree,

[PATCH 12/26] [SCSI] hptiop: constify local structures

in a variable. Declare structures having all of these properties as const. Done using Coccinelle. Based on a suggestion by Joe Perches <j...@perches.com>. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- The semantic patch seems too long for a commit log, but is in the

Re: [PATCH 00/26] constify local structures

On Sun, 11 Sep 2016, Joe Perches wrote: > On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote: > > Constify local structures. > > Thanks Julia. > > A few suggestions & questions: > > Perhaps the script should go into scripts/coccinelle/ > so that future

[PATCH 22/26] esas2r: constify local structures

in a variable. Declare structures having all of these properties as const. Done using Coccinelle. Based on a suggestion by Joe Perches <j...@perches.com>. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- The semantic patch seems too long for a commit log, but is in the

[PATCH 00/26] constify local structures

Constify local structures. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // // The first rule ignores some cases that posed problems @r disable optional_qualifier@ identifier s != {peri_clk_data,threshold_attr,tracer_flags,tracer}; identifier i !=

Re: [PATCH 00/26] constify local structures

On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > Constify local structures. > > > > The semantic patch that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > Just my two cents b

Re: [PATCH 12/26] [SCSI] hptiop: constify local structures

On Sun, 11 Sep 2016, Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-le

Re: [PATCH 00/26] constify local structures

On Mon, 12 Sep 2016, Jarkko Sakkinen wrote: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > > > > > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > > > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrot

Re: [PATCH 00/26] constify local structures

On Mon, 12 Sep 2016, Felipe Balbi wrote: > > Hi, > > Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> writes: > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > >> > >> > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > >

Re: [PATCH 00/26] constify local structures

On Mon, 12 Sep 2016, Jarkko Sakkinen wrote: > On Mon, Sep 12, 2016 at 04:43:58PM +0300, Felipe Balbi wrote: > > > > Hi, > > > > Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> writes: > > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote

[PATCH] scsi: constify sr_pm_ops structure

sr_pm_ops, of type struct dev_pm_ops, is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/scsi/sr.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/sr.c b/driver

Re: [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing (fwd)

ang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing In-Reply-To: <1481065220-18431-5-git-send-email-sasikumar...@broadcom.com> Hi Sasikumar,

Re: [PATCH 04/22] target: Make use of the new sg_map function at 16 call sites (fwd)

It looks like >cmdr_lock should be released at line 512 if it has not been released otherwise. The lock was taken at line 438. julia -- Forwarded message -- Date: Fri, 14 Apr 2017 22:21:44 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Jul

[PATCH 1/6] scsi: mpt3sas: constify pci_error_handlers structures

These pci_error_handlers structures are only stored in the err_handler field of a pci_driver structure, and this field is declared as const. Thus the pci_error_handlers structures can be const too. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6

[PATCH 4/6] scsi: be2iscsi: constify pci_error_handlers structures

These pci_error_handlers structures are only stored in the err_handler field of a pci_driver structure, and this field is declared as const. Thus the pci_error_handlers structures can be const too. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6

[PATCH 3/6] scsi: aacraid: constify pci_error_handlers structures

These pci_error_handlers structures are only stored in the err_handler field of a pci_driver structure, and this field is declared as const. Thus the pci_error_handlers structures can be const too. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6

[PATCH 0/6] constify pci_error_handlers structures

These pci_error_handlers structures are only stored in the err_handler field of a pci_driver structure, and this field is declared as const. Thus the pci_error_handlers structures can be const too. Done with the help of Coccinelle. --- drivers/misc/genwqe/card_base.c |2 +-

[PATCH 6/6] bfa: constify pci_error_handlers structures

These pci_error_handlers structures are only stored in the err_handler field of a pci_driver structure, and this field is declared as const. Thus the pci_error_handlers structures can be const too. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6

[PATCH 5/6] [SCSI] csiostor: constify pci_error_handlers structures

These pci_error_handlers structures are only stored in the err_handler field of a pci_driver structure, and this field is declared as const. Thus the pci_error_handlers structures can be const too. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6

Re: [PATCH 0/6] constify pci_error_handlers structures

On Sat, 12 Aug 2017, Christoph Hellwig wrote: > On Sat, Aug 12, 2017 at 09:52:28AM +0200, Julia Lawall wrote: > > OK, sure. So to be precise, you want the fields error_detected, > > mmio_enabled, etc to be added as new fields to the pci_driver structure? > > Yes. > >

Re: [PATCH 0/6] constify pci_error_handlers structures

On Sat, 12 Aug 2017, Christoph Hellwig wrote: > On Sat, Aug 12, 2017 at 07:44:28AM +0200, Julia Lawall wrote: > > These pci_error_handlers structures are only stored in the err_handler > > field of a pci_driver structure, and this field is declared as const. Thus > > t

Re: [PATCH 0/6] constify pci_error_handlers structures

Another issue arises in the files drivers/infiniband/hw/hfi1/pcie.c and drivers/infiniband/hw/qib/qib_pcie.c, where the pci_error_handlers structure is defined in one file and used in another file. The structure definition references various functions that are static in the same file. Should I

Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock (fwd)

Please check on whether an unlock is neeed before line 1965. julia -- Forwarded message -- Date: Fri, 23 Jun 2017 15:23:00 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH] qla2xxx: Pr

Re: [PATCH 34/35] scsi: Move eh_device_reset_handler() to use scsi_device as argument (fwd)

Hello, It looks like the goto on line 2374 could result in the io_lock not being released. julia -- Forwarded message -- Date: Sat, 24 Jun 2017 13:27:41 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr>

Re: [PATCH] Eliminate extra 'out_free' label from fcoe_init function

On Fri, 2 Jun 2017, Milan P. Gandhi wrote: > On 06/01/2017 08:32 PM, Dan Carpenter wrote: > > On Thu, Jun 01, 2017 at 05:41:06PM +0530, Milan P. Gandhi wrote: > >> Simplify the check for return code of fcoe_if_init routine > >> in fcoe_init function such that we could eliminate need for > >>

Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function

On Fri, 2 Jun 2017, walter harms wrote: > > > Am 02.06.2017 14:39, schrieb Milan P. Gandhi: > > Simplify the check for return code of fcoe_if_init routine > > in fcoe_init function such that we could eliminate need for > > extra 'out_free' label and duplicate mutex_unlock statement. > > > >

Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function

On Fri, 2 Jun 2017, Milan P. Gandhi wrote: > Simplify the check for return code of fcoe_if_init routine > in fcoe_init function such that we could eliminate need for > extra 'out_free' label and duplicate mutex_unlock statement. > > Signed-off-by: Milan P. Gandhi > --- >

Re: [PATCH] Remove white spaces from fcoe.h

On Mon, 5 Jun 2017, Milan P. Gandhi wrote: > Remove the white spaces in do/while loop used for checking fcoe > debug logging Is it converting spaces to tabs? If so, saying that would be clearer. julia > > Signed-off-by: Milan P. Gandhi > --- > drivers/scsi/fcoe/fcoe.h

Re: [PATCH v2 00/15] make structure field, function arguments and structures const

On Tue, 17 Oct 2017, Greg KH wrote: > On Mon, Oct 16, 2017 at 05:18:39PM +0200, Bhumika Goyal wrote: > > Make the ci_type field and some function arguments as const. After this > > change, make config_item_type structures as const. > > > > * Changes in v2- Combine all the followup patches and

Re: [PATCH] scsi: Use vzalloc instead of vmalloc/memset

On Wed, 8 Nov 2017, Himanshu Jha wrote: > On Tue, Nov 07, 2017 at 08:51:36PM +0100, Luis R. Rodriguez wrote: > > On Sun, Nov 05, 2017 at 03:26:26AM +0530, Himanshu Jha wrote: > > > Use vzalloc instead of vmalloc/memset to allocate memory filled with 0 > > > value. > > > > > > Done using

[target:for-next 17/33] drivers/target/target_core_user.c:891:2-8: preceding lock on line 791 (fwd)

Please check whether an unlock is needed before the return on line 891. julia -- Forwarded message -- Date: Wed, 8 Nov 2017 15:05:33 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: [target:fo

  1   2   >