[PATCH, resend] sd: fix infinite kernel/udev loop on non-removable Medium Not Present

2013-04-12 Thread Steve Magnani
Commit eface65c336eff420d70beb0fb6787a732e05ffb (2.6.38) altered set_media_not_present() in a way that prevents the sd driver from remembering that a non-removable device has reported Medium Not Present. This condition can occur on hotplug of a (i.e.) USB Mass Storage device whose medium is

Re: READ_CAPACITY_16 vs. READ_CAPACITY_10

2013-09-11 Thread Steve Magnani
On Wed, 2013-09-11 at 11:42 -0400, Alan Stern wrote: On Wed, 11 Sep 2013, Oliver Neukum wrote: I'll try to get a Windows machine for a trace. Can you suggest a tracer for Win7? I don't know of any, offhand. Maybe Google can help. Alternatively, you could install Windows 7 in a

Re: [Scst-devel] [SPF:fail] Re: FC initiator performance tanks once target mode is enabled

2013-12-23 Thread Steve Magnani
happily on as a modular extension to the kernel. With this in place we can all focus on more pressing issues, such as why Steve Magnani can't get two ports on the same ISP chip to run in different modes. I have code from QLogic that appears to resolve the issue with which I started this thread

Re: Why is (2 2) true? Is it a gcc bug?

2014-01-17 Thread Steve Magnani
On 01/17/2014 08:55 AM, Dorau, Lukasz wrote: On Friday, January 17, 2014 2:58 PM Richard Weinberger richard.weinber...@gmail.com wrote: Can you reproduce this using a standalone test? I.e: #include assert.h int main() { assert(2 2 != 1); return 0; } No, I can't of

Re: [PATCH] sd: close hole in > 2T device rejection when !CONFIG_LBDAF

2017-02-28 Thread Steve Magnani
On 02/27/2017 12:57 PM, Bart Van Assche wrote: ... How about the (untested) patch below? The approach below avoids that the check is duplicated and - at least in my opinion - results in code that is easier to read. I find lba_too_large() a little dense, but functionally OK. The "shift >= 0"

Re: [PATCH] sd: close hole in > 2T device rejection when !CONFIG_LBDAF

2017-02-27 Thread Steve Magnani
Hi Bart - Thanks for taking the time to look this over. On 02/27/2017 10:13 AM, Bart Van Assche wrote: On Mon, 2017-02-27 at 09:22 -0600, Steven J. Magnani wrote: @@ -2122,7 +2122,10 @@ static int read_capacity_16(struct scsi_ return -ENODEV; } - if

RE: [SCSI] qla2xxx: Fix a memory leak in an error path of qla2x00_process_els()

2017-08-14 Thread Steve Magnani
Bart - I've been porting patches from mainline into a copy of QLogic's target driver tree and ran across an anomaly in this changeset of yours from 2013 (8c0eb596baa51f2b43949c698c644727ef17805c). The commit log says: ... Make it easy for Coverity (and for humans) to recognize that there

Re: Sniffing FC traffic

2017-08-18 Thread Steve Magnani
On 08/18/2017 08:31 AM, Laurence Oberman wrote: On Fri, Aug 18, 2017 at 8:37 AM, Thomas Glanzmann wrote: I would like to create a setup that allows me to sniff FC traffic. Is it possible with Linux or can someone recommend a setup that works. I want to avoid buying a