Re: [PATCH 1/1] aacraid: Dual firmware image support

2013-03-18 Thread Tomas Henzl
On 03/18/2013 05:58 AM, Mahesh Rajashekhara wrote: This patch adds dual flash firmware support for Series 7 and above controllers. Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com --- drivers/scsi/aacraid/aacraid.h |6 +- drivers/scsi/aacraid/comminit.c |2 +-

Re: [PATCH 0/4] scsi: 64-bit LUN support

2013-03-29 Thread Tomas Henzl
On 03/27/2013 08:37 AM, Hannes Reinecke wrote: On 03/26/2013 07:00 PM, Chad Dupuis wrote: On Tue, 19 Feb 2013, Hannes Reinecke wrote: This patchset updates the SCSI midlayer to use 64-bit LUNs internally. It eliminates the need to limit the number of LUNs artificially to avoid aliasing

Re: [PATCH 0/4] scsi: 64-bit LUN support

2013-03-31 Thread Tomas Henzl
On 03/30/2013 05:53 PM, Hannes Reinecke wrote: On 03/29/2013 05:32 PM, Tomas Henzl wrote: On 03/27/2013 08:37 AM, Hannes Reinecke wrote: On 03/26/2013 07:00 PM, Chad Dupuis wrote: On Tue, 19 Feb 2013, Hannes Reinecke wrote: This patchset updates the SCSI midlayer to use 64-bit LUNs

Re: [PATCH 0/4] scsi: 64-bit LUN support

2013-04-08 Thread Tomas Henzl
On 04/05/2013 05:24 PM, James Smart wrote: On 4/4/2013 6:17 AM, Hannes Reinecke wrote: On 03/31/2013 07:44 PM, Tomas Henzl wrote: What we can do is to decode the LUN and compare it to max_lun provided by the driver, I think that sg_luns is able to do that, so what is needed is just

Re: [PATCH RESEND] scsi: megaraid: check kzalloc

2013-05-29 Thread Tomas Henzl
On 05/24/2013 11:40 AM, Libo Chen wrote: we should check kzalloc, avoid to hit oops Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/scsi/megaraid.c |4 1 files changed, 4 insertions(+), 0 deletions(-) instead of checking scmd-device, sdev is more appropriate. diff

Re: [PATCH RESEND] scsi: megaraid: check kzalloc

2013-05-29 Thread Tomas Henzl
On 05/24/2013 11:40 AM, Libo Chen wrote: we should check kzalloc, avoid to hit oops Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/scsi/megaraid.c |4 1 files changed, 4 insertions(+), 0 deletions(-) instead of checking scmd-device, sdev is more appropriate. diff

Re: [PATCH RESEND] scsi: megaraid: check kzalloc

2013-05-30 Thread Tomas Henzl
On 05/30/2013 04:32 AM, Libo Chen wrote: On 2013/5/30 9:38, Libo Chen wrote: On 2013/5/29 23:03, Tomas Henzl wrote: On 05/24/2013 11:40 AM, Libo Chen wrote: we should check kzalloc, avoid to hit oops Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/scsi/megaraid.c |4 1

[PATCH 1/3] hpsa: remove unneeded loop

2013-08-01 Thread Tomas Henzl
From: Tomas Henzl the...@redhat.com The cmd_pool_bits is protected everywhere with a spinlock, we don't need the test_and_set_bit, set_bit is enough and the loop can be removed too. Signed-off-by: Tomas Henzl the...@redhat.com --- drivers/scsi/hpsa.c | 15 ++- 1 file changed, 6

[PATCH 2/3] hpsa: fix a race in cmd_free/scsi_done

2013-08-01 Thread Tomas Henzl
From: Tomas Henzl the...@redhat.com When the driver calls scsi_done and after that frees it's internal preallocated memory it can happen that a new job is enqueud before the memory is freed. The allocation fails and the message cmd_alloc returned NULL is shown. Patch below fixes it by moving cmd

[PATCH 3/3] hpsa: remove unneeded variable

2013-08-01 Thread Tomas Henzl
From: Tomas Henzl the...@redhat.com Remove unneeded variables. Signed-off-by: Tomas Henzl the...@redhat.com --- drivers/scsi/hpsa.c | 2 -- drivers/scsi/hpsa.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 48fa81e..e0f6b00 100644

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-01 Thread Tomas Henzl
On 08/01/2013 03:39 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 03:11:22PM +0200, Tomas Henzl wrote: From: Tomas Henzl the...@redhat.com The cmd_pool_bits is protected everywhere with a spinlock, we don't need the test_and_set_bit, set_bit is enough and the loop can

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-01 Thread Tomas Henzl
On 08/01/2013 04:21 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 04:05:20PM +0200, Tomas Henzl wrote: On 08/01/2013 03:39 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 03:11:22PM +0200, Tomas Henzl wrote: From: Tomas Henzl the...@redhat.com

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-01 Thread Tomas Henzl
On 08/01/2013 05:19 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 04:59:45PM +0200, Tomas Henzl wrote: On 08/01/2013 04:21 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 04:05:20PM +0200, Tomas Henzl wrote: On 08/01/2013 03:39 PM, scame...@beardog.cce.hp.com

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-02 Thread Tomas Henzl
On 08/01/2013 06:18 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 05:39:36PM +0200, Tomas Henzl wrote: On 08/01/2013 05:19 PM, scame...@beardog.cce.hp.com wrote: [...] Btw. on line 1284 - isn't it similar to patch 2/3 ? ^^^ Oh, missed this the first time around, the sop

Re: [PATCH] pm80xx: Fix for 32 bit compilation issue.

2013-08-07 Thread Tomas Henzl
On 08/07/2013 09:51 AM, Anand wrote: From cc606631fae60a38ab9532bab79fd93523f4c579 Mon Sep 17 00:00:00 2001 From: Anand Kumar Santhanam anandkumar.santha...@pmcs.com Date: Mon, 5 Aug 2013 14:16:52 +0530 Subject: [PATCH] pm80xx: Fix for 32 bit compilation issue. pm80xx driver does not compile

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-07 Thread Tomas Henzl
On 08/06/2013 05:46 PM, scame...@beardog.cce.hp.com wrote: On Fri, Aug 02, 2013 at 01:13:59PM +0200, Tomas Henzl wrote: On 08/01/2013 06:18 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 05:39:36PM +0200, Tomas Henzl wrote: On 08/01/2013 05:19 PM, scame...@beardog.cce.hp.com

Re: [PATCH] [SCSI] mpt3sas: Added a driver module parameter max_msix_vectors

2013-08-15 Thread Tomas Henzl
want to stop it. So, lower the value of this variable 'max_msix_vectors' only if kernel couldn't allocate the DMA'able memory that the driver requests for and crash is observed. Regards, Sreekanth -Original Message- From: Tomas Henzl [mailto:the...@redhat.com] Sent

Re: [PATCH 1/1] cciss: set max scatter gather entries to 32 on P600

2013-08-15 Thread Tomas Henzl
) Brown bubr...@redhat.com Signed-off-by: Tomas Henzl the...@redhat.com Acked-by: Stephen M. Cameron steve.came...@hp.com I don't quite understand the signoff chain on this patch. For a one line patch, are you saying it has three authors? It look a bit funny, but from what I know everybody from

[PATCH] be2iscsi: add an missing goto in error path

2014-06-06 Thread Tomas Henzl
a jump to 'free_memory' is apparently missing Signed-off-by: Tomas Henzl the...@redhat.com --- diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index ac54cf5..442982d 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -4209,6

[PATCH 1/1] be2iscsi: remove potential junk pointer free

2014-06-06 Thread Tomas Henzl
commit 0e7c60c [SCSI] be2iscsi: fix memory leak in error path fixed an potential junk pointer free if mgmt_get_if_info() returned an error fix it on one more place Signed-off-by: Tomas Henzl the...@redhat.com --- diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c

[PATCH] hpsa: refine the pci enble/disable handling

2014-06-12 Thread Tomas Henzl
-disabled device ... This patch fixes it, in addition to this I tried to balance also some other pairs of enable/disable device in the driver. Unfortunately I wasn't able to verify the functionality for the case of a sw reset, because of a lack of proper hw. Signed-off-by: Tomas Henzl

[PATCH 2/4] pm8001: honor return value

2014-06-26 Thread Tomas Henzl
The driver ignores the return value in a lot of places, fix it at least somewhere (and release the resources in such cases), to avoid that bad things happen. Signed-off-by: Tomas Henzl the...@redhat.com --- drivers/scsi/pm8001/pm8001_hwi.c | 27 +++--- drivers/scsi/pm8001

[PATCH 3/4] pm8001: add a new spinlock to protect the CCB

2014-06-26 Thread Tomas Henzl
Patch adds a new spinlock to protect the ccb management. It may happen that concurrent threads become the same tag value from the 'alloc' function', the spinlock prevents this situation. Signed-off-by: Tomas Henzl the...@redhat.com --- drivers/scsi/pm8001/pm8001_init.c | 1 + drivers/scsi

[PATCH 4/4] pm8001: more fixes to honor return value

2014-06-26 Thread Tomas Henzl
The driver ignores the return value in a lot of places, fix it at least somewhere (and release the resources in such cases), to avoid that bad things happen. A memory leak is fixed too. Signed-off-by: Tomas Henzl the...@redhat.com --- drivers/scsi/pm8001/pm8001_ctl.c | 5 - drivers/scsi

[PATCH 1/4] pm8001: clean bitmap management functions

2014-06-26 Thread Tomas Henzl
In the driver two different functions are used to free the same resource, this patch makes the code easier to read. In addittion to that, some minor optimisations were made too. Signed-off-by: Tomas Henzl the...@redhat.com --- drivers/scsi/pm8001/pm8001_hwi.c | 10 +- drivers/scsi/pm8001

Re: [PATCH 3/4] pm8001: add a new spinlock to protect the CCB

2014-06-27 Thread Tomas Henzl
::rc= 5 and the system became 'unstable'. --tm Regards, Viswas G -Original Message- From: Tomas Henzl [mailto:the...@redhat.com] Sent: Thursday, June 26, 2014 8:48 PM To: linux-scsi@vger.kernel.org Cc: zzzAnand Kumar Santhanam(Nov-20-2013); Vasanthalakshmi Tharmarajan; Suresh

Re: [PATCH] b2iscsi: Fix memory leak in mgmt_set_ip()

2014-06-29 Thread Tomas Henzl
On 06/27/2014 09:38 PM, Maurizio Lombardi wrote: diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c index 07934b0..a3e5648 100644 --- a/drivers/scsi/be2iscsi/be_mgmt.c +++ b/drivers/scsi/be2iscsi/be_mgmt.c @@ -1015,7 +1015,7 @@ int mgmt_set_ip(struct beiscsi_hba

Re: [PATCH] b2iscsi: Fix memory leak in mgmt_set_ip()

2014-07-07 Thread Tomas Henzl
On 07/01/2014 08:53 PM, Christoph Hellwig wrote: On Sun, Jun 29, 2014 at 08:28:34PM +0200, Tomas Henzl wrote: On 06/27/2014 09:38 PM, Maurizio Lombardi wrote: diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c index 07934b0..a3e5648 100644 --- a/drivers/scsi

Re: [PATCH 1/4] pm8001: clean bitmap management functions

2014-07-07 Thread Tomas Henzl
On 07/07/2014 03:12 PM, Suresh Thiagarajan wrote: On Thu, Jul 3, 2014 at 2:15 PM, Christoph Hellwig h...@infradead.org wrote: Suresh, do you maintain pm8001 for pmcs now? There have been lots of pm8001 patches on the list, many of them with reviews from various people including Jack. I'd

Re: [PATCH] hpsa: refine the pci enble/disable handling

2014-07-07 Thread Tomas Henzl
Steve, Joe, any chance you could review this patch and verify the sw reset case? Thanks, Tomas On 06/12/2014 05:29 PM, Tomas Henzl wrote: When a second(kdump) kernel starts and the hard reset method is used the driver calls pci_disable_device without previously enabling it, so the kernel shows

[PATCH 4/4] scsi: pm8001: fix pm8001_store_update_fw

2014-07-07 Thread Tomas Henzl
The current implementation may mix the negative value returned from pm8001_set_nvmd with with count. -(-ENOMEM) could be interpreted as bytes programmed, this patch fixes it. Signed-off-by: Tomas Henzl the...@redhat.com --- drivers/scsi/pm8001/pm8001_ctl.c | 20 ++-- 1 file

[PATCH 1/4] scsi: pm8001: fix a memory leak in nvmd_resp

2014-07-07 Thread Tomas Henzl
Instead of copying information to fw_control_context free it. The task is forgotten thus also the reference to fw_control_context and the completion thread takes the info from virt_ptr again. Signed-off-by: Tomas Henzl the...@redhat.com --- drivers/scsi/pm8001/pm8001_hwi.c | 8 ++-- 1 file

[PATCH 3/4] scsi: pm8001: fix a memory leak in flash_update

2014-07-07 Thread Tomas Henzl
ccb-fw_control_context is copied to local fw_control_context and the local variable is never used later Free ccb-fw_control_context. The task is forgotten thus also the reference to fw_control_context and the completion thread takes the info from virt_ptr again. Signed-off-by: Tomas Henzl

[PATCH 2/4] scsi: pm8001: fix update_flash

2014-07-07 Thread Tomas Henzl
The driver checks the return valu, but after he tries to wait_for_completion which might never happen. Also the ioctlbuffer is freed at the end of the function, so the first removal is not needed. Signed-off-by: Tomas Henzl the...@redhat.com --- drivers/scsi/pm8001/pm8001_ctl.c | 6 +++--- 1

Re: [PATCH] beiscsi: the custom_length field has been set to a wrong value.

2014-07-07 Thread Tomas Henzl
-by: Tomas Henzl the...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/8] pm8001: Resend previous patches

2014-07-09 Thread Tomas Henzl
Hi Suresh, thanks for resending, please have a look and review also the patches I sent out two days ago beginning with [PATCH 1/4] scsi: pm8001: fix a memory leak in nvmd_resp, (I'm afraid they will get otherwise lost the in the pm8001 patchflood) Cheers, Tomas On 07/09/2014 01:47 PM, Suresh

Re: [PATCH 4/4] scsi: pm8001: fix pm8001_store_update_fw

2014-07-10 Thread Tomas Henzl
On 07/10/2014 08:43 AM, Christoph Hellwig wrote: On Mon, Jul 07, 2014 at 05:20:01PM +0200, Tomas Henzl wrote: The current implementation may mix the negative value returned from pm8001_set_nvmd with with count. -(-ENOMEM) could be interpreted as bytes programmed, this patch fixes

Re: mpt2sas and mpt3sas merge (again)

2014-07-14 Thread Tomas Henzl
On 07/14/2014 05:10 PM, Hannes Reinecke wrote: On 07/14/2014 04:57 PM, James Bottomley wrote: On Mon, 2014-07-14 at 16:39 +0200, Hannes Reinecke wrote: On 07/14/2014 04:17 PM, James Bottomley wrote: [ .. ] This isn't really a democracy; it's about who maintains the drivers and right now it's

Re: [PATCH 1/15] block copy: initial XCOPY offload support

2014-07-18 Thread Tomas Henzl
On 07/15/2014 09:34 PM, Mikulas Patocka wrote: This is Martin Petersen's xcopy patch (https://git.kernel.org/cgit/linux/kernel/git/mkp/linux.git/commit/?h=xcopyid=0bdeed274e16b3038a851552188512071974eea8) with some bug fixes, ported to the current kernel. This patch makes it possible to use

Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed

2014-07-29 Thread Tomas Henzl
Hi, patch looks good. A correction in pm8001_request_irq might be added too to allow the INT-X path when pm8001_setup_msix fails, but that is not part of this fix. Tomas Reviewed-by: Tomas Henzl the...@redhat.com On 07/16/2014 08:05 PM, Alexander Gordeev wrote: When a call to request_irq

Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed

2014-07-29 Thread Tomas Henzl
On 07/29/2014 03:20 PM, Christoph Hellwig wrote: On Tue, Jul 29, 2014 at 03:13:06PM +0200, Tomas Henzl wrote: Hi, patch looks good. A correction in pm8001_request_irq might be added too to allow the INT-X path when pm8001_setup_msix fails, but that is not part of this fix. There's

Re: [PATCH 4/4] scsi: pm8001: fix pm8001_store_update_fw

2014-07-30 Thread Tomas Henzl
On 07/10/2014 03:30 PM, Tomas Henzl wrote: On 07/10/2014 08:43 AM, Christoph Hellwig wrote: On Mon, Jul 07, 2014 at 05:20:01PM +0200, Tomas Henzl wrote: The current implementation may mix the negative value returned from pm8001_set_nvmd with with count. -(-ENOMEM) could be interpreted

[PATCH 2/3 V2] pm8001: Fix erratic calculation in update_flash

2014-07-30 Thread Tomas Henzl
V2 - 'from' string removed (as it comes from me now) and changed a signed-off to acked-by (Suresh is the maintainer) Tomas The loopcount is calculated by using some weird magic. Use instead a boring macro Signed-off-by: Tomas Henzl the...@redhat.com Acked-by: Suresh Thiagarajan suresh.thiagara

Re: [RFC] hpsa: work in progress lockless monster patches

2014-07-30 Thread Tomas Henzl
On 07/25/2014 09:28 PM, scame...@beardog.cce.hp.com wrote: hpsa: Work In Progress: lockless monster patches To be clear, I am not suggesting that these patches be merged at this time. This patchset is vs. Christoph Hellwig's scsi-mq.4 branch which may be found here:

Re: [RFC] hpsa: work in progress lockless monster patches

2014-07-31 Thread Tomas Henzl
for taking a look and for the feedback. I'm actually the one responsible for the changes you refer to, so I'll try to address your comments. On 7/30/14 10:55 AM, Tomas Henzl wrote: I'm not sure if I got it right, it seems it uses the same cmd_pool for both alloc function, from (0 - reserved_cmds

Re: [RFC] hpsa: work in progress lockless monster patches

2014-08-04 Thread Tomas Henzl
On 07/31/2014 05:16 PM, scame...@beardog.cce.hp.com wrote: On Thu, Jul 31, 2014 at 03:56:13PM +0200, Tomas Henzl wrote: Hi Steve, Webb, let me start with the part most important for me - from my previous mail And please have a look at [PATCH] hpsa: refine the pci enble/disable handling I

Re: [RFC] hpsa: work in progress lockless monster patches

2014-08-04 Thread Tomas Henzl
On 08/01/2014 06:40 PM, Webb Scales wrote: On 7/31/14 9:56 AM, Tomas Henzl wrote: In cmd_tagged_alloc Thus, there should never be a collision here between two requests if this is true you don't need the refcount and just a simple flag were sufficient for your other needs. (And maybe you get

Re: [RESEND][PATCH 7/8][SCSI]mpt3sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2014-08-05 Thread Tomas Henzl
On 06/25/2014 12:41 PM, Reddy, Sreekanth wrote: Up to now, Driver allocates a single contiguous block of memory pool for all reply queues and passes down a single address in the ReplyDescriptorPostQueueAddress field of the IOC Init Request Message to the firmware. When firmware receives this

Re: [RESEND][PATCH 7/8][SCSI]mpt3sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2014-08-06 Thread Tomas Henzl
On 08/05/2014 06:41 PM, Sreekanth Reddy wrote: Hi Tomas, Can you please review this updated patch, Hi Sreekanth, the patch is mangled so a resend is needed anyway and I think you will probably also want implement the changes you were asked for in the mpt2sas sibling of this patch. Thanks,

Re: [PATCH v1.3 1/18] arcmsr: Revised interrupt service routine relate function to fix bug

2014-08-07 Thread Tomas Henzl
, the overall logic seems to be correct. Reviewed-by: Tomas Henzl the...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1.3 4/18] arcmsr: limit max. number of SCSI command request

2014-08-07 Thread Tomas Henzl
On 08/04/2014 06:00 AM, Ching Huang wrote: On Fri, 2014-08-01 at 05:35 -0700, Christoph Hellwig wrote: @@ -2220,8 +2220,7 @@ static int arcmsr_queue_command_lck(stru arcmsr_handle_virtual_command(acb, cmd); return 0; } - if (atomic_read(acb-ccboutstandingcount)

Re: [PATCH v1.3 3/18] arcmsr: Add code to support system hibernation

2014-08-07 Thread Tomas Henzl
On 08/01/2014 10:36 AM, Ching Huang wrote: This patch adds code to support system hibernation. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c2014-08-01

Re: [PATCH v2 3/17] arcmsr: Add code to support system hibernation

2014-08-08 Thread Tomas Henzl
On 08/08/2014 02:05 PM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch adds code to support system hibernation. Changes in v2 of 3/17: * merge patch 18/18 to this patch Thanks, and please mark the the 18/18 as obsolete - add a comment there In my previous response

Re: [PATCH] pm8001: Update nvmd response data to request buffer

2014-08-11 Thread Tomas Henzl
On 08/11/2014 08:20 AM, Suresh Thiagarajan wrote: Instead of using the virt_ptr use request buffer for copying back the nvmd response data and use the same in request function also Patch looks good to me Reviewed-by: Tomas Henzl the...@redhat.com Signed-off-by: Suresh Thiagarajan

Re: [PATCH v2 RESEND 16/23] mpt3sas: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-08-11 Thread Tomas Henzl
: linux-...@vger.kernel.org Looks good Reviewed-by: Tomas Henzl the...@redhat.com --- drivers/scsi/mpt3sas/mpt3sas_base.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 0cf4f70..7b65ec2

Re: [PATCH v2 RESEND 15/23] mpt2sas: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-08-11 Thread Tomas Henzl
: linux-...@vger.kernel.org Looks good Reviewed-by: Tomas Henzl the...@redhat.com --- drivers/scsi/mpt2sas/mpt2sas_base.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c index 8b88118

Re: [PATCH] hpsa: refine the pci enble/disable handling]

2014-08-14 Thread Tomas Henzl
On 08/13/2014 10:24 PM, scame...@beardog.cce.hp.com wrote: Let me try again, this time not from gmail. On Thu, Jun 12, 2014 at 10:29 AM, Tomas Henzl the...@redhat.com wrote: When a second(kdump) kernel starts and the hard reset method is used the driver calls pci_disable_device without

[PATCH V2] hpsa: refine the pci enable/disable handling

2014-08-14 Thread Tomas Henzl
- removed a no more valid comment - added pci_enable/disable pair when kdump kernel starts - fixed a typo in subject line Signed-off-by: Tomas Henzl the...@redhat.com --- drivers/scsi/hpsa.c | 42 -- 1 file changed, 28 insertions(+), 14 deletions(-) diff

Re: [PATCH v3 08/13] be2iscsi: Use pci_enable_msix_range()

2014-08-21 Thread Tomas Henzl
. Patch looks good to me. Reviewed-by: Tomas Henzl the...@redhat.com Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: Jayamohan Kallickal jayamohan.kallic...@emulex.com Cc: linux-scsi@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/be2iscsi/be_main.c | 6 +++--- 1 file

Re: [PATCH v3 10/13] csiostor: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-08-21 Thread Tomas Henzl
() and pci_enable_msix_range() or pci_enable_msix_exact() interfaces. Patch looks good to me. Reviewed-by: Tomas Henzl the...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v3 09/13] csiostor: Remove superfluous call to pci_disable_msix()

2014-08-21 Thread Tomas Henzl
On 08/18/2014 08:01 AM, Alexander Gordeev wrote: There is no need to call pci_disable_msix() in case the previous call to pci_enable_msix() failed Patch looks good to me. Reviewed-by: Tomas Henzl the...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi

Re: [PATCH v3 11/13] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-08-21 Thread Tomas Henzl
On 08/18/2014 08:01 AM, Alexander Gordeev wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or pci_enable_msi_exact() and

Re: [PATCH v3 13/13] pmcraid: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-08-21 Thread Tomas Henzl
() and pci_enable_msix_range() or pci_enable_msix_exact() interfaces. Patch looks good. Reviewed-by: Tomas Henzl the...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v3 12/13] pmcraid: Get rid of a redundant assignment

2014-08-21 Thread Tomas Henzl
; pinstance-num_hrrq = 1; - rc = 0; rc = request_irq(pdev-irq, pmcraid_isr, IRQF_SHARED, PMCRAID_DRIVER_NAME, pinstance-hrrq_vector[0]); Patch looks good to me. Reviewed-by: Tomas Henzl the...@redhat.com -- To unsubscribe from this list: send the line

Re: [PATCH v3 11/13] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-08-21 Thread Tomas Henzl
On 08/21/2014 01:32 PM, Tomas Henzl wrote: On 08/18/2014 08:01 AM, Alexander Gordeev wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-22 Thread Tomas Henzl
On 08/19/2014 09:17 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Rewrite ioctl entry and its relate function. This patch fix ioctl data read/write error and change data I/O access from byte to Dword. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN

Re: [PATCH v3 0/17] arcmsr: change note since v13 or v2

2014-08-22 Thread Tomas Henzl
On 08/19/2014 05:02 PM, Christoph Hellwig wrote: Hi Ching, I've fixed up various checkpatch errors and fixed up some descriptions and applied the patches to a branch. This includes patch 4, so please send a fix for this and any other patches relative to the branch. Please find the branch

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-25 Thread Tomas Henzl
On 08/25/2014 07:59 PM, Ching Huang wrote: On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: On 08/19/2014 09:17 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Rewrite ioctl entry and its relate function. This patch fix ioctl data read/write error and change data I/O

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-25 Thread Tomas Henzl
On 08/25/2014 12:29 PM, Tomas Henzl wrote: On 08/25/2014 07:59 PM, Ching Huang wrote: On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: On 08/19/2014 09:17 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Rewrite ioctl entry and its relate function. This patch fix ioctl

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-26 Thread Tomas Henzl
On 08/26/2014 10:27 PM, Ching Huang wrote: On Mon, 2014-08-25 at 12:29 +0200, Tomas Henzl wrote: On 08/25/2014 07:59 PM, Ching Huang wrote: On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: On 08/19/2014 09:17 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Rewrite ioctl

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-27 Thread Tomas Henzl
On 08/27/2014 10:19 PM, Ching Huang wrote: On Tue, 2014-08-26 at 15:20 +0200, Tomas Henzl wrote: On 08/26/2014 10:27 PM, Ching Huang wrote: On Mon, 2014-08-25 at 12:29 +0200, Tomas Henzl wrote: On 08/25/2014 07:59 PM, Ching Huang wrote: On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-08-27 Thread Tomas Henzl
On 08/19/2014 09:25 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Add code for supporting Areca new Raid adapter ARC12x4 series. Signed-off-by: Ching Huang ching2...@areca.com.tw --- Hi Ching, please look at the comments below - } @@ -1039,7 +1147,60 @@ static void

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-08-28 Thread Tomas Henzl
On 08/28/2014 05:46 PM, Ching Huang wrote: On Wed, 2014-08-27 at 16:00 +0200, Tomas Henzl wrote: On 08/19/2014 09:25 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Add code for supporting Areca new Raid adapter ARC12x4 series. Signed-off-by: Ching Huang ching2

Re: [PATCH V2] hpsa: refine the pci enable/disable handling

2014-09-08 Thread Tomas Henzl
On 09/07/2014 01:38 AM, Elliott, Robert (Server Storage) wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Tomas Henzl ... +/* kdump kernel is loading, we don't know in which state is + * the pci

Re: [PATCH 02/11] megaraid_sas : Use writeq for 64bit pci write to avoid spinlock overhead

2014-09-09 Thread Tomas Henzl
On 09/06/2014 03:25 PM, sumit.sax...@avagotech.com wrote: Use writeq() for 64bit PCI write instead of writel() to avoid additional lock overhead. Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com Signed-off-by: Kashyap Desai kashyap.de...@avagotech.com ---

Re: [PATCH 03/11] megaraid_sas : Update threshold based reply post host index register

2014-09-09 Thread Tomas Henzl
On 09/06/2014 03:25 PM, sumit.sax...@avagotech.com wrote: Current driver updates reply post host index to let firmware know that replies are processed, while returning from ISR function, only if there is no oustanding replies in reply queue. Driver will free the request frame immediately

Re: [PATCH 04/11] megaraid_sas : Firmware crash dump feature support

2014-09-09 Thread Tomas Henzl
On 09/06/2014 03:25 PM, sumit.sax...@avagotech.com wrote: This feature will provide similar interface as kernel crash dump feature. When megaraid firmware encounter any crash, driver will collect the firmware raw image and dump it into pre-configured location. Driver will allocate two

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-10 Thread Tomas Henzl
On 09/09/2014 06:30 PM, Christoph Hellwig wrote: Ching, do you have a chance to address Thomas second concern below? As far as I can tell (Thomas, please correct me) that's the last outstanding concern, and I'd really like to merge the arcmsr updates for the Linux 3.18 merge window.

Re: [PATCH 04/11] megaraid_sas : Firmware crash dump feature support

2014-09-10 Thread Tomas Henzl
On 09/09/2014 06:18 PM, Elliott, Robert (Server Storage) wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Tomas Henzl Sent: Tuesday, 09 September, 2014 10:54 AM Subject: Re: [PATCH 04/11] megaraid_sas : Firmware

Re: [PATCH 02/11] megaraid_sas : Use writeq for 64bit pci write to avoid spinlock overhead

2014-09-10 Thread Tomas Henzl
On 09/10/2014 12:15 PM, Kashyap Desai wrote: -Original Message- From: Tomas Henzl [mailto:the...@redhat.com] Sent: Tuesday, September 09, 2014 7:01 PM To: sumit.sax...@avagotech.com; linux-scsi@vger.kernel.org Cc: martin.peter...@oracle.com; h...@infradead.org; jbottom

Re: [PATCH 05/11] megaraid_sas : Extended VD support

2014-09-10 Thread Tomas Henzl
On 09/06/2014 03:25 PM, sumit.sax...@avagotech.com wrote: Current MegaRAID firmware and hence the driver only supported 64VDs. E.g: If the user wants to create more than 64VD on a controller, it is not possible on current firmware/driver. New feature and requirement to support upto

Re: [PATCH 08/11] megaraid_sas : Add module parameter to disable IRQ-CPU affinity hint

2014-09-10 Thread Tomas Henzl
On 09/06/2014 03:25 PM, sumit.sax...@avagotech.com wrote: For certain deployment, we may need to disable irq cpu affinity hint. This module parameter provides option for use to disable irq cpu affinity hint and allow irqbalancer to handle the rest. Only curious , in which environments causes

Re: [PATCH 10/11] megaraid_sas : MFI MPT linked list corruption fix

2014-09-10 Thread Tomas Henzl
On 09/06/2014 03:25 PM, sumit.sax...@avagotech.com wrote: Problem statement: MFI link list in megaraid_sas driver is used from mfi-mpt pass-through commands. This list can be corrupted due to many possible race conditions in driver and eventually we may see kernel panic. One example -

Re: [PATCH 04/11] megaraid_sas : Firmware crash dump feature support

2014-09-10 Thread Tomas Henzl
On 09/10/2014 05:06 PM, Elliott, Robert (Server Storage) wrote: From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Sumit Saxena From: Tomas Henzl [mailto:the...@redhat.com] With several controllers in a system this may take a lot memory, could you

Re: [PATCH 04/11] megaraid_sas : Firmware crash dump feature support

2014-09-11 Thread Tomas Henzl
On 09/11/2014 11:02 AM, Kashyap Desai wrote: -Original Message- From: Vivek Goyal [mailto:vgo...@redhat.com] Sent: Wednesday, September 10, 2014 9:17 PM To: Tomas Henzl Cc: Elliott, Robert (Server Storage); Sumit Saxena; linux-scsi@vger.kernel.org; martin.peter...@oracle.com; h

Re: [PATCH 10/11] megaraid_sas : MFI MPT linked list corruption fix

2014-09-11 Thread Tomas Henzl
On 09/11/2014 04:48 AM, Kashyap Desai wrote: On Wed, Sep 10, 2014 at 8:36 PM, Tomas Henzl the...@redhat.com wrote: On 09/06/2014 03:25 PM, sumit.sax...@avagotech.com wrote: Problem statement: MFI link list in megaraid_sas driver is used from mfi-mpt pass-through commands. This list can

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-11 Thread Tomas Henzl
On 09/11/2014 05:59 AM, Ching Huang wrote: On Wed, 2014-09-10 at 11:58 +0200, Tomas Henzl wrote: On 09/09/2014 06:30 PM, Christoph Hellwig wrote: Ching, do you have a chance to address Thomas second concern below? As far as I can tell (Thomas, please correct me) that's the last outstanding

Re: [PATCH 04/11] megaraid_sas : Firmware crash dump feature support

2014-09-11 Thread Tomas Henzl
On 09/11/2014 06:39 PM, Kashyap Desai wrote: On Thu, Sep 11, 2014 at 4:50 PM, Tomas Henzl the...@redhat.com wrote: On 09/11/2014 11:02 AM, Kashyap Desai wrote: -Original Message- From: Vivek Goyal [mailto:vgo...@redhat.com] Sent: Wednesday, September 10, 2014 9:17 PM To: Tomas Henzl

Re: [PATCH 10/11] megaraid_sas : MFI MPT linked list corruption fix

2014-09-11 Thread Tomas Henzl
On 09/11/2014 08:41 PM, Kashyap Desai wrote: On Thu, Sep 11, 2014 at 5:53 PM, Tomas Henzl the...@redhat.com wrote: On 09/11/2014 04:48 AM, Kashyap Desai wrote: On Wed, Sep 10, 2014 at 8:36 PM, Tomas Henzl the...@redhat.com wrote: On 09/06/2014 03:25 PM, sumit.sax...@avagotech.com wrote

[PATCH] hpsa: add missing pci_set_master in kdump path

2014-09-12 Thread Tomas Henzl
Add a call to pci_set_master(...) missing in the previous patch hpsa: refine the pci enable/disable handling. Found thanks to Rob Elliot. --- drivers/scsi/hpsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 7828834..cef5d49

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-12 Thread Tomas Henzl
On 09/12/2014 09:29 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch is to modify previous patch 13/17 and it is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr change in v4: 1. for readability, rename

Re: [PATCH v4 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-12 Thread Tomas Henzl
On 09/12/2014 10:22 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch is to modify previous patch 16/17 and it is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr change in v4: 1. clean up of duplicate variable

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-15 Thread Tomas Henzl
On 09/15/2014 04:56 AM, Ching Huang wrote: On Fri, 2014-09-12 at 15:34 +0200, Tomas Henzl wrote: On 09/12/2014 09:29 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch is to modify previous patch 13/17 and it is relative to http://git.infradead.org/users/hch/scsi

Re: [PATCH v4 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-15 Thread Tomas Henzl
On 09/15/2014 06:34 AM, Ching Huang wrote: On Fri, 2014-09-12 at 16:05 +0200, Tomas Henzl wrote: On 09/12/2014 10:22 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch is to modify previous patch 16/17 and it is relative to http://git.infradead.org/users/hch/scsi

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-15 Thread Tomas Henzl
On 09/15/2014 12:36 PM, Ching Huang wrote: On Mon, 2014-09-15 at 12:25 +0200, Tomas Henzl wrote: On 09/15/2014 04:56 AM, Ching Huang wrote: On Fri, 2014-09-12 at 15:34 +0200, Tomas Henzl wrote: On 09/12/2014 09:29 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-15 Thread Tomas Henzl
On 09/10/2014 11:58 AM, Tomas Henzl wrote: On 09/09/2014 06:30 PM, Christoph Hellwig wrote: Ching, do you have a chance to address Thomas second concern below? As far as I can tell (Thomas, please correct me) that's the last outstanding concern, and I'd really like to merge the arcmsr

Re: [PATCH v5 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-15 Thread Tomas Henzl
in arcmsr_done4abort_postqueue for protect doneq_index. 2. fix spinlock area in arcmsr_hbaD_polling_ccbdone. You might have kept the previous change log here too, it's probably better when merged with the 16/17. I have no more concerns, so Reviewed-by: Tomas Henzl the...@redhat.com -- To unsubscribe from

Re: [PATCH] hpsa: add missing pci_set_master in kdump path

2014-09-24 Thread Tomas Henzl
Christoph, this is a fix for 132aa220b45d60e9b20def1e9d8be9422eed9616 hpsa: refine the pci enable/disable handling which is in 'for-3.18'. If this patch will not be reviewed and added to 3.18 the aforementioned patch needs to be reverted. Tomas On 09/12/2014 02:44 PM, Tomas Henzl wrote

Re: [PATCH] hpsa: add missing pci_set_master in kdump path

2014-09-25 Thread Tomas Henzl
On 09/25/2014 02:20 PM, Christoph Hellwig wrote: Tomas, can you also give me a signed-off-by for this one? Oh, I forgot to add it before. Patch is Signed-off-by: Tomas Henzl the...@redhat.com On Fri, Sep 12, 2014 at 02:44:15PM +0200, Tomas Henzl wrote: Add a call to pci_set_master

[PATCH 1/2] hpsa: create new workqueue instead of using a shared wq

2014-10-31 Thread Tomas Henzl
hpsa_wait_for_clear_event_notify_ack) Signed-off-by: Tomas Henzl the...@redhat.com --- drivers/scsi/hpsa.c | 38 -- drivers/scsi/hpsa.h | 1 + 2 files changed, 25 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index cef5d49b59..f60ce7e5bb 100644

  1   2   3   4   5   6   7   >