Re: [PATCH] xen/scsifront: use offset_in_page() macro

2017-04-25 Thread Juergen Gross 
On 22/04/17 03:21, Geliang Tang wrote:
> Use offset_in_page() macro instead of open-coding.
> 
> Signed-off-by: Geliang Tang 

Pushed to xen/tip for-linus-4.12


Thanks,

Juergen

Re: [PATCH] xen/scsifront: use offset_in_page() macro

2017-04-24 Thread Juergen Gross 
On 25/04/17 00:15, Martin K. Petersen wrote:
> 
> Juergen,
> 
>> On 22/04/17 03:21, Geliang Tang wrote:
>>> Use offset_in_page() macro instead of open-coding.
>>>
>>> Signed-off-by: Geliang Tang 
>>
>> Reviewed-by: Juergen Gross 
> 
> Taking this through the Xen tree or should I queue it?

I can take it through the Xen tree.


Thanks,

Juergen

Re: [PATCH] xen/scsifront: use offset_in_page() macro

2017-04-24 Thread Martin K. Petersen 

Juergen,

> On 22/04/17 03:21, Geliang Tang wrote:
>> Use offset_in_page() macro instead of open-coding.
>> 
>> Signed-off-by: Geliang Tang 
>
> Reviewed-by: Juergen Gross 

Taking this through the Xen tree or should I queue it?

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH] xen/scsifront: use offset_in_page() macro

2017-04-23 Thread Juergen Gross 
On 22/04/17 03:21, Geliang Tang wrote:
> Use offset_in_page() macro instead of open-coding.
> 
> Signed-off-by: Geliang Tang 

Reviewed-by: Juergen Gross 


Thanks,

Juergen

[PATCH] xen/scsifront: use offset_in_page() macro

2017-04-21 Thread Geliang Tang 
Use offset_in_page() macro instead of open-coding.

Signed-off-by: Geliang Tang 
---
 drivers/scsi/xen-scsifront.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
index 9aa1fe1..a6a8b60 100644
--- a/drivers/scsi/xen-scsifront.c
+++ b/drivers/scsi/xen-scsifront.c
@@ -434,7 +434,7 @@ static int map_data_for_request(struct vscsifrnt_info *info,
 
if (seg_grants) {
page = virt_to_page(seg);
-   off = (unsigned long)seg & ~PAGE_MASK;
+   off = offset_in_page(seg);
len = sizeof(struct scsiif_request_segment) * data_grants;
while (len > 0) {
bytes = min_t(unsigned int, len, PAGE_SIZE - off);
-- 
2.9.3