Re: [PATCH 4/4] scsi: pmcraid: fix minor sparse warnings
Looks fine, Reviewed-by: Christoph Hellwig
[PATCH 4/4] scsi: pmcraid: fix minor sparse warnings
pmcraid_minor is only used in this one file and should be 'static' as suggested by sparse: drivers/scsi/pmcraid.c:80:1: warning: symbol 'pmcraid_minor' was not declared. Should it be static? In Linux coding style, a literal '0' integer should not be used to represent a NULL pointer: