Re: [PATCH v2] virtio_scsi: Reject commands when virtqueue is broken

2017-01-20 Thread Martin K. Petersen
> "Eric" == Eric Farman writes: Eric> In the case of a graceful set of detaches, where the Eric> virtio-scsi-ccw disk is removed from the guest prior to the Eric> controller, the guest behaves quite normally. Specifically, the Eric> detach gets us into

Re: [PATCH v2] virtio_scsi: Reject commands when virtqueue is broken

2017-01-15 Thread Fam Zheng
On Fri, 01/13 12:48, Eric Farman wrote: > In the case of a graceful set of detaches, where the virtio-scsi-ccw > disk is removed from the guest prior to the controller, the guest > behaves quite normally. Specifically, the detach gets us into > sd_sync_cache to issue a Synchronize Cache(10)

[PATCH v2] virtio_scsi: Reject commands when virtqueue is broken

2017-01-13 Thread Eric Farman
In the case of a graceful set of detaches, where the virtio-scsi-ccw disk is removed from the guest prior to the controller, the guest behaves quite normally. Specifically, the detach gets us into sd_sync_cache to issue a Synchronize Cache(10) command, which immediately fails (and is retried a

[PATCH v2] virtio_scsi: Reject commands when virtqueue is broken

2017-01-13 Thread Eric Farman
While doing some disruptive testing with QEMU/KVM, I have encountered some guest problems during hot unplug of virtio-scsi devices depending on the order of operations in which they are performed. The following notes describe my setup (s390x), and how I'm able to reproduce the error and test the