On 12/7/18 8:20 PM, Martin K. Petersen wrote:
>
> Jens,
>
> This went in through your tree. Can you please pick this fix up?
Yep, applied, thanks Dan.
--
Jens Axboe
James,
> Update lpfc to revision 12.0.0.9
>
> This patch contains lpfc bug fixes
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> If "interface" is NULL then we can't release it and trying to will
> only lead to an Oops.
Applied to 4.20/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This reverts commit db186382af21e926e90df19499475f2552192b77.
>
> This commit introduced regression with FCP discovery so revert it back
> to fix discovery for FCP luns
Applied to 4.20/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
Jens,
This went in through your tree. Can you please pick this fix up?
> On Thu, Nov 29, 2018 at 01:37:10PM +0300, Dan Carpenter wrote:
>> Smatch generates a warning:
>>
>> drivers/scsi/scsi_lib.c:1656 scsi_mq_done() warn: test_bit() takes a bit
>> number
>>
>> The problem is that
r-PQI-Config-Table-handshake
> . add support for get/set controller features.
> - smartpqi-add-retries-for-device-resets
> . re-attempt device reset.
> - smartpqi-add-no_write_same-for-logical-volumes
> . turn off WRITE SAME for logical volumes.
> - smartpqi-correct-host-serial-
Steffen,
> One new recovery fix, which is not urgent, for an old bug. It's
> sufficient to apply it on top of the previously sent 23 zfcp updates
> for the v4.21 merge window
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
David,
> This patch-set allows for the modification of the T10 Vendor
> Identification string returned in the SCSI INQUIRY response, via the
> target/core/$backstore/$name/wwn/vendor_id ConfigFS path.
Applied to 4.21/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Bart,
> Nesting in __qla2x00_abort_all_cmds() is way too deep. Reduce the
> nesting level by introducing a helper function. This patch does not
> change any functionality.
Applied to 4.21/scsi-queue. Thank you.
--
Martin K. Petersen Oracle Linux Engineering
Varun,
> flush_scheduled_work() is not required as csio_hw_exit_workers() calls
> cancel_work_sync() for hw->evtq_work.
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Steffen,
> Introduce separate zfcp module parameters to individually select
> support for: DIF which should work (zfcp.dif, which used to be
> DIF+DIX, disabled) or DIX+DIF which can cause trouble (zfcp.dix, new,
> disabled).
Applied to 4.21/scsi-queue.
--
Martin K. Petersen Oracle
Avri,
> By spec, the ufs sense data is 18 bytes long.
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Note that independent of what we do in the Linux iSCSI initiator
this is a network DOS, so we'll have to fix it.
On Wed, Dec 05, 2018 at 12:09:40PM -0800, Lee Duncan wrote:
> I recently found what I believe is a bug, and I'd appreciate feedback
> on if that is correct, and if so how to proceed.
>
On Thu, 6 Dec 2018, Christoph Hellwig wrote:
> This function is a huge mess with duplicated error handling. Split out
> a few useful helpers and use goto labels to untangle the error handling
> and no-data ioctl handling.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/gdth.c |
Would be nice to be pointed to the correct place to report major
regressions, if not here.
Note that the same error occurs:
* on 4.18.19
* on 4.19.8-rc1
* with the latest firmware (16.00.01)
* on a number of other peoples' powerpc64/power9 hardware.
Note that both 4.18.X and 4.19.Y will,
On 06/12/2018 17:50, Johannes Thumshirn wrote:
> Why not calling dma_alloc_coherent() directly instead of using the
> pci_alloc_consistent() wrapper?
Ah should've read the whole series
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de
On 06/12/2018 16:57, Christoph Hellwig wrote:
> Out of the three callers once insists on the scratch buffer, and the
> others are fine with a new allocation. Switch those two to juse use
> pci_alloc_consistent directly, and open code the scratch buffer
> allocation in the remaining one. This
On 23/10/2018 06:35, Can Guo wrote:
> From: Dov Levenglick
>
> Enables core reset support. Add full initialization of the PHY and the
> controller before initializing UFS PHY and during link recovery.
>
> Signed-off-by: Dov Levenglick
> Signed-off-by: Amit Nischal
> Signed-off-by: Subhash
David,
> Indeed, the comment should refer to page 0x83.
> @Martin: all patches in this series have now been reviewed+acked. Can
> you fix the above comment (s/0x80/0x83) if/when you merge, or
>should I resend the series with this fixed?
I'll fix it up.
--
Martin K. Petersen
On Thu, 6 Dec 2018 15:25:42 +0300, Roman Bolshakov wrote:
> > /*
> > + * STANDARD and VPD page 0x80 T10 Vendor Identification
>
> Perhaps you meant 0x83 (Device Identification VPD page, T10 vendor ID
> based designator). INQUIRY page 0x80 is Unit Serial Number.
Indeed, the comment should
On Wed, Dec 05, 2018 at 01:18:35PM +0100, David Disseldorp wrote:
> In preparation for supporting user provided vendor strings, add an extra
> byte to the vendor, model and revision arrays in struct t10_wwn. This
> ensures that the full INQUIRY data can be carried in the arrays along
> with a
On Wed, Dec 05, 2018 at 01:18:36PM +0100, David Disseldorp wrote:
> The vendor_id attribute will allow for the modification of the T10
> Vendor Identification string returned in inquiry responses. Its value
> can be viewed and modified via the ConfigFS path at:
>
Hi,
在 2018/12/6 20:04, John Garry 写道:
On 06/12/2018 04:17, Martin K. Petersen wrote:
+
Bart,
Had you considered to use lower_32_bits() instead of "0x"?
That would to avoid that reviewers have to count the 'f'-s to verify
correctness of t10_pi_ref_tag().
I hadn't. I guess I tend
4/6, I have already reviewed the entire series,
> and it looks good.
> If adding new bindings for sdm845 needs a further review, can you separate out
> just the phy patches from this series (patch 1, 2, 3 & 6), and re-send them.
> We can ask Kishon if he can pull them in for
On 06/12/2018 04:17, Martin K. Petersen wrote:
+
Bart,
Had you considered to use lower_32_bits() instead of "0x"?
That would to avoid that reviewers have to count the 'f'-s to verify
correctness of t10_pi_ref_tag().
I hadn't. I guess I tend to think of lower_32_bits() as something
Dne 6.12.2018 v 11:34 Maurizio Lombardi napsal(a):
> This is what I see when a cd burn operation completes:
>
This is the complete blktrace log:
11,034 0.81759 11653 D W 63488 (2a 00 00 03 3c 29 00 00
1f 00 ..) [wodim]
11,034 0.81759 11653 D
Hi Jens,
Dne 20.6.2018 v 16:09 Jens Axboe napsal(a):
> On 6/20/18 5:52 AM, Maurizio Lombardi wrote:
>> Hi Jens,
>>
>> Dne 23.5.2018 v 16:42 Jens Axboe napsal(a):
>>> On 5/23/18 3:19 AM, Maurizio Lombardi wrote:
Dne 22.5.2018 v 16:47 Jens Axboe napsal(a):
> It's been many years,
Bart,
> Had you considered to use lower_32_bits() instead of "0x"?
> That would to avoid that reviewers have to count the 'f'-s to verify
> correctness of t10_pi_ref_tag().
I hadn't. I guess I tend to think of lower_32_bits() as something you do
to pointers, not to block numbers.
--
On 11/21/18 1:41 AM, Christoph Hellwig wrote:
> Hi all,
>
> you in the To list maintain or wrote SCSI drivers that set the
> DISABLE_CLUSTERING flag, which basically disable merges of any
> bio segments. We already have the actual max_segment size limit
> to say which length a segment should
On 12/5/18 6:04 AM, Martin K. Petersen wrote:
Since the return value of this function is 'u32', can the ' &
0x' be left out?
Absolutely, and I almost zapped it. However, I decided to leave it to
emphasize the point that the reference tag is truncated to a 32-bit
value. To me, this is
Hi Bart,
> Since the return value of this function is 'u32', can the ' &
> 0x' be left out?
Absolutely, and I almost zapped it. However, I decided to leave it to
emphasize the point that the reference tag is truncated to a 32-bit
value. To me, this is more obvious than having to
On 12/4/18 6:31 PM, Martin K. Petersen wrote:
Commit ddd0bc756983 ("block: move ref_tag calculation func to the block
layer") moved ref tag calculation from SCSI to a library function. However,
this change broke returning the correct ref tag for devices operating in
DIF mode since these do not
On Tue, 2018-12-04 at 16:26 +0300, Roman Bolshakov wrote:
> wrt PATCH 5 in the series. Should we allow to set vendor_id for for
> pscsi?
I think we should allow that.
Bart.
On Tue, 4 Dec 2018 15:13:51 +0300, Roman Bolshakov wrote:
> > + /* Assume ASCII encoding. Strip any newline added from userspace. */
> > + BUILD_BUG_ON(sizeof(dev->t10_wwn.vendor) != INQUIRY_VENDOR_LEN + 1);
> > + strlcpy(dev->t10_wwn.vendor, strstrip(buf),
> > +
On Tue, 4 Dec 2018 16:26:59 +0300, Roman Bolshakov wrote:
> wrt PATCH 5 in the series. Should we allow to set vendor_id for for
> pscsi? target_transport_configure sets t10_wwn fields for pscsi, but but
> an attempt to set vendor_id will overwrite the value recieved from
> scsi_device.
I
On Tue, Dec 04, 2018 at 03:13:51PM +0300, Roman Bolshakov wrote:
> On Tue, Dec 04, 2018 at 11:12:36AM +0100, David Disseldorp wrote:
> > The vendor_id attribute will allow for the modification of the T10
> > Vendor Identification string returned in inquiry responses. Its value
> > can be viewed
On Tue, Dec 04, 2018 at 11:12:38AM +0100, David Disseldorp wrote:
> Initialise the t10_wwn vendor, model and revision defaults when a
> device is allocated instead of when it's enabled. This ensures that
> custom vendor or model strings set prior to enablement are not later
> overwritten with
On Tue, Dec 04, 2018 at 11:12:37AM +0100, David Disseldorp wrote:
> Use the value stored in t10_wwn.vendor, which defaults to "LIO-ORG", but
> can be reconfigured via the vendor_id ConfigFS attribute.
>
> Signed-off-by: David Disseldorp
> Reviewed-by: Bryant G. Ly
> Reviewed-by: Lee Duncan
>
On Tue, Dec 04, 2018 at 11:12:36AM +0100, David Disseldorp wrote:
> The vendor_id attribute will allow for the modification of the T10
> Vendor Identification string returned in inquiry responses. Its value
> can be viewed and modified via the ConfigFS path at:
>
On Sat, Dec 01, 2018 at 12:34:20AM +0100, David Disseldorp wrote:
> In preparation for supporting user provided vendor strings, add an extra
> byte to the vendor, model and revision arrays in struct t10_wwn. This
> ensures that the full INQUIRY data can be carried in the arrays along
> with a
On Sat, Dec 01, 2018 at 12:34:19AM +0100, David Disseldorp wrote:
> spc5r17.pdf specifies:
> 4.3.1 ASCII data field requirements
> ASCII data fields shall contain only ASCII printable characters (i.e.,
> code values 20h to 7Eh) and may be terminated with one or more ASCII
> null (00h)
Shchislowski
> ; Alex Lemberg ;
> Bart Van Assche ; Evan Green
> ; Doug Anderson ;
> Tomas Winkler ; adrian.hun...@intel.com;
> Sayali Lokhande
> Subject: RE: [PATCH 0/3] scsi: ufs-bsg: Add read descriptor
>
> A gentle ping.
>
> Cheers,
> Avri
>
> > -Origi
On Sat, 2018-12-01 at 15:59 +0100, Hannes Reinecke wrote:
> On 12/1/18 12:34 AM, David Disseldorp wrote:
> > Initialise the t10_wwn vendor, model and revision defaults when a
> > device is allocated instead of when it's enabled. This ensures that
> > custom vendor or model strings set prior to
On Mon, 3 Dec 2018, Hannes Reinecke wrote:
> As I said: I need to do PIO for the last two bytes of the data buffer.
> For everything else DMA works nicely, it's just the last two bytes which
> might be left over in the FIFO buffer under certain circumstances.
I read the driver a few times
On 12/2/18 11:13 PM, Finn Thain wrote:
On Sun, 2 Dec 2018, Hannes Reinecke wrote:
On 12/2/18 10:21 PM, Finn Thain wrote:
On Sun, 2 Dec 2018, Hannes Reinecke wrote:
Well, that lone 'kmap' is due to a quirk/errata in the datasheet;
essentially
we have to PIO a lone byte out of the FIFO to
On Sun, 2 Dec 2018 23:22:23 +0100, David Disseldorp wrote:
> > > + if (!(dev->transport->transport_flags & TRANSPORT_FLAG_PASSTHROUGH)) {
> > > + strlcpy(dev->t10_wwn.vendor, "LIO-ORG",
> > > + sizeof(dev->t10_wwn.vendor));
> > > + strlcpy(dev->t10_wwn.model,
Hi Hannes,
Thanks for the feedback...
On Sat, 1 Dec 2018 15:59:25 +0100, Hannes Reinecke wrote:
> On 12/1/18 12:34 AM, David Disseldorp wrote:
...
> > @@ -810,6 +810,23 @@ struct se_device *target_alloc_device(struct se_hba
> > *hba, const char *name)
> >
On Sun, 2 Dec 2018, Hannes Reinecke wrote:
> On 12/2/18 10:21 PM, Finn Thain wrote:
> > On Sun, 2 Dec 2018, Hannes Reinecke wrote:
> >
> > > Well, that lone 'kmap' is due to a quirk/errata in the datasheet;
> > > essentially
> > > we have to PIO a lone byte out of the FIFO to clear it up.
> > >
On 12/2/18 10:21 PM, Finn Thain wrote:
On Sun, 2 Dec 2018, Hannes Reinecke wrote:
Well, that lone 'kmap' is due to a quirk/errata in the datasheet; essentially
we have to PIO a lone byte out of the FIFO to clear it up.
And this byte is technically still part of the SCSI data, so we need to
On Sun, 2 Dec 2018, Hannes Reinecke wrote:
> Well, that lone 'kmap' is due to a quirk/errata in the datasheet; essentially
> we have to PIO a lone byte out of the FIFO to clear it up.
> And this byte is technically still part of the SCSI data, so we need to
> stuff it onto the end of the actual
On 11/26/18 10:46 AM, Finn Thain wrote:
On Mon, 26 Nov 2018, Christoph Hellwig wrote:
On Thu, Nov 22, 2018 at 09:02:13AM +1100, Finn Thain wrote:
you in the To list maintain or wrote SCSI drivers that set the
DISABLE_CLUSTERING flag, which basically disable merges of any
bio segments. We
On 12/1/18 12:34 AM, David Disseldorp wrote:
Initialise the t10_wwn vendor, model and revision defaults when a
device is allocated instead of when it's enabled. This ensures that
custom vendor or model strings set prior to enablement are not later
overwritten with default values.
Signed-off-by:
On 12/1/18 12:34 AM, David Disseldorp wrote:
Use the value stored in t10_wwn.vendor, which defaults to "LIO-ORG", but
can be reconfigured via the vendor_id ConfigFS attribute.
Signed-off-by: David Disseldorp
Reviewed-by: Bryant G. Ly
Reviewed-by: Lee Duncan
---
On 12/1/18 12:34 AM, David Disseldorp wrote:
The vendor_id attribute will allow for the modification of the T10
Vendor Identification string returned in inquiry responses. Its value
can be viewed and modified via the ConfigFS path at:
target/core/$backstore/$name/wwn/vendor_id
"LIO-ORG" remains
On 12/1/18 12:34 AM, David Disseldorp wrote:
In preparation for supporting user provided vendor strings, add an extra
byte to the vendor, model and revision arrays in struct t10_wwn. This
ensures that the full INQUIRY data can be carried in the arrays along
with a null-terminator.
Change a
On 12/1/18 12:34 AM, David Disseldorp wrote:
spc5r17.pdf specifies:
4.3.1 ASCII data field requirements
ASCII data fields shall contain only ASCII printable characters (i.e.,
code values 20h to 7Eh) and may be terminated with one or more ASCII
null (00h) characters.
ASCII data
On 11/30/18 4:44 AM, David Disseldorp wrote:
> On Wed, 28 Nov 2018 17:23:07 -0800, Lee Duncan wrote:
>
>>> +* unused bytes at the end of the field (i.e., highest offset) and the
>>> +* unused bytes shall be filled with ASCII space characters (20h).
>>> +*/
>>> + memset([8], 0x20, 8
On Fri, 2018-11-30 at 15:41 +0100, David Disseldorp wrote:
> On Fri, 30 Nov 2018 14:17:49 +0100, David Disseldorp wrote:
>
> > > Where is the code that initializes dev->t10_wwn.vendor to "LIO-ORG"? Did I
> > > perhaps overlook something?
> >
> > This is done in target_configure_device() .
>
>
On Fri, 30 Nov 2018 14:17:49 +0100, David Disseldorp wrote:
> > Where is the code that initializes dev->t10_wwn.vendor to "LIO-ORG"? Did I
> > perhaps overlook something?
>
> This is done in target_configure_device() .
Hmm, continuing to do it there may cause a bit of confusion if vendor_id
On Thu, 29 Nov 2018 08:35:26 -0800, Bart Van Assche wrote:
> Where is the code that initializes dev->t10_wwn.vendor to "LIO-ORG"? Did I
> perhaps overlook something?
This is done in target_configure_device() .
> Additionally, why are you using strnlen() for
> a string of which it is guaranteed
A gentle ping.
Cheers,
Avri
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org
> On Behalf Of Avri Altman
> Sent: Monday, November 26, 2018 11:03 AM
> To: James E.J. Bottomley ; Martin K. Petersen
> ; linux-scsi@vger.kernel.org
> Cc: Christoph Hellwig ; Bart Van Assche
> ;
On Thu, 29 Nov 2018 08:32:47 -0800, Bart Van Assche wrote:
> > + unsigned char buf[INQUIRY_VENDOR_LEN + 1];
> > +
> > + if (strlen(page) > INQUIRY_VENDOR_LEN) {
> > + pr_err("Emulated T10 Vendor Identification exceeds"
> > + " INQUIRY_VENDOR_LEN: "
On Thu, 2018-11-29 at 21:31 +0100, David Disseldorp wrote:
> On Thu, 29 Nov 2018 08:24:38 -0800, Bart Van Assche wrote:
> > On Thu, 2018-11-29 at 02:01 +0100, David Disseldorp wrote:
> > > [ ... ]
> > Additionally, have you considered to use strlcpy()
> > instead of snprintf()?
>
> Happy to
On Thu, 29 Nov 2018 08:24:38 -0800, Bart Van Assche wrote:
> On Thu, 2018-11-29 at 02:01 +0100, David Disseldorp wrote:
> > diff --git a/drivers/target/target_core_configfs.c
> > b/drivers/target/target_core_configfs.c
> > index f6b1549f4142..9f49b1afd685 100644
> > ---
On Thu, 2018-11-29 at 02:01 +0100, David Disseldorp wrote:
> The existing for loops step over null-terminators for right-padding.
> Padding can be achieved in a much simpler way using printf width
> specifiers.
How about squashing patches 2, 3, 4 and 7 into a single patch? I think
that would make
On Thu, 2018-11-29 at 02:01 +0100, David Disseldorp wrote:
> Use the value stored in t10_wwn.vendor, which defaults to "LIO-ORG", but
> can be reconfigured via the vendor_id ConfigFS attribute.
>
> Signed-off-by: David Disseldorp
> ---
> drivers/target/target_core_spc.c | 8 +---
> 1 file
On Thu, 2018-11-29 at 02:01 +0100, David Disseldorp wrote:
> +static ssize_t target_wwn_vendor_id_show(struct config_item *item,
> + char *page)
> +{
> + return sprintf(page, "%s\n", _t10_wwn(item)->vendor[0]);
> +}
The "&" and "[0]" are superfluous in the above sprintf()
On Thu, 2018-11-29 at 02:01 +0100, David Disseldorp wrote:
> strncpy(>t10_wwn.revision[0],
> - dev->transport->inquiry_rev, 4);
> + dev->transport->inquiry_rev, INQUIRY_REVISION_LEN);
> + dev->t10_wwn.revision[INQUIRY_REVISION_LEN]
On Thu, 2018-11-29 at 02:01 +0100, David Disseldorp wrote:
> diff --git a/drivers/target/target_core_configfs.c
> b/drivers/target/target_core_configfs.c
> index f6b1549f4142..9f49b1afd685 100644
> --- a/drivers/target/target_core_configfs.c
> +++ b/drivers/target/target_core_configfs.c
> @@
On Thu, 2018-11-29 at 02:01 +0100, David Disseldorp wrote:
> - strncpy(>t10_wwn.vendor[0], "LIO-ORG", 8);
> + strncpy(>t10_wwn.vendor[0], "LIO-ORG", INQUIRY_VENDOR_LEN);
> + dev->t10_wwn.vendor[INQUIRY_VENDOR_LEN] = '\0';
This looks weird to me. Have you
On Thu, Nov 29, 2018 at 01:37:10PM +0300, Dan Carpenter wrote:
> Smatch generates a warning:
>
> drivers/scsi/scsi_lib.c:1656 scsi_mq_done() warn: test_bit() takes a bit
> number
>
> The problem is that SCMD_STATE_COMPLETE is supposed to be bit number 0
> and not a mask like "(1 << 0)". It
Bart,
> The two patches in this series make the qla2xxx driver source code
> easier to read without changing the driver functionality. Please
> consider these patches for kernel v4.21.
I applied patch #1. #2 had conflicts, please rebase.
Thanks!
--
Martin K. Petersen Oracle Linux
Nilesh,
> Please consider below patch set for next 'scsi-fixes' submission.
Some of these smelled more like features than bug fixes. So I applied
the series to 4.21/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Steffen,
As I said, I don't have a problem with having module parameters.
> There's one more important thing that has performance impact: We need to
> pack payload and protection data into the same queue of limited
> length. So for the worst case with DIX, we have to use half the size for
>
On 11/28/18 5:01 PM, David Disseldorp wrote:
> From: Bart Van Assche
>
> The existing for loops step over null-terminators for right-padding.
> Padding can be achieved in a much simpler way using printf width
> specifiers.
>
> Signed-off-by: David Disseldorp
> ---
>
On 11/28/18 5:01 PM, David Disseldorp wrote:
> Use the value stored in t10_wwn.vendor, which defaults to "LIO-ORG", but
> can be reconfigured via the vendor_id ConfigFS attribute.
>
> Signed-off-by: David Disseldorp
> ---
> drivers/target/target_core_spc.c | 8 +---
> 1 file changed, 5
On 11/28/18 5:01 PM, David Disseldorp wrote:
> The vendor_id attribute will allow for the modification of the T10
> Vendor Identification string returned in inquiry responses. Its value
> can be viewed and modified via the ConfigFS path at:
> target/core/$backstore/$name/wwn/vendor_id
>
>
On 11/28/18 5:01 PM, David Disseldorp wrote:
> The pscsi_set_inquiry_info() codepath doesn't currently explicitly
> null-terminate t10_wwn.revision.
> Add an extra byte to the t10_wwn.model buffer and perform null string
> termination in all cases.
>
> Signed-off-by: David Disseldorp
> ---
>
On 11/28/18 5:01 PM, David Disseldorp wrote:
> The pscsi_set_inquiry_info() and emulate_model_alias_store() codepaths
> don't currently explicitly null-terminate t10_wwn.model.
> Add an extra byte to the t10_wwn.model buffer and perform null string
> termination in all cases.
>
>
On 11/28/18 5:01 PM, David Disseldorp wrote:
> In preparation for supporting user provided vendor strings, add an extra
> byte to t10_wwn.vendor which will ensure null string termination when an
> eight byte vendor string is provided by the user.
>
> Signed-off-by: David Disseldorp
> ---
>
> On Nov 28, 2018, at 7:01 PM, David Disseldorp wrote:
>
> In preparation for supporting user provided vendor strings, add an extra
> byte to t10_wwn.vendor which will ensure null string termination when an
> eight byte vendor string is provided by the user.
>
> Signed-off-by: David
> On Nov 28, 2018, at 7:01 PM, David Disseldorp wrote:
>
> spc5r17.pdf specifies:
> 4.3.1 ASCII data field requirements
> ASCII data fields shall contain only ASCII printable characters (i.e.,
> code values 20h to 7Eh) and may be terminated with one or more ASCII
> null (00h) characters.
On 11/28/18 5:01 PM, David Disseldorp wrote:
> spc5r17.pdf specifies:
> 4.3.1 ASCII data field requirements
> ASCII data fields shall contain only ASCII printable characters (i.e.,
> code values 20h to 7Eh) and may be terminated with one or more ASCII
> null (00h) characters.
> ASCII
> On Nov 28, 2018, at 7:01 PM, David Disseldorp wrote:
>
> Use the value stored in t10_wwn.vendor, which defaults to "LIO-ORG", but
> can be reconfigured via the vendor_id ConfigFS attribute.
>
> Signed-off-by: David Disseldorp
> ---
> drivers/target/target_core_spc.c | 8 +---
> 1 file
> On Nov 28, 2018, at 7:01 PM, David Disseldorp wrote:
>
> The vendor_id attribute will allow for the modification of the T10
> Vendor Identification string returned in inquiry responses. Its value
> can be viewed and modified via the ConfigFS path at:
>
> On Nov 28, 2018, at 7:01 PM, David Disseldorp wrote:
>
> The pscsi_set_inquiry_info() and emulate_model_alias_store() codepaths
> don't currently explicitly null-terminate t10_wwn.model.
> Add an extra byte to the t10_wwn.model buffer and perform null string
> termination in all cases.
>
>
> On Nov 28, 2018, at 7:01 PM, David Disseldorp wrote:
>
> The pscsi_set_inquiry_info() codepath doesn't currently explicitly
> null-terminate t10_wwn.revision.
> Add an extra byte to the t10_wwn.model buffer and perform null string
> termination in all cases.
>
> Signed-off-by: David
On 11/21/18 1:25 AM, Nilesh Javali wrote:
> From: Manish Rangankar
>
> 1. Removed logic to update HW producer index in interrupt context.
> 2. Update HW producer index after UIO ring and buffer gets initialized.
>
> Signed-off-by: Manish Rangankar
> ---
> drivers/scsi/qedi/qedi_main.c | 31
On 11/21/18 1:25 AM, Nilesh Javali wrote:
> Default packet size is 0x400.
> For jumbo packets set to 0x2400.
>
> Signed-off-by: Nilesh Javali
> ---
> drivers/scsi/qedi/qedi.h | 1 -
> drivers/scsi/qedi/qedi_main.c | 13 +
> 2 files changed, 9 insertions(+), 5 deletions(-)
>
>
On 11/21/18 1:25 AM, Nilesh Javali wrote:
> From: Manish Rangankar
>
> Add packet filter to avoid unnecessary packet processing in iscsiuio.
>
> Signed-off-by: Manish Rangankar
> ---
> drivers/scsi/qedi/qedi_main.c | 24
> 1 file changed, 24 insertions(+)
>
> diff
On 11/21/18 1:25 AM, Nilesh Javali wrote:
> From: Manish Rangankar
>
> The kernel panic was observed after switch side perturbation,
>
> BUG: unable to handle kernel NULL pointer dereference at (null)
> IP: [] strcmp+0x20/0x40
> PGD 0 Oops: [#1] SMP
> CPU: 8 PID: 647 Comm:
On 11/21/18 1:25 AM, Nilesh Javali wrote:
> Use QEDI_PAGE_SIZE for enablement of module on systems with 64K page size.
>
> Signed-off-by: Nilesh Javali
> ---
> drivers/scsi/qedi/qedi_main.c | 16 +---
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git
On 11/21/18 1:25 AM, Nilesh Javali wrote:
> Fix trivial spelling mistake within macro definition.
>
> Signed-off-by: Nilesh Javali
> ---
> drivers/scsi/qedi/qedi.h | 4 ++--
> drivers/scsi/qedi/qedi_main.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
On 11/21/18 1:25 AM, Nilesh Javali wrote:
> Remove redundant macro definition.
>
> Signed-off-by: Nilesh Javali
> ---
> drivers/scsi/qedi/qedi.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h
> index a6f96b3..e966855 100644
> ---
On 11/21/18 1:25 AM, Nilesh Javali wrote:
> The driver load on some systems failed with error,
> [0004:01:00.5]:[qedi_request_msix_irq:2524]:8: request_irq failed.
>
> Allocate the IRQs based on MSIX count obtained from qed module
> instead of number of queues.
>
> Signed-off-by: Nilesh Javali
David,
> This patchset removes unneeded se_dev_attrib.pi_prot_format and
> fabric_ops.get_fabric_name() struct members. Removal of the latter
> allowed for further cleanup due to the fact that all fabric modules
> except iscsi_target_mod provide matching strings for fabric_ops.name
> and
> On Nov 27, 2018, at 3:04 PM, Bart Van Assche wrote:
>
> External Email
>
> Nesting in __qla2x00_abort_all_cmds() is way too deep. Reduce the nesting
> level by introducing a helper function. This patch does not change any
> functionality.
>
> Cc: Himanshu Madhani
> Signed-off-by: Bart Van
> On Nov 27, 2018, at 3:04 PM, Bart Van Assche wrote:
>
> External Email
>
> This patch improves code readability but does not change any
> functionality.
>
> Cc: Himanshu Madhani
> Signed-off-by: Bart Van Assche
> ---
> drivers/scsi/qla2xxx/qla_target.c | 14 +++---
> 1 file
Martin,
> Since f44ac12f1dcc, BG enablement is tracked with the
> LPFC_SLI3_BG_ENABLED bit, which is set in lpfc_get_cfgparam before
> lpfc_sli_config_sli_port() is called. The bit shouldn't be cleared
> before checking the feature. Based on problem analysis by David Bond.
Applied to
On Wed, 2018-11-28 at 17:44 +0100, David Disseldorp wrote:
> Hi Bart,
>
> On Wed, 28 Nov 2018 08:36:19 -0800, Bart Van Assche wrote:
>
> > Maybe I'm missing something, but why is zeroing of unused bytes in these
> > functions
> > necessary? Would the following be correct if all strings in
1 - 100 of 39577 matches
Mail list logo
