Re: [PATCH 1/1] mpt3sas: Ignore unaligned completion length for ZBC_IN

2017-02-13 Thread Damien Le Moal
Christoph, On 2/14/17 15:18, h...@lst.de wrote: > On Tue, Feb 14, 2017 at 02:21:37PM +0900, Damien Le Moal wrote: >>> I think we want to keep the knowledge of which requests have a request size >>> that should be a multiple of the logical block size in the block layer core >>> or in the SCSI core

Re: [PATCH 1/1] mpt3sas: Ignore unaligned completion length for ZBC_IN

2017-02-13 Thread h...@lst.de
On Tue, Feb 14, 2017 at 02:21:37PM +0900, Damien Le Moal wrote: > > I think we want to keep the knowledge of which requests have a request size > > that should be a multiple of the logical block size in the block layer core > > or in the SCSI core but not in the mpt3sas driver. But I'm not sure

Re: [PATCH 1/1] mpt3sas: Ignore unaligned completion length for ZBC_IN

2017-02-13 Thread Damien Le Moal
Bart, On 2/14/17 14:11, Bart Van Assche wrote: > On Tue, 2017-02-14 at 13:42 +0900, Damien Le Moal wrote: >> I think so. But my understanding of REQ_TYPE_BLOCK_PC is that it is the >> type for requests issued internally (scsi_execute) of from things like >> the SG driver, so in essence, all

Re: [PATCH 1/1] mpt3sas: Ignore unaligned completion length for ZBC_IN

2017-02-13 Thread Bart Van Assche
On Tue, 2017-02-14 at 13:42 +0900, Damien Le Moal wrote: > I think so. But my understanding of REQ_TYPE_BLOCK_PC is that it is the > type for requests issued internally (scsi_execute) of from things like > the SG driver, so in essence, all requests not derived from a BIO... Is > this correct ? If

Re: [PATCH 1/1] mpt3sas: Ignore unaligned completion length for ZBC_IN

2017-02-13 Thread Damien Le Moal
Bart, On 2/14/17 12:59, Bart Van Assche wrote: >>> What software generated a ZBC_IN request with type REQ_TYPE_FS? Shouldn't >>> all ZBC_IN requests be assigned type REQ_TYPE_BLOCK_PC? >> >> Any application that issues a BLKREPORTZONE ioctl (e.g. mkfs.f2fs or >> libzbc tools) or kernel component

Re: [PATCH 1/1] mpt3sas: Ignore unaligned completion length for ZBC_IN

2017-02-13 Thread Bart Van Assche
On Tue, 2017-02-14 at 12:45 +0900, Damien Le Moal wrote: > On 2/14/17 03:57, Bart Van Assche wrote: > > On Mon, 2017-02-13 at 14:11 +0900, Damien Le Moal wrote: > > > The ZBC_IN command (REPORT ZONES) reply length is always a multiple of > > > 64B and thus may not be aligned on the device LBA

Re: [PATCH 1/1] mpt3sas: Ignore unaligned completion length for ZBC_IN

2017-02-13 Thread Damien Le Moal
Bart, On 2/14/17 03:57, Bart Van Assche wrote: > On Mon, 2017-02-13 at 14:11 +0900, Damien Le Moal wrote: >> The ZBC_IN command (REPORT ZONES) reply length is always a multiple of >> 64B and thus may not be aligned on the device LBA size. >> For this command, retry due to the unaligned completion

Re: [PATCH 1/1] mpt3sas: Ignore unaligned completion length for ZBC_IN

2017-02-13 Thread Bart Van Assche
On Mon, 2017-02-13 at 14:11 +0900, Damien Le Moal wrote: > The ZBC_IN command (REPORT ZONES) reply length is always a multiple of > 64B and thus may not be aligned on the device LBA size. > For this command, retry due to the unaligned completion length is > incorrect so do not check alignment of