Re: [PATCH 1/2] qed: Add support for hardware offloaded FCoE.

2017-01-21 Thread kbuild test robot 
Hi Arun,

[auto build test ERROR on net-next/master]
[also build test ERROR on v4.10-rc4 next-20170120]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Dupuis-Chad/Add-QLogic-FastLinQ-FCoE-qedf-driver/20170117-052438
config: i386-randconfig-x0-01220741 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from drivers/net/ethernet/qlogic/qed/qed.h:49:0,
from drivers/net/ethernet/qlogic/qed/qed_dcbx.c:41:
   include/linux/qed/qed_if.h:428:37: warning: 'struct qed_dcbx_get' declared 
inside parameter list will not be visible outside of this definition or 
declaration
 void (*dcbx_aen)(void *dev, struct qed_dcbx_get *get, u32 mib_type);
^~~~
   drivers/net/ethernet/qlogic/qed/qed_dcbx.c: In function 'qed_dcbx_aen':
>> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:873:42: error: 'struct 
>> qed_dcbx_info' has no member named 'get'
  op->dcbx_aen(cookie, >p_dcbx_info->get, mib_type);
 ^~
   drivers/net/ethernet/qlogic/qed/qed_dcbx.c: In function 
'qed_dcbx_mib_update_event':
>> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:902:2: error: implicit 
>> declaration of function 'qed_dcbx_get_params' 
>> [-Werror=implicit-function-declaration]
 qed_dcbx_get_params(p_hwfn, p_ptt, _hwfn->p_dcbx_info->get, type);
 ^~~
   drivers/net/ethernet/qlogic/qed/qed_dcbx.c:902:57: error: 'struct 
qed_dcbx_info' has no member named 'get'
 qed_dcbx_get_params(p_hwfn, p_ptt, _hwfn->p_dcbx_info->get, type);
^~
   cc1: some warnings being treated as errors

vim +873 drivers/net/ethernet/qlogic/qed/qed_dcbx.c

   867  void qed_dcbx_aen(struct qed_hwfn *hwfn, u32 mib_type)
   868  {
   869  struct qed_common_cb_ops *op = hwfn->cdev->protocol_ops.common;
   870  void *cookie = hwfn->cdev->ops_cookie;
   871  
   872  if (cookie && op->dcbx_aen)
 > 873  op->dcbx_aen(cookie, >p_dcbx_info->get, mib_type);
   874  }
   875  
   876  /* Read updated MIB.
   877   * Reconfigure QM and invoke PF update ramrod command if operational MIB
   878   * change is detected.
   879   */
   880  int
   881  qed_dcbx_mib_update_event(struct qed_hwfn *p_hwfn,
   882struct qed_ptt *p_ptt, enum qed_mib_read_type 
type)
   883  {
   884  int rc = 0;
   885  
   886  rc = qed_dcbx_read_mib(p_hwfn, p_ptt, type);
   887  if (rc)
   888  return rc;
   889  
   890  if (type == QED_DCBX_OPERATIONAL_MIB) {
   891  rc = qed_dcbx_process_mib_info(p_hwfn);
   892  if (!rc) {
   893  /* reconfigure tcs of QM queues according
   894   * to negotiation results
   895   */
   896  qed_qm_reconf(p_hwfn, p_ptt);
   897  
   898  /* update storm FW with negotiation results */
   899  qed_sp_pf_update(p_hwfn);
   900  }
   901  }
 > 902  qed_dcbx_get_params(p_hwfn, p_ptt, _hwfn->p_dcbx_info->get, 
 > type);
   903  qed_dcbx_aen(p_hwfn, type);
   904  
   905  return rc;

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH 1/2] qed: Add support for hardware offloaded FCoE.

2017-01-18 Thread Arun Easi 
This will be addressed in v2 of the series. The warning pops up when 
CONFIG_DCB is not set. Thanks.

Regards,
-Arun

On Tue, 17 Jan 2017, 6:35am, kbuild test robot wrote:

> Hi Arun,
> 
> [auto build test WARNING on net-next/master]
> [also build test WARNING on v4.10-rc4 next-20170117]
> [if your patch is applied to the wrong git tree, please drop us a note to 
> help improve the system]
> 
> url:
> https://github.com/0day-ci/linux/commits/Dupuis-Chad/Add-QLogic-FastLinQ-FCoE-qedf-driver/20170117-052438
> config: i386-randconfig-c0-01172134 (attached as .config)
> compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386 
> 
> All warnings (new ones prefixed by >>):
> 
>In file included from drivers/net/ethernet/qlogic/qed/qed.h:49:0,
> from drivers/net/ethernet/qlogic/qed/qed_cxt.c:44:
> >> include/linux/qed/qed_if.h:428:37: warning: 'struct qed_dcbx_get' declared 
> >> inside parameter list
>  void (*dcbx_aen)(void *dev, struct qed_dcbx_get *get, u32 mib_type);
> ^
> >> include/linux/qed/qed_if.h:428:37: warning: its scope is only this 
> >> definition or declaration, which is probably not what you want
> --
>In file included from drivers/net/ethernet/qlogic/qed/qed.h:49:0,
> from drivers/net/ethernet/qlogic/qed/qed_dcbx.c:41:
> >> include/linux/qed/qed_if.h:428:37: warning: 'struct qed_dcbx_get' declared 
> >> inside parameter list
>  void (*dcbx_aen)(void *dev, struct qed_dcbx_get *get, u32 mib_type);
> ^
> >> include/linux/qed/qed_if.h:428:37: warning: its scope is only this 
> >> definition or declaration, which is probably not what you want
>drivers/net/ethernet/qlogic/qed/qed_dcbx.c: In function 'qed_dcbx_aen':
>drivers/net/ethernet/qlogic/qed/qed_dcbx.c:873:42: error: 'struct 
> qed_dcbx_info' has no member named 'get'
>   op->dcbx_aen(cookie, >p_dcbx_info->get, mib_type);
>  ^
>drivers/net/ethernet/qlogic/qed/qed_dcbx.c: In function 
> 'qed_dcbx_mib_update_event':
>drivers/net/ethernet/qlogic/qed/qed_dcbx.c:902:2: error: implicit 
> declaration of function 'qed_dcbx_get_params' 
> [-Werror=implicit-function-declaration]
>  qed_dcbx_get_params(p_hwfn, p_ptt, _hwfn->p_dcbx_info->get, type);
>  ^
>drivers/net/ethernet/qlogic/qed/qed_dcbx.c:902:57: error: 'struct 
> qed_dcbx_info' has no member named 'get'
>  qed_dcbx_get_params(p_hwfn, p_ptt, _hwfn->p_dcbx_info->get, type);
> ^
>cc1: some warnings being treated as errors
> 
> vim +428 include/linux/qed/qed_if.h
> 
>412u8  name[QED_DRV_VER_STR_SIZE];
>413};
>414
>415#define ILT_PAGE_SIZE_TCFC 0x8000 /* 32KB */
>416
>417struct qed_int_info {
>418struct msix_entry   *msix;
>419u8  msix_cnt;
>420
>421/* This should be updated by the protocol driver */
>422u8  used_cnt;
>423};
>424
>425struct qed_common_cb_ops {
>426void(*link_update)(void *dev,
>427   struct qed_link_output   *link);
>  > 428void(*dcbx_aen)(void *dev, struct qed_dcbx_get 
> *get, u32 mib_type);
>429};
>430
>431struct qed_selftest_ops {
>432/**
>433 * @brief selftest_interrupt - Perform interrupt test
>434 *
>435 * @param cdev
>436 *
> 
> ---
> 0-DAY kernel test infrastructureOpen Source Technology Center
> https://lists.01.org/pipermail/kbuild-all   Intel Corporation
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] qed: Add support for hardware offloaded FCoE.

2017-01-17 Thread kbuild test robot 
Hi Arun,

[auto build test WARNING on net-next/master]
[also build test WARNING on v4.10-rc4 next-20170117]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Dupuis-Chad/Add-QLogic-FastLinQ-FCoE-qedf-driver/20170117-052438
config: i386-randconfig-c0-01172134 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from drivers/net/ethernet/qlogic/qed/qed.h:49:0,
from drivers/net/ethernet/qlogic/qed/qed_cxt.c:44:
>> include/linux/qed/qed_if.h:428:37: warning: 'struct qed_dcbx_get' declared 
>> inside parameter list
 void (*dcbx_aen)(void *dev, struct qed_dcbx_get *get, u32 mib_type);
^
>> include/linux/qed/qed_if.h:428:37: warning: its scope is only this 
>> definition or declaration, which is probably not what you want
--
   In file included from drivers/net/ethernet/qlogic/qed/qed.h:49:0,
from drivers/net/ethernet/qlogic/qed/qed_dcbx.c:41:
>> include/linux/qed/qed_if.h:428:37: warning: 'struct qed_dcbx_get' declared 
>> inside parameter list
 void (*dcbx_aen)(void *dev, struct qed_dcbx_get *get, u32 mib_type);
^
>> include/linux/qed/qed_if.h:428:37: warning: its scope is only this 
>> definition or declaration, which is probably not what you want
   drivers/net/ethernet/qlogic/qed/qed_dcbx.c: In function 'qed_dcbx_aen':
   drivers/net/ethernet/qlogic/qed/qed_dcbx.c:873:42: error: 'struct 
qed_dcbx_info' has no member named 'get'
  op->dcbx_aen(cookie, >p_dcbx_info->get, mib_type);
 ^
   drivers/net/ethernet/qlogic/qed/qed_dcbx.c: In function 
'qed_dcbx_mib_update_event':
   drivers/net/ethernet/qlogic/qed/qed_dcbx.c:902:2: error: implicit 
declaration of function 'qed_dcbx_get_params' 
[-Werror=implicit-function-declaration]
 qed_dcbx_get_params(p_hwfn, p_ptt, _hwfn->p_dcbx_info->get, type);
 ^
   drivers/net/ethernet/qlogic/qed/qed_dcbx.c:902:57: error: 'struct 
qed_dcbx_info' has no member named 'get'
 qed_dcbx_get_params(p_hwfn, p_ptt, _hwfn->p_dcbx_info->get, type);
^
   cc1: some warnings being treated as errors

vim +428 include/linux/qed/qed_if.h

   412  u8  name[QED_DRV_VER_STR_SIZE];
   413  };
   414  
   415  #define ILT_PAGE_SIZE_TCFC 0x8000 /* 32KB */
   416  
   417  struct qed_int_info {
   418  struct msix_entry   *msix;
   419  u8  msix_cnt;
   420  
   421  /* This should be updated by the protocol driver */
   422  u8  used_cnt;
   423  };
   424  
   425  struct qed_common_cb_ops {
   426  void(*link_update)(void *dev,
   427 struct qed_link_output   *link);
 > 428  void(*dcbx_aen)(void *dev, struct qed_dcbx_get *get, u32 
 > mib_type);
   429  };
   430  
   431  struct qed_selftest_ops {
   432  /**
   433   * @brief selftest_interrupt - Perform interrupt test
   434   *
   435   * @param cdev
   436   *

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH 1/2] qed: Add support for hardware offloaded FCoE.

2017-01-16 Thread David Miller 
From: Chad Dupuis 
Date: Mon, 16 Jan 2017 16:47:52 -0500

> I forgot to add netdev-next to the subject line.  Is a repost needed
> here?

Not this time, no.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] qed: Add support for hardware offloaded FCoE.

2017-01-16 Thread Chad Dupuis 
I forgot to add netdev-next to the subject line.  Is a repost needed here?

On Mon, 16 Jan 2017, 7:53pm -, Dupuis, Chad wrote:

> From: Arun Easi 
> 
> This adds the backbone required for the various HW initalizations
> which are necessary for the FCoE driver (qedf) for QLogic FastLinQ
> 4 line of adapters - FW notification, resource initializations, etc.
> 
> Signed-off-by: Arun Easi 
> Signed-off-by: Yuval Mintz 
> ---
>  drivers/net/ethernet/qlogic/Kconfig   |   3 +
>  drivers/net/ethernet/qlogic/qed/Makefile  |   1 +
>  drivers/net/ethernet/qlogic/qed/qed.h |  11 +
>  drivers/net/ethernet/qlogic/qed/qed_cxt.c |  98 ++-
>  drivers/net/ethernet/qlogic/qed/qed_cxt.h |   3 +
>  drivers/net/ethernet/qlogic/qed/qed_dcbx.c|  11 +
>  drivers/net/ethernet/qlogic/qed/qed_dcbx.h|   1 +
>  drivers/net/ethernet/qlogic/qed/qed_dev.c | 205 -
>  drivers/net/ethernet/qlogic/qed/qed_dev_api.h |  42 +
>  drivers/net/ethernet/qlogic/qed/qed_fcoe.c| 990 
> ++
>  drivers/net/ethernet/qlogic/qed/qed_fcoe.h|  52 ++
>  drivers/net/ethernet/qlogic/qed/qed_hsi.h | 781 -
>  drivers/net/ethernet/qlogic/qed/qed_hw.c  |   3 +
>  drivers/net/ethernet/qlogic/qed/qed_ll2.c |  25 +
>  drivers/net/ethernet/qlogic/qed/qed_ll2.h |   2 +-
>  drivers/net/ethernet/qlogic/qed/qed_main.c|   7 +
>  drivers/net/ethernet/qlogic/qed/qed_mcp.c |   3 +
>  drivers/net/ethernet/qlogic/qed/qed_mcp.h |   1 +
>  drivers/net/ethernet/qlogic/qed/qed_reg_addr.h|   8 +
>  drivers/net/ethernet/qlogic/qed/qed_sp.h  |   4 +
>  drivers/net/ethernet/qlogic/qed/qed_sp_commands.c |   3 +
>  include/linux/qed/common_hsi.h|  10 +-
>  include/linux/qed/fcoe_common.h   | 715 
>  include/linux/qed/qed_fcoe_if.h   | 145 
>  include/linux/qed/qed_if.h|  39 +
>  25 files changed, 3152 insertions(+), 11 deletions(-)
>  create mode 100644 drivers/net/ethernet/qlogic/qed/qed_fcoe.c
>  create mode 100644 drivers/net/ethernet/qlogic/qed/qed_fcoe.h
>  create mode 100644 include/linux/qed/fcoe_common.h
>  create mode 100644 include/linux/qed/qed_fcoe_if.h
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html