Re: [PATCH 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling

2017-06-19 Thread Madhani, Himanshu 

> On Jun 19, 2017, at 1:26 PM, James Smart  wrote:
> 
> On 6/16/2017 3:47 PM, Himanshu Madhani wrote:
>>/* FCP-4 types */
>>  #define FC4_TYPE_FCP_SCSI   0x08
>> +#define FC4_TYPE_NVME   0x28
>>  #define FC4_TYPE_OTHER  0x0
>>  #define FC4_TYPE_UNKNOWN0xff
> 
> please use the types from include/uapi/scsi/fc/fc_fs.h

Sure.

Re: [PATCH 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling

2017-06-19 Thread James Smart 

On 6/16/2017 3:47 PM, Himanshu Madhani wrote:
  
  /* FCP-4 types */

  #define FC4_TYPE_FCP_SCSI 0x08
+#define FC4_TYPE_NVME  0x28
  #define FC4_TYPE_OTHER0x0
  #define FC4_TYPE_UNKNOWN  0xff


please use the types from include/uapi/scsi/fc/fc_fs.h

Re: [PATCH 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling

2017-06-19 Thread Madhani, Himanshu 

> On Jun 19, 2017, at 1:09 AM, Johannes Thumshirn  wrote:
> 
> On Fri, Jun 16, 2017 at 03:47:39PM -0700, Himanshu Madhani wrote:
>> From: Duane Grigsby 
>> 
>> Signed-off-by: Darren Trapp 
>> Signed-off-by: Duane Grigsby 
>> Signed-off-by: Anil Gurumurthy 
>> Signed-off-by: Giridhar Malavali 
>> Signed-off-by: Himanshu Madhani 
>> ---
> 
> [...]
> 
>> +
>> +if ((fcport->fw_login_state == DSC_LS_PLOGI_PEND) ||
>> +(fcport->fw_login_state == DSC_LS_PLOGI_COMP) ||
>> +(fcport->fw_login_state == DSC_LS_PRLI_PEND))
>> +return rval;
> 
> Minor nit, superfluous parenthesis.
> 
> 

Will fix it in v2

> Anyways,
> Reviewed-by: Johannes Thumshirn 
> 
> -- 
> Johannes Thumshirn  Storage
> jthumsh...@suse.de+49 911 74053 689
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
> Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Thanks,
- Himanshu

Re: [PATCH 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling

2017-06-19 Thread Johannes Thumshirn 
On Fri, Jun 16, 2017 at 03:47:39PM -0700, Himanshu Madhani wrote:
> From: Duane Grigsby 
> 
> Signed-off-by: Darren Trapp 
> Signed-off-by: Duane Grigsby 
> Signed-off-by: Anil Gurumurthy 
> Signed-off-by: Giridhar Malavali 
> Signed-off-by: Himanshu Madhani 
> ---

[...]

> +
> + if ((fcport->fw_login_state == DSC_LS_PLOGI_PEND) ||
> + (fcport->fw_login_state == DSC_LS_PLOGI_COMP) ||
> + (fcport->fw_login_state == DSC_LS_PRLI_PEND))
> + return rval;

Minor nit, superfluous parenthesis.


Anyways,
Reviewed-by: Johannes Thumshirn 

-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850